GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/e7479e6d0dad..6918b882e519

2020-06-10 khokhlov@google.com Merge "trace_processor_shell: Add flag to execute queries before metrics"
2020-06-10 khokhlov@google.com Merge "trace_processor: Create a power_profile table"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ie8a20a8a8ee8f6d9eb339f8d2ffb7a6407d59e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239357Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776961}

This issue has been found by a test:
MenuViewDragAndDropTestTestInMenuDrag.TestInMenuDrag

The grag_context_ can become nullptr before the task comes to execution.  This CL fixes that.

Bug: 1014860
Change-Id: I279a4bec0274cc50c8f745361463a787471fca9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238149
Auto-Submit: Alexander Dunaev <adunaev@igalia.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776960}

https://dawn.googlesource.com/dawn.git/+log/527080ff03ce..4aca14ccb6b4

2020-06-10 natlee@microsoft.com Unify TickImpl called during Device shutdown.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I93035c0866e75e0929b4cb7fa248ac2fcec282fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239359Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776959}

... instead of WebMediaStreamTrack.

CL also updates the use on all child classes, including:
  - RTCRtpReceiverImpl
  - FakeRTCRtpReceiverImpl
  - DummyRTCRtpReceiverPlatform

This is part of the effort to reduce the needless use of
public Blink APIs (wrappers) within renderer/modules.

BUG=704136
R=guidou@chromium.org

Change-Id: I98d38b932279aa5241ccc8603b311ccc70979b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239668Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#776958}

Bug: 973801
Change-Id: Ie40fc51ca936e7c1557ec6fb148bfc03c22451b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238385Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Chris Fredrickson <cfredric@google.com>
Cr-Commit-Position: refs/heads/master@{#776957}

This change makes some fixes to minor bugs with the split.
1) Two localized string fragments had the same name, resulting in an
error when the string is used in tests.
2) ManagedDisplayMode::IsEquivalent() is updated to use epsilon for both
refresh rate and scale factor.

Bug: 1024113
Change-Id: I77013e8ceca0efb15bef0126764486ee6572fdcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225292Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776956}

* dns_response.h: Fix parameter name typos.
* dns_transaction.cc: Update comment that mentions
                      DnsConfig::nameservers to also mention
                      DnsConfig::dns_over_https_servers.

Change-Id: I7a788f61aa9b2a015c0e0dc77abea0b60ef5796e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218529Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776955}

https://skia.googlesource.com/skia.git/+log/990a04ecd5e8..f7005498d416

2020-06-10 jlavrova@google.com Keeping run metrics rather than calculating them every time
2020-06-10 ethannicholas@google.com fixed sample(..., matrix) with runtime effects
2020-06-10 jvanverth@google.com Fix Build-Win-Clang-x86_64-Debug-Direct3D
2020-06-10 bungeman@google.com Revert "Delete .a file before writing static library."
2020-06-10 bungeman@google.com Delete .a file before writing static library.
2020-06-10 egdaniel@google.com Add GrContext API to allow updating GrBackendSurfaceMutableState.
2020-06-10 mtklein@google.com Revert "remove -Fast bots"
2020-06-10 mtklein@google.com Revert "Reland "remove unnecessary hsw opts""
2020-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 608bc0c5 to 82b62a7d (444 revisions)
2020-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from dbb18b53c4b4 to d80d9044857e (10 revisions)
2020-06-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0a79bee135cd to 527080ff03ce (7 revisions)
2020-06-10 rosasco@google.com [fuchsia] Fix fidlc command.
2020-06-10 johnstiles@google.com Revert "Update GrCircleBlurFragmentProcessor to use a child FP."
2020-06-10 csmartdalton@google.com Re-enable GrCaps::fSampleLocationsSupport in Vulkan
2020-06-10 michaelludwig@google.com Remove unnecessary GrFixedClip includes/declarations
2020-06-10 jvanverth@google.com Add D3D descriptor tables and bind to command list.
2020-06-10 reed@google.com Revert "Switch persistent cache to use SkReadBuffer/SkWriteBuffer"
2020-06-09 liyl@google.com [fuchsia] Always use full name of FIDL libraries.
2020-06-09 csmartdalton@google.com Add an interactive sample that fits cubics to circular arcs
2020-06-09 brianosman@google.com Switch persistent cache to use SkReadBuffer/SkWriteBuffer
2020-06-09 johnstiles@google.com Update GrAlphaThresholdFragmentProcessor to use a child FP.
2020-06-09 johnstiles@google.com Update GrCircleBlurFragmentProcessor to use a child FP.
2020-06-09 mtklein@google.com Reland "remove unnecessary hsw opts"
2020-06-09 mtklein@google.com remove -Fast bots
2020-06-09 jcgregorio@google.com Move Pixel4 Perf jobs to the  4XL.
2020-06-09 egdaniel@google.com Update vulkan linux sdk version on bots.
2020-06-09 adlai@google.com Allow surfaces to validate against matching contexts, not ptr equality
2020-06-09 herb@google.com make GrAtlasTextOp a friend of GrRenderTargetContext
2020-06-09 robertphillips@google.com Auto-resolve DDL targets in flushSurfaces
2020-06-09 fmalita@chromium.org [skrive] Initial artboard plumbing
2020-06-09 jlavrova@google.com Removing fOffsets array from Run; optimizing copyTo

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1056730,chromium:1064662,chromium:1091259,chromium:1091723
Tbr: bungeman@google.com
Test: Test: Test: MEC of Angry Birds 2
Change-Id: Ibc01e9960285a7efa5b7989d5b7ef2aa9170afe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239356Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776954}

I added this line in Document::Shutdown in crrev.com/c/2048035
because I was trying to recreate logic from NavigationScheduler, and I
noticed that there was a line there to to cancel scheduled http
refreshes, which is that NavigationScheduler was renamed to.

I thought this would help make the async form submission behavior more
like the correct behavior we used to have, but it turns out that back
when we had async form submissions (before crrev.com/c/1520353),
Document::Shutdown actually didn't cancel pending form submissions. The
http refresh canceling was actually added to avoid a crash after the
http refresh scheduler was moved from Frame to Document.

Now that I moved pending form submissions from the Document containing
the form which initiated the submission to the Frame which is being
navigated in crrev.com/c/2212458, it introduced a race condition where
the subframe being navigated would cancel its pending form submission in
Document::Shutdown.

This patch stops canceling form submissions in Document::Shutdown. I
don't think this will cause problems now that pending form submissions
are no longer stored in Document.

I wasn't able to add a test because the undesired behavior was extremely
flaky. The reporter provided a test which they said failed on their
computer, but I couldn't get it to fail on mine or any of the cq+1
trybots. I was only able to reproduce the bug on their production
website which they mentioned in the bug, which is how I figured out how
to fix this.

Bug: 1092200
Change-Id: I59b8cf81a5629d5eba09c55e6f320874f3f0ad72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236218Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776953}

This reverts commit a71864a7.

Reason for revert:
 * Added min_sdk_version to cronet targets
 * Made dex.py not package incremental dex in cronet's test apks

Original change's description:
> Revert "Android: Increase default_min_sdk_version 19 -> 21"
>
> This reverts commit ce14e58b.
>
> Reason for revert: The CL causes failures on Cronet KitKat builders https://ci.chromium.org/p/chromium/builders/ci/android-cronet-kitkat-arm-rel
>
> The error code is INSTALL_FAILED_OLDER_SDK
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878029920810653312/+/steps/cronet_smoketests_missing_native_library_instrumentation_apk_on_Android_device_Nexus_5/0/stdout
>
> Original change's description:
> > Android: Increase default_min_sdk_version 19 -> 21
> >
> > Cronet is the only project that requires a lower minSdkVersion. To
> > continue supporting building of their targets, this change enabled
> > proguard on all of their apks in order to have all files desugared at
> > the proper minApiVersion.
> >
> > This change should speed up compiles somewhat, as it removes the need to
> > generate main-dex-lists for legacy multidex purposes.
> >
> > Bug: 1091919
> > Change-Id: Ifd8089bbf4965b55a13dea11464ccda979fd5028
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233581
> > Reviewed-by: Peter Wen <wnwen@chromium.org>
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#776166}
>
> TBR=wnwen@chromium.org,agrieve@chromium.org
>
> Change-Id: Id4b92d5549d13de9684f542ce646993c3833795f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1091919
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236715
> Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
> Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776237}

Bug: 1091919
Change-Id: Ie2dc5d64739a3f57c36f3380502d290129d634f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235737
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776952}

This change ensures that when just the interlaced bit is changed on a
display, the proper observer events fire.


Bug: 1024113
Change-Id: Ie8433a1db9a4f3ed3ddee0e2c407eadf126a1932
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228363
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776951}

Bug: 981472
Change-Id: Iaedd614b138737a7d735152e78e6acfe76c5c602
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232405
Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776950}

To confirm/refute whether leaked processes from prior test executions
may be causing Fuchsia x64 test slowdowns, temporarily add process
printout under --test-launcher-bot-mode.

Bug: 1092054
Change-Id: Id53d498b4f3d9d369062ebc813ba92b9fae16aa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237978
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776949}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/735f964fa54d..3190b5943579

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC finnur@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: finnur@google.com
Change-Id: Ifb8dba51a5e46864dcea8b574d12bb281c918f16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239351Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776948}

Plugin Prefs is updated to purge all OTR profiles (instead of just the
primary one).

Bug: 1060940
Change-Id: I3e56363d22e7803d9083243ff3e1081bf2311a26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239574Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776947}

Bug: 1019129
Change-Id: Ic618dbcb2aed55b895d0eb868c533786569c96f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238929Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
Cr-Commit-Position: refs/heads/master@{#776946}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4caabe11..aa617c8a

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ic3c668443c1828e784e7921e24f79c64b417348d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239172Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776945}

On the renderer there needs to be a method for determining whether the
identifiability study is active. In addition to being a performance
tweak -- no need to generate samples that would never be used -- this
facility can also be used to turn down misbehaving samples.

Bug: 973801
Change-Id: I717f3abc4fbda1c97f5d6518c4f1f7d1ca174c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225537
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776944}

Permission requests from pages inside portals are automatically denied
without a user prompt being shown.

Bug: 1087101
Change-Id: Idb6a36215e86e7417e8b104a498e5f4e7351ad75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225371Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776943}

The prototype:
https://chromium-review.googlesource.com/c/chromium/src/+/2223934

will soon properly reports:
  report > url
  report > body > violation-type
  report > body > property
  report > body > source-file
  report > body > lineno
  report > body > colno

This patch reflect this in the existing tests and fixes a few bugs.

Bug: 1090273
Change-Id: I840a07ef98979ab7b36286124161ca165c228303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238114
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776942}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b45583d6eab0..25a3db43f29a

2020-06-10 jacktfranklin@chromium.org Screenshots: remove the URL fragment before trimming it.
2020-06-10 tvanderlippe@chromium.org Disable network_test.ts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1093076,chromium:1093287
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I559cfb09468323ebc2803c8a29a0f705232e6139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239352Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776941}

Unit tests for ExtensionInstallEventLog are added. This class is
used for event based reporting for installation process of forced
extensions.

Bug: 1081215
Change-Id: I25497627d60192045845d49ea0928d1ce1274f31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193616
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776940}

https://android.googlesource.com/platform/external/perfetto.git/+log/60cf022c0223..e7479e6d0dad

2020-06-10 lalitm@google.com Merge "metrics: add surfaceflinger metric and derived events"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I8db238393ed501c970f200cd63a62035b9c05f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239353Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776939}

Bug: 1092911
Change-Id: Iace9537aa0b971efd9b31734230117541884c757
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237658
Commit-Queue: Peng Huang <penghuang@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776938}

https://chromium.googlesource.com/catapult.git/+log/e5d1f8690561..05fd9a2a039b

2020-06-10 dberris@chromium.org operations: Remove the delete-tests-queue
2020-06-10 dberris@chromium.org operations: Remove the dev_console API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC sadrul@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1092865
Tbr: sadrul@google.com
Change-Id: I2b575c14923fbc26fd19a49d912ecc5432400d6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239479Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776937}

https://webrtc.googlesource.com/src.git/+log/8498c259b987..249aa4dd35f3

2020-06-10 landrey@webrtc.org Fix chromium roll

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I1f8d7872e78adbbb0f938af8ec0ac90489fb7fca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776936}

TBR=bling-team@google.com

Change-Id: Ife034bee023d9c81eb0de8b29291766a71d4d3e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239294Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776935}

Currently if we would trigger a network intervention but it falls below
the noise threshold for an intervention, and then later we do trigger
a different type of intervention, the intervention is reported as a
network intervention.  This change fixes the reporting to use the
noised intervention type for reporting, rather than the non-noised.

Bug: 1092962
Change-Id: Ia88838e980fab369b3eb9f5af2204a6f94eecd72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238455
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776934}

Bug: 1081716
Change-Id: I48aa648d4ee6fc38e5fba36689814431e2cb56be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238463Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776933}

It's currently a bit tricky to add support for this, because
StyleEngine can't currently gracefully support the scenario of
user/author rules sharing a single storage location. (We have a
similar issue with the font cache).

This CL handles @property rules roughly the same way as
@font-face rules are handled:

 - When adding user @property rules, clear all rules (including
   author), then add user rules.
 - MarkDocumentDirty + SetNeedsAppendAllSheets, to ensure that
   we ApplyRuleSetChanges for author rules.
 - When adding author @property rules, clear all rules (including
   user), then add all user rules, then author rules.

This should cover all the different cases where only user sheets are
present/modified, only author sheets present/modified, or when both
types of sheets are present/modified.

It's a bit of extra clear/add churn, but storing author/user rules
separately will add much more complexity (e.g. to PropertyRegistry::
Iterator).

Note: I seem to have declared ClearPropertyRules in a previous CL
without defining it.

Bug: 973830
Change-Id: Id8e490665c2bae371578311eb0636ca7e74b480b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236141Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776932}

Using wpt-import in Chromium ed6b36f0.
With Chromium commits locally applied on WPT:
9c24e63c "Check for first frame in CreateImageBitmap"
a8a28083 "[Security][Coop] Browsing context switch reporting WPT"
b2436c3b "Ensure cloning a template element into an inactive document does not crash."
027aefc6 "OPTION element: Update OPTION label even if it has invalid markup"
0776aa6d "Mark pointerevent_pointermove_in_pointerlock test non flaky"
d2ee98f4 "Move manual offscreen wpt tests to own folder"
458dc853 "WPT: Migrate content-visibility tests to wpt."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=foolip@google.com

No-Export: true
Change-Id: I13e42bfd7807ec7118298ed04ebdc717b5299f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239170Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#776931}

Without this, several reports from COOP-access-reporting would show in
between and cause most of the tests to fail.

BUG=1090273

Change-Id: I360b82da4b6a2dcb0380dfa4dce5a678e6ad73a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235851Reviewed-by: Pâris Meuleman <pmeuleman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776930}

The event handler resets the iframe's AutofillHandler. This ensures that
unique renderer IDs are actually unique within AutofillHandler and
avoids false positive cache hits in the FormStructure cache.

Specifically, this concerns the FormRendererId for synthetic forms.
Without resetting the AutofillHandler, a pre-navigation synthetic
form cache entry persists and leads to false positives.

Bug: 1064709
Change-Id: Iface6ded3027c7b31322685122f2ea1fc8427607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120721
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776929}

This CL removes FormStructure::operator==() and replaces it with direct
comparison of the unique renderer ID.

It appears that operator==() attempts to implement equality in terms of
underlying <form> tags, i.e., FormStructure == FormData iff they
originate from the same <form> tag. However, the implementation preceded
renderer IDs and thus could only approximate the intended relation.

Since there is no canonical way of defining equivalence between
FormStructure and FormData, it seems best to compare the renderer IDs
directly.

Renderer IDs suffice to uniquely identify forms and fields within
AutofillHandler since there is a one-to-one mapping from
RenderFrameHosts to AutofillDrivers and from AutofillDrivers to
AutofillHandlers.

Bug: 1007974,1064709
Change-Id: I9a3f1b02d06bab345d6e9df86273020ee888903a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113574
Commit-Queue: Christoph Schwering <schwering@google.com>
Reviewed-by: Vadym Doroshenko  <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776928}

This reverts commit 096c1762.

Reason for revert: new tests fail on iphone-simulator (see crbug.com/1093306)

Original change's description:
> [iOS] Make password leak checks toggleable when Safe Browsing is not available
> 
> This CL fixes a regression from http://crrev.com/c/2174995
> that prevents users who do not yet have Safe Browsing
> rolled out to them from toggling the password leak check setting.
> 
> This CL ensures that the value of the Safe Browsing opt-out
> pref is always initialized in GoogleServicesSettingsMediator,
> regardless of whether Safe Browsing has been rolled out. With
> this change, the other logic changes in
> http://crrev.com/c/2174995 work as expected, whether or not
> Safe Browsing is available.
> 
> Bug: 1090406
> Change-Id: I901f04faad60f136b89161091eeb6504415718a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237716
> Commit-Queue: Ali Juma <ajuma@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#776646}

TBR=ajuma@chromium.org,sczs@chromium.org

Change-Id: Iac9d50cbbdd03ee5098565cb83d5a3c2ae4b6deb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1090406
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239841Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776927}

1. Removed PolicyMap::Entry::get_value which accepts unique_ptr.
2. Changed all its references to use the new one with
base::Optional instead.

Bug: 1092471
Change-Id: Iaa1246f55e63bc3737e36141bb349905d48335e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237974
Auto-Submit: Aya Elsayed <ayaelattar@google.com>
Commit-Queue: Aya Elsayed <ayaelattar@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776926}

A utility file is created to convert extension events to base::Value
so that we can upload extension events using
ExtensionInstallEventLogUploader. This is a prework for extension
event based reporting.

Bug: 1081211
Change-Id: I66a7c5811af16ffa3a658e1f6b8e8f544dfb8f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193582
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776925}

RenderFrameHostImpl::is_active is used either when the RFH is in
pending deletion or in back forward cache.

We would like to remove all the |is_active| occurrences to avoid
confusion with all the other methods and use specific methods like:

- RenderFrameHost::IsCurrent()
- RenderFrameHostImpl::IsPendingDeletion()
- RenderFrameHostImpl::IsInBackForwardCache()
- RenderFrameHostImpl::IsInActiveAndDisallowReactivation()

This patch updates the callers of |is_active| and make use of above
mentioned methods along with removing RenderFrameHostImpl::is_active().

Detailed list of investigations for each is_active usage is
presented in this spreadsheet:
https://docs.google.com/spreadsheets/d/1TTzZ5r0m7nHBS_TkrEAdcFGs0M2iXO_tS0-lJmbQ3EY/edit?usp=sharing

BUG=1073449

Change-Id: I3be34f9ac66389edb36f53a73fc806f2d9d942a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186641
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776924}

Allowing BVC to become first responder is letting it answer keyboard
shortcuts.
It also makes sure that the BVC is set as first responder when shown.

Fixed: 1088068
Change-Id: I04cab9d4d9e20487778f64b0cbba49d64f611408
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2235849Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776923}

This allows enterprise admins to force-enable or force-disable
the feature.

BUG=1075553

Change-Id: I1ca1a6373945100f92f0a84f2e27d323000154a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232772Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#776922}