GitLab

NOTRY=true

Review URL: https://codereview.chromium.org/387723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282454 0039d316-1c4b-4281-b951-d872f2087c98

In r273854 we may have removed an indirect pathway used to close open
autofill popups when the associated web_contents undergoes a zoom
change. This CL replaces that by directly registering the
ChromeAutofillClient as a ZoomObserver, allowing it to directly
react to zoom events.

BUG=392412

Review URL: https://codereview.chromium.org/377423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282453 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Possibly-uninitialized local variable
* Signedness mismatch

This also contains a small number of other cleanups/simplifications to
nearby code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/382613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282451 0039d316-1c4b-4281-b951-d872f2087c98

R=enne

Review URL: https://codereview.chromium.org/387613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282449 0039d316-1c4b-4281-b951-d872f2087c98

Most everything but android and cdm code has been converted. Next step is to break these up into smaller BUILD.gn files per subdirectory.

All hail GN. orz

BUG=none
R=brettw@chromium.org, dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/268713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:29764
R=jennyz@chromium.org
TBR=jennyz@chromium.org

Review URL: https://codereview.chromium.org/382923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282447 0039d316-1c4b-4281-b951-d872f2087c98

This fixes the bug that resourceless software mode not
dirtying the draw properties.

This allows OutputSurface::ForcedDrawToSoftwareDevice to be
removed. And merged the valid_for_tile_management parameter
into resourceless_software_draw. This effectively reverses
the last bool parameter on SetExternalDrawConstraints.

BUG=391829

Review URL: https://codereview.chromium.org/376683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282445 0039d316-1c4b-4281-b951-d872f2087c98

This also breaks a few more misc. bonds between chrome/common and component_updater.

BUG=371463

Review URL: https://codereview.chromium.org/375973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282444 0039d316-1c4b-4281-b951-d872f2087c98

All hail GN. oRZ

BUG=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/380483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282443 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391203

Review URL: https://codereview.chromium.org/387543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389016

Review URL: https://codereview.chromium.org/369893008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375379
NOTRY=true
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/379963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282440 0039d316-1c4b-4281-b951-d872f2087c98

Implements support for receiving nudges from the non-blocking sync
engine.  When a non-blocking sync type requests a commit, it will also
send a request to the sync scheduler asking it to schedule
a sync cycle for some time in the future.

Adds some of the code required to support refresh requests, but does not
include an interface to allow clients of the non-blocking sync API to
access it.

Adds basic support for the initial download nudge.  When a non-blocking
type starts syncing for the first time, it sends a request to the
scheduler asking it to download any data available on the server.  This
allows it to complete initial sync quickly and without putting the
scheduler into configure mode.  For now, this looks like
a refresh request in the sync protocol.  This will be changed in
a future CL.

BUG=351005

Review URL: https://codereview.chromium.org/375023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282439 0039d316-1c4b-4281-b951-d872f2087c98

New components:
- rappor
- data_reduction_proxy
- captive_portal
- translate
- usb_service
- web_modal

Removes the _IMPLEMENTATION define for web_modal. It is unused (it is a static library, not a component).

Adds third_party/cld and third_party/cld_2 BUILD files.

Separates out the include dir setting of "//" and the root gen directory so. cld_2 needed to not have this due to base file name conflicts.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/382663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282438 0039d316-1c4b-4281-b951-d872f2087c98

being misused in such a way that makes it impossible to add other trusted
extension context types. It's also a nice cleanup, though requires rewriting
the ExtensionAPI::IsPrivileged function with sightly different semantics.

BUG=391944
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/377753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282437 0039d316-1c4b-4281-b951-d872f2087c98

MSVC evaluates functions in a different order, causing test failures.

> Remove media::AudioRendererImpl::now_cb_ and clean up tests.
> 
> It's no longer needed as of r282376.
> 
> BUG=370634
> R=rileya@chromium.org
> 
> Review URL: https://codereview.chromium.org/380893002

TBR=scherkus@chromium.org

Review URL: https://codereview.chromium.org/380303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282436 0039d316-1c4b-4281-b951-d872f2087c98

This is a prerequisite for http://crrev.com/23228004
(RenderText must elide correctly for direct Label use)

Use RenderText in gfx::ElideText on Win, Linux, Mac.
(old impl still needed for iOS and Android, for now)

Support additional eliding types in RenderText.
(matches behavior of gfx::ElideText, see TextEliderTest)
(still fixes the directionality of trailing ellipses)
(respect head and middle eliding when truncating)

Disambiguate gfx::NO_ELIDE from gfx::TRUNCATE.
Make the ElideEmail helper a private RenderText function.
Disable tests and no-op gfx::ElideText on iOS/Android.
Improve ElideTextSurrogatePairs perf: 7561 ms -> 3196 ms.

TODO: Fix RenderText::ElideEmail GetStringWidthF calls.
TODO: Support eliding filenames, like gfx::ElideFilename.

BUG=249938,327846,240037,125348,338784
R=asvitkine@chromium.org,sky@chromium.org
TEST=No observable text eliding behavior changes.

Review URL: https://codereview.chromium.org/354963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282433 0039d316-1c4b-4281-b951-d872f2087c98

TBR=grunell
NOTRY=True

Review URL: https://codereview.chromium.org/385613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282432 0039d316-1c4b-4281-b951-d872f2087c98

When this lands, we can remove SkBitmap::Config entirely from Skia
TBR=kmadhusu@chromium.org

mac_chromium_rel failure is unrelated to this CL (and passes locally)
NOTRY=True

Review URL: https://codereview.chromium.org/382623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282431 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/384643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282430 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/356953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282429 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282428 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=177845:177866&mode=html
TBR=yutak@chromium.org,junov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/388543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282427 0039d316-1c4b-4281-b951-d872f2087c98

Introduced static initializers into chrome binary:
preload_supplier.cc _GLOBAL__sub_I_preload_supplier.cc+0xa
preload_supplier.cc i18n::addressinput::StringCompare::StringCompare()
preload_supplier.cc __cxa_atexit@plt [registers a dtor to run at exit]

Run ./tools/linux/dump-static-initializers.py before re-landing to
verify they're no longer present.

> Use upstream libaddressinput in Chrome.
> 
> Most of the changes are mechanical switches from chromium/ to src/
> directory in third_party/libadressinput/.
> 
> To simplify the switch, autofill::AddressValidator is a shim between
> Chromium and i18n::addressinput::AddressValidator. The shim behaves the
> same way as Chromium's version of libaddressinput. The goal is to
> gradually remove the shim and make Chromium work directly with
> libaddressinupt.
> 
> Upstream libaddressinput does not include suggestions, which now can be
> found in third_party/libadressinput/chromium/input_suggester.{h,cc}.
> 
> A follow up patch will remove Chromium's version of libaddressinput.
> 
> BUG=327046
> 
> Review URL: https://codereview.chromium.org/298863012

TBR=rouslan@chromium.org

Review URL: https://codereview.chromium.org/388613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282426 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer needed as of r282376.

BUG=370634
R=rileya@chromium.org

Review URL: https://codereview.chromium.org/380893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282424 0039d316-1c4b-4281-b951-d872f2087c98

These are not null everywhere now, including android webview.
Remove obsolete conditionals and comments, and add asserts.

BUG=

Review URL: https://codereview.chromium.org/385643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282421 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch

The problem here is that using enums to declare bitmasks results in the enum values being signed, when all consumers want to use the values in an unsigned context.  Declaring them as consts allows using the more appropriate uint32 type.

In C++11 we could use "enum class" for this, but C++11 isn't legal yet.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/385443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282419 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/380023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282418 0039d316-1c4b-4281-b951-d872f2087c98

from the message pipes.

This includes the following:-
1. Number of bytes in the message.
2. Number of fields in the message.
3. The message id.
4. The request id of the message.
5. Whether the message expects a response message.
6. Whether the message is a response message.
7. The URL of the service.

We also intercept the first message pipe which is used for
vending services in the debugger.

Support for tracing additional information will be added as needed.

BUG=360188
TBR=viettrungluu

Review URL: https://codereview.chromium.org/354043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282417 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/382773006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282416 0039d316-1c4b-4281-b951-d872f2087c98

Many functions in Python's logging module grab a lock internally. Some
appear to do so before converting the provided message to a string via
its __str__ method.

Calling an object's __str__ method before calling a logging funciton
allows anything called by the __str__ method to log without the risk of
hitting a deadlock.

BUG=392869

Review URL: https://codereview.chromium.org/385653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282412 0039d316-1c4b-4281-b951-d872f2087c98

Extracted UserSessionManager::Delegate as UserSessionManagerDelegate.

Added UserSessionStateDelegate which will for now coexist with UserManager::UserSessionStateDelegate till latter will be deprecated and merged with the former.

BUG=387614

Review URL: https://codereview.chromium.org/385633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282411 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/371003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282410 0039d316-1c4b-4281-b951-d872f2087c98

Use new sync backup DB if settings are reset to avoid undoing reset from backup data, e.g. reinstall removed extensions, etc.


BUG=389690

Review URL: https://codereview.chromium.org/367063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282409 0039d316-1c4b-4281-b951-d872f2087c98

Most of the changes are mechanical switches from chromium/ to src/
directory in third_party/libadressinput/.

To simplify the switch, autofill::AddressValidator is a shim between
Chromium and i18n::addressinput::AddressValidator. The shim behaves the
same way as Chromium's version of libaddressinput. The goal is to
gradually remove the shim and make Chromium work directly with
libaddressinupt.

Upstream libaddressinput does not include suggestions, which now can be
found in third_party/libadressinput/chromium/input_suggester.{h,cc}.

A follow up patch will remove Chromium's version of libaddressinput.

BUG=327046

Review URL: https://codereview.chromium.org/298863012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/381153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386982
TEST=VISUAL

Review URL: https://codereview.chromium.org/379253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282406 0039d316-1c4b-4281-b951-d872f2087c98

In this test, index 0 is set as separator and TextComboboxModel::GetItemAt
asserts that separator items are not reached.
However, the combobox's selected index is 0 (default value) and on the Mac
OnPaint() will be triggered to cause the NOTREACHED to trigger.
TestComboboxModel is now initialized with the separators instead of being 
mutated after, and GetDefaultIndex is implemented to return the first
non-separator index.

BUG=378134

Review URL: https://codereview.chromium.org/376703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282405 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/383763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282403 0039d316-1c4b-4281-b951-d872f2087c98

Broke gpu_unittests FramebufferInfoTest.DrawBuffers:
[ RUN      ] FramebufferInfoTest.DrawBuffers
../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:653: Failure
Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
../../gpu/command_buffer/service/framebuffer_manager_unittest.cc:657: Failure
Actual function call count doesn't match EXPECT_CALL(*gl_, DrawBuffersARB(kMaxDrawBuffers, _))...
         Expected: to be called once
           Actual: never called - unsatisfied and active
[  FAILED  ] FramebufferInfoTest.DrawBuffers (1 ms)

> Do not call glDrawBuffersARB when the extension is absent
> 
> The function Framebuffer::ChangeDrawBuffersHelper was assuming
> that binding of an FBO with no GL_COLOR_ATTACHMENT0 was
> accompanied by setting the first draw buffer to GL_NONE with
> glDrawBuffersARB in the fix introduced in:
> https://codereview.chromium.org/315283002
> 
> When the extension is not present, it can be assumed that the
> glDrawBuffersARB state need not be set and restored.
> 
> BUG=(wrangling)
> NOTRY=True
> 
> Review URL: https://codereview.chromium.org/375413003

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/382003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282402 0039d316-1c4b-4281-b951-d872f2087c98