GitLab

Instead of using the factories to retrieve the dependended upon keyed service,
pass them explicitly to WebHistoryService from the WebHistoryServiceFactory.

Fix the dependency of WebHistoryService to add the service used and to remove
the service unused.

Move file into //components/history/core/browser, remove unnecessary #include
and fix files that did not #include all the files they used.

BUG=371835

Review URL: https://codereview.chromium.org/882753002

Cr-Commit-Position: refs/heads/master@{#313926}

This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/868253010

Cr-Commit-Position: refs/heads/master@{#313925}

BUG=

Review URL: https://codereview.chromium.org/880003002

Cr-Commit-Position: refs/heads/master@{#313924}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ebfe939..2d45b1e

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/890933002

Cr-Commit-Position: refs/heads/master@{#313923}

base::Time uses int64, but blink time stamps use double. Blink Resource
response time stamps are converted from base::Time. When storing
Resource metadata to the HTTP cache, that double time stamp is converted
back to base::Time. This conversion is lossy and causes metadata to not
being cached due to time stamp mismatch.

The fix is not to convert the time stamp back to base::Time, and do the
comparison in double instead.

R=gavinp@chromium.org, jochen@chromium.org
BUG=chromium:453298

Review URL: https://codereview.chromium.org/887973003

Cr-Commit-Position: refs/heads/master@{#313922}

Revert of Update SSL/malware/net error interstitial design (patchset #3 id:40001 of https://codereview.chromium.org/882973003/)

Reason for revert:

revert_reason: Fails ChromeOS tests.

ErrorPageTest.DNSError_DoClickLink
ErrorPageTest.DNSError_DoReload

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55516

Original issue's description:
> Update SSL/malware/net error interstitial design
> + On small screens the navigation buttons are anchored to the bottom of the screen.
> + Tweaks to the text colour
> + Change button styling of safe browsing page
>
> BUG=422882
>
> Committed: https://crrev.com/c2e35628285c2113775566cd85c52320e6fcf565
> Cr-Commit-Position: refs/heads/master@{#313910}

TBR=arv@chromium.org,edwardjung@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=422882

Review URL: https://codereview.chromium.org/889983002

Cr-Commit-Position: refs/heads/master@{#313921}

After the most recent WebRTC roll, removal of dead code reduced the list by one. The dead code referred to sched_getaffinity which pulled this in.

R=perkj@chromium.org
TBR=mmoss@chromium.org

Review URL: https://codereview.chromium.org/881783004

Cr-Commit-Position: refs/heads/master@{#313920}

See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=dsinclair@chromium.org

Review URL: https://codereview.chromium.org/893603002

Cr-Commit-Position: refs/heads/master@{#313919}

As per
https://docs.google.com/document/d/1aerLjBm5jc7OILH0BDZmDX8npqop38zfnSO824LnH00,
all permanent nodes are treated equally.

BUG=453024

Review URL: https://codereview.chromium.org/884933002

Cr-Commit-Position: refs/heads/master@{#313918}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/888863003

Cr-Commit-Position: refs/heads/master@{#313917}

When run without "--multi-install", an update will properly convert
multi-install Chrome back to single-install.

BUG=452585
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/869153004

Cr-Commit-Position: refs/heads/master@{#313916}

It has been proven (via a live UMA experiment under "SBOffDomainInclusion.InvalidMainFrameURL")
to never happen in off-domain inclusion analysis.

BUG=412468

Review URL: https://codereview.chromium.org/789613008

Cr-Commit-Position: refs/heads/master@{#313915}

BUG=427418

Review URL: https://codereview.chromium.org/888573002

Cr-Commit-Position: refs/heads/master@{#313914}

Sorry if I disabled too many tests...

BUG=453787
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/864313004

Cr-Commit-Position: refs/heads/master@{#313913}

This patch allows sbox_unittests and sbox_integration_tests to pass under ASan/Win
BUG=382867
NOTRY=true

Review URL: https://codereview.chromium.org/891663004

Cr-Commit-Position: refs/heads/master@{#313912}

Cr-Commit-Position: refs/heads/master@{#313911}

+ On small screens the navigation buttons are anchored to the bottom of the screen.
+ Tweaks to the text colour
+ Change button styling of safe browsing page

BUG=422882

Review URL: https://codereview.chromium.org/882973003

Cr-Commit-Position: refs/heads/master@{#313910}

BUG=453318
TEST=manual

Review URL: https://codereview.chromium.org/882423002

Cr-Commit-Position: refs/heads/master@{#313909}

These variables were left unused after
https://chromium.googlesource.com/chromium/src/+/23e63803fbf9a7aaf0a6107e36ea9c2ef6857d95%5E%21/#F1

BUG=None
TEST=components_unittests --gtest_filter=BookmarkCodecTest.*
R=sky@chromium.org

Review URL: https://codereview.chromium.org/889473002

Cr-Commit-Position: refs/heads/master@{#313908}

WebRTC 8207:8214
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/1a48d11..29882bb

Libjingle 8202:8213
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/237ae43..d0c206c

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/882763003

Cr-Commit-Position: refs/heads/master@{#313907}

BUG=453796
TBR=spang@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/865273003

Cr-Commit-Position: refs/heads/master@{#313906}

BUG=

Review URL: https://codereview.chromium.org/887023002

Cr-Commit-Position: refs/heads/master@{#313905}

Don't auto allow access to media devices unless a the security origin of the requester is the same as its ancestors.

This adds a field in MediaStreamRequest to verify that the security origin of the requester is the same as its ancestors.
This field have to be set on the UI-thread and is therefore set just before sending the request to the UI.

BUG=448378
TEST= please see bug report

Review URL: https://codereview.chromium.org/795703003

Cr-Commit-Position: refs/heads/master@{#313904}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0437733..ebfe939

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/890863002

Cr-Commit-Position: refs/heads/master@{#313903}

And, in the process, fix a bug in the CookieTreeModel, where it was prematurely sending BatchEnded events.

BUG=445962, 447395

Review URL: https://codereview.chromium.org/863503002

Cr-Commit-Position: refs/heads/master@{#313902}

After successfull pairing session will call auth API to get access token.

BUG=449864

Review URL: https://codereview.chromium.org/880373004

Cr-Commit-Position: refs/heads/master@{#313901}

BUG=none
R=jshin@chromium.org

Review URL: https://codereview.chromium.org/878143002

Cr-Commit-Position: refs/heads/master@{#313900}

Review URL: https://codereview.chromium.org/889663002

Cr-Commit-Position: refs/heads/master@{#313899}

Revert of Create a Android Sync integration test for typed URLs (patchset #4 id:140001 of https://codereview.chromium.org/862113005/)

Reason for revert:
This is breaking building chrome/android:chrome_sync_shell_test_apk
with gn due to a dependency to the autogenerated enum org.chromium.ui.base.PageTransition;

I am not sure why no bots failed when landing it (we don't seem to have gn builder upstream for android?) but reverting it locally makes it build again.

To repro: Reapply the patch and run
gn gen out/Release  --args='is_debug=false os="android" cpu_arch="arm" use_goma=true goma_dir="/usr/local/google/clank/goma/goma"'

ninja -C out/Release -j 200  chrome/android:chrome_sync_shell_test_apk

Original issue's description:
> Create a Android Sync integration test for typed URLs
>
> This CL introduces JNI plumbing for one method of the FakeServer's
> verification API. One test (testUploadTypedUrl) has been added to use
> the API; it types a URL on the client and verifies that the URL was
> sent to the server.
>
> BUG=NONE
>
> Committed: https://crrev.com/cba424b9309c8c75d0a3797b9b228f7ef11425e4
> Cr-Commit-Position: refs/heads/master@{#313824}

TBR=nyquist@chromium.org,maxbogue@chromium.org,zea@chromium.org,pvalenzuela@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/881753003

Cr-Commit-Position: refs/heads/master@{#313898}

BUG=434643
TBR=jennyz@chromium.org

Review URL: https://codereview.chromium.org/871373011

Cr-Commit-Position: refs/heads/master@{#313897}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8a5af16..0437733

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/889853002

Cr-Commit-Position: refs/heads/master@{#313896}

Mainly, this breaks out braille span classes and the EditableTextBase
class into their own files.  This removes lots of dependencies on code that
should only run in the content script in ChromeVox classic from the
ChromeVox next background script.

BUG=

Review URL: https://codereview.chromium.org/889593002

Cr-Commit-Position: refs/heads/master@{#313895}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/06fb35f..f4ee92e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/886963004

Cr-Commit-Position: refs/heads/master@{#313894}

TBR=kinuko@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/888823002

Cr-Commit-Position: refs/heads/master@{#313893}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/79abaa8..8a5af16

TBR=junov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/891653002

Cr-Commit-Position: refs/heads/master@{#313892}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/863263005

Cr-Commit-Position: refs/heads/master@{#313891}

Pairing generates secret know to the session and
device. The secret will be used for for certificate validation and for device authentication.

BUG=449864

Review URL: https://codereview.chromium.org/877613002

Cr-Commit-Position: refs/heads/master@{#313890}

Following the discussion about the term "main-frame" in https://codereview.chromium.org/843413003/, I experimented with a testing webpage that embedded <iframe>s which triggered different content setting requests.

Apparently, in the descriptions in content_settings.json, we used the term "main-frame" in two different contexts. This CL get rids of the term completely in favor of "top-level frame" and "document which requests X".

BUG=447978

Review URL: https://codereview.chromium.org/883983003

Cr-Commit-Position: refs/heads/master@{#313889}

toolkit-views builds on mac are getting:
Undefined symbols for architecture x86_64:
   ShowProximityAuthErrorBubble

To fix, move proximity_auth_error_bubble.cc to mac_sources. This works
because the symbol is only referenced on platforms with extensions,
which are toolkit_views platforms + mac.

After proximity_auth_error_bubble_view.cc moves in
chrome_browser_ui.gypi from chrome_browser_ui_views_non_mac_sources to
chrome_browser_ui_views_sources then proximity_auth_error_bubble.cc can
be deleted.

BUG=399191
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/887563003

Cr-Commit-Position: refs/heads/master@{#313888}

Currently |SSL_shutdown| is only called to avoid that the
session is marked as unresumable. Without the quiet flag the
close notify message is generated without being sent on the
network.

BUG=None

Review URL: https://codereview.chromium.org/885083002

Cr-Commit-Position: refs/heads/master@{#313887}