- 12 Aug, 2020 40 commits
-
-
Jit Yao Yap authored
The |pem_path_| member of ChromeTestExtensionLoader is currently always empty and so will be unused. This CL adds a method to set the pem_path to be used when packing an extension. Change-Id: I977c29de7f8078d054ee9d8052c7628551356d1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332613 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797150}
-
Mahmoud Gawad authored
Currently, telemetry_extension_ui files are behind !is_official_build flag, while creation of the SystemAppType::TELEMETRY is not. This generates an error when the is_official_build=true indicating that the TelemetryExtension cannot be installed because there are no resources. To achieve consistency, move the creation of SystemWebType::TELEMETRY behind !defined(OFFICIAL_BUILD). Future work, when Telemetry SWX is ready to be shipped with Chrome, move out the SystemApp and resources creation outside !is_official_build flag. Bug: b:153335834 Change-Id: Id4add254e0e032c201c6dd7e54020ab6f262e802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346659Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#797149}
-
Emily Stark authored
This CL fixes a bug where we were incorrectly bailing out on simplified domain elision all together when the whole URL doesn't fit in the omnibox. As background, note that the simplified domain field trials code sets the steady-state omnibox's RenderText into NO_ELIDE mode. This is because RenderText over-elides when a display offset has caused part of the text to scroll offscreen. (I'm not sure if this RenderText behavior is a bug or not, but it's tracked at crbug.com/1099078.) The bug is that ElideURL() was bailing out early if the RenderText() didn't fit the whole URL; instead we want to switch the RenderText into NO_ELIDE mode and then elide in OmniboxViewViews as best we can. (Currently, if the full domain doesn't fit, we elide from the right, but a follow-up CL implements left-edge elision which is better from a security perspective.) This change also serves as a speculative fix for crbug.com/1107912, which I can't reproduce. In that bug, the omnibox seems to somehow get set back into ELIDE_TAIL mode when switching tabs, so that ElideURL() early-returns when landing on a different tab instead of properly eliding to the simplified domain. I'm not sure how the omnibox would be getting set back into ELIDE_TAIL mode, but if this fix makes the problem go away, then it confirms the theory that that is indeed what's happening. Bug: 1107912 Change-Id: I22ede3b875bac343a6d01fc8d5d8aeb25c2bb5e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348156 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#797148}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.57-1597055597-benchmark-86.0.4228.0-r1 to 86-4183.57-1597055597-benchmark-86.0.4229.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If2518c4d7d06fbeb3fc80b26075c4d6a2ab2804e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351855Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797147}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0376edf14e58..c4451adcce85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I090e2c0ed74f1efa5bcaf5528a102055a98286ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351162Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797146}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6ca01b98c51..0377420e4c71 2020-08-12 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1a7566b77503f77308085c1820538a5f0be46ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797145}
-
Keishi Hattori authored
Replaces WebFrame::opener_ with the equivalent Frame::opener_ OpenedFrameTracker has also been moved from WebFrame to Frame Inside WebFrame::Swap(), opener_ needs to be cleared on the old frame before it is detached to avoid it from calling DidChangeOpener() and notifying the browser process. Also the opener must be saved to a local variable, |old_frame_opener| because old_frame->Opener() will be cleared in Detach(). Bug: 1100056 Change-Id: I403afbf7558a84d9ae1a3ba427b7613efd9edeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331958 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797144}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic00a45c271769c471acce9eb08679e42d4f15848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797143}
-
Meilin Wang authored
Bug: b/161481195 Test: manually. Change-Id: Ia86508989c58adb32faef27d74be2910507a382c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333037 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797142}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db1dd1b60d1c..95027d0c5d61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:810097 Tbr: noel@google.com Change-Id: I2fa27e98c89f83c6e28d423b6b91c876e49c3319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351440Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797141}
-
yiyix authored
Moved all video related tests and drawImage related tests. Bug: 1077148 Change-Id: I7eabfa7a2b2770919b7774fb8193a2f6d6d51ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268381Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#797140}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48d951e22d45..d667ad2f0127 2020-08-11 cnorthrop@google.com Tests: Add Mobile Legends trace 2020-08-11 cnorthrop@google.com Capture/Replay: Allow starting capture at an unknown frame If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Capture application frames using triggerTest: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*mobile* Change-Id: I0a60fd9366b1139eb16509439b903d4925c194cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797139}
-
nancylingwang authored
Since we have the circle checking, we can call the CreateStandardIcon interface to convert all apps (including the essential apps/default apps) to the standard icons, and the CreateStandardIcon interface can check whether the icon is circle or not to apply shrink or not. So the default apps checking can be removed. BUG=1114771 Change-Id: I6c60fa8127c6f22e19824e21bffc8720100576f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351259 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797138}
-
Peter Kasting authored
Bug: none Change-Id: I8e0a3a1770185108d270569d9cedafd2853d1914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348193 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797137}
-
Gayane Petrosyan authored
Change-Id: Iffe51fbe33c40264a1b09feb1bc93db5d43b12f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347087Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#797136}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596045560-16c58258c8890a214570e6099d355ac47072ea3d.profdata to chrome-win32-master-1596815835-17de714c85521ed0db12b66b0c37f9edb8bc5aba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6fb471fb588ac5c6d2f1cf01895cce5e65f91a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350494 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797135}
-
Peter Kasting authored
Complies with https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#initialize-members-in-the-declaration-where-possible Bug: none Change-Id: Ie5d21f9bf83bb1dae3ddd9e85b1a0e332687e6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347200 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797134}
-
Ana Salazar authored
Tween type for the animations involved in apps grid cardified state enter and exit should be FAST_OUT_SLOW_IN per spec. Bug: 1115231 Change-Id: Ie80037f25cab3912b5b1436121276002615395ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350134Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797133}
-
Yuwei Huang authored
The host TCP experiment has been rolled out to 100% and we are not seeing any regressions, so this CL makes TCP enabled on the host by default. It can still be disabled by adding a `Disable-TCP` host experiment. Bug: 600032 Change-Id: Ic5694049965e510a69c7c4c547d8d9567c05d997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350390 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#797132}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/11c0f579b1d2..37f547456cc6 2020-08-12 enga@chromium.org Support depth-only/stencil-only copies on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I95a8cef379309105b7cd6bee159c4f5ae6f542d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351083Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797131}
-
Tibor Goldschwendt authored
The history entry appeared because we set the background image URL by setting src of the background image iframe. This CL changes this to contentWindow.location.replace, which does not add a history entry. Fixed: 1114089 Change-Id: I2038de67b7fab71fc732152357a43c3fd885f7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347317 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797130}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia0d0094da38b3c03b53fd14034210edeb30ecf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797129}
-
Peter Kasting authored
These are common operations that aren't necessarily obvious when reading code, and it's easy to get them subtly wrong. Before: TimeDelta frame_time = TimeDelta::FromSeconds(1) / monitor_refresh_rate_; TimeDelta duration = TimeDelta::FromSeconds(frame_count) / monitor_refresh_rate_; double framerate = TimeDelta::FromSeconds(1) / vsync_frame_interval_; double bps = 8.0 / time_per_byte_.InSecondsF(); After: TimeDelta frame_time = TimeDelta::FromHz(monitor_refresh_rate_); TimeDelta duration = frame_count * TimeDelta::FromHz(monitor_refresh_rate_); double framerate = vsync_frame_interval_.ToHz(); double bps = time_per_byte_.ToHz() * 8; Bug: 1104532 Change-Id: I0919738d841177c77294e8983256a0cd93c5338b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337596 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797128}
-
Thanh Nguyen authored
Remove this flag as it is expired and not required now. Bug: 1110680 Change-Id: I1d68f279a0d75286d95cb523c7565e2b481626f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350721Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797127}
-
Joel Hockey authored
Change-Id: Ia50b78d1e3bff37929c44688044b66251eef1edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342230 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#797126}
-
Taylor Brandstetter authored
Bug: chromium:1113227 Change-Id: Ifc8e856fde4cf4eee25149f0a1e86a3cad71ea83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344747 Commit-Queue: Taylor <deadbeef@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#797125}
-
Hirokazu Honda authored
Bug: 811912 Test: HW encoder is used on https://appr.tc/?debug=loopback&vsc=vp9&vrc=vp9 Test: video.EncodeAccel.vp9* Test: webrtc.*.vp9* Change-Id: If0457bac7e06488b54b4fd77e7b7e8e766da3352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298883Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797124}
-
Jaehyun Ko authored
Bug: 1010217 Change-Id: I579859a6926a13c2afc26d273d240056c50703f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344429Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#797123}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If713268ea2c10eddad7d76a37e7347c809c18e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797122}
-
Yuki Shiino authored
Introduces a fast path for conversion from v8::String to WTFString / AtomicString in order to mitigate perf regressions on Android. Bug: 839389 Change-Id: Icb0a9bf4ac756cba02d6d0e73abacfd943996606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333906Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797121}
-
Lei Zhang authored
In the current implementation, sometimes the scope of a page's "pause" is too wide compared to the definition in the spec [1], and sometimes it does not pause at all. So narrow the scope to better conform to the spec, and apply it consistently to all possible ways users can print. This is based on an earlier CL [2] which only did this for printing with the system dialog, but not for Print Preview. Some of the trickier cases handled, which require unpausing, are: - Navigations while previewing. - Printing selections, which require a navigation. [1] https://html.spec.whatwg.org/C/#printing-steps [2] https://crrev.com/c/1669250 Bug: 956832 Change-Id: I9bf274fcfb70eefe896fbbae9ce13a88b6f4dfc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338819Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797120}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ed6947787e7..ab6f9ef34a2b 2020-08-11 mtklein@google.com don't use out of range float values in the test 2020-08-11 mtklein@google.com allow all CPU surfaces 2020-08-11 bsalomon@google.com Check for OOM in GrVkMemory 2020-08-11 michaelludwig@google.com Don't over simplify near-colinear vertices 2020-08-11 jlavrova@google.com Revert "ICU: SkShaper (bidi iterator only)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1086705,chromium:1113777 Tbr: fmalita@google.com Change-Id: I657954a4057e8e2982b0a1db29598e9027fe3bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350554Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797119}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596045560-6c3207dc8f6ea5df1e0c422b4fa4d700088c0a24.profdata to chrome-win64-master-1596801568-da9053c5545285a0551be6620dd66e88ca5fbe04.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ice06ae41f601b795bd2183da56317bee88bf88b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797118}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597168794-5b254c70fb11ba814efe16d5fff8c307263d75ab.profdata to chrome-mac-master-1597190183-f5edc71fe82787227048a24a0d9d0eec5f67340b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I60ad226c5fa2b616778a0d3f3895bc700f5a5504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797117}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f07b5182eeda..c4451adcce85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I03c0ef1b8c586fa4eb418b8e955a38d1d5bebed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797116}
-
Yuki Yamada authored
The previous CL for HeapObserverList https://crrev.com/c/2060348 addressed two things: changing HeapObserverList to HeapObserverSet and allowing removal while iteration, and was reverted for performance reasons. This CL only does the former and avoids performance implications of the latter. This CL is for migration of NewLinkedHashSet. See: https://crrev.com/c/2134039 Bug: 1100257 Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797115}
-
Alice Boxhall authored
AX-Relnotes: n/a Bug: 1114959 Change-Id: If21af718588dc0281cbd096285bd7577582e39d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346685 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#797114}
-
Michael Giuffrida authored
Bug: none Change-Id: I985c149e396912fd65bf0e7ce3ac6710ae8dadb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351140 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797113}
-
Eugene But authored
Synthetic Crash Report feature suppose to upload configs to go/crash after Unexpected Termonation Event, but there are no reports yet. This metric will help to understand where to look for a bug. Bug: 1103752 Change-Id: I350add1794bad8e2f41fb92e2633548884da173d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346941 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797112}
-
Toni Barzic authored
The method was not handling BOOKMARK_TITLE match type, even though it can be added to app list search results. BUG=1084862 Change-Id: I2d805f4553b12dede90226a8bb2150b2b26aff8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349969Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797111}
-