- 22 Oct, 2018 4 commits
-
-
Asami Doi authored
to use an existing script on offline is correct or not. The goal is to import and evaluate as a module script at ServiceWorker. Users can use it by adding type 'module' when register a service worker script. The reason why I use browser tests instead of WPT tests is I want to make sure an installed script works well offline. There is no way to terminate a worker from WPT tests. These new tests are for 'classic' and 'module' scripts. Change-Id: I17f201080eeced93b8dccb8a3867721798b3699c Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 824647 Reviewed-on: https://chromium-review.googlesource.com/c/1276046 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#601465}
-
Nico Weber authored
The value is never read, and storing it makes context snapshot writing nondeterministic. A comment claims that the mere presence of the field is needed to identify prototypes, with a link to https://bugs.webkit.org/show_bug.cgi?id=110436 The code in that patch does indeed use v8PrototypeInternalFieldcount to identify prototypes (see CustomElementHelpers::findWrapperType in that patch), but the corresponding code in modern blink is V0CustomElementConstructorBuilder::HasValidPrototypeChainFor which instead uses a pointer comparison with script_state_->PerContextData()->PrototypeForType(type). However, V0CustomElementConstructorBuilder::PrototypeIsValid() does check `prototype_->InternalFieldCount()` to check if a prototype is already registered -- so keep kV8PrototypeInternalFieldcount around and just keep the uninitialized default value (the code only cares about the number of fields being > 0, not about the value of the field). TBR=peria (who lg'd this, but Gerrit lost the LG) Bug: 870584 Change-Id: If5474f37499121047c4b0232a85435f139e5cbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1292385 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601464}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0b0136ae0e2..21b78cac03d3 Created with: gclient setdep -r src-internal@21b78cac03d3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8adf9ff479a3580f4a77d5bac5caa1a03e940e16 Reviewed-on: https://chromium-review.googlesource.com/c/1292988Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601463}
-
Giovanni Ortuño Urquidi authored
Bug: 896113 Change-Id: I60f8e082a01dd1a7007004ae26ff275c87eaa8bf Reviewed-on: https://chromium-review.googlesource.com/c/1290576Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#601462}
-
- 21 Oct, 2018 36 commits
-
-
Sergei Datsenko authored
If there are watchers on a mount that just got unmounted some paths there will be unresolvable. Fix the code to handle those errors reasonably. BUG=chromium:862835 Change-Id: I9cc993d01c98a20da06a6487dfc59a342f0c7412 Reviewed-on: https://chromium-review.googlesource.com/c/1290055Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#601461}
-
Dominic Battre authored
The privacy team considered the precondition to have browsing history syncing enabled in order to fetch password requirements files as arbitrary as Google cannot learn what sites you visit from the spec fetching (only a very short hash prefix is sent, currently this has size 0). They asked to remove that precondition, which is happening with this CL. This is largely a revert of crrev.com/566756. Bug: 846694 Change-Id: I65ad40758d81de7ba6ab816be8e874e561b06a8b Reviewed-on: https://chromium-review.googlesource.com/c/1292051Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#601460}
-
Robert Sesek authored
Change-Id: I9e929ef2ac76d6bf5a30a538bc2bb84510eb1ea1 Reviewed-on: https://chromium-review.googlesource.com/c/1291629Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601459}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24281eafcf82..e0b0136ae0e2 Created with: gclient setdep -r src-internal@e0b0136ae0e2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic7e805b31bcf019f3147d2cfff4afa08170f06fa Reviewed-on: https://chromium-review.googlesource.com/c/1292987Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/60d5074bd655..24281eafcf82 Created with: gclient setdep -r src-internal@24281eafcf82 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I84510d9b88e91f4cf886e6335188b11597153be5 Reviewed-on: https://chromium-review.googlesource.com/c/1292986Reviewed-by:
-
John Delaney authored
Record the Media.BytesRecevied metrics separately for media players contained in ad subframes. Currently, there is no metric capturing the amount of bytes used to load ad videos via MSE. These metrics are useful for measuring impact of any ad interventions targeting video playback. Bug: 884899 Change-Id: I95a519d2f7393103b5e67d5bed4bf9217a4b2f99 Reviewed-on: https://chromium-review.googlesource.com/c/1288855 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#601456}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c3446511. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26460 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cvazac@akamai.com, igrigorik@chromium.org: external/wpt/server-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib4460436ccd7b0cde87ff5c8c2d18226eeb33542 Reviewed-on: https://chromium-review.googlesource.com/c/1293048 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601455}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bcf7f1a7ed0..60d5074bd655 Created with: gclient setdep -r src-internal@60d5074bd655 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I101d88397140624a7227806c3e2dcb5b4a9a9fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1292985Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/47876718a546..4bcf7f1a7ed0 Created with: gclient setdep -r src-internal@4bcf7f1a7ed0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9c217d42268193138bb253d6e68a14f37c68530c Reviewed-on: https://chromium-review.googlesource.com/c/1292984Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e90cb89640c9..47876718a546 Created with: gclient setdep -r src-internal@47876718a546 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I929880bf51f4d5de7b17a3088e98d49de5e58635 Reviewed-on: https://chromium-review.googlesource.com/c/1292983Reviewed-by:
-
Jamie Madill authored
This reverts commit 57df0676. Reason for revert: Seems to be causing a crash on Mac. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%2010.14%20Release%20%28Intel%29/327 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Experimental%20Release%20%28Intel%29/6072 Crash in __ZN13GrCCPathCache5evictEP18GrCCPathCacheEntry Bug: 897507 Original change's description: > cc: Cache text blobs in the GPU service. > > Since skia's internal caching is keyed on text blobs, its important to > reuse the same object. Make sure we cache text blobs in the > ServiceTransferCache to get a cache hit in skia. > > R=enne@chromium.org > > Bug: 894200 > Change-Id: I8808d649ca3520211d034e07e7d4670ffb39094c > Reviewed-on: https://chromium-review.googlesource.com/c/1292722 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601404} TBR=enne@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894200 Change-Id: I5e0a151c5a539aa8a9b6cac5f9bcf710ba2f405a Reviewed-on: https://chromium-review.googlesource.com/c/1292384Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#601451}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d5c1d247f34a..e90cb89640c9 Created with: gclient setdep -r src-internal@e90cb89640c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie3cb5bd143cf7da9e4e946c3b24f611f2c6a5367 Reviewed-on: https://chromium-review.googlesource.com/c/1292982Reviewed-by:
-
Jungshik Shin authored
This roll has two changes: https://chromium.googlesource.com/chromium/deps/icu.git/+log/ccad447..b029971 One is for the timezone database update to 2018f and the other is to fix a memory misalignment on ARM. TBR=ftang@chromium.org Bug: 896322,473288 Test: See the bug and ICU CL descriptions. Change-Id: I5802783e20637bc2dfa6950abe680a85e42e6c4c Reviewed-on: https://chromium-review.googlesource.com/c/1293045Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601449}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef56f7c65dbe..d5c1d247f34a Created with: gclient setdep -r src-internal@d5c1d247f34a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idcc13920017a8d85f94136177d1d49f6d485978f Reviewed-on: https://chromium-review.googlesource.com/c/1292981Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de43c5dcc872..ef56f7c65dbe Created with: gclient setdep -r src-internal@ef56f7c65dbe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I80ae3b4bb5ae88c3a13fa7eeeaf359b1dac59c38 Reviewed-on: https://chromium-review.googlesource.com/c/1292980Reviewed-by:
-
Mounir Lamouri authored
This CL implements the audibility timer for multiple AudioContexts in AudioContextManagerImpl. The "started" event triggers the tracking and the "stopped" event triggers the calculation of elapsed time followed by UKM data record. Bug: 896944 Change-Id: Id1f635df4783247aca3656d07c02af907ffd72e4 Reviewed-on: https://chromium-review.googlesource.com/c/1289695 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#601446}
-
Corentin Wallez authored
This is a reland after contacting the infra team about the addition of dawn.googlesource.com to allowed_hosts. It also doesn't have the Dawn build targets listed in BUILD.gn. These will be listed separately. Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to translate shaders from SPIRV to other shading languages, and requires glfw for testing. Adds the Zlib license to the list of allowed license for Android. This also adds back shaderc that was very recently removed. So hopefully a new third_party review isn't required. BUG=chromium:870747 Change-Id: Ib5bb0530fc147e41a4f31796c30542e032bf0603 Reviewed-on: https://chromium-review.googlesource.com/c/1286135Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601445}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9979b237ec8f..b1a002e850e1 git log 9979b237ec8f..b1a002e850e1 --date=short --no-merges --format='%ad %ae %s' 2018-10-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@b1a002e850e1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: Iee1b529f6e61f2f3734a8a64b0218a1c31e7e2fa Reviewed-on: https://chromium-review.googlesource.com/c/1292979Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601444}
-
Alan Cutter authored
This CL updates hosted app windows on Mac to paint the site's theme colour and include the hosted app menu button and permission icons. This change is hidden behind the kDesktopPWAWindowing flag. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363793&signed_aid=_Z4yIZ_JlJC81IRgR-cUrA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363794&signed_aid=hHrKili6tqk3XTdQPfWLiQ==&inline=1 Bug: 895690 Change-Id: I7753b5119f165dab9573cc35f6d56cafb1ccfdb8 Reviewed-on: https://chromium-review.googlesource.com/c/1290057 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601443}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01df7b90af69..de43c5dcc872 Created with: gclient setdep -r src-internal@de43c5dcc872 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I85fc12e327737ff437e4cfe93db7abecc361c91c Reviewed-on: https://chromium-review.googlesource.com/c/1292978Reviewed-by:
-
Richard Li authored
Firstly, this CL de-couples the relation between blink::WebReferrerPolicy and blink::mojom::ReferrerPolicy. Then, blink::mojom::ReferrerPolicy is moved into network::mojom::ReferrerPolicy. At last, consumers of blink::WebReferrerPolicy are updated to use network::mojom::ReferrerPolicy. blink::WebReferrerPolicy is finally removed. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo Change-Id: I8a7a37b147c6a7090d9a57917759e5a3a8e9ba87 Reviewed-on: https://chromium-review.googlesource.com/c/1212345 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#601441}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f8c43c97599..9979b237ec8f git log 8f8c43c97599..9979b237ec8f --date=short --no-merges --format='%ad %ae %s' 2018-10-21 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@9979b237ec8f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: Ie0610c5e6f1964c817f8e01d0e1e4ed13d59629d Reviewed-on: https://chromium-review.googlesource.com/c/1292975Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a188b76c8da..01df7b90af69 Created with: gclient setdep -r src-internal@01df7b90af69 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If809b7242f4d48c991fed4e1eee6157db61b4df6 Reviewed-on: https://chromium-review.googlesource.com/c/1292976Reviewed-by:
-
Findit authored
This reverts commit 638ab304. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601431 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzOGFiMzA0MDhjZmNkOTk3MDM5MTYwYzVmZmIxMjZjNWE4MmVmZjMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/51310 Sample Failed Step: content_unittests Original change's description: > AppCache: clean up WeakPtrFactory members in classes with children. > > This CL marks AppCache clases with WeakPtrFactory members as final, and > removes WeakPtrFactory members from classes that have subclasses. > > The superclasses of AppCache classes with WeakPtrFactory members were > checked for WeakPtrFactory members, resulting in minor cleanups. > > This CL does not tackle AppCacheUrlRequestJob, because net:URLRequestJob > (which has a WeakPtrFactory) has 35 subclasses. This case will be > addressed separately. > > TBR=kinuko > > Change-Id: I04bb0757c34fa03620517d04571cba5a0e4a77a5 > Reviewed-on: https://chromium-review.googlesource.com/c/1267337 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601431} Change-Id: I61dd61aee9e5289784403ebfb085c90809d25cde No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1293044 Cr-Commit-Position: refs/heads/master@{#601438}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9b88efb6. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26413 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9bf2285eaa6ecceb31015fa1c2fd513ec7187efb Reviewed-on: https://chromium-review.googlesource.com/c/1293038 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia1ba06bdb9485cc44bd3519856b47e31e898ce40 Reviewed-on: https://chromium-review.googlesource.com/c/1292977Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d4f07760e9ee..0cc11c684b54 git log d4f07760e9ee..0cc11c684b54 --date=short --no-merges --format='%ad %ae %s' 2018-10-20 jmadill@chromium.org StateManagerGL: Remove setGenericShaderState. Created with: gclient setdep -r src/third_party/angle@0cc11c684b54 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I59aec8b4beaca52e168b73e8b38c1a412392686e Reviewed-on: https://chromium-review.googlesource.com/c/1292974Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/6c448e3f5b2f..c67f445aea5f git log 6c448e3f5b2f..c67f445aea5f --date=short --no-merges --format='%ad %ae %s' 2018-10-21 primiano@google.com Merge "Docs: add docsify support" Created with: gclient setdep -r src/third_party/perfetto@c67f445aea5f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I6110a926374d829bb2cdb1bfc35b38484724bc54 Reviewed-on: https://chromium-review.googlesource.com/c/1292971Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/410c469a02ae..3a188b76c8da Created with: gclient setdep -r src-internal@3a188b76c8da The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4d589cc5f3e58a131736cd4f9bf096b9462264c2 Reviewed-on: https://chromium-review.googlesource.com/c/1292972Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/47133fdb992a..8f8c43c97599 git log 47133fdb992a..8f8c43c97599 --date=short --no-merges --format='%ad %ae %s' 2018-10-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d4f07760e9ee..0cc11c684b54 (1 commits) 2018-10-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b8eec4a4ab53..d4f07760e9ee (1 commits) 2018-10-20 mtklein@google.com rename some flattenable routines 2018-10-20 mtklein@google.com move all registration into optional hooks 2018-10-20 mtklein@google.com remove old type deserialization aliases 2018-10-20 mtklein@google.com small tweaks to SkFlattenable::Register 2018-10-20 mtklein@google.com remove unused SkReadBuffer features Created with: gclient setdep -r src/third_party/skia@8f8c43c97599 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I3b41c105ada357e2082e7558346604219eab421c Reviewed-on: https://chromium-review.googlesource.com/c/1292973Reviewed-by:
-
Victor Costan authored
This CL marks AppCache clases with WeakPtrFactory members as final, and removes WeakPtrFactory members from classes that have subclasses. The superclasses of AppCache classes with WeakPtrFactory members were checked for WeakPtrFactory members, resulting in minor cleanups. This CL does not tackle AppCacheUrlRequestJob, because net:URLRequestJob (which has a WeakPtrFactory) has 35 subclasses. This case will be addressed separately. TBR=kinuko Change-Id: I04bb0757c34fa03620517d04571cba5a0e4a77a5 Reviewed-on: https://chromium-review.googlesource.com/c/1267337 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601431}
-
Findit authored
This reverts commit c7e36b09. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601422 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M3ZTM2YjA5MDEzYzA0NmUyNjVkNzBkZmVkMGNhNDBiNzNiYzIzZGEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/mac-dbg/1239 Sample Failed Step: compile Original change's description: > Migrate chrome/test/chromedriver/net/net_util.cc using SimpleURLLoader > > URLFetcher will stop working with advent of Network Service, and > SimpleURLLoader is the replacement API for most clients. > This CL migrates chromedriver and its respective unittests away from > URLFetcher. > > Note that because of the multithreaded nature of the code, the natural > approach was to simply call SharedURLLoaderFactory::Clone and pass > the "info" mojo handle accross threads, until the operational thread. > However, the structure holding this mojo handle is called/passed from > > (i) an indirect chain of BindRepeating calls, > (ii) various threads. > > Given that network::mojom::URLLoaderFactoryPtrInfo and > network::SharedURLLoaderFactoryInfo are both move-only object > (which does not comply with BingRepeating) and that raw > a network::SharedURLoaderLoader instance must operate on the same > thread it was created on, this CL comes up with a local thread-agnostic > "wrapper" to mojom::URLLoaderFactory, named WrapperURLLoaderFactory > (see chrome/test/chromedriver/server/http_handler.cc). > Its instance replaces URLRequestContextGetter instead across threads > and BindRepeating chains just fine. > > This CL is based on the original work of Sergio Villar (svillar@igalia.com) > on [1]. > > TBR=johnchen@chromium.org (John +1'ed the original incarnation of this CL at [1]). > > [1] https://crrev.com/c/1221256 > > Bug: 872887 > > Change-Id: I21386edb04b25438ba3aa40dd5ecc1461342aecf > Reviewed-on: https://chromium-review.googlesource.com/c/1289849 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601422} Change-Id: I0bb5f07fde222dacb7e34892d907458c8b8535a5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872887 Reviewed-on: https://chromium-review.googlesource.com/c/1293041 Cr-Commit-Position: refs/heads/master@{#601430}
-
Philip Rogers authored
BlinkGenPropertyTrees (BGPT) is an incremental step towards making compositing decisions after the paint lifecycle phase. The primary changes are to build property trees in blink and send a layer list to the compositor, rather than building property trees in cc from a layer tree. This patch marks the project as experimental which will give us test and perf coverage on the bots. Sheriffs: This shifts time (e.g., we now run PaintArtifactCompositor and no longer run the cc property tree builder) and will likely change performance benchmarks. Because this is an initial trial, feel free to roll this patch out. Bug: 836884 Change-Id: Ia1073bdd0922503925c17161f052bdfcd94196b7 Reviewed-on: https://chromium-review.googlesource.com/c/1292555Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601429}
-
Philip Rogers authored
This patch prepares for promoting BlinkGenPropertyTrees (BGPT) to experimental by ensuring all unit tests pass. This patch has three changes: 1) The foreign layer BGPT code has been disabled when SPV2 is on in LocalFrameView::PaintTree. 2) Some CompositedLayerMapping tests of non-BGPT code have been changed to only run without BGPT. 3) ScrollingCoordinatorTest of sticky have been updated to look up sticky constraints on property trees when BGPT is enabled. Bug: 836902 Change-Id: If5c32b3e02c0908bf505bddbb2d4b635b8049555 Reviewed-on: https://chromium-review.googlesource.com/c/1287169Reviewed-by:
-
Alan Cutter authored
Subclasses of BrowserNonClientFrameView that contain a HostedAppButtonContainer child view have duplicate logic outside of creation, colors and layout. This CL dedupes the logic involved in having a HostedAppButtonContainer in preparation for adding one to BrowserNonClientFrameViewMac. Bug: 895690 Change-Id: If2e5d58af58cd72ea9d0902d3a15f3375a9e1585 Reviewed-on: https://chromium-review.googlesource.com/c/1288092Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601427}
-
Ryan Sturm authored
This is a reland of 310c6fa1 This was caused by a CL that landed on Friday morning that was missing a RunUntilIdle (that was added for the rest of the tests in the file). https://chromium-review.googlesource.com/c/chromium/src/+/1289086 added the failing test. The delta for the reland is adding a RunUntilIdle. Original change's description: > Switching Previews triggering from the IO thread to the UI thread > > This CL moves previews triggering from the IO thread > (ChromeResourceDispatcherHostDelegate) to the UI thread > (ChromeContentBrowserClient). The new call sites occur in > NavigationRequest and update the previews_state in > CommonNavigationParams held by the NavigationRequest directly. This > means PreviewsDeciderImpl is being moved to the UI thread. > > Significant changes: > - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of > profile IO data. > - PreviewsUserData is now entirely a UI thread notion. For now, we use > PreviewsUITabHelper to manage its lifetime, but it could move to > NavigationHandle (if NavigationHandle already supported UserData, > that solution would be ideal). > - ChromeNavigationData is update to remove PreviewsUserData and > PreviewsState (the latter has moved into PreviewsUserData and there is a > notion of Allowed PreviewsState and committed PreviewsState) > - Offline Previews committed checks use the OfflinePreviewsTabHelper > instead of PreviewsUserData now that we are on the same thread. > - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well > as cleanup to remove PreviewsState from being passed back out of the > loader code into NavigationRequest. > - There is a TODO to re-evaluate PreviewsState during redirects, which > will *not* be plumbed into the network service, so DataReductionProxy > Previews will not be updated. > > Bug: 842233 > Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb > Reviewed-on: https://chromium-review.googlesource.com/c/1266196 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601298} Bug: 842233,897385 Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8 TBR=jochen@chromium.org,clamy@chromium.org,tbansal@chromium.org,mmenke@chromium.org,jianli@chromium.org Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8 Reviewed-on: https://chromium-review.googlesource.com/c/1292955Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#601426}
-
