- 24 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f9898ac95a9b..ba416f33b636 2020-06-24 jbudorick@chromium.org devil: add --blacklist-file back to device_recovery temporarily. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1097306,chromium:1098775 Tbr: oysteine@google.com Change-Id: I159571126491456342e82e581731350ee2c92154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782037}
-
Lily Chen authored
Warning messages for cookies with unspecified SameSite that are accessed in a cross-site context, and for cookies with SameSite=None but not Secure, are removed from the JS console in DevTools. Analogous warnings have been added to the DevTools Issues Panel, so these are no longer needed. Bug: 977040 Change-Id: I7089e11679d603db8e9bb6e1380dca949dd2aa89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264262Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#782036}
-
David Dorwin authored
This reverts commit c0913ca9 and most of commit b11af76b, including support for release channel suffix on packages, archive_name_override, and C++ build flags for channel name. context_provider_test_connector.* are kept in their new locations. The TODO for https://crbug.com/1046615 is removed as that is obsolete. Bug: 1029184,1046615,1049378 Change-Id: Ia0b7191d15a889bc497ce77a4250b9db168e58f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262594Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782035}
-
Lucía Cantú-Miller authored
Several console methods were intended for old Chrome versions that are not longer supported. Console.messageAdded event was eliminated and Chrome 54 TODOS where resolved. Unit test was updated to test newer Chrome versions. Bug: chromedriver:3518 Change-Id: Iebf08a32a3c90d3ffd200fb81686c54a636d49f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259132Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lucía Cantú-Miller <cantumiller@google.com> Cr-Commit-Position: refs/heads/master@{#782034}
-
Robert Ogden authored
m.foo.com can set cookies on foo.com, so when checking for cookies in the eligibility code path, any cookie applicable to the same or higher domain up until TLD should cause the prefetch to be non-eligible. Also adds some browsertesting in the same vein. Bug: 1096765 Change-Id: I23801d45bbdd789b52977613bf1086deda166460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264933Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782033}
-
Yves Arrouye authored
By default the absence of the flag means that the feature is disabled. This is to protect code while in development. Bug: chromium:1098854 Test: Manual Change-Id: I20063bf28ea74d9aeaa1bb541809fc6ab7162c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264577 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#782032}
-
Tim Judkins authored
Changes the expected schema format that indicates promise support to no longer specify a callback in the parameters, but instead supply a "returns_async" key. This key species the format of the return value to the promise, or to the callback if one is supplied. Also adjusts associated tests to check for such. Bug: 978538 Change-Id: Ifcb0b8e8152fd6b6c9049e2d856b10d577c955fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253205Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#782031}
-
Daniel Rubery authored
These tests were disabled due to MSan failures, but have been fixed by https://chromium-review.googlesource.com/c/chromium/src/+/2253759 Fixed: 1096972 Change-Id: I49d5da2660c78a55b7b5590e7b6f775c4bf65a0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264018Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Auto-Submit: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#782030}
-
Charlie Hu authored
The CL which caused the flakiness was reverted in (https://chromium-review.googlesource.com/c/chromium/src/+/2218833). The cause was attaching request params to image requests causing multiple requests being sent(previously only one request with one url). Upon first layout, different number of requests complete causes flaky behaviour. Unmark the test as flaky. Bug: 1087208 Change-Id: I5124c9107b50500962e82e63c6f846f557d6f282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261255Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782029}
-
Devlin Cronin authored
Allow action.setIcon() to be called from ServiceWorker contexts. Also expand the existing MV3 browsertest to cover calling setIcon() from a ServiceWorker context. Bug: 893373, 1093832 Change-Id: Iedf20774dd7653245777ff8046e667d024dd3979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257274Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782028}
-
Charlie Hu authored
The test sometimes timeouts currently. It is suspected some slow bots cannot handle 6 test_no_interpolation within assigned time limit. Increase the time limit for the test. Further inspection is required if the test is still flaky afterwards. Bug: 1087208 Change-Id: I29ce6f0ec8f3b1a92642a586be8f3633f9c7a5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259253 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
-
danakj authored
In that case we can't wait for results, and we just end the test instead of crashing. R=avi@chromium.org Bug: 866140, 1098835 Change-Id: I954be9e0ec795d5e17dbfb054b2c4479e3d772ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264938Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#782026}
-
yilkal authored
Send ARC++ applications that should be hidden from the family link app through ChildStatusReport. Example of these apps are the new ARC++ TWAs installed through playstore. The user is not able to launch these applications from the launcher and hence they shouldn't be added to AppActivityRegistry. Bug: 1093072 Change-Id: I0b6bd2016cf5c00bf5096d90d88c0ebbf500cecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252919Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
-
Yu Su authored
- enable lens shopping experiments variants for google.com - add unit tests to LensUtilsTest for shopping intent Bug: 158099013 Change-Id: Ib605afcfe069320a0b2a52d4ea045759a39e3592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261093 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#782024}
-
Katie D authored
This brings extensions APIs that access accessibility features up to date. Bug: None Change-Id: Iab3b588738b148ee0249488ce47c0bbd86f31cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261179 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
-
Kramer Ge authored
Currently a wl_surface is in a 1:1 relationship with WaylandWindow. To get wayland subsurface forwarding, fields that are 1:1 to wl_surface should be grouped and moved out of WaylandWindow. In the future, WaylandWindow can have 1 to many relationship with wl_surfaces, some of which are assigned wl_subsurface role. A new WaylandSurface class is created. Original WaylandSurface is now renamed to WaylandToplevelWindow. Bug: 1063865 Change-Id: I23feed2a98329e3c0cc5067065af6e7dd1b2e4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261252Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#782022}
-
Tom Anderson authored
R=adunaev,sky CC=msisov,nickdiego Change-Id: I88402f8562b37ee7eee4013331c593ad093e47ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258350 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#782021}
-
Charlie Hu authored
Using |DefaultHash<mojom::blink::DocumentPolicyFeature>| to substitute |IntHash<mojom::blink::DocumentPolicyFeature>| fixes the timeout issue in release build. Note: Although |DefaultHash<mojom::blink::DocumentPolicyFeature>| is defined in document_policy_feature.mojom-blink-forward.h, its hash impl |blink_mojom_internal_DocumentPolicyFeature_DataHashFn| is defined in document_policy_feature.mojom-blink.h. Include forward.h is not enough for DefaultHash to be used as HashTrait. Bug: 1069021 Change-Id: Ia267c2de06f8fbc787e471103fcccc8ce861b1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264854Reviewed-by:
-
Jimmy Gong authored
- Status text was missing a set width, resulting in its column overlapping the "Date" column. Screenshot: https://screenshot.googleplex.com/kct7u0vDHPw Bug: 1055841 Change-Id: I9d251867a48dbacddaf7e2a0d036390c0edae751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264498 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782019}
-
Juan Mojica authored
Bug: 1098431 Change-Id: I59d6d61731c4eb515ee1bc648adf7c8607133f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261258 Auto-Submit: Juan Mojica <juanmojica@google.com> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#782018}
-
Moe Ahmadi authored
crrev.com/c/2206222 broke this behavior by making the outer <div> focusable and preventing the inner <button> to which the click handler is attached to from gaining focus. This CL restores the original behavior by attaching the handlers to the outer focusable container. It also simplifies the a11y setup by making the outer container a real button and the inner container an unfocusable div. Bug: 1095549 Change-Id: Iacc1d5f673545cd25cc93965463d57d7447a7ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264801 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782017}
-
Mohamed Amir Yosef authored
This is a follow up to crrev.com/c/2254319 By using the layout constants instead of the hard coded values. For the combobox, this however affects only Mac The reason for that is on Mac both config.icons_in_label and type_ == Type::kCheckbox evaluated to true. while on Linux both were false. Screenshots: Before: https://screenshot.googleplex.com/YC96zjVu2Cx After: https://screenshot.googleplex.com/Uusea7yG6wd Bug: 1044038 Change-Id: I20ee4e2aa416e0405df7a660e419b2b3a01e16e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264335Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#782016}
-
Taylor Brandstetter authored
The underlying data channel always returns true on sending, asynchronously invoking a callback to notify that the message was sent, so there's no reason not to call it asynchronously at the blink level. This will make the main thread more responsive. Bug: webrtc:11547 Change-Id: I8a8fd518bf25d14242561501a3b05c614be0a3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255317 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782015}
-
Matt Menke authored
It previously had no logic to evict unexpired entries, but we'll be keying it on NIK soon, which will potentially blow up the number of entries. To avoid this causing issues, either with memory usage, disk usage, or load time, we need to add such logic. Bug: 1091496 Change-Id: Ifa875726dfa36e1796a78c5e7ceac41cef7953af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240031 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#782014}
-
Lei Zhang authored
Now that this function exists, there is no need to reinvent it. Bug: 1009837 Change-Id: I2980378d90d7c2f7440caec519d532d3656ee569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261696Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782013}
-
Haiyang Pan authored
Bug: 1098111, 997376 Change-Id: Ie7a98821799cb45e0db94cd4e1aa61fb064066b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261693Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#782012}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592999982-db22937bc7e305fa743bdb260ed4ee93f882ca20.profdata to chrome-mac-master-1593021431-7b0ea0cd42ff146f154f99cb6b34c129710780a4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: Ia94664cb2170f6f73d63338f6df5b7bbe1cd1a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264850Reviewed-by:
-
Anastasia Helfinstein authored
Instead of doing nothing if the focus ring manager hasn't yet been initialized, initialize it. Fixes a bug where there's no focus ring when the feature is enabled. TBR=dtseng@chromium.org AX-Relnotes: n/a. Bug: None Change-Id: I5cb3c4f7e837b5d0c6ffbdd969fc4594b9359b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264880Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#782010}
-
Chong Gu authored
Switch from headless ozone to scenic for viz_unittests. Bug: 865172 Change-Id: I1103b27b5e9285ad90612e6597b35b5c2bab0d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258360 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782009}
-
Sky Malice authored
Will be disabled when either SDK is <= M, or when run on an emulator. These are the configurations we're currently seeing flakes on. Bug: 1095535 Change-Id: I16aca30f1535cfafc706fe10932b42dcbebc50d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255125Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#782008}
-
Eric Lawrence authored
Previously, failing to invoke an external protocol handler ('foo://bar') would fail silently if the protocol was not registered or if the user gesture requirement was not met. This limitation made it difficult for web developers to troubleshoot such situations. This CL emits errors to the Developer Tools console when the protocol handler is not registered, is forbidden, or is temporarily blocked pending a user-gesture. Similarly, if an external handler is launched, an informational log entry is added. Bug: 1096610 Change-Id: Ie562d0c030f138f7e5ac0a09576ba73a79de3971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252848Reviewed-by:Matt Giuca <mgiuca@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782007}
-
Asanka Herath authored
These settings are directly controlled via feature flags and field trials. On the browser, they are used to filter out surfaces that should be excluded from the study. Such exclusions are meant as a privacy measure. On the renderer, they are used to prevent specific surfaces from being sampled in the first place. Such an exclusion is meant as a granular kill switch to account for unforeseen adverse effects of the act of sampling a surface. Browser-side filtering of reported data cannot address such issues. Directory layout including per-directory division of responsibilities is now described in //docs/privacy_budget_code_locations.md. Bug: 973801 Change-Id: Id0ba366a4f5625a59d5b40031d80764d3584a892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232892Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#782006}
-
Tibor Goldschwendt authored
Logging for dark image doodles works identical to light image doodles but with different logging URLs. + Remove DoodleLogging feature flag. Doodle logging is enabled since a long time and there is other code that assumes doodle logging is enabled. Bug: 688960 Change-Id: If825a29abb8e23c11fa837cac4fd7288e0107fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262057 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782005}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/54f92068caa2..47daa4df3387 $ git log 54f92068c..47daa4df3 --date=short --no-merges --format='%ad %ae %s' 2020-06-22 rsbultje Accumulate leb128 value using uint64_t as intermediate type Created with: roll-dep src/third_party/dav1d/libdav1d R=dalecurtis@chromium.org,tguilbert@chromium.org Bug: 1098714 Change-Id: Ie5ae97d3979ba5873d2f24b39eb2deb83cb9fbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264798 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782004}
-
Jeremy Roman authored
This makes the origin trial functional pending the issuance of tokens. It includes a test that verifies that the default feature state is appropriate for this trial, and adjusts those defaults. Also as a consequence of this, cross-origin portals will now be disabled by default. They can be re-enabled for development purposes only via: flags: chrome://flags/#enable-portals-cross-origin or switch: --enable-features=PortalsCrossOrigin Finally, the toggling of these makes our tests a little wonky. Previously we were forcing the browser-side logic on in response to experimental web platform features, but some tests rely on cross-origin portals which probably shouldn't be on for all users with experimental web platform features. Instead these tests are moved to a virtual test suite for the time being, consistent with a number of other unlaunched features. Bug: 1040212,1093466 Change-Id: I7dd75e0e2053206368d806439eed4b6b918a1a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240057 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#782003}
-
David Tseng authored
This reverts changes: 4fe3a6a4 Ensure AccessibilityManager::ChromeVoxDeferredLoader's warmup utterance targets Googletts 8df286c2 Moves load progress tones from js to native which were mainly workarounds for slow Google tts during the web assembly porteffort. This revert removes now unnecessary complexity around ChromeVox's load path now that text to speech is native. R=dmazzoni@chromium.org TBR=dmazzoni@chromium.org Change-Id: I8cdc9a946b1c112011aabfd3babd533aff03ed2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264193Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782002}
-
Toni Barzic authored
When the user navigates through launcher using search + up or down, the a11y focus jumps from expand button (in app list widget) to search box view (in search box widget) using new focus override. When focus is about to move from the expand arrow to the search box, the expand arrow is announced twice - the wrapped cursor for the expand arrow node first transitions from (expand arrow node, -1 index) to (expand arrow node, 0 index), and the direct transitions are only looked up if the current and the next cursor are equal. This changes Cursor.move to keep the existing index if directional line move cannot find the next node, so wrapped cursor movement can fall-back to the node's next/prev focus. AX-Relnotes: Fix search + up/down traversal in Chrome OS launcher. BUG=1010967 Change-Id: Ib92351084350a7fcf2006441fa9e74998225354b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261992Reviewed-by:
-
David Van Cleve authored
It was changed around a month ago to be mandatory. Change-Id: I4c76887f77aee2dc62efb4c7ce034541cc96e9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264840 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593007185-9f44ccb8893f05162537134149388feea4a6ce51.profdata to chrome-win64-master-1593014209-7e980a1dfa67a2e51666ab74889d15022f0ab030.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I1fa97208cbe7355b5e32d27f8eca090c446dc681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264839Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I67baddf930ff8efec7cd14b7b456d905541a0630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264624Reviewed-by:
-
