GitLab

Review URL: http://codereview.chromium.org/7640022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96621 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91737
R=mmenke@chromium.org,dtseng@chromium.org
TEST=browser_tests --gtest_filter=WebUIBrowserAsyncTest.*

Review URL: http://codereview.chromium.org/7576024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96620 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7637018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96619 0039d316-1c4b-4281-b951-d872f2087c98

https://bugs.webkit.org/show_bug.cgi?id=66037 upstream.

BUG=
TEST=

Review URL: http://codereview.chromium.org/7637002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96618 0039d316-1c4b-4281-b951-d872f2087c98

Convenience methods for WindowedNotificationObserver.

R=phajdan.jr@chromium.org
BUG=various
TEST=none


Review URL: http://codereview.chromium.org/7489019

TBR=gbillock@chromium.org
Review URL: http://codereview.chromium.org/7633032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96617 0039d316-1c4b-4281-b951-d872f2087c98

R=apatrick@chromium.org
BUG=none
TEST=everything still compiles

Review URL: http://codereview.chromium.org/7634014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96616 0039d316-1c4b-4281-b951-d872f2087c98

Previously we'd crash (DCHECK in Debug, SEGV in Release) if the client (plugin)
requested more than 10 concurrent Decode()s, because that's how many input
buffers the OMX component would have.  Now we just queue extra Decode()s and
drain them as we get buffers back from the decoder.
Added test coverage.

BUG=none
TEST=ovdatest, gles2

Review URL: http://codereview.chromium.org/7461154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96615 0039d316-1c4b-4281-b951-d872f2087c98

So instead of:

base::Value::ValueType

We write a nice:

base::Value::Type

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7634018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96614 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96613 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=
TEST=


Review URL: http://codereview.chromium.org/7640024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96612 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7587011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96610 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51716,92717
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7633028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=68657
TEST=CookieMonsterTest.InitializeFromCookieMonster

Moving here from http://codereview.chromium.org/7541021/

TBR=rdsmith
TBR=zel

Review URL: http://codereview.chromium.org/7599025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96607 0039d316-1c4b-4281-b951-d872f2087c98

Fixes a corner case bug in the HexStringToInt conversion function which caused the string "0x" to be treated as a valid hexadecimal number.
Although the parsed result was 0, the boolean flag returned indicated that the hex number was in proper format

The IteratorRangeToNumber class's Invoke function increments the string pointer by 2 if the string starts with "0x" or "0X" and the length is greater than *or equal* to 2
If the length of the string is 2, i.e "0x", after the pointer increment, the string would be empty and the function returns true as the parse result

Changed the condition from "greater than or equal to" to "greater than"

Added another test cases which now properly treats "0x" as an invalid hex string

Contributed by ali.akbar@gmail.com

BUG=92054

Review URL: http://codereview.chromium.org/7584031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:17755
TEST=manual
Review URL: http://codereview.chromium.org/7635027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96604 0039d316-1c4b-4281-b951-d872f2087c98

Fixes the test break on ChromeOS.

TEST=none
BUG=none

modified:   chrome/browser/ui/panels/panel_browsertest.cc

Review URL: http://codereview.chromium.org/7629023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96603 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18953
TEST=Login on production build and check for extra extension processes

Review URL: http://codereview.chromium.org/7630002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=87457
TEST=none
R=mirandac
TBR=zea,willchan

Review URL: http://codereview.chromium.org/7639002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96596 0039d316-1c4b-4281-b951-d872f2087c98

We need to do so because we now have asserts which make sure ref/deref of RefCounted happen on the right thread.

TEST=None
BUG=None


Review URL: http://codereview.chromium.org/7629006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96595 0039d316-1c4b-4281-b951-d872f2087c98

This was causing auto-complete popup windows to have their contents always overpainted by the linen texture, since contents_size was empty for them.

BUG=92645
TEST=see bug

Review URL: http://codereview.chromium.org/7640018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96594 0039d316-1c4b-4281-b951-d872f2087c98

Convenience methods for WindowedNotificationObserver.

R=phajdan.jr@chromium.org
BUG=various
TEST=none


Review URL: http://codereview.chromium.org/7489019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96593 0039d316-1c4b-4281-b951-d872f2087c98

Flash forwards some window messages when it has no handler set. The only ones I've observed are WM_MOUSEWHEEL and WM_GESTURE (gestures are supported only on Win7). So, we need to allow these messages through the UIPI boundary. 

One important note is that I use per-process message filters on Vista, but per-window filters on Win7 or later (because they're supported). 

BUG=86810
TEST=None.
Review URL: http://codereview.chromium.org/7617019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96592 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/7614001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96587 0039d316-1c4b-4281-b951-d872f2087c98

On the Mac GPU bot, tex_image_and_sub_image_2d_with_video occasionally fails.
Marked as flaky until resolved.

BUG=92587
TEST=gpu_tests --gtest_filter=WebGLConformanceTests.tex_image_and_sub_image_2d_with_video


Review URL: http://codereview.chromium.org/7633007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96586 0039d316-1c4b-4281-b951-d872f2087c98

Hopefully this isn't too draconian.

BUG=19878
TEST=none

Review URL: http://codereview.chromium.org/7634002

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/7634030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96584 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7634013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96583 0039d316-1c4b-4281-b951-d872f2087c98

Revert 96567 - Reland 96406 - Print preview page selection should not require a rerendering of draft pages.

On page selection, regenerate the complete document with the selection, but preserve the existing draft pages and simply display a subset of them.

1. Added a new param |clear all preview data| to |PrintHostMsg_DidGetPreviewPageCount|.
2. Removed |requested_preview_page_index| from |PrintMsg_ContinuePreview|

Review URL: http://codereview.chromium.org/7544018

Original Commit: http://src.chromium.org/viewvc/chrome?view=rev&revision=96406

Revert Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96414

BUG=84383
TEST=print preview works after code changes.

Review URL: http://codereview.chromium.org/7628019

TBR=kmadhusu@chromium.org
Review URL: http://codereview.chromium.org/7639023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96581 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49379
TEST=none

Review URL: http://codereview.chromium.org/7523060

TBR=hnguyen
Review URL: http://codereview.chromium.org/7629019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96580 0039d316-1c4b-4281-b951-d872f2087c98

tests.
BUG=none
TEST=none
TBR=hnguyen

Review URL: http://codereview.chromium.org/7640017

TBR=hnguyen
Review URL: http://codereview.chromium.org/7637017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96579 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18769
TEST=Lock icon for wifi should not be visible in the bottom-right corner in the status bar, but should still be visible in the menu and the network settings page. (See issue).

Review URL: http://codereview.chromium.org/7637007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96578 0039d316-1c4b-4281-b951-d872f2087c98

We've moved our i18n library from v8/src/extensions/experimental to a separate
code.google.com project. Some files were renamed, and gyp file was cleaned up.

We will update webkit tree once this DEPS change propagates to chromium port of WebKit.

Pros:
- Faster development cycle
- Makes easier for v8 team to handle merges and rolls to chromium
- Library uses only public v8 API so we don't expect breakages

Cons:
- Library is not so visible now that's outside of v8 tree
Review URL: http://codereview.chromium.org/7583050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96577 0039d316-1c4b-4281-b951-d872f2087c98

completing the request (returning 0 bytes from a read).

BUG=91898
TEST=net_unittests
Review URL: http://codereview.chromium.org/7569027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96576 0039d316-1c4b-4281-b951-d872f2087c98

TBR=akalin
BUG=
TEST=

Review URL: http://codereview.chromium.org/7634027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96575 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7613009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96574 0039d316-1c4b-4281-b951-d872f2087c98

Hopefully this isn't too draconian.

BUG=19878
TEST=none

Review URL: http://codereview.chromium.org/7634002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96573 0039d316-1c4b-4281-b951-d872f2087c98

Allocate |url_label_| on the stack instead of in the free store(heap), and set
set_parent_owned to false.

Thus, we manage its memory when we create a unittest with EditDetails::NEW_FOLDER.

BUG=92159
TEST=None

R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/7617006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96572 0039d316-1c4b-4281-b951-d872f2087c98

The CL also adds a simple framework for writing platform
independent tests.

TEST=PanelBrowserTest.DragPanels
BUG=73936

modified:   chrome/browser/ui/panels/native_panel.h
modified:   chrome/browser/ui/panels/panel_browser_view.cc
modified:   chrome/browser/ui/panels/panel_browser_view.h
modified:   chrome/browser/ui/panels/panel_browser_view_browsertest.cc
modified:   chrome/browser/ui/panels/panel_browser_window_cocoa.h
modified:   chrome/browser/ui/panels/panel_browser_window_cocoa.mm
modified:   chrome/browser/ui/panels/panel_browser_window_gtk.cc
modified:   chrome/browser/ui/panels/panel_browser_window_gtk.h
modified:   chrome/browser/ui/panels/panel_browsertest.cc

Review URL: http://codereview.chromium.org/7605009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96571 0039d316-1c4b-4281-b951-d872f2087c98

Caught by clang chromiumos bot.

TBR=thakis

Review URL: http://codereview.chromium.org/7635021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96570 0039d316-1c4b-4281-b951-d872f2087c98

Moving from http://codereview.chromium.org/7355025/

BUG=XXXX
TEST=BrowsingDataCookieHelperTest

TBR=rdsmith

Review URL: http://codereview.chromium.org/7601018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96569 0039d316-1c4b-4281-b951-d872f2087c98