GitLab

BUG=128472
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/10377183

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137665 0039d316-1c4b-4281-b951-d872f2087c98

This is upstreaming a Gentoo Linux patch.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10389187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137664 0039d316-1c4b-4281-b951-d872f2087c98

(This re-enables by default, it was only supposed to be off on M20 branch)

Turning on by default before M20 branch, but leaving flag code for now so that
it's just a one-liner to disable if necessary post-branch.

BUG=118552,112879

Review URL: http://codereview.chromium.org/10281003

TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10310173

TBR=scottmg@google.com
Review URL: https://chromiumcodereview.appspot.com/10386191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137663 0039d316-1c4b-4281-b951-d872f2087c98

The CLs that this is restoring are http://codereview.chromium.org/10343007 and http://codereview.chromium.org/10381021. 

BUG=121695
TEST=

Review URL: https://chromiumcodereview.appspot.com/10392007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10310067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137659 0039d316-1c4b-4281-b951-d872f2087c98

Nothing is wrong with this patch, but we don't want to submit refactoring
patches until M20 issues are fixed.

BUG=126672
TEST=unit_tests --gtest_filter="GData*"


Review URL: https://chromiumcodereview.appspot.com/10383156

TBR=hashimoto@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10399063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137658 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126672
TEST=unit_tests --gtest_filter="GData*"


Review URL: https://chromiumcodereview.appspot.com/10383156

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137657 0039d316-1c4b-4281-b951-d872f2087c98

ui_tests are all gone now, so the old exclusion no longer applies.  We
should nuke the ui_tests exclusion file once the browser_tests bots are
looking greener.  For now it's a nice reference.

TBR=thestig@chromium.org
BUG=104517

Review URL: https://chromiumcodereview.appspot.com/10382219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137656 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137652 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10392131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137651 0039d316-1c4b-4281-b951-d872f2087c98

TEST=PluginTest
BUG=128519
TBR=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10406028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137650 0039d316-1c4b-4281-b951-d872f2087c98

TEST=GeolocationApiTest
BUG=128518
TBR=erikkay

Review URL: https://chromiumcodereview.appspot.com/10392145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:127779
TEST=Manual testing on the Alex device.


Review URL: https://chromiumcodereview.appspot.com/10332115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127687
TEST=Should not be able to rename in readonly directory.
Review URL: https://chromiumcodereview.appspot.com/10387152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137647 0039d316-1c4b-4281-b951-d872f2087c98

Move Cryptohome D-Bus method calls to chromeos::CertLibrary

BUG=125848
TEST=can login

Review URL: https://chromiumcodereview.appspot.com/10332191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137646 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126898
TEST=

Review URL: https://chromiumcodereview.appspot.com/10399047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137643 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137642 0039d316-1c4b-4281-b951-d872f2087c98

Revert 137538 - Nacl sdk Nacl sdk automated test(method-testNaClSDK) of new installation process of NaCl sdk.

+++ REVERT NOTICE +++
Reverting because this test is failing on all QA bots.
http://master.chrome.corp.google.com:8012/builders/Chrome%20Linux64%20Ubuntu%20QA/builds/4028/steps/pyauto_functional_tests/logs/stdio
http://master.chrome.corp.google.com:8012/builders/Chrome%20Mac%2010_7%20QA/builds/1189/steps/pyauto_functional_tests/logs/stdio
+++               +++

-Changed list of files being checked for NaCl sdk installer.
-Changed Download and unziping of nacl_sdk folder on all the platforms(Used Zipfile module).
-Changed installation of NaCl SDK.
-Removed Hello world examples from test case.
-Added new examples like Input Events, Dynamic Library(Magic * ball), Load progress, Multi-threaded input events, Web socket
Code Cleanup:
-Removed unused methods and pre-defined global variables.
-Removed pre-release gallery test.test(method-testNaClSDK) of new installation process of NaCl sdk.

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10310047

TBR=pnihalani@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10389188

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137640 0039d316-1c4b-4281-b951-d872f2087c98

This removes the behaviour where browser actions get generated if missing,
but maintains the behaviour of page actions becoming browser actions if the
action box is enabled.

BUG=127988

Review URL: https://chromiumcodereview.appspot.com/10382216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137639 0039d316-1c4b-4281-b951-d872f2087c98

Only return the visible page actions from PageActionController.

This is a bit of a yak shave to support having the "action box" show active
extensions on the current page rather than page actions. Previously,
PageActionController was creating widgets for everything then
LocationBarViewGtk was hiding them as necessary. This is assumes too much; we
need to push the visibility logic into the Controller for the future.

BUG=127988


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137630

Review URL: https://chromiumcodereview.appspot.com/10388160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10389164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137637 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10383229

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137636 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/10008047 introduced delete-with-inflight-tasks in Write sequence but I failed to convert this callback to use WeakPtr().

BUG=128178
TEST=manual test

Review URL: https://chromiumcodereview.appspot.com/10408006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=timurrrr
Review URL: https://chromiumcodereview.appspot.com/10406026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137634 0039d316-1c4b-4281-b951-d872f2087c98

- move property definitions to window_properties
- removed unused kOpenWindowSplitKey

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10384212

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137633 0039d316-1c4b-4281-b951-d872f2087c98

Only return the visible page actions from PageActionController.

This is a bit of a yak shave to support having the "action box" show active
extensions on the current page rather than page actions. Previously,
PageActionController was creating widgets for everything then
LocationBarViewGtk was hiding them as necessary. This is assumes too much; we
need to push the visibility logic into the Controller for the future.

BUG=127988


Review URL: https://chromiumcodereview.appspot.com/10388160

TBR=kalman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10392142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137632 0039d316-1c4b-4281-b951-d872f2087c98

CID=104015

R=jhawkins@chromium.org
BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10399042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137631 0039d316-1c4b-4281-b951-d872f2087c98

This is a bit of a yak shave to support having the "action box" show active
extensions on the current page rather than page actions. Previously,
PageActionController was creating widgets for everything then
LocationBarViewGtk was hiding them as necessary. This is assumes too much; we
need to push the visibility logic into the Controller for the future.

BUG=127988


Review URL: https://chromiumcodereview.appspot.com/10388160

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137630 0039d316-1c4b-4281-b951-d872f2087c98

Currently, Ash accelerators are handled at a very early stage, right after a native key event is received by aura::RootWindowHost. This CL change the way of handling Ash accelerators as follows to make it more App friendly:

1. If no window is focused, handle an Ash accelerator immediately in ash/accelerators/accelerator_filter.cc in the same way as before.
2. Otherwise, do not handle it in ash/accelerators/accelerator_filter.cc but let a custom views::FocusManager handle it (see ash/shell.cc). There are 3 types of scenarios here depending on the type of the focused window:
2-a. If the focused window is a browser, and the browser is not for an app, let the custom focus manager pre-handle Ash accelerators before passing it to the browser (see PreHandleKeyboardEvent() in chrome/browser/ui/views/frame/browser_view.cc).
2-b. If the focused window is a browser, and the browser is for an app, let the app handle Ash accelerators first (see chrome/browser/ui/views/frame/browser_view.cc). If the accelerator is not consumed by the app, let the custom focus manager handle it.
2-c. If the focused window is not a browser, let the window handle Ash accelerators first. If the accelerator is not consumed by the window, then let the custom focus manager handle it. This means a WebView without the chrome/browser/ui/ layer can handle Ash accelerators first whenever needed.

Other changes:

chrome/browser/ui/views/frame/browser_view.cc:
Support ET_KEY_RELEASED accelerators in BrowserView::PreHandleKeyboardEvent().

ui/views/focus/focus_manager.cc:
Support ET_KEY_RELEASED accelerators. Also fix code for handing VKEY_MENU so that the Shift+Alt+ET_KEY_RELEASED accelerator for Ash could be handled correctly.

This CL depends on http://codereview.chromium.org/10377158/ (by jochen), https://chromiumcodereview.appspot.com/10388023, http://codereview.chromium.org/10389035/, and https://chromiumcodereview.appspot.com/10332051/, and should not be submitted until the 4 CLs are landed.

BUG=123856
TEST=ran aura_shell_unittests
TEST=manual; launch Chromoting app as a window, connect to a Chromoting server, focus Chrome on the remote machine, press Ctrl-n, confirm a new window is opened on the remote machine.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135791

Review URL: https://chromiumcodereview.appspot.com/10134036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137629 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127706
TEST=Start chrome, sign in to sync, start print job spooling and exit while the print job is spooling, should not get a crash.


Review URL: https://chromiumcodereview.appspot.com/10391080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137628 0039d316-1c4b-4281-b951-d872f2087c98

So that we can handle directories in drop event as well as on other platforms.

BUG=58977,99823
TEST=manually tested with LayoutTestsediting/pasteboard/data-transfer-items-drag-drop-entry.html

Review URL: https://chromiumcodereview.appspot.com/10382191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124829
TEST=run aura build with flash and compositor thread, open youtube video, reload many times.


Review URL: https://chromiumcodereview.appspot.com/10382215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137626 0039d316-1c4b-4281-b951-d872f2087c98

Bug=124566
Test=Manual

Review URL: https://chromiumcodereview.appspot.com/10389109

TBR=pkotwicz@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10391179

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137625 0039d316-1c4b-4281-b951-d872f2087c98

This was broken by r136239.

BUG=None
TEST=Tested file inputs work again.


Review URL: https://chromiumcodereview.appspot.com/10332213

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137623 0039d316-1c4b-4281-b951-d872f2087c98

Bug=124566
Test=Manual

Review URL: https://chromiumcodereview.appspot.com/10389109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137622 0039d316-1c4b-4281-b951-d872f2087c98

- Use VKEY_CONTROL instead of VKEY_LCONTROL/VKEY_RCONTROL to be consistent with Windows' behavior.

Windows (and ui/base/keycodes/keyboard_code_conversion_x.cc) never sends a VKEY_[LR]CONTROL event when left/right control is pressed. The VKs are used only as a return value of GetKeyboardState() Windows API.

- Add unit tests for Command+NumPad presses.

Add tests that checks if NumPad1 + Command key presses on an Apple keyboard are treated as VKEY_NUMPAD1 with EF_CONTROL_DOWN.

BUG=None
TEST=manual + unit_tests


Review URL: https://chromiumcodereview.appspot.com/10397003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137621 0039d316-1c4b-4281-b951-d872f2087c98

Adds a new histogram that can be called from JS to record stats on the upcoming destination selector.

BUG=128275
TEST=No user visible change.


Review URL: https://chromiumcodereview.appspot.com/10387162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137620 0039d316-1c4b-4281-b951-d872f2087c98

BUG=122687
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10310113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137617 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126132


Review URL: https://chromiumcodereview.appspot.com/9985012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137616 0039d316-1c4b-4281-b951-d872f2087c98

Streamline methods of PushClient and its Observer subclass.

Remove sync/protocol/service_constants.h and consolidate use of each
constant in one place.  Remove duplicate constant in cloud print code.

BUG=76764
TEST=
TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10398051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137615 0039d316-1c4b-4281-b951-d872f2087c98