GitLab

This adds active descendant to a few output rules that should have it.

Note that explicitly including the active descendant in these rules makes it possible to continue to see the entire output rule as a whole. This makes it possible to provide more intelligent output based on @message_strings, if desired.

Bug: 781840
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia3f8bb0e6613d55e080be7b6eccfbdf0ee35033e
Reviewed-on: https://chromium-review.googlesource.com/898023Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533835}

Adds the IDL code and accessor methods into ComputedAccessibleNode for
the intersection of properties between AccessibleNode and
AXStringAttribute. These accessors will return null strings to the
window in a few cases:
   - when the AXNode for a given matching AXID is not in the tree,
   - when the string property has not been set.

Currently, the accessors are rudimentary and require an enum
translation, although this may change in future in favour of an
individual hard coded method on the AomContentAXTree.

BUG=792783

Change-Id: Icd9cac2cb8486d549932f400b0aeeae569a1f712
Reviewed-on: https://chromium-review.googlesource.com/883863
Commit-Queue: Meredith Lane <meredithl@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533834}

https://chromium.googlesource.com/angle/angle.git/+log/9dbaeba89424..5c5d7deef28d

$ git log 9dbaeba89..5c5d7deef --date=short --no-merges --format='%ad %ae %s'
2018-02-01 lucferron Remove test restrictions on dEQP gles3 texture.compressedtexsubimage* tests

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ibc4a50753d2891146725eb3c593674974af374fa
Reviewed-on: https://chromium-review.googlesource.com/898098Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533833}

Bug: none
Change-Id: I2d5b7c11a77d990e9b6c243a9fa335f970f7358f
Reviewed-on: https://chromium-review.googlesource.com/898073Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533832}

This reverts commit 0c264842.

The new iframe test is fragile and is not properly waiting for the
iframe onload event. Since the problem is in the test, relanding
without the test for now to unblock other changes.

Original change's description:
> Capture all DOM nodes reachable from V8 in heap snapshot.
>
> This patch uses the new EmbedderGraph API to provide the heap snapshot
> generator with all DOM nodes and references reachable from V8.
>
> Bug: 749490
> Change-Id: I26750a8b80dab4f88508e504b431d976a598c6c3
> Reviewed-on: https://chromium-review.googlesource.com/890260
> Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>

Change-Id: I1d736a74b2f39443c490aecbfe7f6d305a669711

TBR=haraken@chromium.org,alph@chromium.org

Change-Id: I1d736a74b2f39443c490aecbfe7f6d305a669711
Reviewed-on: https://chromium-review.googlesource.com/897644
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533831}

ui_java resources are intended to be used later. Other resources were no
longer being used.

Bug: 806060
Change-Id: Ifde5a469adc0453e65483d6988dcbb3dc4a1a876
Reviewed-on: https://chromium-review.googlesource.com/896405
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533830}

By default, ICU tries to load data items (e.g. brkitr/char.brk)
from individual files before trying the common data. Because
all the ICU data Chrome needs is included in the common ICU data file
that is memory mapped in InitializeICU(), trying to load from the
disk just wastes cycles (It fails inside sandbox. So does it in
the browser process because there's no file with separate ICU data
items).

Bug: 805694
Test: None
Change-Id: I3c633dd9d3bffc2cfb714eb4ec36c17a4ab9fd46
Reviewed-on: https://chromium-review.googlesource.com/890176Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533829}

In screen capture it is possible to have multiple sessions associated to
the same device in the same renderer process.
Prior to this CL, MSM::StopStreamDevice() received only the device ID,
which sometimes resulted in the wrong screen-capture tracks being stopped
on the renderer side.
This CL adds the session ID to the StopStreamDevice() so that only the
correct track is stopped.

Bug: 788400
Change-Id: If759af86fa9819e4c3574b2bc840ad45c3c924b7
Reviewed-on: https://chromium-review.googlesource.com/892859Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533828}

Reduce network::URLLoader dependencies to net::URLRequestContextGetter and network::mojom::NetworkServiceClient.

This makes it easier to reuse on iOS for servicing network::mojom::URLLoader requests.

This also allows the removal of the URLLoader lifetime management in NetworkContext, and instead we can use the lifetime management in net::URLRequestContextGetter.

Lastly, move url_request_context_owner to services/network as it's not really a client library.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I5dfeefd8b29f37ea24ac26167ccb064b6af42afc
Reviewed-on: https://chromium-review.googlesource.com/897462
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533827}

In https://bugs.chromium.org/p/chromium/issues/detail?id=791929 we
provided a quick fix for extensions which were erroneously marked as
corrupted by the content verifier. The fix involved checking for empty
paths. However, extensions could also make requests to one of their
folders and trigger the content verifier.

Bug: 792538
Change-Id: Ie5c62e6e54481bcd4670e8b19cc5608268014494
Reviewed-on: https://chromium-review.googlesource.com/894162
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533826}

A single anonymous flex/grid item should just contain a contiguous
sequence of text runs.

TEST=external/wpt/css/css-flexbox/anonymous-flex-item-004.html

Bug: 807497
Change-Id: If995a5ac107210083fd13de9c6983b91b4ef3fa3
Reviewed-on: https://chromium-review.googlesource.com/895844
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533825}

This reverts commit 091e44cb.

Reason for revert: Suspect that this broke the tree:
https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fiphone11-device-x64%2F2513%2F%2B%2Frecipes%2Fsteps%2Fios_web_unittests__iPhone_7_iOS_11.2.1__on_iOS-11.2.1%2F0%2Fstdout

Original change's description:
> [Nav Experiment] Fix form repost detection in WKBasedNavigationManager.
> 
> This CL moves form repost detection for WKBasedNavigationManager to
> in |webView:decidePolicyForNavigationAction|, where WKWebView gives a
> clear signal about form reposting (WKNavigationTypeFormResubmitted).
> This allows simplifying reload for WKBasedNavigationManager to directly
> delegating to [WKWebView reload].
> 
> FormsTestCase now pass with WKBasedNavigationManager.
> 
> Bug: 807428,705020
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: Ia35978c42b21405a3749d1764a0485cde9c805d2
> Reviewed-on: https://chromium-review.googlesource.com/894892
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533692}

TBR=eugenebut@chromium.org,danyao@chromium.org

Change-Id: I1db11102b3df8a8c0a37610e36ca229343367c8a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 807428, 705020
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/898164Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533824}

This reverts commit e0a03346.

Reason for revert: compile failed on linux cfi:

https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/5604

[19881/22628] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x64)
FAILED: v8_context_snapshot.bin 
python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
../../base/no_destructor.h:64:21: runtime error: control flow integrity check for type 'gin::(anonymous namespace)::PageAllocator' failed during cast to unrelated type (vtable address 0x000000000000)
0x000000000000: note: invalid vtable
<memory cannot be printed>
./v8_context_snapshot_generator failed with exit code 1

Original change's description:
> Update V8 to version 6.6.133.
> 
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/2fc50dd0..595a0288
> 
> Please follow these instructions for assigning/CC'ing issues:
> https://github.com/v8/v8/wiki/Triaging%20issues
> 
> Please close rolling in case of a roll revert:
> https://v8-roll.appspot.com/
> This only works with a Google account.
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
> 
> TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org
> 
> Change-Id: I5634398067826ef46a257e578af8958d333caf57
> Reviewed-on: https://chromium-review.googlesource.com/897748
> Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533775}

TBR=v8-autoroll@chromium.org,machenbach@chromium.org,hablich@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ie2f24c3d0d5ad77e34b60ec6373ae270ddd6b0e8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/898163Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533823}

Bug: 805479
Change-Id: Icf3110416b4f619f6854e46a685b39b4664cbef9
Reviewed-on: https://chromium-review.googlesource.com/897995Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Daniel Park <danielpark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533822}

https://webrtc.googlesource.com/src.git/+log/28dbf9724281..bc3b7828139c

$ git log 28dbf9724..bc3b78281 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I446c61c0e537dcde85a4585bd274c2684eb480fd
Reviewed-on: https://chromium-review.googlesource.com/897986
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533821}

This is a partial revert of the big refactoring CL
https://chromium-review.googlesource.com/c/chromium/src/+/864630. That CL
made the creation of CanvasResourceProvider for canvas 2d earlier at the point
of time when Canvas2DLayerBridge is created; this changed the code paths of
some instances and should not belong to a refactoring CL that is not intended
to change behavior.


Bug: 806066
Change-Id: I00493338f6bda4a9ea17ee01db2dcab29223398c
Reviewed-on: https://chromium-review.googlesource.com/896084Reviewed-by: Justin Novosad <junov@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533820}

AXTree now keeps track of reverse relationships automatically,
so take advantage of that to expose reverse relationships for
some attributes already exposed in the automation API.
Also add two relation attributes that are supported by Blink
but weren't added to automation yet: details, errorMessage.

The new attributes are:

detailsFor (reverse of details)
errorMessageFor (reverse of errorMessage)
controlledBy (reverse of controls)
descriptionFor (reverse of describedBy)
flowFrom (reverse of flowTo)
labelFor (reverse of labelledBy)

Bug: 757707
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I112c283c87274388fc9e7e725bcc126393133e39
TBR: michaelpg@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/837643
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533819}

The API supports passing WifiProperties.Passphrase to setProperties,
but that hasn't been documented - this fixes the documentation.

BUG=none

Change-Id: I1ab278f82cc61385d12faff32e7e66a9d44da57b
Reviewed-on: https://chromium-review.googlesource.com/896867Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533818}

Bug: 177475
Change-Id: I7985f9356fcac3c4c2e05fc3cdda0b52d132c7c7
Reviewed-on: https://chromium-review.googlesource.com/896718
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533817}

Porting this test to a world where the message center and notification
blockers live out of the Chrome process would be difficult.

The functionality under test is already covered by two ash unit tests:
- SessionStateNotificationBlockerTest
- InactiveUserNotificationBlockerTest

Bug: 578868
Change-Id: Ibbbfc232bb3938eec1c84e6a6bd8bb4a5d028236
Reviewed-on: https://chromium-review.googlesource.com/897885Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533816}

The parent/browser process can set these clone options to configure
the capabilities which will be propagated to the newly
launched child process.


Bug: 750938
Change-Id: Ic4403c5e9c61e7ce226af22d0bcdb3f1362a95f4
Reviewed-on: https://chromium-review.googlesource.com/861283
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533815}

We will observe which display the Media Router dialog's initiator web contents are on, and hide the local screen sink for that display from the sink list. This is to prevent the user from launching a presentation window that covers the controlling window.

It would be nicer if the WiredDisplayMRP were responsible for determining which sinks should be disabled. Unfortunately, there is no clean way for MRUI to notify WiredDisplayMRP which display the dialog is on. So it is done in MRUI instead.

Also doing some cleanups in MRUI (base::MakeUnique to std::make_unique, base::Callback to base::RepeatingCallback).

Bug: 800433
Change-Id: I0ec74758c485b89eee4f4417b7358922aa4f32a1
Reviewed-on: https://chromium-review.googlesource.com/830972
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533814}

https://skia.googlesource.com/skia.git/+log/f8393c861975..7a13705e03b7

$ git log f8393c861..7a13705e0 --date=short --no-merges --format='%ad %ae %s'
2018-02-01 robertphillips Fix DDL unit tests
2018-02-01 rmistry Add recipe and bots for android-compile.skia.org
2018-02-01 borenet Fix skcms DEPS hash
2018-02-01 bsalomon Revert "Redefine the meaning of sample counts in GPU backend."
2018-02-01 ethannicholas updated .fp file headers
2018-02-01 reed add gpu impl for shadermaskfilter
2018-02-01 bsalomon Redefine the meaning of sample counts in GPU backend.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: Ida26dd048815bf86d32874001500bf05b9b0bdcc
Reviewed-on: https://chromium-review.googlesource.com/898038
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533813}

If an OOPIF detaches itself from the frame tree during layout, then its
compositor is shutdown while in the midst of a BeginFrame, which causes
a crash. This CL defers compositor shutdown, while allowing
WebWidget closing to remain synchronous.

Bug: 802392
Change-Id: Iefef08fca2e892409d12cc748ddaf257f3aa68e4
Reviewed-on: https://chromium-review.googlesource.com/890042
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533812}

TLS 1.3 includes a server_random-based anti-downgrade mechanism which
gives it a stronger anti-downgrade store than prior versions of TLS.
(This is essentially working around a bug in TLS 1.2 where it did not
incorporate enough into the signature.) This is a few security
improvement for Chrome users that should not disrupt the existing
ecosystem.

Unfortunately, we are aware that some Cisco middleboxes have buggy TLS
1.2 implementations that fail to generate their own server random value.
Instead, they copy over another server's random value. This is invalid
and does not comply with the TLS 1.2 specification. See
https://www.ietf.org/mail-archive/web/tls/current/msg25168.html

Due to deployment considerations, this feature cannot be enabled until
TLS 1.3 is final. In preparation for that, this CL adds metrics to
determine the prevalance of these and potentially other non-compliant
middlebox products out there.

Bug: boringssl:226
Change-Id: Ie1288fadf84ff6988c741ceef1465c25559a369a
Reviewed-on: https://chromium-review.googlesource.com/891499Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533811}

https://chromium.googlesource.com/catapult.git/+log/76e0bf087745..d2080c565153

$ git log 76e0bf087..d2080c565 --date=short --no-merges --format='%ad %ae %s'
2018-01-31 eakuefner [Dashboard] Filter out memory stats in V8 tests

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I9696b147cfb92f85079e70ee79cf8514c452fd5e
Reviewed-on: https://chromium-review.googlesource.com/897982Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533810}

If the Context is invalidated before the object GCCallback is watching
is collected, a fallback is run and the original callback (for garbage
collection) is never triggered. There was a bug where we only properly
disposed of GCCallback (thus preventing it from triggering after the
context invalidated) if a non-null fallback was provided.

Fix this, properly cleaning up the GCCallback even with a null fallback,
and add unit tests to cover this case.

Bug: 808032
Change-Id: I0e17dfcec7d796883bc1b59bf450c86d3e79ac99
Reviewed-on: https://chromium-review.googlesource.com/898071Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533809}

If we have a new LocalSurfaceId, the parent is blocking on us. Even if
there is no damage, submit a CompositorFrame to unblock the parent.

Bug: 672962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id29b855d111db8ee461778461314099c0885c415
Reviewed-on: https://chromium-review.googlesource.com/892142Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533808}

https://chromium.googlesource.com/angle/angle.git/+log/c0db9addeaeb..9dbaeba89424

$ git log c0db9adde..9dbaeba89 --date=short --no-merges --format='%ad %ae %s'
2018-02-01 lucferron Validation layer fixes for compressedtexsubimage* dEQP tests

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Idef8176d7037d9903eae88e118a84636b7cc8cf1
Reviewed-on: https://chromium-review.googlesource.com/898035Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533807}

Functions formatted in console populate their element asynchronously
with their function name. This may result in the blue 'i' info note
on the wrong side.

Screenshot: https://imgur.com/a/qQUBb

Bug: 807815
Change-Id: Idd4e0bcba4369a0572dc26f57f61e46302205cb1
Reviewed-on: https://chromium-review.googlesource.com/896640Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533806}

This patch is preparing for the new implementation of Direct
Manipulation API. In the patch, we move direct_manipulation.h|cc to
ui/base/win, change related macros, includes and run git cl format.

Bug: 647140
Change-Id: Ib3acccf84737ae6c25be27ad0d2776ab005c5fd3
Reviewed-on: https://chromium-review.googlesource.com/896704Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533805}

Useful for people where the linux installation doesn't provide it by
default, and for bots.

I copied the system ciopfs binary on my ubuntu trusty box to build/ciopfs
and ran:

  upload_to_google_storage.py -b chromium-browser-clang/ciopfs build/ciopfs

Bug: 808098
Change-Id: Ia6dd7548a5a5761898506f6bbe50625c33151988
Reviewed-on: https://chromium-review.googlesource.com/897890Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533804}

https://pdfium.googlesource.com/pdfium.git/+log/55c62a48d36c..fb25606e584e

$ git log 55c62a48d..fb25606e5 --date=short --no-merges --format='%ad %ae %s'
2018-02-01 tsepez Make FXJSE_Engine constructed from FXJS_Engine.
2018-02-01 hnakashima Change return of FPDFDest_GetDestPageIndex to int.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I023583f878742362d9afabd93c3cfc6396114801
Reviewed-on: https://chromium-review.googlesource.com/898001Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#533803}

Removing all OfflinePageModelImpl related code, since we've migrated to
OfflinePageModelTaskified.

Bug: 807845
Change-Id: Ibe3c0bfbcb090b590c873163959abddad8f2f98d
Reviewed-on: https://chromium-review.googlesource.com/896956Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533802}

Bug: 714962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie0c8fe0bcc6f84284b60c2843c93ae6d5c63e1da
Reviewed-on: https://chromium-review.googlesource.com/897983
Commit-Queue: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533801}

Following bot results are included.
3459 3463 3464 3466

Deflake was skipped due to insufficient resuls.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I748b29a8770932893634e1d23fe7b11d986fc237
Reviewed-on: https://chromium-review.googlesource.com/897166
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533800}

Change-Id: Ibe081bcd630f86a26f2b4ebe562873022bbfc795
Reviewed-on: https://chromium-review.googlesource.com/897945Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533799}

This fixes a couple of minor sim unlock polish issues.

Bug: 797749, 786344
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9140397f4723c27514e09ce38cd2e527c231e9a9
Reviewed-on: https://chromium-review.googlesource.com/897823Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533798}

Before BlobURLStore resolved URLs to Blob instances, and Blob then had
a CreateLoader method. After this BlobURLStore instead resolves a URL to
a URLLoaderFactory instance, where that instance can only load the specific
blob URL.

This achieves two goals:
 - Eliminate dependency from Blob mojo interface to URLLoader code, which
   should reduce the amount of code needed for java mojo bindings (at least
   until the network service actually gets used by android).
 - Makes it easier to actually implement blob URL loading in the renderer as
   all the loading code eventually expects a URLLoaderFactory anyway.

Bug: 807289, 800901
Change-Id: Ibed4d9819029ce5d94d312d6acccb18ab2f82dd9
Reviewed-on: https://chromium-review.googlesource.com/894285
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533797}

Add support for a new EnableIf attribute to conditionally
enable fields/types in mojom definitions.

In order to do this, mojom parsing and code generation has
been split into two separate GN stages. The mojom bindings
generator has been refactored to separate the logic for
parsing and code generation and the GN mojom template has
been updated to express these two distinct stages.

The parse stage now prunes a mojom's AST - filtering
definitions based on the enabled features. These
intermediate ASTs are then pickled to gen/ to be later
read by the code generation stage.

Bug: 676224
Change-Id: I5fc106b43e8ac48339c63c48f7ce42ba5145d174
Reviewed-on: https://chromium-review.googlesource.com/846399
Commit-Queue: Eve Martin-Jones <evem@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Chris Watkins <watk@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533796}