GitLab

Generating a depfile from the manifest building step gives Ninja
the information it needs to trigger incremental rebuilds when static
assets or shared libraries have been modified.

Bug: 839496
Change-Id: I15aee25e8684f9d1fd6a8ad63318cc74639237f0
Reviewed-on: https://chromium-review.googlesource.com/1043047
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555887}

Change-Id: I7008b98fbf392801b796517a9a442c34815b13c4
Reviewed-on: https://chromium-review.googlesource.com/1040988Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555886}

Bug: 839534
Change-Id: I7242753e5777b15168ba8a0ff91a000a8a16c980
Reviewed-on: https://chromium-review.googlesource.com/1042624Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555885}

This reverts commit 1536dfa3.

Reason for revert: Causes data race in DownloadContentTest.ForceDownloadMessageRfc822Page test 
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/21108

Original change's description:
> Reland "Move zygote code to service_manager"
> 
> Relanding the move zygote to the service manager. It was breaking the
> non NaCl build.
> 
> Original description:
> 
> "This CL moves the zygote code from content/ to
> services/service_manager/zygote. This involves moving some switches from
> content_switches.h to services/service_manager/embedder/switches.h and
> moving some codes from content/public/common/result_codes.h to the new
> services/service_manager/embedder/result_codes.h."
> 
> Tbr: avi@chromium.org
> Tbr: sky@chromium.org
> Tbr: scottmg@chromium.org
> Tbr: rockot@chromium.org
> Tbr: slan@chromium.org
> Tbr: eseckler@chromium.org
> Tbr: rsesek@chromium.org
> Bug: 831846
> Change-Id: I8a4ceb2fe6b402d512a2f45b7fab0735b891c578
> Reviewed-on: https://chromium-review.googlesource.com/1037633
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Eric Seckler <eseckler@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Luke Halliwell <halliwell@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Jay Civelli <jcivelli@chromium.org>
> Commit-Queue: Jay Civelli <jcivelli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555851}

TBR=avi@chromium.org,sky@chromium.org,jcivelli@chromium.org,rockot@chromium.org,tsepez@chromium.org,slan@chromium.org,halliwell@chromium.org,scottmg@chromium.org,rsesek@chromium.org,eseckler@chromium.org

Change-Id: If3e2d0985960aaafec57f0a6db26e6f078dd7ad9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831846
Reviewed-on: https://chromium-review.googlesource.com/1043185Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555884}

Change-Id: I6cf1b34580fcd29954d15c729c4f290117d9bdeb
Reviewed-on: https://chromium-review.googlesource.com/1039064
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555883}

These tests either pass on Firefox or are bugs in Firefox.

Bug: 745778
Change-Id: I0a2997d5c3602f026e5cf9132a68a833c975d32d
Reviewed-on: https://chromium-review.googlesource.com/1042801Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555882}

Bug: 824967
Change-Id: I4eb57d85bb057061bf12848f39127a6542ebe886
Reviewed-on: https://chromium-review.googlesource.com/1037523
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555881}

Now that all desktop platforms have a browser-level implementation
for keyboard lock, it is time to remove the platform restriction
for the keyboard lock BrowserTests.

BUG=680809

Change-Id: Iad4ddea988069a73dd6cb31683a3a2086c753c47
Reviewed-on: https://chromium-review.googlesource.com/1042542Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555880}

This CL adds two UI tests:
* Testing interaction with touches.
* Verify touch and mouse events don't interfere with each other.

Bug: 829606
Change-Id: Iaea466d8746e69ce3e2081a64b9f915440a9ef8f
Reviewed-on: https://chromium-review.googlesource.com/1040775Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555879}

Update PermissionsData::AccessType to an enum class, and rename it to
PermissionsData::PageAccess. This will help prevent accidental misuse of
the enum (e.g., implicit conversion to bool, etc).

Bug: None

Change-Id: Ic81bf8cbcfd53e0700258413ef56d8150b23a046
Reviewed-on: https://chromium-review.googlesource.com/1042486
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555878}

Doing |getHeight() - getHeightMinusBrowserControls()| for the top toolbar
height does not work when the bottom toolbar is present since
|getHeightMinusBrowserControls()| takes into account the bottom toolbar.
The correct way to get the top toolbar height is through
|getTopBrowserControlsHeight()|.

Change-Id: I93ec1e43b8246c4babfa8a427bd9122c0a8fb39f
Reviewed-on: https://chromium-review.googlesource.com/1041218Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555877}

This covers the code added in crrev/c/1031010.

Bug: 833663, 734095
Change-Id: Iea3502b3543d076d6dc3285bea6e229320a2b980
Reviewed-on: https://chromium-review.googlesource.com/1040739Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555876}

* Added string converters for ScreenlockState and
RemoteDeviceLifeCycleState
* Removed 'generating EIDs' log
* Removed duplicate life cycle log

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: I40e8b5e43b1e2dc29d6542aae33b6af8b78ca722
Reviewed-on: https://chromium-review.googlesource.com/1042962Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555875}

Bug: 839154
Change-Id: Iebceacd23dde5275c72d4fb6afecedb3dab75396
Reviewed-on: https://chromium-review.googlesource.com/1035207
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555874}

This patch adds an explicit function to the SwipeableBottomSheet that
determines if a touch event is inside of the sheet's toolbar. This
eliminates the hack that existed previously that made too many
assumptions about the height of the toolbar.

Bug: 834795
Change-Id: Id195e72718ff2d37deb2891fd6264300d517352a
Reviewed-on: https://chromium-review.googlesource.com/1036224
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555873}

These tests can run on Win7 machines so enable them.

Bug: 734095
Change-Id: Idcd8e426feaf1202e544db2793a50f3574bdaaed
Reviewed-on: https://chromium-review.googlesource.com/1041154Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555872}

It's convenient to be able to specify this for both bots and in
individual test suite exceptions, where it's desired to turn on a
particular feature for all tests that are run on a particular
bot. Detect this situation and merge them into proper comma-sorted
lists.

Bug: 826341
Tbr: jbudorick@chromium.org
Change-Id: I11ff1c498182625dae3cfc5c2f0e5e0b4cc4bc5c
Reviewed-on: https://chromium-review.googlesource.com/1042960Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555871}

Change for reland:
The debug bot failure was because tests passed an invalid base::File
to a method with a mojo_base.mojom.File --- as opposed to
mojo_base.mojom.File? --- parameter type.

This commits to not accepting those files, by adding an additional
DCHECK on it and adjusting tests to not do that.

Rationale: passing in a broken file is ultimately doing an RPC to
do a lot of work that accomplishes nothing, so it's silly to support it,
even if a 1-character fix CL would be easier.

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1030033

Original description:
S13n: Add APIs for implementing net-export in Network Service

(But don't use them yet).
This takes care of managing the FileNetLogObserver with a passed-in
destination file, and also of all aspects of pulling state from
URLRequestContexts, which browser-end NetExportFileExporter presently
does but won't be able to with network service.

There is one behavior difference in that respect: the in-progress
entries for things that are in flight when the export is started
now included all URLRequestContexts known, rather than just the
main + media + system for whever the export UI is running. Given
that events collected when export is active included everything
already, this seemed rational as consistent, and avoiding complexity
of finding the particular contexts, including the going-away media one.

Bug: 767450
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifd7f8fbcd60ec2dadf7a8b31c6b0ec67d27b9b7b
Reviewed-on: https://chromium-review.googlesource.com/1037243
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555870}

This Cl changes spellings.
There are no logic changes.

(code health)

Bug: None
Change-Id: I28192930065af7a92fd3b4b4a47edc1eee84e989
Reviewed-on: https://chromium-review.googlesource.com/1042822
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555869}

If an API is called without a callback, that API may still result in
an error. For instance:
chrome.foo.doBar();  // May fail asynchronously!

In this case, we should log the error to the console, in the same way
we would for an unchecked error in the callback.

This implements this for APIs invoked and resolved through the
APIRequestHandler, and adds a ReportUncheckedError() to the
APILastError object. This requires adding a pending request for
all requests through APIRequestHandler, instead of just those with
an associated callback.

Also add unittests for both the new APILastError method and the full
flow of logging the last error from the APIRequestHandler when a
callback isn't provided.

Bug: 839528
Change-Id: I42418bb968e06d27e34e3f8981468229343dc5c9
Reviewed-on: https://chromium-review.googlesource.com/1028357
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555868}

Move the rewriter files to ash, keep the delegate impl in chrome.
Add a mojo interface for the delegate to receive and return events.
Ash's controller creates the rewriter, Chrome sets the delegate.

Move, expand, and refine the existing unit tests.

Add TODOs to refine the rewriter/delegate/ChromeVox pattern.
(the rewriter shouldn't pass events that will need to be reposted)

This should allow Mash to support this rewriter in the future.
(for now, Ash doesn't get Window Service events sent to Chrome)

Bug: 647781
Test: No regressions with ChromeVox spoken feedback on Chrome OS.
Change-Id: I4f7805298156ab9463ca3110a1e957f922c6d82b
Reviewed-on: https://chromium-review.googlesource.com/1038819
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555867}

Bug: 809635
Change-Id: Ifd6e73c24c0994f551442ce2d21355829e5454dd
Reviewed-on: https://chromium-review.googlesource.com/1022257
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555866}

Bug: 838609
Change-Id: I990017ba66d3be60d86204b7e216999caaf2c25b
Reviewed-on: https://chromium-review.googlesource.com/1041071
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555865}

This CL implements the new GM2 styles for the non-
client frames caption buttons:
- Use circular inkdrop flood fill and highlight.
- Use the new colors and opacities for the caption icons.
- Use a height of 32dp for the non-browser frames.

TODO: Implement the same styles for PWAs' frame buttons

BUG=831872
TEST=manual

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id2c2603b67b290b5eba1970d78d5d0c395df7fe4
Reviewed-on: https://chromium-review.googlesource.com/1041144
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555864}

Implement function to extract U2F check only sign command from
CtapMakeCredentialRequest. This is used to iterate through key handles
in the exclude list to prevent duplicate registration.

Bug: 798573
Change-Id: I51ab3dc21c6a7229e99dd513dae4ec9322014a75
Reviewed-on: https://chromium-review.googlesource.com/1032257Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555863}

This reverts commit 210545ea.

Reason for revert: Causes ModuleEventSinkImplTest.CallsForwardedAsExpected to fail. 

Original change's description:
> Reporting: Include include-subdomains in net log
> 
> We weren't including the `include-subdomains` field of each endpoint
> group in the data we were handing over to the net-internals page.  (The
> net-internals code that reads this field is already there; we just
> weren't filling in a value.)
> 
> Bug: 829353
> Change-Id: Ifdff1d6e0baf802eb7f094571060b93c761936af
> Reviewed-on: https://chromium-review.googlesource.com/1019661
> Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
> Commit-Queue: Douglas Creager <dcreager@google.com>
> Cr-Commit-Position: refs/heads/master@{#555755}

TBR=juliatuttle@chromium.org,dcreager@google.com

Change-Id: I720f83c34a1df94a9f3193c6dc453ab80bb98c8c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829353
Reviewed-on: https://chromium-review.googlesource.com/1042623Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555862}

There are good reasons for displaying the Android Secret on this page,
but we need to make sure that users don't include it by accident when
making a screenshot for other reasons.

Following this CL, they can type "secret" to display the Android Secret
that's associated with the already included Android ID.

Bug: 833949
Change-Id: I20131dbf0f113738cd1f9acd2ece0763db032921
Reviewed-on: https://chromium-review.googlesource.com/1034803
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555861}

The callee runs in a sandbox and the caller can handle the termination
of the process as an error condition.

Bug: 826743
Change-Id: I9c0cddf9319c6db8dc2a9bf825c787a890976e0c
Reviewed-on: https://chromium-review.googlesource.com/1038141Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555860}

In particular the permenent node creation moves to
BookmarkLoadDetails, and LoadBookmarks() becomes a bare function.

BUG=680698
TEST=covered by existing tests

Change-Id: Ifdc7ef84ee73ac7b59c122976a37cb85d5d27b4f
Reviewed-on: https://chromium-review.googlesource.com/1041575
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555859}

Bug: 773295
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic37eb92d81b0f0f16f997fad635d22933b3ce098
Reviewed-on: https://chromium-review.googlesource.com/1040445
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555858}

Also replace the LazyInstance with NoDestructor.

Change-Id: I057bc873f2ebd0a331fed1298e2e38e7f9f1265e
Reviewed-on: https://chromium-review.googlesource.com/1038893
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555857}

Adjust the flags so that the FullscreenOptions object is read and the
system ui visibility flags are set appropriately.

BUG=829937

Change-Id: I698f0dabd4ca9acfad27f1efc4ffb75361e7df69
Reviewed-on: https://chromium-review.googlesource.com/1034600
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555856}

When selecting a tab in the tab switcher the animation that brought
the selected tab to full-screen placed offset the tab down and this
led to janky looking animation. This happened because the tab switcher
animation code assumed that the browser controls only contained the top
bar. This CL fixes that assumption.

Bug: 839181
Change-Id: Ide349b8bcd5290acd8a8d9cde80b6f10886ac177
Reviewed-on: https://chromium-review.googlesource.com/1041162Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555855}

MediaSinkServiceBase changes:

- Move the Observer interface currently in CMSSImpl to
MediaSinkServiceBase and generalizes it so it can be used for other
MediaSinkServiceBase implementations.
- Standardizes add/update/remove/get sink operations in
MediaSinkServiceBase.
Both of these make the code using MediaSinkServiceBase more testable as
additional code in MRP depend on them.

Also cleaned up logic related to the discovery timer by combining
Start/RestartTimer().

-----

DialMediaSinkSevice changes:
- DMSSImpl now pools sinks discovered in the latest round and is used
to merge with the |MSSBase::sinks_| when the discovery timer fires.
Before this patch, the current set is removed on the start of a discovery
round (because unlike Cast, there is no active connection to a device to
tell that it is still alive or gone), which makes the sink list unstable.
With this patch, the current set is only modified at the end of a discovery
round.
- TODOs in future patches:
-- move app discovery service out of DMSSImpl, similar to Cast.
-- get rid of DMSS and move UI thread dependencies (if any) into part
   of DMSSImpl. Then rename DMSSImpl -> DMSS.

-----

CastMediaSinkService changes;
- No longer keep track of sinks by ip endpoint. Instead uses
|MSSBase::sinks_| to maintain sink list.
- CastAppDiscoveryService no longer need to maintain its own map of
sinks, and instead uses |MSSBase::GetSinks()/GetSinkById()|.
- The callback used for dual disovery is converted to use
MediaSinkServiceBase::Observer.
- TODOs in future patches:
-- get rid of CMSS and move UI thread dependencies into CMSSImpl.
Rename CMSSImpl -> CMSS.
-----

Notes:
- The MediaRouteDesktop ProvideSinks callback is not converted to use
Observers. This is because the callback is expected to be temporary (until
we can turn off the extension MRPs), so we treat it as a special case.

Bug: 816628,698940
Change-Id: I11fd13f7ebf743d78c9499ad24f98cf72f571ee5
Reviewed-on: https://chromium-review.googlesource.com/1033727
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555854}

This reverts commit a6889a09.

Reason for revert: Seeing multiple failures that might be caused by this change: 839362, 838785, 838858, 839327

Original change's description:
> [CFI] Enable cfi-icall for official Linux x64 builds
> 
> The measured size impact is 1.5% and perf impact is ~1%.
> 
> Bug: 701919
> Change-Id: I541242711bc85cc124ff3a2680171577e75475bd
> Reviewed-on: https://chromium-review.googlesource.com/1033918
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#554828}

TBR=dpranke@chromium.org,pcc@chromium.org,vtsyrklevich@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 701919
Change-Id: Ia73c2508483576a16fbc00749f081f013e6fd813
Reviewed-on: https://chromium-review.googlesource.com/1042765Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555853}

Bug: 839172
Change-Id: I9881db40caa593819cfaaf686a8e24ab0dc8bc4e
Reviewed-on: https://chromium-review.googlesource.com/1041158Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555852}

Relanding the move zygote to the service manager. It was breaking the
non NaCl build.

Original description:

"This CL moves the zygote code from content/ to
services/service_manager/zygote. This involves moving some switches from
content_switches.h to services/service_manager/embedder/switches.h and
moving some codes from content/public/common/result_codes.h to the new
services/service_manager/embedder/result_codes.h."

Tbr: avi@chromium.org
Tbr: sky@chromium.org
Tbr: scottmg@chromium.org
Tbr: rockot@chromium.org
Tbr: slan@chromium.org
Tbr: eseckler@chromium.org
Tbr: rsesek@chromium.org
Bug: 831846
Change-Id: I8a4ceb2fe6b402d512a2f45b7fab0735b891c578
Reviewed-on: https://chromium-review.googlesource.com/1037633Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555851}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/1f462965..a2f0a25c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7a0b82711b1c390e774c32507f460f716d204f61
Reviewed-on: https://chromium-review.googlesource.com/1042217Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555850}

Ensure that we use upload tasks for uploading bitmaps in the Gpu image
cache. This allows the image to be locked across multiple tasks.

R=ericrk@chromium.org

Bug: 791828
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7f82f2001846df02469e9976d12581706c1673b7
Reviewed-on: https://chromium-review.googlesource.com/1041525
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555849}

Previously, if a test was retried (because of unexpected failures), the
results from all retry attempts would show up in the "actual" field in
the summary; but if a test ran multiple times because of --iterations or
--repeat-each, only the last result would be included in the summary.

This CL makes iterations and repeats behave the same as retries in terms
of the result summary. All results from all iterations and repeats from
all retries are now included in the "actual" result field in summary.
This will make it easier for other tools (e.g. FindIt) and users to
debug flaky tests, and won't affect existing bots as they don't use
--iterations or --repeat-each.

Some code-health improvements are done along the way (e.g.
expectation_to_string).

There are some questions regarding the existing behaviours. In order to
minimize the risk, this CL strives to ensure backward compatibility. We
will revisit some of the behaviours later.

Bug: 828605
Change-Id: Ibb5a329eb8dc60fd0ae857083ebddc3b1c86f5f0
Reviewed-on: https://chromium-review.googlesource.com/1029430
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555848}