- 12 Jun, 2014 40 commits
-
-
ernstm@chromium.org authored
R=tonyg@chromium.org,nduca@chromium.org BUG=373045 Review URL: https://codereview.chromium.org/271733008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276623 0039d316-1c4b-4281-b951-d872f2087c98
-
engedy@chromium.org authored
The semantics for NOTIFICATION_HISTORY_URLS_MODIFIED was changed as of revision 131865 (https://chromiumcodereview.appspot.com/9852002) so that it would be fired not only for typed URLs, but also for non-typed ones (that is, URLs having |typed_count| == 0). However, HistoryBackend::AddPagesWithDetails() was not updated to reflect these new semantics. Rectify this omission to make the code less mysterious. BUG=None Review URL: https://codereview.chromium.org/323043004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276622 0039d316-1c4b-4281-b951-d872f2087c98
-
jorgelo@chromium.org authored
This makes the code clearer, and will make simplifying GPU sandbox init easier. BUG=356959 TEST=content_shell loads webpages. Review URL: https://codereview.chromium.org/327033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276621 0039d316-1c4b-4281-b951-d872f2087c98
-
phoglund@chromium.org authored
Broke linux chromium build: http://build.chromium.org/p/chromium/builders/Linux/builds/50505/steps/compile/logs/stdio. > Cast: Synthetic benchmark tool. > > This benchmark tests how much latency, packet loss and bandwidth loss we can tolerate. > It runs hundreds of times faster than real-time and results are independent of CPU speed. > So far, it does a series of binary searches to find a spanning tree of the space in which > our algorithms can operate comfortably. > > This is a re-upload of cl 293173002, which was reverted because it broke some windows build. > > Review URL: https://codereview.chromium.org/308713005 TBR=hubbe@chromium.org Review URL: https://codereview.chromium.org/328313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276620 0039d316-1c4b-4281-b951-d872f2087c98
-
felt@chromium.org authored
Glen asked for a small tweak to the SSL interstitial strings. BUG=331453 Review URL: https://codereview.chromium.org/321393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276619 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
AppModelBuilder creates the list of applications in the home card. Right now app_list doesn't have such API, so the interface is in athena. It would be integrated with other app builders eventually. BUG=380421 R=oshima@chromium.org TBR=xiyuan@chromium.org TEST=manually Review URL: https://codereview.chromium.org/311113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276618 0039d316-1c4b-4281-b951-d872f2087c98
-
mkosiba@chromium.org authored
BUG=377720 NOTRY=true Review URL: https://codereview.chromium.org/302843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276617 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
This CL eliminates the appending of the Google locale to all "learnMore" and "help" URLs. BUG=164939 TBR=sky Review URL: https://codereview.chromium.org/325963007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276616 0039d316-1c4b-4281-b951-d872f2087c98
-
blundell@chromium.org authored
The componentization is straightforward. BUG=382568 Review URL: https://codereview.chromium.org/310393006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276615 0039d316-1c4b-4281-b951-d872f2087c98
-
yhirano@chromium.org authored
IDMap<T, OS> owns its values only if OS == IDMapOwnPtr. BUG=NONE R=toyoshim@chromium.org Review URL: https://codereview.chromium.org/323083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276614 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Review URL: https://codereview.chromium.org/324883006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276613 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
The CopyOutputRequest's area is now in layer's scale factor, not in pixel. R=danakj@chromium.org, piman@chromium.org BUG=381578 TEST=manually, snapshot_unittests succeeds Review URL: https://codereview.chromium.org/321323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276612 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
This tries to update the bandwidth used to what is available. The algorithm is essentially that we estimate how much bandwidth we've been sending recently. Then we check how full our buffers are. We set a target for having our buffers be 90% empty. If the buffer is more than 90% empty, we use more bandwidth than the resently sent, if the buffer is less than 90% empty, we use less. This change should be relatively safe since we normally set our min and max bandwidth to a very limited range, and this change respects those limits. Review URL: https://codereview.chromium.org/326783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276611 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Shrink value passed over IPC only in if defined (OS_WIN && !WIN_PDF_METAFILE_FOR_PRINTING) This build config should be gone in near future. PrintedPage::shrink_factor_ is used only for OS_WIN. BUG=379961 NOTRY=true Review URL: https://codereview.chromium.org/335473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276610 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
BUG=379331 Review URL: https://codereview.chromium.org/308713007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276609 0039d316-1c4b-4281-b951-d872f2087c98
-
benwells@chromium.org authored
This is experimental and behind a flag. It does not currently do anything except allow us to explore what kind of UI we want. BUG=378171 Review URL: https://codereview.chromium.org/324043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276608 0039d316-1c4b-4281-b951-d872f2087c98
-
rsadam@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/323143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276607 0039d316-1c4b-4281-b951-d872f2087c98
-
matthewyuan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276606 0039d316-1c4b-4281-b951-d872f2087c98
-
nhiroki@chromium.org authored
BUG=380030 TEST=n/a Review URL: https://codereview.chromium.org/322003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276605 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
Unfortunately, toolbox WebContents may be referenced by browser window on Mac while undocked DevToolsWindow is being destroyed. Destroying toolbox WebContents after browser window update fixes this. BUG=382502 Review URL: https://codereview.chromium.org/329193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276604 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
This benchmark tests how much latency, packet loss and bandwidth loss we can tolerate. It runs hundreds of times faster than real-time and results are independent of CPU speed. So far, it does a series of binary searches to find a spanning tree of the space in which our algorithms can operate comfortably. This is a re-upload of cl 293173002, which was reverted because it broke some windows build. Review URL: https://codereview.chromium.org/308713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276603 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
BUG=380356 Review URL: https://codereview.chromium.org/318973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276602 0039d316-1c4b-4281-b951-d872f2087c98
-
xians@chromium.org authored
This is needed with some recent refactoring to separate media stream from peerconnection. And it will crash if the peerconnection goes away before media stream is stopped. NOTRY=true BUG=379856 TEST=cluster-fuzz bot, and local build with ASAN. Review URL: https://codereview.chromium.org/310013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276600 0039d316-1c4b-4281-b951-d872f2087c98
-
ksakamoto@chromium.org authored
This CL adds UMA histograms that tracks age (time since creation) of cache entries for web fonts. Histograms are suffixed with font names: "roboto", "opensans", or "others". Also, fixes a bug that DiskCache.ReuseCount.Evict was recording evictions of non-webfont entries. BUG=379670 Review URL: https://codereview.chromium.org/323013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276599 0039d316-1c4b-4281-b951-d872f2087c98
-
sammc@chromium.org authored
Previously, the namespace was omitted for interface and interface request arguments imported from another module. Review URL: https://codereview.chromium.org/332653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276598 0039d316-1c4b-4281-b951-d872f2087c98
-
jeremy@chromium.org authored
This patch changes the sampling rate of `powermetrics` from 20hz to the default - 5s. We don't need the extra resolution for our measurements and it seems that increasing the sampling rate draws power in and of itself which affects what's being measured. BUG=None Review URL: https://codereview.chromium.org/322423004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276597 0039d316-1c4b-4281-b951-d872f2087c98
-
eustas@chromium.org authored
BUG=245436 Review URL: https://codereview.chromium.org/324953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276596 0039d316-1c4b-4281-b951-d872f2087c98
-
rickyz@google.com authored
To use, make a BPF program return ErrorCode(ERR_TRACE + ret_data), where ret_data is a 16 bit value that will be available to the tracing process via PTRACE_GETEVENTMSG. BUG=231000 Review URL: https://codereview.chromium.org/278583005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276595 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
Knowing which window managers Chrome is most often used on will help in testing in new feature development. BUG=372580 TEST=None Review URL: https://codereview.chromium.org/330493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276593 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
Finding whether you are running 64-bit or 32-bit is proving tricky for users since the chrome://version page is not linked anywhere. This adds "64-bit" string to the chrome://chrome page for 64-bit builds. BUG=381246 Review URL: https://codereview.chromium.org/326773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276592 0039d316-1c4b-4281-b951-d872f2087c98
-
tzik@chromium.org authored
- Make observers to external services sticky over re-initialization. - Leave SyncWorker NULL when non sign-in state. - Observe sign-in event and trigger initialization on it. BUG=374101,380615 Review URL: https://codereview.chromium.org/324343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276591 0039d316-1c4b-4281-b951-d872f2087c98
-
mcasas@chromium.org authored
VideoCaptureDevice Win: Enumerate devices' supported formats when they don't have a DevicePath property. BUG=380939 Review URL: https://codereview.chromium.org/328463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276590 0039d316-1c4b-4281-b951-d872f2087c98
-
noel@chromium.org authored
Add a global device color profile cache and use it to extract the color profile associated with screen display devices. TEST=ui_unittests.exe --gtest_filter="ColorProfileTest*" BUG=368694 Review URL: https://codereview.chromium.org/312723003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276589 0039d316-1c4b-4281-b951-d872f2087c98
-
sammc@chromium.org authored
Review URL: https://codereview.chromium.org/326303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276588 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
This is the first step in refactoring the (overly-gigantic) extension_service_unittest.cc BUG=381251 TBR=atwilson@chromium.org (c/b/background/) TBR=bauerb@chromium.org (c/b/managed_mode/) TBR=battre@chromium.org (c/b/profile_resetter/) TBR=pkotwicz@chromium.org (c/b/themes) TBR=koz@chromium.org (c/b/ui/app_list) All TBRs are for simple mechanical changes (primarily namespace move). Review URL: https://codereview.chromium.org/318863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276587 0039d316-1c4b-4281-b951-d872f2087c98
-
mnaganov@chromium.org authored
This patch adds GinJavaMethodInvocationHelper class which serves for coercion of arguments and return values of Java methods to / from base::Value and GinJavaBridgeValue. The coercion code is taken from the existing implementation (JavaBoundObject) with required conversions to use base::Value and GinJavaBridgeValue instead of NPVARIANT and friends. There are extensive Java tests for coercion, so here we only add some unit tests for edge cases. This patch also adds a trivial EventLog class for writing into Android Event Log from C++ code. BUG=355644 R=bulach@chromium.org, torne@chromium.org TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/302173006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276586 0039d316-1c4b-4281-b951-d872f2087c98
-
kouhei@chromium.org authored
This is to fix permission breakage on extension background pages after blink patch r173044. Before this patch, permission settings were loaded on V8 context initialize. However, the blink patch deferred the V8 context initialize until its first use. This patch adds a call to |Dispatcher::InitOriginPermissions| on |Dispatcher::OnActivateExtension| which is called when render process for the extension is created. TEST=Manually confirmed that Files.app image viewer can load images on its first load. BUG=380346, 380502 Review URL: https://codereview.chromium.org/315143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276585 0039d316-1c4b-4281-b951-d872f2087c98
-
hanxi@chromium.org authored
Two remaining issues: 1. It seems that WebviewGuest doesn't support SharedWorker yet, so this CL doesn't include the changes for SharedWorker. 2. To request file system access for operations like getFile(), removeFile() etc., I have to set "unlimitedstorage" permission in manifest.json, otherwise will get QuotaExceededError (request persistent storage without "unlimitedstorage" permission). Any idea? BUG=343382 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276251 Review URL: https://codereview.chromium.org/306473012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276584 0039d316-1c4b-4281-b951-d872f2087c98
-
anandc@chromium.org authored
BUG=383430 Review URL: https://codereview.chromium.org/333443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276583 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
Used to maximize menu as well. Toggle home card when ctrl-l is pressed. BUG=380438 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/332463002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276582 0039d316-1c4b-4281-b951-d872f2087c98
-