- 24 Sep, 2020 40 commits
-
-
Hiroshige Hayashizaki authored
As ModuleRecord::Evaluate() returns a successful result (with a promise rejected with an exception) for a module script throwing an exception when kTopLevelAwait is enabled, this CL fixes the expectation of ModuleRecordTest accordingly. This also fixes ModuleRecordResolverImplTest to call ParametrizedModuleTest::TearDown() appropriately. Bug: 1111134, 1129743 Change-Id: I7f8267bd7966df58158f4cf70597276d2a0acd5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419055 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810085}
-
Jimmy Gong authored
The added setters are going to be used by a future Cl that implements the PhoneStatusProcessor class. Bug: 1106937 Change-Id: Ie95210cfcedbba2ad3ed5875a34ef21a7486b13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423346 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810084}
-
David Black authored
With the ability to select multiple holding space items at a time, we want to be able to open, pin, and unpin items in bulk. Bug: 1129981 Change-Id: Ifa0f80de5f3a30c87678858d66c697b8852381a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426085 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810083}
-
James Vecore authored
Reland as is because the fix was in the parent CL: https://crrev.com/c/2426864/2 Original commit message: > [Nearby] Trigger onboarding when first enabling Nearby > > This CL adds a pref to track if onboarding was run by this user before. > If it has not, when enabling for the first time, onboarding is run first > by navigating to the subpage and showing in a dialog. Once onboarding > has been done once, the user can freely toggle on/off without > triggering onboarding. However, onboarding will still run if the user > triggers the pod button and the feature is disabled. This matches the > Android behavior. > > Additionally, this CL fixes a bug with the premature closing of the > shared receiveManager which needs to stay alive and connected after the > dialog closes otherwise getReceiveManager returns a remote with a closed > pipe. > > Bug: b/154866951 > Change-Id: I1e3cbd15f4995f019b3476c2f7a69f67d6eb1888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424763 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#809623} Change-Id: I91e3a3749ae15ae6bf7879c259e3622e74eba337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427004Reviewed-by:
-
Jeffrey Young authored
Only allow approved topics to be displayed. All topics are defaulted to false and must be enabled by finch params. BUG=b:167458920 TEST=turn on ambient mode with "GeoPhotosEnabled" param set to false. Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I2ce8057999279d4792840ce99cd379edba2955ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422583 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#810081}
-
Marijn Kruisselbrink authored
At a high level, this enables creating handles from either local paths or external paths. An external path is a path that can be used as virtual path in a kFileSystemTypeExternal file system URL. These external paths are intentionally not wrapped in an isolated file system, as doing so would make it much harder to keep track of this virtual path, and we need the virtual path to be able to serialize these handles to IndexedDB. (local paths are still wrapped in an isolated file system, although some of the previous CLs that enabled not using one in this case has made that no longer needed either. In the future I hope to be able to eliminate/replace isolated file systems entirely). This adds a PathType enum/parameter to CreateFile/DirectoryEntryFromPath methods in NFSEntryFactory/NFSManagerImpl. This parameter makes it clear if the path is a local path or an external path. And changes the result FileSystemChooser returns from simply being a base::FilePath to being a combination of a FilePath and a PathType. This is then used by NFSManagerImpl to create the right type of FileSystemURL/entry. Currently all the permissions code still just deals with raw base::FilePaths without indication if a path is a virtual/external or local path. This shouldn't matter, since on ChromeOS (the only place we use external paths) these paths will never overlap anyway, but we might want to revisit this in the future. This could have been implemented by having FileSystemChooser return the appropriate FileSystemURL directly (and changing the NFSEntryFactory API to be in terms of FileSystemURL); that was not done because in my ideal end state FileSystemURL wouldn't be used anywhere in the native file system code. I.e. it would purely be an implementation detail, but the interface between the native file system code and file system backends wouldn't depend on it anymore. Still working out the details for that. Bug: 1093653 Change-Id: I201703d427a5368e67b0410428f366d1dca91aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354596Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810080}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8134d1f70669..c23abb18bf27 2020-09-23 chrche@microsoft.com Calling localization API on grid setting titles 2020-09-23 chrche@microsoft.com Avoid term "Framework" being translated If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I240fc2691b9cf66149aea1164e4127a4d9a81053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810079}
-
kouhei authored
Bug: None Change-Id: If388c4ca16c76c7793ca17f15afa8aa6c6ec5199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423762Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#810078}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ia3528bd03480f080027975fa31b3dfd1f86a887e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427869Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810077}
-
Hiroshige Hayashizaki authored
Bug: 1129795 Change-Id: Ibff0827b206b9a0290fcdbcaccb3c57cae2a00da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413725 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810076}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600883819-6d81c41c506f5dfe6d7f3151056b14ae70cf74e3.profdata to chrome-linux-master-1600905490-263a31e7c986c96eb226e442771660364e68ddae.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I038c1f2f5b8a9f081210f9d2e2eeedb905e1492a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427746Reviewed-by:
-
Donn Denman authored
The Related Searches flag has expired, and we want it to stay active. This extends it until M89. BUG=1069096 Change-Id: Ib437a8f7b00833516be113d9a2216a0f9fa72880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412830 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#810074}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600883819-b4e54673a8ac66af896b73e5221cf1b275c98c77.profdata to chrome-mac-master-1600905490-fdb2e7b3449a423d26d1d15a08c032508e6d13fa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I0ed53d6c7cc3caee025cbc87ef699fa9b2d91d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427528Reviewed-by:
-
Piotr Pawliczek authored
Printer URIs with a "socket" protocol cannot have a path component. However, our UI allows a user to provide a queue name (a path) for all types of printers. Moreover, this field has a non-empty default value. This causes a validation error of provided printer URIs with a "socket" protocol when a user doesn't clean the field by hand. This patch solves the problem by automatically removing a path component from provided URI when the protocol is set to "socket". BUG=chromium:1129047 TEST=tested on atlas Change-Id: I92d8afbaaf4f0e74d102b1384ef7378d34b15496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423344 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810072}
-
Meilin Wang authored
This CL adds the notification opt in view on the Phone Hub panel to provide another entry point for user to grant access for notifications from the phone. This CL also introduces a |PhoneHubViewID| enum for easy access to main components of the bubble view during unittests. Screenshot: https://screenshot.googleplex.com/3XBngS9RArKjD44.png BUG=1106937,1126208 Change-Id: Ie440ebad2080382f48e48778eb94f559474aa5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424647 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Fan Yang authored
https://quiche.googlesource.com/quiche.git/+log/d18fe67a2b86..9a74ee9f6be4 $ git log d18fe67a2..9a74ee9f6 --date=short --no-merges --format='%ad %ae %s' 2020-09-23 fayang Discard initial key right after a HANDSHAKE packet has been sent and unify the fixes for missing initial keys. This goal is to make sure an endpoint never tries to serialize initial frames (could be pending frames or re-serialize initial packet in the coalescer) while initial key gets dropped. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=dschinazi@chromium.org Change-Id: Idf244b113439019dec06702ea5b5faba186a7b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427547 Commit-Queue: Fan Yang <fayang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Fan Yang <fayang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810070}
-
Brandon Wylie authored
Failing on more than n builders so disabling the test completely. Bug: 1131545 Change-Id: I089905b189e9dcece65ad2d5e7e174fccaa9565d TBR=wychen@chromium.org Change-Id: I089905b189e9dcece65ad2d5e7e174fccaa9565d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427441Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#810069}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/61c15b0ea08f..4e32ab4dd7c3 2020-09-23 dproy@google.com Merge "metrics: Implement getting prototext formatted metric result" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I50d7118fdf734852d9e91e554efa05cb8ab3fbee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427473Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009230800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/2a08myhDLFnYjNwtbn3d4RoitoxiNvUZkfWohkxJIP8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/141204984,b/157703611,b/159170892,b/159873698,b/159892033,b/167632244,b/167933216,b/169015908,b/169121815,b/169131919,b/169188037 Tbr: media-app@grotations.appspotmail.com Change-Id: I1b56db47c9fcb4375d2bbd9c26a91da54aaf513f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426294Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810067}
-
Daniel Nicoara authored
Breakpad change landed. Revert workaround. Bug: 1105559 Test: components/crash/content/tools/generate_breakpad_symbols.py --build-dir=out/andrd --binary=out/andrd/lib.unstripped/libcontent_shell_content_view.so --symbols-dir=/tmp/foo --platform=android Change-Id: I519534002898a97b15a57b9b87ac78ef3f216dee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427349 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810066}
-
Leo Zhang authored
Due to an upcoming change in glibc, we won't be able to support dlopening after engaging the sandbox unless a very new kernel. So we preload the libimedecoder in the sandbox hook and remove the permissions of its shared library dependencies from the sandbox. TEST=builds and run on vm. Bug: 837156 Change-Id: I64bcb651c055553390785d8cb1eaa2e516157a3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423826Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#810065}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1d3378762d82..5b2e586ff35d 2020-09-23 tsepez@chromium.org Perform GC on teardown of FXCG_UnitTest. 2020-09-23 tsepez@chromium.org Declare CXFA_FMLexer as stack-allocated 2020-09-23 vmiklos@collabora.co.uk Add FPDF_GetTrailerEnds() API 2020-09-23 tsepez@chromium.org Use members in CFXA_TabParam sorting code 2020-09-22 tsepez@chromium.org Make CXFA_TabParam private to cxfa_ffpageview.cpp 2020-09-22 tsepez@chromium.org Use sets of members in CFXA_Node node shuffling code. 2020-09-22 tsepez@chromium.org Rename XFA_GetWidgetFromLayoutItem() to CXFA_FFWidget::FromLayoutItem() 2020-09-21 tsepez@chromium.org Make iterator a stack variable in CFDE_TextEditEngine::RebuildPieces() 2020-09-21 tsepez@chromium.org Remove forward declarations of CFDE_RenderDevice. 2020-09-21 thestig@chromium.org Improve FPDFSysFontInfoEmbedderTest.DefaultTTFMap. 2020-09-21 tsepez@chromium.org Create a cppgc::Heap for xfa fuzzers 2020-09-21 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from a54f10f750ba to 0de987471899 (51 revisions) 2020-09-21 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Jinja2 from 61cfe2ac6c91 to a82a4944a7f2 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1130100 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I017abb70ef678f0ca460305d8cf46f3d250db946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427239 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
James Vecore authored
Fixed the debug test failure by removing contact manager all together from the onboarding page test since it was not actually needed in the fist place. PS1 has the original PS2 has the fix > [Nearby] Add onboarding to receive dialog > > This converts the onboarding and visibility pages to use the > nearby-template-page and hosts them in receive dialog. If the user > attempts to enter high visibility mode and nearby is not enabled, we > force onboarding to be run first. > > Screenshot of onboarding running from settings: > http://screen/xnm86ZduzQ6bGEr.png > > Bug: b:154866951 > Change-Id: I195fa803762635f0a19d58d7d4db919c825b8ffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420770 > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809599} Change-Id: I1825dbcfd1006ba32acaf16379945afbd306db27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426864 Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3a5612a8de0b..5e85c8bc3139 2020-09-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dc725cd5..adce4958 (809732:809911) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I70a8ff473c35f7f7c05d66a873972736680ac59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427564Reviewed-by:
-
Fabrice de Gans-Riberi authored
This is only used in one place for qemu. Use the implementation directly for this one usage. Bug: 1104411 Change-Id: Ifcc86426a87abbcbe8e539c2f028a7bdcc24dd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427036Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#810061}
-
Hiroki Nakagawa authored
LinkLoader::LoadLink() aborts inflight prerendering by calling Abort() at the beginning of the function, so it doesn't have to run another abort sequence later. This is tested by the existing PrerenderTest.MutateTarget test case. Bug: n/a Change-Id: Ibc70b94c0acaae52eb4f7d27f1a65210c15f9c10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426664Reviewed-by:
-
Caitlin Fischer authored
This is because Windows has a command line size limit and too many testing configs can result in the limit being hit. See comment 1 on the bug for details on why these studies are candidates for removal. Bug: 1126640 Change-Id: Ib3c5b2fdc5917bdf6a4119ff35657c1c29082bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402108Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#810059}
-
David Vallet authored
Bug: 1124062 Change-Id: I5422ddab8a7e9fafa9042bd65e59b1430dc4211a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422106Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#810058}
-
Omid Tourzan authored
Bug: 953308 Change-Id: I2315038143d708324783eaa788cb08d277b0d4c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397035 Commit-Queue: Omid Tourzan <oto@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810057}
-
Elly Fong-Jones authored
This reverts commit fe6e27d6. Reason for revert: newly-added OpenOrClosedShadowRootInBackgroundPage is very flaky, see https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64 or https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 Original change's description: > Allow access to closed shadow root from Extension > > This CL introduces chrome.dom.openOrClosedShadowRoot that is a > read-only property to allow access to the closed shadow root in > the Extension's content script. > > Bug: 778816 > Change-Id: I933bc5d3996a74f46ee75181c535150901a5a46a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319951 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809277} TBR=peria@chromium.org,yukishiino@chromium.org,rdevlin.cronin@chromium.org,tkent@chromium.org,karandeepb@chromium.org,mkwst@chromium.org,masonfreed@chromium.org,myid.shin@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 778816 Change-Id: If2a26a4aea10a0e03c9a8bca25ca34965bca9110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426265Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#810056}
-
Brian Sheedy authored
Does the following minor refactoring, prompted by the fact that ANGLE is in the process of adopting Gold and can make use of some existing code if it's moved into the common implementation. 1. Moves //content/test/gpu/gpu_tests/skia_gold/gpu_skia_gold_session.py and its associated tests to //build/skia_gold_common/output_managerless_skia_gold_session.py. 2. Makes 'chrome' the default instance in SkiaGoldSessionManager since the GPU tests have moved to using that instance and thus all tests use the 'chrome' instance. 3. Makes _GetSessionClass() no longer protected and uses its return value in test runners instead of manually importing the class. Bug: angleproject:4090 Change-Id: I1c2743d2dbe10e168f00e5f169f25fe9568c7c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427354 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810055}
-
David Black authored
This is a reland of 5aa92900 Original change's description: > Rough in support for multiple selection in holding space. > > Holding space needs to support selection of multiple holding space items > to perform bulk context menu and drag/drop operations on them at a time. > > This CL refactors HoldingSpaceItemContextMenu into a shared > HoldingSpaceItemViewDelegate to facilitate these requirements. > > Note that this CL does not change any existing behavior, just lays the > groundwork for supporting multiple selection. > > Bug: 1129981 > Change-Id: If4da6c19ba01bd7104a1b1487350c362d7be1dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419136 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809625} Bug: 1129981 Change-Id: I122a335d92a3df5e51933fc2eadf35080d0e87c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425894 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Adam Langley authored
caBLEv2 shard IDs have turned into 24-bit routing IDs. Also, fix a race caused by the fact that the network service sends notice of a data frame before writing its contents to the Mojo data pipe. Thus the data might not be ready to read as the code previously assumed. BUG=1002262 Change-Id: I2af2ce1ffa909f09559fc061881ce8bc72fbea55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416562 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#810053}
-
Mason Freed authored
Previously, the view-source table used the UA stylesheet value for word-break, which was break-word. This, combined with the prior quirks-mode view source document, was a very slow Layout path. With this change, the view-source table is set to break-all, which should be faster. Long lines are now broken at the edge of the page, rather than on word boundaries. So the display is different than before. However, the content is the same, so this should be ok. Bug: 920571 Change-Id: Ic045c4dc5f6f467ef1bfb3a6317d6c9020968370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424038 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#810052}
-
Jazz Xu authored
Change-Id: I6812f253ad2fde354219816298ebfd0c2f511f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427080 Auto-Submit: Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810051}
-
Caroline Rising authored
This change is behind the kReadLater feature flag and uses styles shared with the Tab Search feature. The delete button removes entries from the reading list model and the mark as read/unread button updates the status. Both buttons will trigger an update to the menu items so changes are seen as they are triggered. Bug: 1109316 Change-Id: Iaa093427c4f9be78901833eca3fd1dabec8ec1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422246 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#810050}
-
Nico Weber authored
This reverts commit 0ca8e290. Reason for revert: Seems to turn linux-chromeos-rel red, e.g. https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/680586? https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel?limit=200 has 151 red builds due to this at the moment. Original change's description: > Check for static initializers on linux-chromeos-rel. > > Bug: 537099 > Change-Id: I7d006d2a563de005b22945f0eabb723f86657862 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416563 > Commit-Queue: Lei Zhang <thestig@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809945} TBR=thakis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org Change-Id: Ic23eb82c485521ff52bb3c5574d048b3b66e3bd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 537099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427572Reviewed-by:
-
Satoshi Niwa authored
- Split createDirectoryContents_ into 2 functions isSearchDirectory() and createScannerFactory() - Removed all DirectoryContents.createFor*() functions. Bug: 1126742 Test: trybot Change-Id: I11c697952bdc275bc398f1e329feb359cfc95559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421848 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#810048}
-
Kunihiko Sakamoto authored
It's enabled by default at crrev.com/c/2415709. Bug: 935267 Change-Id: Icc35a4f8934a209b03b5f405f35cb559a855d845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423701Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Elaine Chien authored
Change-Id: I4b44ac7e7cb067bfd6679322ed3af245d3d4dbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427106 Auto-Submit: Elaine Chien <elainec@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810046}
-
