GitLab

Not bothering to put it behind the MD downloads flag because this design
change works well on its own.

Bug: 765389
Change-Id: I447cbe35dffaef6790d7ae67ea33d1a121b10b39
Reviewed-on: https://chromium-review.googlesource.com/754581Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516043}

The main change is the tab strip is a copy-paste of the old tab
strip, abandoning the previous implementation which attempted to move
things one-at-a-time. Things related to TabController were removed.
Most features (like dragging) that aren't currently supported are
commented out with a brief TODO so they can be added back later.

Separate out experimental tab painting from the tab class itself. There
is a lot of painting code and the tabs will get much more complicated,
so separating these will help code clarity.

Make the experimental tab controller work on non-Windows Views builds.

Updates to the model and tab to work better.

Bug: 
Change-Id: Iec432dc3ca1ccf18cc240656fa5e81f3c9fe51a4
Reviewed-on: https://chromium-review.googlesource.com/765212Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516042}

`discovery_completed_included_charateristics_` should be
`discovery_completed_included_characteristics_`.  This change fixes
that.

Change-Id: I30648137fa54920a11f58455d15b8ce3706f63fe
Reviewed-on: https://chromium-review.googlesource.com/764947
Commit-Queue: Conley Owens <cco3@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516041}

Change-Id: I862f8457790ab37dd82345f3ce04c92c83868c39
Reviewed-on: https://chromium-review.googlesource.com/764989Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516040}

For Active Directory managed devices.

Provides computer name, user name, user id, last fetched and fetch
interval details.

Bug: 664747
Change-Id: If19697e925379a0455b548e53dfefc9bead4d3c2
Reviewed-on: https://chromium-review.googlesource.com/732983Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516039}

Bug: 720131
Change-Id: Ic6e617a2ef1d9242614a157c57720242be9114c1
Reviewed-on: https://chromium-review.googlesource.com/760672Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516038}

Introduced in https://chromium-review.googlesource.com/759262

Bug: chromium:778632
Change-Id: Ibd35e0a2d4d01ae61e47c617012cb6a34f97f819
Reviewed-on: https://chromium-review.googlesource.com/763457
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516037}

Browser Actions will pass only the resource ids of the custom items'
icons through the Intent, instead of passing the whole Bitmaps. Then
with the source package name, Chrome can retrieve the client app's
Resources by PackageManager.getResourcesForApplication() and use it to
get the icons.

Bug: 775798
Change-Id: Ia63f07a6245673df63e71b550ffff2f63753964f
Reviewed-on: https://chromium-review.googlesource.com/758745
Commit-Queue: Lei Tian <ltian@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516036}

https://chromium.googlesource.com/angle/angle.git/+log/1974452966bb..7af63727f058

$ git log 197445296..7af63727f --date=short --no-merges --format='%ad %ae %s'
2017-11-13 oetuaho Fix nullptr dereference on struct parameter error
2017-11-13 oetuaho Fix MSVS 2015 warnings

Created with:
  roll-dep src/third_party/angle
BUG=784158


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I107192c15d2261899e64e715d49c3a5f9f85e68d
Reviewed-on: https://chromium-review.googlesource.com/767048Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516035}

When pinch zooming with a Mac trackpad, we generate synthetic ctrl-wheels
so that JS can handle the gesture. We now use these wheel events in the
PDF viewer's gesture detector to create pinch events for the viewer's
pinch zoom mechanism, as we currently do for pinches from touch events.

We also use this for non-synthetic ctrl-wheels. This allows us to have
zooming with the mouse wheel anchor the zoom around the mouse position
instead of the scroll position.

Bug: 715662, 715670
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia672a266cdd69c3e87d1451548c7470176ed8fd6
Reviewed-on: https://chromium-review.googlesource.com/730648Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516034}

GLES2DecoderImpl::offscreen_target_samples_ should be 0 for
nonmultisampled offscreen targets, but it was set to 1 instead sometimes.

Bug: 782497, b/30976816
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2efa1e432632c7d86d8b071ead7a0cdbfc9a2784
Reviewed-on: https://chromium-review.googlesource.com/765091Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516033}

https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/06fb50c..a00e807

Bug: 539572
Change-Id: I782a1625fdb9161ea356420fa5246fa435f17677
Reviewed-on: https://chromium-review.googlesource.com/764888Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516032}

The Rotate button in device mode now remains visible
in Responsive Mode, and swaps width/height.

Bug: 558594
Change-Id: I2c711944445a8c973d8d291298373aa0a31d0b06
Reviewed-on: https://chromium-review.googlesource.com/744988Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516031}

OfflineContentAggregator won't inform the observer if no provider is
registered, this may result in some downstream classes fail to
initialize.


Bug: 782975
Change-Id: I472f1cddff04d2b390a385b55c84f7658f001d80
Reviewed-on: https://chromium-review.googlesource.com/758628Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516030}

Change-Id: I27262f6dbcb146f9c0939d03e831b750b8978c8f
Reviewed-on: https://chromium-review.googlesource.com/765048
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516029}

All mentions of "tray" should now be confined to ash.

- MessageCenterTray => UiController
- MessageCenterTrayDelegate => UiDelegate
- (Chrome's) WebNotificationTray => MessageCenterUiDelegate

Also remove some unnecessary includes.

TBR=atwilson@chromium.org

Bug: 755413
Change-Id: Ic7774387ad313ed3ce356e5122a97dd9427699a9
Reviewed-on: https://chromium-review.googlesource.com/758931
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516028}

Test testDeviceMetricsWithDeviceWidth is disabled because of it occasionally fails
in Chromedriver test automation on Waterfall Linux bot.

Bug: chromedriver:2132
Change-Id: I49d98e53fc3d9ddb247b4b68cbd073d0d4afb370
Reviewed-on: https://chromium-review.googlesource.com/767047Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516027}

Added tests to track an infobar displaying but not actually attaching to
the window, which caused a BadTokenException when trying to show IPH on
that infobar.

BUG=779598

Change-Id: I79d33f4dd9ed48a161723e7f12814156021e433d
Reviewed-on: https://chromium-review.googlesource.com/758819Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516026}

We are preparing to remove this getter in Skia so updating the calling
code to not use it.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If0606bbaf55dfa5d17d7902e211dc71c4d033b4a
Reviewed-on: https://chromium-review.googlesource.com/766948Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Greg Daniel <egdaniel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516025}

Details:
1- Stores info into proto format and writes to a file.
2- The cache is instantiated & owned by ChromeDownloadManagerDelegate.
3- The entry is created when download starts and will be deleted as
soon as the download completes.

This is continued from this CL by shaktisahu@:
https://chromium-review.googlesource.com/c/chromium/src/+/731403.

Bug: 778425
Change-Id: I6bd3f6df2648ac7b812c464b572492fb670d32bb
Reviewed-on: https://chromium-review.googlesource.com/753537
Commit-Queue: Joy Ming <jming@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516024}

Change-Id: Id77e331feb60bd0c5fee6952b02763ea3c3081b5
Reviewed-on: https://chromium-review.googlesource.com/763127
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516023}

Bug: 771486
Change-Id: I37311373c130878c87201166266d320dba17c39e
Reviewed-on: https://chromium-review.googlesource.com/765618Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516022}

Bug: 740993
Change-Id: I9bc0340fcf8609702187a79f9d7ed07a5c781e4d
Reviewed-on: https://chromium-review.googlesource.com/764042
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516021}

Use the state of the frame to record highly granular frame type.

R=skyostil@chromium.org, kinuko@chromium.org

Change-Id: I82eed01bcc58e3e82aa8ff94c3b1dbcc1a24d1cb
Reviewed-on: https://chromium-review.googlesource.com/765507
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516020}

The timezones in 10.13 moved to a new location, so this adds that path
for 10.13 to the V2 sandbox profile.

Bug: 773532
Change-Id: I7944d4fb7a34869c80337fa8109a1a830a663671
Reviewed-on: https://chromium-review.googlesource.com/767108Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516019}

Change-Id: I0901b91d182ad4b47402a23748302f229a82fbf5
Reviewed-on: https://chromium-review.googlesource.com/764517
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516018}

Added testPassKitParsingError test which verifies the flow where PassKit
file can not be parsed. A test where PassKit UI is presented for a valid
PassKit file which be added in a separate CL.

Bug: 780646
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I189806c8eae0d93dc2b531ef31cf2c2fc8e22561
Reviewed-on: https://chromium-review.googlesource.com/762648
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516017}

This CL points to an updated method for installing the fonts needed by
LayoutTests on Fedora. It also adds ixorg-x11-server-Xvfb to the list of
required packages, as Blink's run-webkit-tests tool requires xvfb.

Bug: 
Change-Id: I8bf9a1539066880ca0ea450786847a5126f9cefb
Reviewed-on: https://chromium-review.googlesource.com/764861Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516016}

We need to be able to log UKM metrics from the compositor thread of the GPU
process, so initialize a global instance of MojoUkmRecorder to do that.

TBR=sky@chromium.org
(for DEPS change)

Bug: 717629
Change-Id: I69bedeed7c16bb69b50b7e12da590ba1c69a3c9c
Reviewed-on: https://chromium-review.googlesource.com/744544
Commit-Queue: Mikhail Fomitchev <mfomitchev@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516015}

Previously, we'd housed all our renderers in VrShellRenderer, but this
file has grown. In this change, the generic renderers (quad renderers,
mostly) have been moved to their own files. Element-specific renderers
have been moved into the files corresponding to said elements.

Since the WebVR content is not yet represented as an element and is
drawn explicitly by VrShellGl, it has a first-class renderer in the
renderers/ directory, but this should be a temporary state of affairs.

Bug: 784369
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6c27328b020e741fd275726b6e9cb51baddc0ff3
Reviewed-on: https://chromium-review.googlesource.com/766267
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516014}

cfi_diag was previously disabled due to issues with the ubsan runtime
library on Android, which have now been resolved.

Bug: 469376
Change-Id: I5de50253c684f66b11174587bfd9caf69bb6d9c8
Reviewed-on: https://chromium-review.googlesource.com/764869Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516013}

This associates original HttpRequestInfo and encoded data size
with Stream in the form of StreamMetadata, so that StreamURLRequestJob
could return actual values instead of the bogus ones that it currently
makes up.

This fixes a problem with reporting actual transferred bytes in
DevTools' network panel and removes the need for at last some of
the stream override params in WebURLLoaderImpl.

Bug: 763700, 705744
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I8493bbe464cd9a81a0864e5bcc9afd8b19aea3c5
Reviewed-on: https://chromium-review.googlesource.com/744290Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516012}

Add a new icon for tab switch suggestions, to visually distinguish them
from suggestions which navigate.

Bug: 780835
Change-Id: I6aac9379808da0d7217d9fe84350c48c25104ff6
Reviewed-on: https://chromium-review.googlesource.com/766447Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516011}

Bug: 780546
Change-Id: Ic363067d95e66f340f9c9425381d57eafd474980
Reviewed-on: https://chromium-review.googlesource.com/751285Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516010}

This is in preparation of enabling ESLint checks on that folder.

Bug: 720034
Change-Id: I1fcb208f7e0c94b2f8457c55a5399ae863dfe951
Reviewed-on: https://chromium-review.googlesource.com/764386
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516009}

Log the recommended audio HW buffer size as well as the actual buffer
size.

These were removed at some point and we're putting them back because
it's relatively hard to get this information.  These are always
printed, but only once when an AudioContext is created, so we aren't
actually spamming the console logs.

NOPRESUBMIT=true

Bug: 783929
Test: 
Change-Id: I6cea5dca504292cae9160899e8240f384453f913
Reviewed-on: https://chromium-review.googlesource.com/764541
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516008}

Remove a shadow variable as well.

Change-Id: I5449012b5d7ff4d041c52981d8e1705198b53dd9
Reviewed-on: https://chromium-review.googlesource.com/764881Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516007}

On CL https://chromium-review.googlesource.com/c/chromium/src/+/755595
Password Generation on IOS was removed. This CL removes leftovers.

Bug: 752077,700010,782224
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idbd84d45874a877bdc0ab81299123600442f2c98
Reviewed-on: https://chromium-review.googlesource.com/758836Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516006}

I believe I wrote most of this file and I constantly find myself tweaking
it for surface synchronization.

Bug: none
Change-Id: I2903d9674421ac5ec96cd9411d4ad1fb83bdfa6d
Reviewed-on: https://chromium-review.googlesource.com/766392Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516005}

Current tab instance through which the content view is obtained
for hit testing may be null, hence caused NPE. This CL moves the hit
testing to SelectionPopupController where the content view is
directly available.

Bug: 783717
Change-Id: I26a1cb264a45b4780a26d27a7174500437a3718c
Reviewed-on: https://chromium-review.googlesource.com/765551
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516004}