GitLab

Also change GRIT configuration from flattenhtml to preprocess where possible.

Bug: 866236
Change-Id: Ief42c461cc6b61d2a3719e823c261053d2bf205d
Reviewed-on: https://chromium-review.googlesource.com/c/1383395
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618273}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79d9455209de..345719ad7687


Created with:
  gclient setdep -r src-internal@345719ad7687

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:790424,chromium:790423,chromium:790405
TBR=mmoss@chromium.org

Change-Id: I015fb0a50e67abc5a5d91fb0c801be97bf5cc5ee
Reviewed-on: https://chromium-review.googlesource.com/c/1386987Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618272}

Bug: 823924
Change-Id: Ic024512bdd6dfe3fe3695459f15ecf926ddab99a
Reviewed-on: https://chromium-review.googlesource.com/c/1383904Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618271}

Because the virtual keyboard's doDefault() behavior is to do nothing,
in order for Switch Access to type on the virtual keyboard we have to
send synthetic mouse events.

Bug: 864826
Change-Id: Ie0562073d3f78baa42a9a6884dc41928922f2d4d
Reviewed-on: https://chromium-review.googlesource.com/c/1380340Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#618270}

https://chromium.googlesource.com/angle/angle.git/+log/96c11cc79490..bcb7890895d2


git log 96c11cc79490..bcb7890895d2 --date=short --no-merges --format='%ad %ae %s'
2018-12-20 ianelliott@google.com Implement eglSwapBuffersWithDamage on top of VK_KHR_incremental_present


Created with:
  gclient setdep -r src/third_party/angle@bcb7890895d2

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I8caf45c633972fef3f1931c0108fbb6044730f1e
Reviewed-on: https://chromium-review.googlesource.com/c/1386986Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618269}

It's a performance bottleneck. It was originally added here:
https://codereview.chromium.org/1195353002 - but the test
added then still passes without this code. I tried reverting
some other recent patches but I can't pinpoint what made it
start working.

I think we should try landing this change and watch out for
new crashes / regressions.

Bug: 489590, 579199

Change-Id: I8fbdeec0f75a22ed12dc1733ec3e1502bad8f90f
Reviewed-on: https://chromium-review.googlesource.com/c/1383053
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618268}

Fix WebAssembly's global/constructor js-api.

Bug: v8:8319
Change-Id: Ic77a5fe3bd9d6c68c27bb5d13c140745bf61fffe
Reviewed-on: https://chromium-review.googlesource.com/c/1386208Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618267}

BUG=910156

Change-Id: Ic41a3ddcaaff6382418ad8d2aa577dcb1b82bccc
Reviewed-on: https://chromium-review.googlesource.com/c/1387127Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618266}

This CL adds a vaapi.md entry to docs/gpu, explaining how to trace its
cpu/memory/power consumption, and to verify/debug its installation.

Bug: 912295, 514914
Change-Id: Ieb7ad033e20f1211a9ae170af9378296a58c0689
Reviewed-on: https://chromium-review.googlesource.com/c/1383147
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618265}

The crash in the issue is because
WindowGrid::GetWindowSelectorItemContaining returns nullptr then cause
crashed at WindowSelector::RemoveWindowSelectorItem. It is nullptr
because the drop target and dragged window are in different displays.
This cl fixes the crash only and will see whether we can do further
work for it.

Bug: 904466
Change-Id: I20a7ca5a0d294d23b28be13ab0c27a5fdfdc5c45
Reviewed-on: https://chromium-review.googlesource.com/c/1383535Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618264}

We can use the |object_has_multiple_boxes| argument here.

Change-Id: I4e20b5e8d1af9efa8b32a13a8be1cde6ec0be1c1
Reviewed-on: https://chromium-review.googlesource.com/c/1386790Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#618263}

Enumerator kUseGeometryMapper defined both in
src/third_party/blink/renderer/core/paint/paint_layer.h and
src/third_party/blink/renderer/core/layout/layout_object.h files which
causes a -Wshadow warning when both of these files are included

Bug: None
Change-Id: Iaabfb627c656d9a54db9a4f8249034696aa8dbbb
Reviewed-on: https://chromium-review.googlesource.com/c/1384284
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618262}

Change-Id: I90b0f33c15c5c45d3c232e2e028d5a5e68147f37
Reviewed-on: https://chromium-review.googlesource.com/c/1384252
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618261}

ShouldUseExtendedBounds returns true only for children, which dones't
have its own window state, so this shouldn't be necessary.

Bug: 912191
Test: no functional change. all tests should pass.
Change-Id: Ia3ea35a59d860ad62a0517daa66f6f1a5b26c070
Reviewed-on: https://chromium-review.googlesource.com/c/1385122
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618260}

This change updates the API in //base/ui/idle to be synchronous as all
the platform-specific implementations call the provided callbacks
synchronously.

Bug: 913988
Change-Id: I0126e5a2fae947109b01c0493de4ea1c2412fd9a
Reviewed-on: https://chromium-review.googlesource.com/c/1379183Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618259}

Bug: 865400
Change-Id: I82b17058dec8c8358953dbef6b53b3ed6fe81a92
Reviewed-on: https://chromium-review.googlesource.com/c/1387145Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#618258}

This reverts commit cb5feb06.

Bug: 909547
Test: CTS and GTS
Test: VDA unittest with --test_import

Original change's description:
> Revert "Re-land "Vaapi: Use GUARDED_BY() static annotations on decoder""
>
> This reverts commit b8ad3f6a.
>
> Reason for revert: This causes inifite-loop in IMPORT mode.
>
> Original change's description:
> > Re-land "Vaapi: Use GUARDED_BY() static annotations on decoder"
> >
> > Deadlocks in the original code are fixed now.
> >
> > TEST=ran VDA tests on Nocturne
> >
> > Bug=909547
> >
> > > Vaapi: Use GUARDED_BY() static annotations on decoder
> > >
> > > This CL introduces GUARDED_BY() static annotation on VaVDA; not all
> > > members variables need to be guarded, so it adds on a number of them
> > > a comment about on which thread it is used.
> >
> > > Bug: 909547
> > > Change-Id: I437a82320795aebc56f77cd1254bb7c8c2f2f5da
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1368590
> > > Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> > > Commit-Queue: Miguel Casas <mcasas@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#616196}
> >
> > Change-Id: If37bfd2d1f24b9b833bf8b291363b5c19861a6c7
> > Reviewed-on: https://chromium-review.googlesource.com/c/1377479
> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> > Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#617781}
>
> TBR=mcasas@chromium.org,hiroh@chromium.org,dstaessens@chromium.org
>
> Change-Id: Ic4b1e7e8de8403173f71a415094ed23cab51f5e4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1385689
> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618085}

Change-Id: I96f758b3f99032db219ffce1d432c348e6a30e90
Reviewed-on: https://chromium-review.googlesource.com/c/1385728Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618257}

These argument are always SkBlendMode::kSrcOver, and are not used in the
end.

Change-Id: I1625bdced4601b3eec3de609063f331208282b0d
Reviewed-on: https://chromium-review.googlesource.com/c/1386789Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#618256}

Pausing and Resuming wasn't necessary for the ScriptPromiseResolver
because it uses the microtask queue to schedule tasks for later.

If a task is resolved during paused state it instead schedules a task
for the micro task queue.

BUG=907125

Change-Id: I6f292200bb7ec6045f2ead2292006d2a0beee723
Reviewed-on: https://chromium-review.googlesource.com/c/1370384Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618255}

CL uses IdentityTestEnvProfileAdaptor and IdentityManager directly when application,
as replacement of SigninManager and PO2TS.

BUG=913393

Change-Id: Iaafac731c8681f8c248a8777eb11b2d5d7df0461
Reviewed-on: https://chromium-review.googlesource.com/c/1387125Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618254}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I4a6495b350d534570f9a30c9fbff621cc60eaa3a
Reviewed-on: https://chromium-review.googlesource.com/c/1387184Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618253}

This patch makes the following changes to cc::Layer{Impl} logging:
1) LayerTreeHostImpl::LayerListAsJson has been moved to
LayerTreeImpl::LayerListAsJson. This lets us fix a bug where logging the
layer list in LayerTreeHost::FinishCommitOnImplThread would log the
active tree instead of the sync tree.
2) JSON output now prints with OPTIONS_OMIT_DOUBLE_TYPE_PRESERVATION.
This simplifies long output from:
  "local": [ 1.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 0.0, 1.0 ],
to:
  "local": [ 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1, 0, 0, 0, 0, 1 ],
3) The cc::Layer logging now lists property tree indices on one line.
4) When logging layers, we now specify cc::Layer or cc::LayerImpl.
5) cc::LayerImpl's "OPACITY" value has been softened to "Opacity".

To test this change, run content shell with: --vmodule=*layer_tree_host*=3

This patch is in support of improved documentation for debugging blink & cc:
https://docs.google.com/document/d/1vgQY11pxRQUDAufxSsc2xKyQCKGPftZ5wZnjY2El4w8

Bug: 836902

Change-Id: I259b64b194ac569dc97eace2c2470ff80c7d2fa5
Reviewed-on: https://chromium-review.googlesource.com/c/1386650Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618252}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46c76f2379ba..79d9455209de


Created with:
  gclient setdep -r src-internal@79d9455209de

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I77a191d83ddd4453e44e518018192d124859b9ee
Reviewed-on: https://chromium-review.googlesource.com/c/1387185Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618251}

Recent refactoring changed missing printer capabilities from |nullptr|
to |base::Value()|. The check for it wasn't added properly however.

Bug: 916697
Change-Id: I8a0c26b239b28ee71c3871bedfa74ca526084bbb
Reviewed-on: https://chromium-review.googlesource.com/c/1386827Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618250}

Add implementation and a new unit test for this legacy API.

Bug: 906065
Change-Id: Iac276d876e2c3b44d2fe8d99c1218a9c9e72ecd3
Reviewed-on: https://chromium-review.googlesource.com/c/1386549
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618249}

Bug: 916994
Change-Id: I93d0e6264e842fb445c30b5b73396695823ade6c
Reviewed-on: https://chromium-review.googlesource.com/c/1387044Reviewed-by: Peter Lee <pkl@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618248}

https://skia.googlesource.com/skia.git/+log/44539be30ef8..f05e6d3a4644


git log 44539be30ef8..f05e6d3a4644 --date=short --no-merges --format='%ad %ae %s'
2018-12-20 bsalomon@google.com Remove superfluous budgeted params and member related to SkImage_GpuBase


Created with:
  gclient setdep -r src/third_party/skia@f05e6d3a4644

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=halcanary@chromium.org

Change-Id: Ied06ae367ce9d8a49772903d7ac421f8d7f2a38c
Reviewed-on: https://chromium-review.googlesource.com/c/1386985Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618247}

Improve memory related metrics by:
 * Sharing gles2::FeatureInfo between RasterDecoderContextState
   and RasterDecoders. It can avoid unnecessary GL calls for multiple
    gles2::FeatureInfo.
 * Only initialize (create) ContextState & GLContextVirtual in
   RasterDecoderContextState when it will be used or is being used.

Bug: 913591
Change-Id: Ia553513ed13b1d2b1ccf53b827757d341d847e06
Reviewed-on: https://chromium-review.googlesource.com/c/1380943
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618246}

Cause TabThemeHelper#onActivityAttachmentChanged to notify listeners
of a theme color change - this is so that the Tab's new Activity is
notified of the Tab's theme color.

Additionally, this requires adding the Tab to the TabModel slightly
earlier (before the Tab is properly reattached), so that the
listeners that the TabModel registers catch the theme color change.

Bug: 833381
Change-Id: I721412dcfc4d9ec6d7ddacfda73b9adac644a937
Reviewed-on: https://chromium-review.googlesource.com/c/1384368
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618245}

Also gets rid of the LogUMAHistogramEnumeration function.

Bug: 916752, 850520
Change-Id: Ia314fbb78f401b284c8da56dcf60995b836cf791
Reviewed-on: https://chromium-review.googlesource.com/c/1385123Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618244}

This reverts commit b77e6c51.

Reason for revert: Caused crashes
crbug.com/902832
crbug.com/902848

Original change's description:
> Oilpan: Enable HeapCompaction for incremental marking
> 
> Enables HeapCompaction for kIncrementalIdleGC and kIncrementalV8FollowupGC.
> 
> Bug: 864425
> Change-Id: I397aefd20a3bde8e6cf5140067f2e1a70ff46811
> Reviewed-on: https://chromium-review.googlesource.com/c/1381321
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#617450}

TBR=haraken@chromium.org,keishi@chromium.org,mlippautz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 864425
Change-Id: I54e486f784a6f0b8eb7bbda80a58b52661fa8501
Reviewed-on: https://chromium-review.googlesource.com/c/1386764Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618243}

https://chromium.googlesource.com/catapult.git/+log/7d95d86a652f..53c753ed351e


git log 7d95d86a652f..53c753ed351e --date=short --no-merges --format='%ad %ae %s'
2018-12-20 sergiyb@chromium.org Redirect stderr to stdout to avoid stdout/stderr races


Created with:
  gclient setdep -r src/third_party/catapult@53c753ed351e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:916164
TBR=sullivan@chromium.org

Change-Id: I0b76e5aaa2013488d48bfda4fb59fcb406689be4
Reviewed-on: https://chromium-review.googlesource.com/c/1386984Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#618242}

Bug: 916866
Change-Id: I12f6d235644850fda295189a776357a5cde5e1de
Reviewed-on: https://chromium-review.googlesource.com/c/1386964
Commit-Queue: Tien Mai <tienmai@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618241}

TableViewDetailTextItem uses "assign" for its UIColor properties, which
may cause a crash. See http://crbug.com/910542 and
http://crrev/c/1356585.

Change-Id: I7c88d62ea5465e34cad771d3c06a73830e63c5fb
Reviewed-on: https://chromium-review.googlesource.com/c/1386873Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618240}

The dependency is now stale as ProfileOAuth2TokenService is no longer
passed to ProfileSyncService.

Bug: 913928
Change-Id: Ic2f3ccab8f9529638e18ae3e1d007f7ef1dc4284
Reviewed-on: https://chromium-review.googlesource.com/c/1386828Reviewed-by: John Wu <jzw@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#618239}

an additional test was added on 11/12/2018 that conflicts with
upstream work in v8.

R=jgruber@chromium.org, marja@chromium.org, mlippautz@chromium.org

Bug: v8:8381
Change-Id: I016774ece8a91efb7f92f7c86653ff369fc233bc
Reviewed-on: https://chromium-review.googlesource.com/c/1376103
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618238}

Bug: 916991
Change-Id: Ie7287aeb9c7acc421a82188b0a08dc991343bd76
Reviewed-on: https://chromium-review.googlesource.com/c/1386850
Commit-Queue: Denis Kuznetsov <antrim@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618237}

- Changes the direction of the Chevron for collapsed sections on Recent Tabs
from ^ to >
- Changes the Show Full History cell text color to blue.

Screenshots:
https://drive.google.com/open?id=10nWzEHY5-I0MPsr93RkckIN3j3GoKVCz
https://drive.google.com/open?id=1s_M1YnTLysIK7GJSYJBr7hQl0AptbIvF
https://drive.google.com/open?id=1eL6pIBdhsOC3_4LJ4cnXNXegbxnPvyJ2

Bug: 913523
Change-Id: Ic788398c60cef39c3c2d72f4ef4a9f6859141d66
Reviewed-on: https://chromium-review.googlesource.com/c/1385284Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618236}

Bug: 806868
Change-Id: Ia549974259696fe60684dd413b1256e2d2e60e76
Reviewed-on: https://chromium-review.googlesource.com/c/1386866Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#618235}

The accessor may be in accessors_waiting_session_queue as SessionStarted
may not have been called when the document shuts down.

Bug: 915578, 915844, 582328
Change-Id: Ie7d864bcdaeb9dec9c3153ff1026de58d7aa8050
Reviewed-on: https://chromium-review.googlesource.com/c/1379920
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618234}