- 14 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d04f123cc7ff..95f0b1673fe6 git log d04f123cc7ff..95f0b1673fe6 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 egdaniel@google.com Miscellaneous updates to handle more vulkan creation failures. 2019-11-14 flar@google.com Only define SK_GL for Flutter on non-Fuchsia platforms. Created with: gclient setdep -r src/third_party/skia@95f0b1673fe6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: Ie6ffb2a0b1c61b530f573210e05201b0122bcd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715322}
-
Toni Barzic authored
Follow-up on CL:1913508. This moves window minimization done during transition to home when overview exit starts after observers were notified about overview start animations have been canceled (as window hiding is actually part of overview exit). BUG=1024107 Change-Id: I1b5a520b3ef38c8cf2d69f32ea54b5ea94bd7c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915227Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#715321}
-
David Van Cleve authored
A recent change (5f37444e) to GURL::PathForRequest led to some crashes caused by URLPattern calling PathForRequest with invalid URLs, which was explicitly prohibited with a DCHECK prior to the change but, in release builds, had been silently accepted. This change makes URLPattern only call GURL::PathForRequest with valid input, by failing URLPattern::MatchesURL on pathless inputs prior to the call to PathForRequest. Test: Added a regression test. Bug: 1022771 Change-Id: I52896977b6474603d30cbea99ebb776eb3ccf308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906511 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#715320}
-
Hans Wennborg authored
The binary or operator meant the if conditions were always true, and recent Clang versions warn about it. This patch makes the code match the comments. Bug: 1024203 Change-Id: Ie4716dadc40a43f8f97e26ee04745cf967fc98f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912718 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#715319}
-
Andreas Haas authored
The removed template parameters are unnecessary, they can be determined from the types of the normal parameters. This is part of my work to reduce uses of blink::ArrayBuffer and co, which were originally WTF::ArrayBuffer and co. Bug: chromium:1008840 Change-Id: Id609a811966405dec14ab62a304ea0a56bd7b287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917139Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#715318}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6fc149b0b16..1dbf452d7ecb git log f6fc149b0b16..1dbf452d7ecb --date=short --no-merges --format='%ad %ae %s' 2019-11-14 khokhlov@google.com [Telemetry] Write Telemetry traces in proto format under experimental flag 2019-11-14 perezju@chromium.org Reland "[Telemetry] Remove more unused properties in results object" Created with: gclient setdep -r src/third_party/catapult@1dbf452d7ecb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:990304,chromium:973837 Change-Id: I2fed45457c98bd47614ccf7d2afb001798d41d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916626Reviewed-by:
-
Thomas Lukaszewicz authored
This reverts commit 0cb19df2. Reason for revert: Reverted change due to transparency issues when using older profile icons. See https://bugs.chromium.org/p/chromium/issues/detail?id=1016334 Bug: 857064,1016334 Change-Id: I9f35f0692c733f1a7544249581104006f0673642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913465Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ff11d441ccdf..4d4332ed66fa git log ff11d441ccdf..4d4332ed66fa --date=short --no-merges --format='%ad %ae %s' 2019-11-14 cjmcdonald@chromium.org Reland 'DependencyService: Provide exact eclass dependency paths' Created with: gclient setdep -r src/third_party/chromite@4d4332ed66fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Idb14d0c1004dfeba2eb52321bcdfb6463ded8b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916634Reviewed-by:
-
Collin Baker authored
Currently, capturing a thumbnail for a background tab must call WebContents::IncrementCapturerCount(). However, this tells the renderer that a page is visible, triggering any deferred media autoplay. This adds a flag to IncrementCapturerCount() which makes it use the new PageVisibilityState::kHiddenButPainting state. This indicates that the page should be rendered, but shouldn't be treated as user-visible yet. Fixed: 995131 Change-Id: Ie90fdc25e412969d904f93c8c5ffcbc2312ddc0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885511Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#715314}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/60bd1aea3d6d..01294f0e2987 git log 60bd1aea3d6d..01294f0e2987 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 philipel@webrtc.org Don't configure video codec switching if no video stream has been created. 2019-11-14 noahric@chromium.org Reduce verbosity of logging around playout underrun count on iOS. 2019-11-13 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-13 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-11-13 danilchap@webrtc.org Stop using DEPRECATED_SingleThreadedTaskQueueForTesting in call tests Created with: gclient setdep -r src/third_party/webrtc@01294f0e2987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com No-Try: True Bug: chromium:none,chromium:None Change-Id: Ib951232ed85757f7df6c6872674056a728204106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916629 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Dave Tapuska authored
It is possible to block the main thread with a invalid pattern, input and CSS. Now that V8 has added a backtracking limit take advantage of it. 1000000 matches the limit Yarr (webkit's regex engine). See https://github.com/WebKit/webkit/blob/89c28d471fae35f1788a0f857067896a10af8974/Source/JavaScriptCore/yarr/Yarr.h#L50 BUG=966405 Change-Id: I08bc956806bc7efb8cdc06dc0db30fa94e68df9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915280 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715312}
-
Gyuyoung Kim authored
This is a reland of 184873e8 The original CL had an extra ')' in audio_output_provider_impl.cc. This CL fixes it. Original change's description: > Clean up old uses of AssistantAudioDecoderFactory > > This CL replaces the last use of old Mojo type of > AssistantAudioDecoderFactory interface with > mojo::Remote. > > Bug: 955171 > Change-Id: I16778198e4dc1b7a7693dbbc0f7b85ae4a3d6bbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890454 > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Tao Wu <wutao@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#711712} Bug: 955171 Change-Id: I559da6829ba6fb8914f08ee761b9f998ec3de98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895265 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#715311}
-
Eric Willigers authored
The minimal-ui buttons (Back and Reload) now appear to the left of the window title, The origin and three dot menu appear to the far right (as before). Box layout is used to layout the buttons on the left and the buttons on the right. Flex layout is used to distribute space between the left and right button areas and the window title area in the center. Platform-specific adjustment of the spacing around the minimal-ui buttons will occur in a subsequent CL. Desktop web applications can request the minimal-ui buttons by specifying display minimal-ui in their web app manifest: https://www.w3.org/TR/appmanifest/#dom-displaymodetype-minimal-ui Bug: 1016663 Change-Id: I449f85b2a8d5912811245e40e084411629e8b1db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900801 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#715310}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c49e3c72fe42..eb53c26684a5 Created with: gclient setdep -r src-internal@eb53c26684a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id6f83f769ccb1e5f7c4fc649d3d134e6bcbdc2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715309}
-
Peter Boström authored
This change keys off of ui::MaterialDesignController::touch_ui(). Bug: chromium:1024013 Change-Id: Ic22087009c21a57b4616c333f652b5fa5a03f63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914533 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#715308}
-
Elly Fong-Jones authored
This change: 1) Marks flags that expired in M80 or earlier as expired, as we are now in M80; 2) Marks flags that expired in M76 or earlier as hard-expired by removing the temporary-unexpire-flags-m76 flag and associated feature. TPMs will begin filing cleanup bugs for the remaining M76 and earlier flags at this point. Bug: 953690 Change-Id: Ibd6922fe1ffc5dbb090e91cdd558a4e60260e345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913866Reviewed-by:
-
Jesse McKenna authored
This reverts commit 9825d9be. Reason for revert: This approach is no longer needed for Progressive Web Apps to find chrome.exe. The path for chrome.exe will be saved in the user-data directory instead (crrev.com/c/1891121). Original change's description: > desktop-pwas: Get install mode from user-data dir > > This change adds function GetUserDataSuffix(), which returns the install > suffix (e.g. "" for the primary install mode, " SxS", " Beta", or > " Dev") given a path in the User Data folder. > > It is based on GetInstallSuffix(), which does the same given a path in > the Application folder. > > This new function is the first part of finding the location of > chrome.exe from within the User Data directory, where Progressive Web > App (PWA) launchers are planned to be. The next step will be a function > that uses the install mode from FindInstallMode(GetUserDataSuffix()) to > get the full path of chrome.exe, which PWAs can then use to launch. > > Change-Id: If69859fc5f36b7d2d2c4262a1955bd432d983597 > Bug: 960245 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866977 > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708663} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960245 Change-Id: I96a4c65176b89c86642bc9eba9a90942c1c724ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914480Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#715306}
-
John Budorick authored
Bug: 1011474 Change-Id: I06d9feecb00ce7e9d277b965a069ff997887fdff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917460 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#715305}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b2407dd746de..90df527f91c3 git log b2407dd746de..90df527f91c3 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 sugoi@google.com Negative baseVertex support Created with: gclient setdep -r src/third_party/swiftshader@90df527f91c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/144353667 Change-Id: I6249d606e5b993d2365a91fa7dcaecf2f6f08c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916632Reviewed-by:
-
Dave Tapuska authored
This change moves the definition of EnforceInsecureNavigationsSet from FrameHost to LocalFrameHost in blink. It removes the public definition on the WebLocalFrameClient as it isn't necessary anymore. BUG=1008432 Change-Id: Ia9d07fe3a1f5e5b97187cea61db73e8c39fd002d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896912 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/subresource_filter This CL was uploaded by git cl split. R=csharrison@chromium.org Bug: 1018667 Change-Id: I72995e8d6b1ec8eccdab2fd5653419eb2953de64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916471 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#715302}
-
Tobias Sargeant authored
Replace cases of LazyInstance that are not DestructorAtExit with NoDestructor equivalents. Clean up trivial con/destructors along the way. Bug: none Change-Id: I7c027948f3bfdc3159d24d7e4c36178b271281f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890336 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#715301}
-
Andreas Haas authored
The removed template parameters are unnecessary, they can be determined from the types of the normal parameters. This is part of my work to reduce uses of blink::ArrayBuffer and co, which were originally WTF::ArrayBuffer and co. Bug: chromium:1008840 Change-Id: I47cd70919e711fcc0337383233da6688a96c3d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916477Reviewed-by:
-
arthursonzogni authored
Replace: FrameHostMsg_ReportContentSecurityPolicyViolation (IPC) By: FrameHost.ReportContentSecurityPolicyViolation (mojo) This corresponds to step 1.f from the "Unify CSP" document: https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao The native struct are going to be converted in a series of follow-up. Bug: 1021462 Change-Id: I74ed8852d64a8c8cebb6b2d59fde5e23c5e0ddab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905987 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715299}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/515f9bebd1f8..6e687af2649d git log 515f9bebd1f8..6e687af2649d --date=short --no-merges --format='%ad %ae %s' 2019-11-14 geofflang@chromium.org Support standalone Android builds in ANGLE. Created with: gclient setdep -r src/third_party/angle@6e687af2649d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I71e174b6740315998b1c29372ca273a3272c9f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916631Reviewed-by:
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/data_reduction_proxy/data_reduction_proxy_settings_unittest_android.cc This CL was uploaded by git cl split. R=mthiesse@chromium.org Bug: 1018667 Change-Id: Ie46aeaf56588980d38c7ae4ea2fd6fc57ad0110e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916868 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#715297}
-
Lukasz Anforowicz authored
After r694827 (request_initiator=website) the |request_initiator_site_lock| set by URLLoaderFactoryManager::CreateFactory was mismatched with the |request_initiator| actually used in requests triggered by a content script. This CL fixes this. The fix in this CL requires passing 2 origins (instead of just 1) to URLLoaderFactoryManager::CreateFactory: - |main_world_origin| (new) - |origin| (renamed from |initiator_origin| and/or |request_initiator|). The CL renames the old parameter to |origin| to reinforce that after r694827 |origin| may be different from |request_initiator| (after r694827, |request_initiator| is always the same as |main_world_origin|). To better understand the motivation for the rename, it might be useful to consider the examples added by this CL to a doc comment for the URLLoaderFactoryManager::CreateFactory method. Note that in some examples (i.e. the content script example) |request_initiator| is different from |origin|. Note that the CL adds a TODO to remove |main_world_origin| and to rename |origin| back to |request_initiator| once we no longer need separate URLLoaderFactories for allowlisted extensions. The goal of this CL is to change/fix the |request_initiator_site_lock| used in URLLoaderFactory of content scripts. This means that the old coupling between |request_initiator_site_lock| and |factory_bound_allow_patterns| is undesirable. This CL addresses this by changing |factory_bound_allow_patterns|'s type away from |array<CorsOriginPattern>| and into |CorsOriginAccessPatterns?| which allows for explicit setting of a |source_origin|. Opportunistically, the CL also changes the type of |source_origin| in cors_origin_pattern.mojom from string to url.mojom.Origin. This CL helps with the following high-level goals: - https://crbug.com/998247: `Sec-Fetch-Site: same-origin` in same-(web)-origin XHRs from content scripts. After the CL the desired behavior will also happen in allowlisted content scripts. This allows the CL to make a small tweak in test expectations to reflect this. - https://crbug.com/920634: Enforcing that |request_initiator| matches |request_initiator_site_lock|. Thanks to the main changes in this CL, the CL can also a add a NOTREACHED assertion to |request_initiator| checks in CorsURLLoaderFactory::IsSane. In a follow-up CL this assertion can be changed into mojo::ReportBadMessage and returning false (i.e. rejecting the IPC). - Moving toward removing global CORS access list in favor of using per-factory access lists. This CL helps by making URLLoaderFactoryParams::factory_bound_access_patterns include the source origin as well as the block list. Bug: 998247, 920634, 936310 Change-Id: Iaf9877f72291b436481c90c1eee5000e731af13b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875273 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
-
Colin Blundell authored
Simple addition to //weblayer/public/README.md. Change-Id: I7c01fbfdcb78a12202d34462c6ec2220468f89ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916459 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#715295}
-
Aaron Leventhal authored
Part of proposal at https://github.com/aleventhal/aria-annotations Bug: 1006767 Change-Id: I5b66cd6a93ea799ec1d61a0592733812f7bdf8a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911081 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#715294}
-
Joey Arhar authored
This patch enables the new form control refresh feature, controlled by the flag #form-controls-refresh, for Android by moving the new form controls from NativeThemeAura to NativeThemeBase. Bug: 1022073 Change-Id: I1fbc4cd2962becbe93a227518354c46886467aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900651 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#715293}
-
Alex Chau authored
- Before SharingUseDeviceInfo was eanbled, first DeviceInfo change propagated already had send_tab_to_self disabled. Therefore SendTabToSelfMultiDeviceActiveChecker can safely assume DeviceInfo is updated just by checkint count > 1 - After SharingUseDeviceInfo is enabled, a Sharing related change is propagated before send_tab_to_self is isabled, causing the checker to stop waiting before disabling send_tab_to_self change is propagated - Fixed by adding a speciifc checker to wait until send_tab_to_self is disabled Bug: 1023950 Change-Id: Id13f3b4a29982c7fd1c1d3d9ae4344de34d8b395 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914389 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715292}
-
Rune Lillesveen authored
Mark as dependent on multi-keyword display issue. Bug: 995106, 1024123 Change-Id: I6eb0fa30750c5ba4e465df7c65a1463084d34099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916821Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#715291}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14dea250..5f43d8c3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I60abca7daeff8120a929a927681e6605ab564110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917040Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715290}
-
Richard Knoll authored
This moves the logic for getting a list of devices from SharingService to a new class. The SharedClipboardMessageHandler can then use the new class instead of the dependency on SharingService. Bug: 1021980 Change-Id: Ie1b0146b6aaf60949481ac161bfd69905cf7c803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910097 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#715289}
-
Elly Fong-Jones authored
There was an error in 74eb4979, which removed this DialogDelegate's GetDialogButtons override but didn't add a matching set_buttons call. TBR=pbos@chromium.org Bug: 1024761 Change-Id: I085c89d0fbaecaa442d7f8036b31ef2b17b20130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917239Reviewed-by:
-
Evan Stade authored
This allows the client to handle backing out of an error page, such as an SSL interstitial, when there's no navigation entry to return to. This would cover the case where the first page that a tab navigates to has an SSL error. The implementation for the Android shell simulates the user pressing 'back'. Bug: 1022607 Change-Id: Id05e035d75b124b63c09c074b38a78eb1810e8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910869Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#715287}
-
Jasper Chapman-Black authored
Change-Id: I027ecd4022ca78872c32188e22c997826bf60027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917240Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715286}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/32197f897c73..d04f123cc7ff git log 32197f897c73..d04f123cc7ff --date=short --no-merges --format='%ad %ae %s' 2019-11-14 robertphillips@google.com Revert "Reland "Implement sample mask and sample locations support in Vulkan"" 2019-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 4f023f565a61..1b52f05868c9 (8 commits) 2019-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 88632cac30e1..b2407dd746de (3 commits) 2019-11-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-14 csmartdalton@google.com Reland "Implement sample mask and sample locations support in Vulkan" Created with: gclient setdep -r src/third_party/skia@d04f123cc7ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: chromium:None,chromium:None Change-Id: Idfdadf77b2eb798a97f830d587c6ca716e1eea58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916630Reviewed-by:
-
Mugdha Lakhani authored
Refactor the scheduling and cancellation of one off tasks that wake up the browser to process (Periodic) Background Sync registrations into two methods. This gets rid of the method that calls the appropriate method and removes special casing base::TimeDelta::Max() as the delay that causes cancellation of one-off task. Unit tests have also been updated. Bug: 996166 Change-Id: Ic35f4833c627220d464641db82feee8bbfc12ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906213 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#715284}
-
Armando Miraglia authored
As suggested in http://crbug.com/990381, it should be beneficial to change the child process flag for the video capture service on MacOS. This is due to issues with entitlements. This CL changes the flag of the utility process to CHILD_PLUGIN. Bug: 990381 Change-Id: I31583c2860678d0fadee00f37cb1cfd089ce53a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905848Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#715283}
-
