- 15 Apr, 2020 9 commits
-
-
Alex Turner authored
Set async=false on all three scripts instead of the first repeatedly. The current typos are causing a test to be flaky (AdTaggingBrowserTest. ChildrenOfFrameWithWindowStopAbortedLoad_StillCorrectlyTagged). Bug: 1069346 Change-Id: Ib5c7f4994d25ebf4eedcc6d23ef2110c321bb454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148846 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#759076}
-
chrome://memory-internalsdpapad authored
Also performing several other small cleanups 1) Eliminate usage of CallJavascriptFunctionUnsafe() 2) Eliminate global setSaveDumpMessage in favor of a WebUI event. 3) Eliminate global returnProcessList in favor of a Promise. 4) Remove bad calls to AllowJavascript(). This method should not be called within async C++ callbacks. 5) Add JS type checking. 6) Move "Refresh" and "Save" button creation in HTML, no need to do this in JS. 7) Remove unnecessary flattenhtml="true" in grd file. Bug: 1028829 Change-Id: I7841982bef7957b7178171ab50211f93deb1d672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956446 Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:Erik Chen <erikchen@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759075}
-
Michael Thiessen authored
Converting String URLs to GURL also required moving some tests from junit to native java unittests, as GURL requires the native library to be loaded. Bug: 783819 Change-Id: Id574a15715effe1845d2cfa50f698461b83bb5b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071376Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#759074}
-
Siyu An authored
This CL updates the unmask dialog on Desktop&Clank (in the window title) and iOS (in the instruction). Bug: 1059087 Change-Id: Ia33fab4eaa7cc35dcb08e7d1c5fe87e33556fb2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144738 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#759073}
-
Tommy Li authored
This CL makes the matches in the popup show and hide in response to the group toggling. Bug: 1052522 Change-Id: Ifdc5684fed01d84a05663cbe3093417392a4a88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149508 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759072}
-
Wenyu Fu authored
Build a standard promo card component that could be used in different area. Bug: 1068831 Change-Id: I8f557c602109abfbe5736e82afad7bfea262d236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141136 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#759071}
-
Matt Menke authored
We want to get rid of the single argument AddHeader() method as the two argument AddHeader() and SetHeader() methods are safer and more flexible. Bug: 1068194 Change-Id: Ia94f58be1f09887d858df8c107843c683da1560a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148023 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#759070}
-
Brian Geffon authored
Both //content/common and //chromeos/system are including core_sceduling.cc source rules resulting in two object files with the same symbols when both dependencies are included. The reason those source files were added in content/common was because //chromeos/system was not exporting its symbols. The correct fix is to let //chromeos/system when using //chromeos:chromeos_export to also properly set the visibility, the other alternative would have been to create a separate chromeos system export rule but that seems unnecessary. Bug: 1070488 Change-Id: I6287388e42ab652c951ee10eb5f96ede74b1c625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149277Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759069}
-
David Black authored
When the Assistant response's first UI element is a card, the card is given an empty top border for spacing. When this occurs, DCHECK fails because we were previously expecting local bounds when we should be expecting contents bounds. Bug: b:153904177 Change-Id: I7f28149cb6317836c76f566827526c8220f0e5a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148221Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#759068}
-
- 14 Apr, 2020 31 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/54e96aa9dd24..69510cd61f1a Created with: gclient setdep -r src-internal@69510cd61f1a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046880 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I502adb49e2d5c4fea8f509a81f34d6eaa72fcee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149808Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759067}
-
Ian Wells authored
Bug: 1044139 Change-Id: Id5d490f24f8fa8adad5821e4f2be0188a95c2fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149475 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#759066}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ifb83ad15153e7b00c072ddb82576c9f5a7bab9ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149815Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759065}
-
John Chen authored
Remove chrome/test/chromedriver/chrome/version.h, which has been made obsolete by https://crrev.com/758971. Change-Id: Id0de8a194e856dad2499902ba3287ef936a16a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149293 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#759064}
-
Nicholas Verne authored
The tests now use FakeCrostiniFeatures to set all things enabled. Bug: 1067487 Change-Id: I8e797002be93a830eb2ce1e425b4bd91cf8bffb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147165 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#759063}
-
Becca Hughes authored
Enhance the GetMediaFeeds API to sort results by audio+video watchtime percentile as well as limiting the number of results and having a minimum watchtime. This will be used for getting feeds to fetch and for display. BUG=1053599 Change-Id: If6015f57ba93a39ec07288fe8a3d1244c3bdb7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145760Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#759062}
-
Sinan Sahin authored
This CL adds an OfflineIndicatorControllerV2 class that controls the status indicator widget for offline indicator specific purposes. This new class is owned by TabbedRootUiCoordinator like the status indicator widget itself. The old offline indicator snackbar is also disabled when V2 is enabled. Bug: 1068725 Change-Id: Ifa34779309f1229ca82d4a9ea7b1b9b49a43f4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148217 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I54b8e787b5c1469efff77fda48d72a4d7251f7f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147401Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759060}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I2e67c7815fa8ce3e9ad784e85e236cf33558e8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147440Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759059}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I0fe1f6d5debb837b6e7abab6fdfa0fd6a8a22e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143190Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759058}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: Ifffa60fa05d5dd2f52fabe0a2d6794db187e0f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147400Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Vincent Boisselle <vincb@google.com> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759057}
-
Nigel Tao authored
Checking (result.error_code != JSON_NO_ERROR) is equivalent to checking result.value (which has a base::Optional type, convertible to bool). The error_code enum is really a private implementation detail. Callers don't care about it (other than it being an error or no error). Removing references (outside of //base/json) to that enum will let us more easily modify the //base/json implementation. Bug: 1070409 Change-Id: I1e026b4b8e1544823b07ce2c6da9f5bd56f6c708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145750Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#759056}
-
Alex Danilo authored
Selector specificity due to selector lengths for files-ng caused the selector for check-select 'Open' button color to be overridden. Change the non files-ng selector 'Open' button color case to not be applied when check-select mode is active. Bug: 1068556 Change-Id: I5fd36169941bcb4a1fad111d090b6ef728761aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147138 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#759055}
-
Taylor Bergquist authored
This obviates the need for the work described in go/chrome-nonpredictive-tabstrip-animations. One known issue: with stacked tabs enabled, resize a window to trigger a transition into the stacked layout. The tabs will animate into the new layout, and while this is taking place, they will ignore any further changes to the tabstrip's bounds. Further work: Continue removing now-dead code from the new animation system. Bug: 958173 Change-Id: I977b3836ad87647fa17e431a1215ebd1ce81727c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055544Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#759054}
-
Robbie McElrath authored
This CL creates a NotificationSettingsClient in site_settings that contains embedder-specific logic needed to render the Site Settings UI. These 4 methods are mostly needed to support TrustedWebActivities, which are a Chrome-specific feature. They were put into their own client interface to keep SiteSettingsClient more organized. Bug: 1058597 Change-Id: Iceeeabc1476c39d079f8eb8aeade142dd5d4e05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146141 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#759053}
-
Kevin McNee authored
Per the style guide, we should use proper test assertions to report failures gracefully. Bug: None Change-Id: I84be462364d6f310c08c591785d7f781a92251b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149376Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#759052}
-
David Bokan authored
Clusterfuzz found that using EventSender::DoDragDrop from a remote frame causes a crash. EventSender doesn't support remote frames in this case and this is a crash in test-only code so not severe but this CL will silence the fuzzer. Bug: 1070137 Change-Id: Ib64b677a792af2311cd7ace745755c2b9055219e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149282 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
David Black authored
The Assistant search provider will be used to provide a single search result from its internal cache of conversation starters. This will be surfaced as a suggestion chip in the launcher. This CL simply stubs in the provider (along with a single hardcoded result) so as to unblock development of the logic which will allocate Assistant a dedicated chip slot. Changes are gated behind a new feature flag: AssistantLauncherChipIntegration Bug: b:146673437, b:153165833 Change-Id: I54159c3ee17110c8fad46bbb3cea4a88b3250df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134651 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This method decides for a given user and username, whether moving to the account store should be offerred or not. Bug: 1032992 Change-Id: Ie57a2d4f4bafe309ac114f2060270ca3d85c0a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135612 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#759049}
-
Russell Davis authored
This bug happened in two cases when using Find: 1) On macOS, always 2) On all platforms, when text is selected This change fixes both cases, while also unifying macOS behavior with other platforms. (I think the previous exclusion of macOS from the find-from-selection behavior may have been due to a misunderstanding of some mac-specific code/comments.) Now, when doing a find-from-selection, the initial result is the same selected text, rather than the next occurrence. So it's a no-op (as it should be) in terms of the selection and the document scroll position. Bug: 1043550 Change-Id: I78a27b74324f74b1e3c7528fc91badf85f65d22f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145247 Auto-Submit: Russell Davis <russell.davis@gmail.com> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#759048}
-
Xiang Ji authored
The update inculdes windows 2019 server support and bring back nested vm support. Change-Id: I83c30ab71da31120d69c9559f10cb04f10a1a54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147885Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#759047}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fea8b94591c3..2136b569eb2e git log fea8b94591c3..2136b569eb2e --date=short --first-parent --format='%ad %ae %s' 2020-04-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 304e175c..72d0f390 (758795:758913) 2020-04-14 mbonadei@webrtc.org Remove AudioProcessing::UpdateHistogramsOnCallEnd. 2020-04-14 mbonadei@webrtc.org Remove NetEq::InsertPacket deprecated method. 2020-04-14 mbonadei@webrtc.org Remove the version of Port::AddrAddress without a URL parameter. 2020-04-14 philipp.hancke@googlemail.com insertable streams: include rtp_timestamp offset for audio Created with: gclient setdep -r src/third_party/webrtc@2136b569eb2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1069278 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I782a927b88f3bf00d68d031ace8ed78866532baa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149807Reviewed-by:
-
Wan-Teh Chang authored
Remove the two special cases (|index| is equal to decoder_->imageIndex or decoder_->imageIndex + 1) for the avifDecoderNthImage() call because avifDecoderNthImage() already handles these special cases internally. Also remove the !decoder_->image check because decoder_->image cannot be NULL after avifDecoderParse() has been called successfully. Bug: 960620 Change-Id: I222187d0619c33cb557b3c17b80af10a7c0e704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149749Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#759045}
-
Brian Geffon authored
This adds a Swap File interface which is a generic interface which contains operations to write to, read from, and drop contents from a swap file. We also add three different swap file implementations on top of the standard swap file, which include a compressed, encrypted, and compressed + encrypted swap file. The compressed swap file implementation is a standard gzip implementation. The encrypted swap file uses AES 256 GCM SIV mode with a 256bit ephemeral key which is randomly generated and a randomly generated nonce. All swap files will write to /mnt/stateful_partition/unencrypted/swap if it exists otherwise swap file creation will fail. The key never leaves the internal EncryptedSwapFile implementation. The swap files are created as O_TMPFILE | O_EXCL meaning they do not actually link and O_EXCL prevents them being linked to the file system, so all space is reclaimed when the file descriptor is closed. Disk space can be incrementally reclaimed after memory has been read out of the swap file using the DropFromSwap API. It uses fallocate(2) with FALLOC_FL_PUNCH_HOLE. Bug: 1067833 Change-Id: Ifeacec0ed5571507f80add2cf43fdd4063478459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142474Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#759044}
-
Rachel Carpenter authored
We use this information to decide whether to show the Getting Started module in the app, and which cards in the module to show. Bug: b/151575693,b/151573827 Change-Id: I4f067a4c8b748e3e49804be650c5a7815e962379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147164Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@google.com> Cr-Commit-Position: refs/heads/master@{#759043}
-
Sammie Quon authored
Adds an optional if restore bounds exist to PersistentWindowInfo. On re-adding display update the restore bounds to what it was before display got removed. Test: manual, ash_unittests PersistentWindowControllerTest.RestoreBounds Bug: 1068458 Change-Id: I72e9b118759e99842a51c2293e496097ca739df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147690Reviewed-by:
-
Thomas Guilbert authored
The video.requestAnimationFrame() API was renamed to the video.requestVideoFrameCallback API. This CL updates WPTs to use the new API name. Bug: 1012063 Change-Id: I065d26131367f43a534249622c7e2ef9a328d9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145965 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#759041}
-
Peng Huang authored
Creating SkSurface is not cost free, so cache SkSurface in ExternalVkImageSkiaRepresentation and reuse it for all write access. Bug: None Change-Id: Ie055731effedb7ab95fff0d8ad734f507d1dea07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146232 Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#759040}
-
Charlie Hu authored
This CL adds use counters to record document policy usage. Details can be found on https://docs.google.com/document/d/1KV--4Btc2hKbCjUTAEl4vTlLAgM9W9qoPWbYAqC49xg/edit?usp=sharing Bug: 1066620 Change-Id: I530e42613929a78184b489a33d6fae67022b1dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119662 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#759039}
-
Shakti Sahu authored
This is a reland of 011b4cb3 Note : Downstream CL will be landed immediately https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2883534 Original change's description: > Query Tiles: Submit query on last level tile click > > This CL adds : > 1 - Submit query and show SRP on the last level tile click > 2 - Shorten most visited tile section to 1 row for smaller screens > > Bug: 1068308 > Change-Id: Icae29ad8bcc563ca6cfa3bfd35d18fa90ff65b7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147041 > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758724} TBR=dtrainor@chromium.org Bug: 1068308 Change-Id: I69b53e5fc89e5982dcffbf927d21a355f7d507cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148826Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#759038}
-
Dale Curtis authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/21eb59531974..4fa54ca5f7fc $ git log 21eb59531..4fa54ca5f --date=short --no-merges --format='%ad %ae %s' 2020-04-14 dalecurtis Disable sanitizers everywhere except msan. 2020-04-13 dalecurtis Disable sanitizers for nasm in all build types. 2020-04-13 dalecurtis Disable sanitizers for nasm like we do for yasm. 2019-10-07 efoo Add "# COMPONENT" to nasm OWNERS file Created with: roll-dep src/third_party/nasm TBR=davidben Bug: 766721 Change-Id: I86327ca55472650591f52b901ecb8a508cad30a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148027Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#759037}
-
