- 28 Aug, 2018 40 commits
-
-
Orsi Batiz authored
Changed window.trustedTypes to window.TrustedTypes. Added TrustedTypes.getPolicyNames. Throw exception for TrustedTypes.createPolicy with non-unique policy name. Adapted tests to match. Most existing applications are synchronous, createPolicy was made synchronous. Changed tests from async_test to test, because of change mentioned above. Bug: 739170 Change-Id: Ie4e2702994a8674e65376b7bf4b42d4c41e9cec4 Reviewed-on: https://chromium-review.googlesource.com/1181362 Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#586630}
-
Juan Antonio Navarro Perez authored
Prevent us from making too many calls to test results server by keeping cached copies of the responses we get. For this we implement a frames.GetWithCache which will store the dataframes created from test result reponses, and reuse them for a set amount of time. Bug: 875251 Change-Id: Ieb87ef4c0a52635287b634e2bd233d248fb878e2 Reviewed-on: https://chromium-review.googlesource.com/1188578Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#586629}
-
Ken Rockot authored
content_browser_client.h includes a generated header from the //media/mojo/interfaces:remoting target. This CL adds the missing public_deps entry. TBR=jochen@chromium.org Bug: 875342 Change-Id: Ieeeca1bcf43ac9f10d51e5a8b0cf939da7a8b091 Reviewed-on: https://chromium-review.googlesource.com/1184782Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#586628}
-
Koji Ishii authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1291bfd6f65472cc455002ea9c93ac5278940ef7 Reviewed-on: https://chromium-review.googlesource.com/1190363 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#586627}
-
Joel Einbinder authored
Change-Id: If7d05b2d5b33761d4872184a3860dba5dc1368a2 Reviewed-on: https://chromium-review.googlesource.com/1188875Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#586626}
-
Fredrik Söderquist authored
The SVGListPropertyTearOffHelper did not call CommitChange(), meaning that the element wasn't notified of the change, and wouldn't invalidate et.c as needed. It also could've failed to synchronize the attribute properly. Bug: 843901 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iad581027c3748e3e90cf6fe3d944273b207fef0f Reviewed-on: https://chromium-review.googlesource.com/1189882 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#586625}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d143f76c. With Chromium commits locally applied on WPT: fbb650b3 "Add WPT serialization tests for wasm modules" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23539 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I784e7de8ee0142fc715e71a591236641e05169a3 Reviewed-on: https://chromium-review.googlesource.com/1192593 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#586624}
-
Takashi Toyoshima authored
This patches introduces OriginAccessList in the NetworkService to manage origin whitelisting in the NetworkService. Also the class is designed to be used even in Blink to unify existing whitelisting implementation in blink::SecurityPolicy. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If44cfadbbf88f5b55c8bc2b01c1ae87c7a6e0a74 Tbr: mkwst@chromium.org, rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1183203 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#586623}
-
Scott Wu authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I432e37bfc45d93b159f9519f4c05c8bef09a8adc Reviewed-on: https://chromium-review.googlesource.com/1186010 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586622}
-
Yuzu Saijo authored
There is an interference of Finch experiment of OomIntervention and AdTagging, and through discussions we have decided that it would be better to activate OomIntervention only when AdTagging is on. This way the user distribution of the experiment groups would be even. Change-Id: If7fc7a07625c107f781596ed0303d3b2ca7a8368 Reviewed-on: https://chromium-review.googlesource.com/1192373 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#586621}
-
Michael Lippautz authored
No-try: true Bug: chromium:843903 Change-Id: I8e08d8514963f029055ab3b611993b7b3d47d413 Reviewed-on: https://chromium-review.googlesource.com/1193022 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Lei Zhang authored
Simplify code and do cleanups along the way. Change-Id: I6def55b56bda86b6665b2e71fe52e7592162ee7b Reviewed-on: https://chromium-review.googlesource.com/1189547Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586619}
-
Sam McNally authored
This restriction causes files in team drives or shared with me to never be dimmed in response to being unavailable while offline. Further, files unaffected by offline-status should never have the dim-offline class set so this restriction is unnecessary so just remove it. Bug: 878278 Change-Id: I0b93dbd125324bfcf9a859f73850801c5c2d0515 Reviewed-on: https://chromium-review.googlesource.com/1192863Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#586618}
-
Scott Wu authored
Bug: 865114 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ieee1dc88df8b3c5533b050bda4f71e7b27588df1 Reviewed-on: https://chromium-review.googlesource.com/1170681 Commit-Queue: Scott Wu <scottwu@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I6a5f3a0ae9831b7db59d8995129877acd49d15e1 Reviewed-on: https://chromium-review.googlesource.com/1190624Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#586616}
-
Koji Ishii authored
NGLineBreaker::BreakText sets kDontReshapeStart for the items at the beginning of a line. This patch fixes to compute it by whether the start offset of the item_result is at the beginning, not the current offset NGLinebreaker is reading at. They are the same for the normal line breaking, but not so when rewinding. Found while investigating crbug.com/866771. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I812d2cd44492a0112bcd037749168e8eb62d8a94 Reviewed-on: https://chromium-review.googlesource.com/1190983Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#586615}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/06b42949b620..482b1744caf3 git log 06b42949b620..482b1744caf3 --date=short --no-merges --format='%ad %ae %s' 2018-08-28 31666470+s-perron@users.noreply.github.com Validate all type ids. (#1868) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@482b1744caf3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2dbba152018dae39410105f4243dd8a7af830eac Reviewed-on: https://chromium-review.googlesource.com/1192258Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586614}
-
Michael Lippautz authored
The tests rely on synchronous image construction and flake if construction is delayed by e.g. garbage collection. Bug: 877461 Change-Id: I976af5b362687839dba091322c4682719ddf84dc Reviewed-on: https://chromium-review.googlesource.com/1190623 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586613}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id9a3b3f448f9f1927a5aa3c3ec43d0c7069691d0 Reviewed-on: https://chromium-review.googlesource.com/1192594Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586612}
-
Sergey Poromov authored
Change-Id: Iee6ea87eafce204c702c3514b940f6f1ddd08f28 Reviewed-on: https://chromium-review.googlesource.com/1190262 Commit-Queue: Drew Wilson <atwilson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#586611}
-
Adam Rice authored
The external/wpt/xhr/timeout-multiple-fetches.html layout test was flaky due to a race condition. Adjust the timeout to improve the probability of the right side winning the race. Also add a uuid to the URL to stop preflight caching from breaking the test. BUG=871578 Change-Id: I76056f7dadc789289755c35f6b6b9d8ae86c1441 Reviewed-on: https://chromium-review.googlesource.com/1174209 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Use write barrier instead of registering call when setting a newly created wrapper. Bug: chromium:843903 Change-Id: I850329c73193c3391bebf65b41bcd82b1783dd51 Reviewed-on: https://chromium-review.googlesource.com/1191262Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6dfdca836806..4e877ad3ed4d git log 6dfdca836806..4e877ad3ed4d --date=short --no-merges --format='%ad %ae %s' 2018-08-28 jmadill@chromium.org Suppress TransformFeedbackNegativeAPI test on Mac AMD. Created with: gclient setdep -r src/third_party/angle@4e877ad3ed4d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I8f18d56910d017fc4764799e1c69cdcd53322733 Reviewed-on: https://chromium-review.googlesource.com/1192260Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586608}
-
Koji Ishii authored
Following bot results are included. 9153 9154 9157 9160 9161 9162 9166 9167 9168 9172 9177 9187 9196 9205 9213 9215 9221 9 lines were removed and 8 lines were deflaked by consecutive results since 9162. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I613bd4cdb0055fb34cf129f3d0bfd3611755cd57 Reviewed-on: https://chromium-review.googlesource.com/1189302 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#586607}
-
Kent Tamura authored
Bug: 878220 Bug: https://github.com/whatwg/html/issues/3950 Change-Id: Ia0d53411b9dbeb15555ed66bf7539d3fd3fdd509 Reviewed-on: https://chromium-review.googlesource.com/1192367Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#586606}
-
Lei Zhang authored
Remove LazyInstance usage as well. BUG=537099 Change-Id: I6424f0b6d60e45b2bfea6a274e87ef58b3023a7e Reviewed-on: https://chromium-review.googlesource.com/1188638Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586605}
-
Marc Treib authored
Bug: 856179 Change-Id: Ied5b62047c4a07044b5f732159f8e5c0a6a282e4 Reviewed-on: https://chromium-review.googlesource.com/1188676Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#586604}
-
Sam McNally authored
With DriveFS, hosted docs aren't openable as normal files so can't be copied as native files. Instead, DriveFS will provide an API to perform the copy. In preparation for this, add detection of hosted files in the DriveFS-specific implementation of AsyncFileUtil. In particular, when considering a copy within DriveFS, query whether the source is hosted. If the file is hosted, fail the operation with a TODO to add a real implementation once the DriveFS side is ready. Otherwise, fallback to the native file copy implementation. Bug: 870009 Change-Id: Ie346306d1c3308a39e5322d16117aec7566575de Reviewed-on: https://chromium-review.googlesource.com/1188006Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#586603}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 22476f41. With Chromium commits locally applied on WPT: fbb650b3 "Add WPT serialization tests for wasm modules" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23538 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I363a21b0a71c003316396ced1761cc2416a9c25c Reviewed-on: https://chromium-review.googlesource.com/1192697 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Adam Rice authored
Update TransformStream to standard version 78cfd1e22b717ce7e6d3aae4e36de0ef9101356e. This includes change https://github.com/whatwg/streams/pull/948 which corrects the behaviour when the transformAlgorithm rejects. Also enable test TransformStreamTest.ThrowFromTransform which was disabled pending this fix. BUG=845427 Change-Id: If0eff40c5855bf662098eecc87e32256b97dc71e Reviewed-on: https://chromium-review.googlesource.com/1167011Reviewed-by:
-
John Abd-El-Malek authored
Bug: 874259 Change-Id: I63329aaab21843fc6d6f626ce581420a55a6931a Reviewed-on: https://chromium-review.googlesource.com/1192591 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#586600}
-
Hwanseung Lee authored
When PostDispatchEventHandler is called, Event object was passed as a parameter. and it is never nullptr. so it can be changed to reference instead of pointer. and DidDispatchClick is also same. Bug: 874385 Change-Id: I13042aa1eb949007db554d8bb98d8789102dfaba Reviewed-on: https://chromium-review.googlesource.com/1189324Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#586599}
-
Matt Falkenhagen authored
Throttles can defer the request and possibly impact performance. There's evidence of this happening like issue 817909. Before this CL, service worker network fallback would incur throttling twice. This CL adds RestartWithFactory to ThrottlingURLLoader to make network fallback a lightweight internal swap of the destination factory after throttling already occurred. Bug: 873575, 876983 Change-Id: Icd44fdf13a27ad1a95e39a6640f7ce0c15cd9184 Reviewed-on: https://chromium-review.googlesource.com/1189250 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#586598}
-
Min Qin authored
The issue is introduced by https://chromium-review.googlesource.com/c/chromium/src/+/948852. If g_default_download_directory in download_prefs.cc is already set by a previous testcase, DownloadTargetDeterminerTest will not be able to reset that global variable. That's causing many tests to fail. This CL fixes the problem by reintroducing the SetDownloadPath() call to set download path tied to the DownloadPrefs. BUG=877026 Change-Id: I235cddd6e28bc2803610bf559528d0722bc61f15 Reviewed-on: https://chromium-review.googlesource.com/1192336Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#586597}
-
Kouhei Ueno authored
Bug: 874323 Change-Id: I484e7fac6b562916c14c0e848672cd54b9187ddd Reviewed-on: https://chromium-review.googlesource.com/1188012 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
Relanding https://crrev.com/c/1180824 with following bug fixes: - |chrome_public_test_vr_apk| was not configured to load the test-only native library calling the content native support lib added in the CL. Recycles the target |libchromefortest| for vr. - Neglected the reminder TODO in render_frame_host_android.h. This CL deletes it. Also minimizes test code present in the production and moves more test code from Java to native (java WebContentsUtil to native RenderFrameHostTestEx class). This reverts commit 38906838. Bug: 862153, 875742, 876375 Change-Id: I93746f36f74f33a93973278dc92890c77b8c2646 Reviewed-on: https://chromium-review.googlesource.com/1184131Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#586595}
-
Kunihiko Sakamoto authored
Before this CL, SignedExchangeHandler did not parse signed exchanges when the v= parameter of content type was invalid. After this CL, SignedExchangeHandler will parse the signed exchange prologue even if content type indicates an unsupported version, and will redirect to the sxg's fallbackUrl as long as it is valid. Bug: 803774, 874323, 876968 Change-Id: I7f890f439c25b8591f0d741fa6257282f791cdf1 Reviewed-on: https://chromium-review.googlesource.com/1192472Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#586594}
-
John Z Wu authored
This is needed to receive wallet data through sync, and does not actually enable credit card upstreaming. Bug: 874694 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie0637e7f70b5a08fb20e20bb6bd6863fdb7a399d Reviewed-on: https://chromium-review.googlesource.com/1176722Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#586593}
-
Sungguk Lim authored
Extension creator which is in chrome://extensions allows only valid pkcs8 format private key. This CL makes the extension creator return proper error message if a private key is not pkcs8 format. Bug: 866604 Change-Id: I4579257f738995f87689c3aea98f6d07c4665f67 Reviewed-on: https://chromium-review.googlesource.com/1186283 Commit-Queue: Sungguk Lim <limasdf@gmail.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Noel Gordon authored
Offline Drive has no test coverage, let's add some. Start Files App with offline Drive and render test files. Verify that the files are correctly rendered for the 'offline' Drive state. file: hello.txt should be rendered as not available offline (dimmed) folder: photos should be rendered as available offline pinned: pinned should be rendered as available offline Enabled for DriveFS only, per CL:1189515. Test: browser_test --gtest_filter="*fileDisplayDriveOffline*" Bug: 878260 Change-Id: I589036310e630480f66ac90a123ae1e3e99669ac Reviewed-on: https://chromium-review.googlesource.com/1192372 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#586591}
-
