- 14 Sep, 2015 40 commits
-
-
yzshen authored
This CL: - removes the scripts for syncing and relevant comments. - adds a note in README.chromium that it has been forked from the Mojo repo. BUG=None Review URL: https://codereview.chromium.org/1338793003 Cr-Commit-Position: refs/heads/master@{#348760}
-
zmo authored
It's simply an overlook in previous CLs. BUG=429053 TEST=gpu_unittests, webgl2_conformance R=piman@chromium.org Review URL: https://codereview.chromium.org/1341133002 Cr-Commit-Position: refs/heads/master@{#348759}
-
spang authored
This library is used by Chrome on Chrome OS to allocate accelerated graphics buffers. The version avaiable on Ubuntu is too old, and as a result we can't run unit tests for the gbm platform code on developer workstations or on the waterfall. This adds the library to third_party and fixes up the build files to use either the OS copy (for Chrome OS release builds) or gardened copy (for testing on the waterfall) depending on the value of "use_system_minigbm". BUG=530712 TEST= GYP_DEFINES="use_ozone=1 chromeos=1 ozone_platform_gbm=1 use_system_minigbm=0" gclient runhooks ninja -C out/Release ozone_unittests ./out/Release/ozone_unittests gn gen out_gn_ozone --args='target_os="chromeos" use_ozone=true ozone_platform_gbm=true use_system_minigbm=false' ninja -C out_gn_ozone ozone_unittests ./out_gn_ozone/Release/ozone_unittests Review URL: https://codereview.chromium.org/1341473003 Cr-Commit-Position: refs/heads/master@{#348758}
-
jdduke authored
Match the native Android TextView handles by using the same PopupWindow visibility type, namely, TYPE_APPLICATION_SUB_PANEL. BUG=528365 Review URL: https://codereview.chromium.org/1339433003 Cr-Commit-Position: refs/heads/master@{#348757}
-
kkimlabs authored
If user edited title and url at the same time, url didn't get saved. The reason is that we save title first, then UI is refreshed by bookmark observer, which resets the url edit text to the original url. BUG=530794 Review URL: https://codereview.chromium.org/1341793004 Cr-Commit-Position: refs/heads/master@{#348756}
-
dfalcantara authored
When opening a tab in the background on Svelte devices, tabs are marked as "frozen" without actually being frozen (no saved state). * Make CompositorViewHolder load these tabs properly instead of trying to unfreeze them. * Make Tab#unfreezeContents() protected so that nothing can handle this. * Clear out pointers when destroying the objects and clean up destruction, in general. * Stop destroying some TabObservers twice. * Add a test to catch this. * Moves process killing to the end of destroy() instead of the middle. BUG=495877 Review URL: https://codereview.chromium.org/1337113007 Cr-Commit-Position: refs/heads/master@{#348755}
-
joelo authored
0 configs already ran on Swarming 43 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.webkit.json: WebKit Linux - chromium.webkit.json: WebKit Linux (dbg) - chromium.webkit.json: WebKit Linux 32 - chromium.webkit.json: WebKit Linux Leak - chromium.webkit.json: WebKit Linux Oilpan - chromium.webkit.json: WebKit Linux Oilpan (dbg) - chromium.webkit.json: WebKit Linux Oilpan Leak - chromium.webkit.json: WebKit Linux Trusty - chromium.webkit.json: WebKit Mac Oilpan - chromium.webkit.json: WebKit Mac Oilpan (dbg) - chromium.webkit.json: WebKit Mac10.10 - chromium.webkit.json: WebKit Mac10.6 - chromium.webkit.json: WebKit Mac10.6 (dbg) - chromium.webkit.json: WebKit Mac10.7 - chromium.webkit.json: WebKit Mac10.7 (dbg) - chromium.webkit.json: WebKit Mac10.8 - chromium.webkit.json: WebKit Mac10.9 - chromium.webkit.json: WebKit Mac10.9 (retina) - chromium.webkit.json: WebKit Win Oilpan - chromium.webkit.json: WebKit Win Oilpan (dbg) - chromium.webkit.json: WebKit Win x64 Builder - chromium.webkit.json: WebKit Win x64 Builder (dbg) - chromium.webkit.json: WebKit Win10 - chromium.webkit.json: WebKit Win7 - chromium.webkit.json: WebKit Win7 (dbg) - chromium.webkit.json: WebKit XP Ran: ./manage.py --convert blink_platform_unittests R=maruel@chromium.org,dpranke@chromium.org BUG=98637, 524758 Review URL: https://codereview.chromium.org/1311253006 Cr-Commit-Position: refs/heads/master@{#348754}
-
mcgrathr authored
GN does not allow tabs, so the mode should always set indent-tabs-mode to nil (off), regardless of the user's global setting. R=erg@chromium.org BUG= Review URL: https://codereview.chromium.org/1341943002 Cr-Commit-Position: refs/heads/master@{#348753}
-
sergeyu authored
BUG=512899 Review URL: https://codereview.chromium.org/1312463005 Cr-Commit-Position: refs/heads/master@{#348752}
-
kalman authored
devToolsConnection.onDisconnect should be devToolsConnection.onDisconnect.addListener. BUG=526882 R=pfeldman@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1339173002 Cr-Commit-Position: refs/heads/master@{#348751}
-
jianli authored
BUG=491352 Review URL: https://codereview.chromium.org/1336883004 Cr-Commit-Position: refs/heads/master@{#348750}
-
http://crrev.com/1334963002mcasas authored
BUG=530687 Review URL: https://codereview.chromium.org/1343843002 Cr-Commit-Position: refs/heads/master@{#348749}
-
bcf authored
BUG=internal b/19210655 Review URL: https://codereview.chromium.org/1336763008 Cr-Commit-Position: refs/heads/master@{#348748}
-
geofflang authored
BUG=504872 Review URL: https://codereview.chromium.org/1345573002 Cr-Commit-Position: refs/heads/master@{#348747}
-
bhnascar authored
This patch changes a DCHECK used to validate WKBackForwardListItems before using them to an if check. This fixes a crash caused by QuickBack. BUG=529890 Review URL: https://codereview.chromium.org/1307103004 Cr-Commit-Position: refs/heads/master@{#348746}
-
davidben authored
This is to help debug https://crbug.com/289715 and try to get a stack trace earlier. BUG=289715 Review URL: https://codereview.chromium.org/1337113004 Cr-Commit-Position: refs/heads/master@{#348745}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/995b4bd..0faed58 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=tomhudson@google.com Commits in this roll: 0faed58 mtklein@chromium.org cmake_build: support SKIA_OUT and BUILDTYPE 59ce45f bsalomon@google.com Revert of Test that GrFragmentProcessors work without input colors. (patchset #2 id:20001 of https://codereview.chromium.org/1341853002/ ) 72c58e7 bsalomon@google.com Test that GrFragmentProcessors work without input colors. 3833daa robertphillips@google.com Fix GPU-only snapping bug in mask blur rendering efd50da reed@google.com impl preroll for all image backends 5a744b7 mtklein@chromium.org Have SkVarAlloc::alloc() use sk_malloc_throw. a46ada5 mtklein@chromium.org SkValidatingReadBuffer: make sure we don't call readTypeface(). 8725e53 reed@google.com fix leak in test Review URL: https://codereview.chromium.org/1336143004 Cr-Commit-Position: refs/heads/master@{#348744}
-
kbr authored
Unfortunately the flaky suppression isn't working in this situation. Filed Issue 530373 about that. BUG=524717 TBR=bajones@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/1336793002 Cr-Commit-Position: refs/heads/master@{#348743}
-
megjablon authored
removing jeremyim from OWNERS and histogram owners. BUG= Review URL: https://codereview.chromium.org/1326683005 Cr-Commit-Position: refs/heads/master@{#348742}
-
jaekyun authored
In document mode, multiple activities could be used concurrently. So registering and unregistering a receiver could happen on different ones, which causes Chrome crash. BUG=530097 Review URL: https://codereview.chromium.org/1338813004 Cr-Commit-Position: refs/heads/master@{#348741}
-
zhenw authored
Platform-level tracing doc: https://docs.google.com/document/d/1Uv8SzOq2ugvzLiOcP85g7qPiaxwsn4tgOdxpe3YjUkM/edit?usp=sharing BUG=515323 Review URL: https://codereview.chromium.org/1338033002 Cr-Commit-Position: refs/heads/master@{#348740}
-
bnc authored
Update PrefsFunctionalTest.TestPrivacySecurityPrefs to test new preference kNetworkPredictionOptions instead of deprecated preference kNetworkPredictionOptions. BUG=526773 Review URL: https://codereview.chromium.org/1316073005 Cr-Commit-Position: refs/heads/master@{#348739}
-
dcastagna authored
AllocateGpuMemoryBuffer can return null (e.g: when the GPU process is down). This CL makes sure we don't crash in that case and make the code behave in the most similar way to when allocations succeed. BUG=529088 Review URL: https://codereview.chromium.org/1304843005 Cr-Commit-Position: refs/heads/master@{#348738}
-
aurimas authored
BUG=530225 TBR=yusufo@chromium.org Review URL: https://codereview.chromium.org/1337213003 Cr-Commit-Position: refs/heads/master@{#348737}
-
newt authored
policy_templates.grd failed to list "fa", while remoting_strings.grd was missing 11 xtbs. As a result, these strings were missing translations in several languages. BUG=518020 Review URL: https://codereview.chromium.org/1308743008 Cr-Commit-Position: refs/heads/master@{#348736}
-
fsamuel authored
The name View Manager doesn't really capture the extent of what we'd like to accomplish here. Renaming this directory to mus (Mandoline UI Services). Some classes and namespaces need to change to but I'll do that in a separate CL. BUG=531533 TBR=jochen@chromium.org for components rename. Review URL: https://codereview.chromium.org/1344573002 Cr-Commit-Position: refs/heads/master@{#348735}
-
bruthig authored
Some users were seeing incorrectly aligned and rotated backgrounds while at the lock screen. It was possible that the session state animations were aborting the screen rotation animations prematurely and thus they would get stuck in a bad position. TEST=ScreenRotationAnimationTest.LayerTransformGetsSetToTargetWhenAborted BUG=496986 Review URL: https://codereview.chromium.org/1315573003 Cr-Commit-Position: refs/heads/master@{#348734}
-
proberge authored
BUG=530675 Review URL: https://codereview.chromium.org/1342873002 Cr-Commit-Position: refs/heads/master@{#348733}
-
bcwhite authored
The MSI installer creates a DisplayVersion registry entry with an encoded version of Chrome's actual version. Since this is done _after_ the setup call completes, we can't simply set the value in the normal setup process. Instead, we launch a background process that waits a while (for msiexec to complete) and then writes the updated version. This is accomplished by having setup, upon successful completion, run itself in the background and then exit normally. --set-display-version-product="ABCD-EF-GH-IJKL" --set-display-version-value="A.B.C.D" --delay=30 BUG=67348 Committed: https://crrev.com/0d3e644a25802bdb3afa7fc09eff5aab456c5733 Cr-Commit-Position: refs/heads/master@{#348556} Review URL: https://codereview.chromium.org/1271893003 Cr-Commit-Position: refs/heads/master@{#348732}
-
kkimlabs authored
On phone, the close button on the top-right corner can be tapped while the bookmark UI is loading, which led to a crash. So make the exiting code doesn't depend on initialization. BUG=531337 Review URL: https://codereview.chromium.org/1339783004 Cr-Commit-Position: refs/heads/master@{#348731}
-
kalyan.kondapally authored
Even though type property is found, we dont break from the loop. This is unnecessary and patch fixes it. Review URL: https://codereview.chromium.org/1339993002 Cr-Commit-Position: refs/heads/master@{#348730}
-
joelo authored
0 configs already ran on Swarming 43 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.webkit.json: WebKit Linux - chromium.webkit.json: WebKit Linux (dbg) - chromium.webkit.json: WebKit Linux 32 - chromium.webkit.json: WebKit Linux Leak - chromium.webkit.json: WebKit Linux Oilpan - chromium.webkit.json: WebKit Linux Oilpan (dbg) - chromium.webkit.json: WebKit Linux Oilpan Leak - chromium.webkit.json: WebKit Linux Trusty - chromium.webkit.json: WebKit Mac Oilpan - chromium.webkit.json: WebKit Mac Oilpan (dbg) - chromium.webkit.json: WebKit Mac10.10 - chromium.webkit.json: WebKit Mac10.6 - chromium.webkit.json: WebKit Mac10.6 (dbg) - chromium.webkit.json: WebKit Mac10.7 - chromium.webkit.json: WebKit Mac10.7 (dbg) - chromium.webkit.json: WebKit Mac10.8 - chromium.webkit.json: WebKit Mac10.9 - chromium.webkit.json: WebKit Mac10.9 (retina) - chromium.webkit.json: WebKit Win Oilpan - chromium.webkit.json: WebKit Win Oilpan (dbg) - chromium.webkit.json: WebKit Win x64 Builder - chromium.webkit.json: WebKit Win x64 Builder (dbg) - chromium.webkit.json: WebKit Win10 - chromium.webkit.json: WebKit Win7 - chromium.webkit.json: WebKit Win7 (dbg) - chromium.webkit.json: WebKit XP Ran: ./manage.py --convert blink_heap_unittests R=maruel@chromium.org,dpranke@chromium.org BUG=98637,524758 Review URL: https://codereview.chromium.org/1313773003 Cr-Commit-Position: refs/heads/master@{#348729}
-
yusufo authored
In M, the key used for these fields inside the ActivityOptions have changed which makes the exit animation not work on M devices. This adds the new keys for M. BUG=530770 Review URL: https://codereview.chromium.org/1338903002 Cr-Commit-Position: refs/heads/master@{#348728}
-
brettw authored
TBR=mmoss@chromium.org (chrome/installer/linux) CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1324623005 Cr-Commit-Position: refs/heads/master@{#348727}
-
bnc authored
Patch Set 1 adds regression test, watch it specatularily fail in trybot logs. Patch Set 2 fixes the issue. BUG=531570 Review URL: https://codereview.chromium.org/1345453005 Cr-Commit-Position: refs/heads/master@{#348726}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/5f48d99..0657feb Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=hayato@chromium.org,dcheng@chromium.org Review URL: https://codereview.chromium.org/1341793005 Cr-Commit-Position: refs/heads/master@{#348725}
-
anthonyvd authored
Some consumers of the ProfileDownloader class dispose of it in the OnProfileDownloadSuccess callback. When the profile image is cached and the image fetch is synchronous, this caused a use-after-free in ProfileDownloader::OnAccountUpdated(). BUG=518866 Review URL: https://codereview.chromium.org/1341113002 Cr-Commit-Position: refs/heads/master@{#348724}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/fbb3af7..5f48d99 Sheriffs: In case of breakage, do NOT revert this roll, revert the offending commit in the blink repository instead. NOTRY=true TBR=hayato@chromium.org,dcheng@chromium.org Review URL: https://codereview.chromium.org/1336803003 Cr-Commit-Position: refs/heads/master@{#348723}
-
jbudorick authored
The initial caching getprop call fails without an exit code when its output gets truncated. It currently gets reran with large_output=True, but switching it to do so by default will reduce noise. see e.g. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/22248/steps/events_unittests/logs/stdio BUG= Review URL: https://codereview.chromium.org/1341103002 Cr-Commit-Position: refs/heads/master@{#348722}
-
dtapuska authored
Pass the evdev scancode down from java so that it can be properly presented to blink. The evdev code is necessary because the android keycode already has the keyboard mapping applied. If the scancode is 0 we fall back to mapping the DomCode based on the android keycode. BUG=227231 Review URL: https://codereview.chromium.org/1310513010 Cr-Commit-Position: refs/heads/master@{#348721}
-
