GitLab

This CL adds some new "TranslateCompactUI" experiments to the
fieldtrial for testing different values of auto-never theshold in the
compact UI on Android.

Bug: 720184
Change-Id: I3360d5724b212ca7aba62b484803e402d54da260
Reviewed-on: https://chromium-review.googlesource.com/623016
Commit-Queue: Marti Wong <martiw@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496539}

Reason for crash:
DesktopNativeWidgetAura::InitNativeWidget binds current widget with the
root window's kDesktopNativeWidgetAuraKey for desktop build. But the
DCHECK in DesktopScreenPositionClient::SetBounds() expects current
widget's root window's kDesktopNativeWidgetAuraKey is not set or is not
set to the current widget.

Changes:
Set bounds widget's native view in parent window's coordinates instead
of screen coordinates to avoid calling Window::SetBoundsInScreen()
which triggers DesktopScreenPositionClient::SetBounds().

BUG=757573

Change-Id: Id627572256fd315ae4609d347a7999cecb2ee0f1
Reviewed-on: https://chromium-review.googlesource.com/627385
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496538}

Now that the Win7 bug is fixed upstream, Chromium can link to the most
recent version of libaddressinput.

Bug: 752122
Change-Id: I58be37ba5b1aeb0fca6d9c9a7e0cfc622c37a7f8
Reviewed-on: https://chromium-review.googlesource.com/627102
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496537}

BUG=b/38124462
TEST=build and flash locally, see keyboard shortcut toggles

Change-Id: Iad6c244d38d9c8140a233d28bf20065bbdda36a1
Reviewed-on: https://chromium-review.googlesource.com/624901
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496536}

Adding several metrics to measure how useful flipping touch handles
would be in avoiding clipping. This will be especially useful in deciding
whether or not we can move WebView to use composited handles instead of
popup handles.

BUG: 757985
Change-Id: I4115b25de5320a2b1c4987fd7290b8390b3b0bef
Reviewed-on: https://chromium-review.googlesource.com/621872
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496535}

Bug: 514674
Change-Id: If1d1cb8bcbf4fa1048a1a9a5d24eafee405d92ef
Reviewed-on: https://chromium-review.googlesource.com/622112Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496534}

Implementing this also obsoleted the updated time mechanism
for tracking whether or not our configuration is up-to-date
in CUPS.  This involved a lot of fixups to remove the last_updated
field from the Printer object.

Bug: 757595,
Change-Id: I7c75f9ce6a3d16e8bba2a9e6cf0c2e7cf7a09358
Reviewed-on: https://chromium-review.googlesource.com/627342Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Justin Carlson <justincarlson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496533}

Enables the use of 'url:foo.js' style queries in the console filter bar,
once exclusive to Network panel's filter. Also brings over the ability
to make negative queries:
-foo
foo -/bar*/

Screenshot: http://imgur.com/a/RAPUP

Bug: 685283
Change-Id: Ib79f68649df92714740aea1f1c36eeb1331f19cc
Reviewed-on: https://chromium-review.googlesource.com/625236Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496532}

BUG=729848
TBR=yzshen@chromium.org

Change-Id: I23d6f6313309668abe5ea510a1b4055dabf519c4
Reviewed-on: https://chromium-review.googlesource.com/627383
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496531}

This large comment is from 2014 and is a bit confusing, as it goes to
great length to justify behaviour that is mandated by the spec. The new
version references the spec, makes the examples clearer, and links to a
bug for ongoing work.

Bug: 351639
Change-Id: Idc726476470c730fbccf983b78be15932f7dcd27
Reviewed-on: https://chromium-review.googlesource.com/625555Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496530}

This change adds a connection error handler to the URLLoaderClient pipe
bound to the ThrottlingURLLoader. If this pipe unexpectedly closes
before the OnComplete message is received then the request is cancelled
with net::ERR_FAILED. This mirrors the behavior of ResourceDispatcher
when the ResourceHostMsg_SyncLoad IPC fails without returning an error
code.

This condition happens when a request is cancelled by the browser
process and the SyncResourceHandler or MojoAsyncResourceHandler is
unexpectedly destroyed.

Until PlzNavigate ships this failure can only be signaled for sync
requests as navigation loads expect to be able to be cancelled without
signaling any failure.

Bug: 756751
Change-Id: I0ac8498ad38f27b50b64e1a13e6af2c6883b2f35
Reviewed-on: https://chromium-review.googlesource.com/621949Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuzhu Shen <yzshen@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496529}

There is little advantage from this extra layer of indirection. Just
remove it to make GraphicsLayer implements WebContentLayerClient
directly.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I36e33a475942f6902b77dd4a92bf31579f227879
Reviewed-on: https://chromium-review.googlesource.com/616204
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496528}

On close the launcher should animate to the shelf height and the
contents of the launcher should shift their opacity to 0.

In side shelf mode the launcher has a different animation, the whole app
list shifts in opacity to 0 with no movement.

Bug: 754072
Change-Id: I245b4fa8b5dd26644d87b5f5717df73fc7dc3742
Reviewed-on: https://chromium-review.googlesource.com/619596Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496527}

This CL changes device::SerialConnection to hold a base::WeakPtrFactory
member rather than inherit base::SupportsWeakPtr<> to avoid the subtle
use-after-destroy issue:
1.
SerialConnection dtor starts, destroyes its'
device::mojom::SerialIoHandlerPtr |io_handler_| member.
2.
The SerialIoHandlerPtr dtor triggers some one callback XXX wrapped by
ScopedCallbackRunner to run.
3.
The callback XXX was actually bound with a weak ptr of SerialConnection,
at this time point the parent class SupportsWeakPtr's dtor has not been
triggered yet so that the weak ptr is still in a valid state, although
we are already inside the execution context of SerialConnection dtor.

A base::WeakPtrFactory member at the end of member list will be
destroyed immediatelly once entering SerialConnection dtor, thus in the
above step 3 the bound weak ptr should be identified as invalid so that
callback XXX won't be called at all. This is the expected behavior.

BUG=757756

Change-Id: Ib73ac55dcfba250c4f8b96fb9e3d3e85490ea9a0
Reviewed-on: https://chromium-review.googlesource.com/626197Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#496526}

Because it's less LOC and now with JUnit4 we can.

Change-Id: Ia7408e85ee8dc73e1f24cea65690103bf015fb7a
Reviewed-on: https://chromium-review.googlesource.com/624830Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Piotr Swigon <piotrs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496525}

. the cursor position needs to take into account the
  ui_scale. Aura expects this behavior, so that without it we end up
  with a mismatch in Env::last_mouse_location() where it can jump
  around.
. WindowEventDispatcher may end up converting the coordinates of
  LocatedEvents. This is only applicable to local coordinates, not the
  root coordinates.

BUG=726865
TEST=covered by tests

Change-Id: I4750b974508b16a04c528ff02ac96d348ec0929a
Reviewed-on: https://chromium-review.googlesource.com/627656Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496524}

https://skia.googlesource.com/skia.git/+log/267641a90cb1..a184ac7e0cdb

$ git log 267641a90..a184ac7e0 --date=short --no-merges --format='%ad %ae %s'
2017-08-22 bsalomon Revert "Revert "Revert "Add GrTextureOp and use to implement SkGpuDevice::drawImage[Rect]() when possible"""
2017-08-22 herb Fix poor handling of nullptr for new blur code
2017-08-22 enne Don't validate() in ~SkPathRef
2017-08-22 brianosman Add GrPrepareCallback, always run at the start of flush
2017-08-22 scroggo Make haveDecodedRow return void

Created with:
  roll-dep src/third_party/skia
BUG=749147


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=jcgregorio@chromium.org

Change-Id: I3c535e2c947d75d30affe0569f30097dfdb9f035
Reviewed-on: https://chromium-review.googlesource.com/627634Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496523}

https://pdfium.googlesource.com/pdfium.git/+log/ed2f2769bf11..32489a0eb4b5

$ git log ed2f2769b..32489a0eb --date=short --no-merges --format='%ad %ae %s'
2017-08-22 rharrison Bypass asserts in string [] operator for empty strings
2017-08-22 janeliulwq Corrected the error setting after calling FPDF_LoadDocument()

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I1dd44e605cf060ac80ae82beb6b5819971583ff0
Reviewed-on: https://chromium-review.googlesource.com/627620
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496522}

Currently when an enabled extension is blocked by ManagementPolicy::UserMayLoad,
it is unloaded without its preferences being removed. Also, ExtensionPrefs shows
the state of such extensions as enabled. This can lead to bugs where unloaded
policy blacklisted extensions can have side-effects. Also,
ManagementPolicy::UserMayLoad is not checked while enabling a disabled
extension. This can cause blacklisted extensions to become enabled.

This CL brings the following changes:
  - A new disabled reason DISABLE_BLOCKED_BY_POLICY is introduced.
  - When an enabled extension fails ManagementPolicy::UserMayLoad, it is
    disabled with DISABLE_BLOCKED_BY_POLICY.
  - Hence extensions which fail UserMayLoad checks are now visible to the user 
    on chrome://extensions page, instead of silently remaining installed.
  - They are re-enabled automatically when they satisfy the policy. 
  - ManagementPolicy::MustRemainDisabled also checks
    ManagementPolicy::UserMayLoad now. This leads to cleaner code at call sites
    and helps avoid inconsistent checking of the management policy.
  - Some cases in which disabled policy blacklisted extensions could be 
    re-enabled are fixed.

BUG=709264, 754448, 461747
TEST=Install EvilProxy (https://chrome.google.com/webstore/detail/evilproxy/jndopnbadbiahpmbnfadmmadjhpjbmon). 
Ensure navigating to tools.google.com causes a 404. Add the extension to policy
blacklist. Ensure navigating to tools.google.com works fine. Restart browser. 
Ensure navigating to tools.google.com works fine.
TEST=Install EvilProxy. Ensure navigating to tools.google.com causes a 404. 
Close browser. Add the extension to policy blacklist. Start browser. Ensure 
navigating to tools.google.com works fine. 
TEST=Install EvilProxy. Add the extension to policy blacklist. Close browser.
Remove extension from policy blacklist. Start browser. Ensure navigating to 
tools.google.com causes a 404.
TEST=Install EvilProxy. Add the extension to policy blacklist. Ensure navigating
to tools.google.com works fine. Remove extension from policy blacklist. Ensure
navigating to tools.google.com causes a 404.
TEST=Install EvilProxy. Disable the extension from chrome://extensions page. Add
it to policy blacklist. Ensure it can't be enabled from chrome://extensions.

Change-Id: Ia25d7a2a49bd1c006a435c26397c834ffa5ae632
Reviewed-on: https://chromium-review.googlesource.com/611662
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496521}

Make AppCacheStorageImpl::ScheduleSimpleTask take a OnceClosure

Bug: 714018
Change-Id: I919bde1c5cc4117f4978aec9ed22f8a07d137218
Reviewed-on: https://chromium-review.googlesource.com/627198
Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496520}

The testcase no longer fails due to unrelated changes, so this is a
preventive measure - it was an oversight not to add it when landing the
original CL.

Bug: 756410
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3f653b17bc3e02b382171f4e2f20701cff30e6e4
Reviewed-on: https://chromium-review.googlesource.com/624165
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#496519}

No changes to strings that may be used as flag values, metrics, as
they're already used.

BUG: 726476

Change-Id: I91588f2bca5ceb100abdf10b5c2be2f2b2b0c979
Reviewed-on: https://chromium-review.googlesource.com/577380
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496518}

This reverts commit b7e830dd.

Reason for revert: <INSERT REASONING HERE>

Based on this comment in the CL summary, "Some layout tests now fail, since we're not using the legacy engine to lay out
multicol. Quite a few crash or freeze, too."

And that layout tests are failing.

Original change's description:
> [LayoutNG] Bring back native support for multicol.
> 
> Still missing: Copy data back into the LayoutObject tree.
> 
> Some layout tests now fail, since we're not using the legacy engine to lay out
> multicol. Quite a few crash or freeze, too.
> 
> Also brought back some of the unit tests. They needed some changes, because of
> the following:
> 
> 1. We now create a fragment for each column, from an anonymous constraint
> space. I.e. we have one more level of fragments, and it's the column fragments
> that have their inline offset shifted to the correct column, rather than
> setting it on the first child block, which is what we did last time these tests
> worked.
> 
> 2. Mistakes introduced when converting test to using setBodyInnerHTML() rather
> than building the layout trees programmatically:
> https://codereview.chromium.org/2725773002
> 
> 3. New bugs. :)
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
> Change-Id: I4df85d684f0ddb8f7f0f75d15230a1ab61e9f9a0
> Reviewed-on: https://chromium-review.googlesource.com/591429
> Commit-Queue: Morten Stenshorne <mstensho@opera.com>
> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496446}

TBR=mstensho@opera.com,eae@chromium.org,kojii@chromium.org,ikilpatrick@chromium.org

Change-Id: I63a5c16af3d9c45ec3edb8d923e03449c975273d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/627041Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496517}

Bug: 757967
Change-Id: I863cb3dc5cc9d3e08dadaeef6ec064c16085b8b8
Reviewed-on: https://chromium-review.googlesource.com/627061Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496516}

This reverts commit ab6ca8e1.

Reason for revert:
NOTIMPLEMENTED() that caused the error has been removed from the path with the CL below. I will re-enable the test. 
https://chromium-review.googlesource.com/c/chromium/src/+/570740

Original change's description:
> Disable WebRTC VerifyCanvasCaptureWebGLFrames (timeout-flaky).
> 
> TBR=emircan@chromium.org
> 
> Bug: 740762
> Change-Id: Ib1714450f52d2fb9634c68c9bc455f09484cca39
> Reviewed-on: https://chromium-review.googlesource.com/566081
> Reviewed-by: Bret Sepulveda <bsep@chromium.org>
> Commit-Queue: Bret Sepulveda <bsep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485467}

TBR=emircan@chromium.org,bsep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 740762
Change-Id: I5d312ffc8e024d303ea175809457bd3de8807cbb
Reviewed-on: https://chromium-review.googlesource.com/627038Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496515}

Ensure that long press allows text selection with the stylus on
Windows.

Rename the supression setting for touch and reuse it for pen as well.

BUG=756951

Change-Id: Ie5c0e75c5ac1d67409c8b4e915db44084fe8348d
Reviewed-on: https://chromium-review.googlesource.com/627136
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496514}

This is a reland of d2506f13
Original change's description:
> Improve suspending logic.
> 
> When loading takes too long, we can suspend the codec before
> we have a chance to load the first frame. This is all normal,
> but should only happen when we are waiting on the network.
> This CL makes sure that we have additional progress callbacks
> expected before suspending.
> 
> Bug: 728468
> Change-Id: I815520e0ba832617b04948f7fbefb88498cf79b7
> Reviewed-on: https://chromium-review.googlesource.com/614360
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494212}

Bug: 728468
Change-Id: Ide175e6e5c8d2ecaeeb81b0055352f66c917d099
Reviewed-on: https://chromium-review.googlesource.com/627616Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496513}

Currently rating and price labels seem to belong to neighbor items.
This commit changes the alignment as the new spec shows to fix this issue.

Bug: 757603
Change-Id: Id05320ee6bf6a9856c9540b0b9e39915cfc0b790
Reviewed-on: https://chromium-review.googlesource.com/627122Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#496512}

Previously it was not invoking EventTargetWithInlineData's wrapper-tracing
method, so this was getting lost in the override. This bug was previously
hidden by the redundant tracing of event listeners which was removed in
r491479: https://chromium.googlesource.com/chromium/src/+/d68025ec

A layout test for this case has been added.

Bug: 756611
Change-Id: I98c8dc49eef3b49c20788a55ca2843521051cd5e
Reviewed-on: https://chromium-review.googlesource.com/627421
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496511}

Otherwise, compositor scrolls might result in the callback being called
on the cc::Layer, which then dereferences the disposed PaintLayerScrollableArea,
before the Blink lifecycle has a chance to update and delete the cc::Layer.

Bug: 747719
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I72656d6ed49e1707d9e9554a72f39b61ed7ecec9
Reviewed-on: https://chromium-review.googlesource.com/627022
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496510}

TBR=mmoss@chromium.org

Change-Id: I226869f66f1b4bc45dea6a6f0bcabd4dd04f5f6b
Reviewed-on: https://chromium-review.googlesource.com/627393Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496509}

The conversion from an uninitialized void* to a T* triggers CFI, but this
is as-designed (the caller of VectorBuffer, in this case circular_deque,
is responsible for calling placement new and delete on this buffer).

Change-Id: I375800df238f2a077720e7d73c35a2e9140f91de
Reviewed-on: https://chromium-review.googlesource.com/627017Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Brett Wilson <brettw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496508}

This is temporary instrumentation to track down root cause of issue
756790.  It will be removed after collecting a few crash dumps with
this data.

Bug: 756790
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ifed68777902ec71ab5366f692337f2148949d677
Reviewed-on: https://chromium-review.googlesource.com/624634Reviewed-by: Charlie Reis (OOO Aug 17-24) <creis@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496507}

Was using == instead of String equals to compare app ID with the
holdback string.

Bug: 758017
Change-Id: I42531ea7bd3895d012f326805f3ca77b182dd1c6
Reviewed-on: https://chromium-review.googlesource.com/627641
Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496506}

Currently cc::ResourceProvider includes output_surface.h but it doesn't
use cc::OutputSurface. This CL removes that include and adds additional
includes directly that were included implicitly by output_surface.h.

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I11da4873ecb5fbee20f52191aaa9064601aff02d
Reviewed-on: https://chromium-review.googlesource.com/627416
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496505}

- allow nodes to be clicked one beyond their text content regardless of where the node falls in the overall line
- the action node should always be the one that best fits the position as we pick the last actionable node span
- selection uses this node so selections can be made at the end of a node's text content as well

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9062ec48dddeda5f85165bac4971bf858cb1ded5
Reviewed-on: https://chromium-review.googlesource.com/618291Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496504}

Skip nans because they cause Skia asserts.

Bug: 752757
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I8ac1ac10c785dad5eb74dd33107f1febb7e361c4
Reviewed-on: https://chromium-review.googlesource.com/627394
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496503}

Always use AppListDelegateImpl for Shell AppList notifications.
(avoid AppListPresenterDelegate[Mus] duplication/disparity)

Remove the delegate removal TODO, may relate to crbug.com/733662
(the delegate may be necessary until ui/app_list moves into ash)

Fix root window checks (they're null for invalid/old display ids).

Rename TestAppListPresenterImpl, connect with the ash app list.
Add helpers to spin a run loop on app list show/dismiss (via mojo).

Enable numerous tests on Mash that rely on the presenter, etc.
Avoid mock app list notifications when possible in tests.

Bug: 730887, 696028, 695751
Change-Id: I19a3f8adc7ca66a7ad81fb254198c96fb4428ae3
Reviewed-on: https://chromium-review.googlesource.com/624515Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496502}

Bug: 
Change-Id: I4b7ffbe40e81c2e2f13feda4dae3437dbf07977b
Reviewed-on: https://chromium-review.googlesource.com/627390Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496501}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0fab1ee4..20961d26

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: I36fecd9b64be80274577865e72dcf09497c031f7
Reviewed-on: https://chromium-review.googlesource.com/627301Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496500}