- 24 May, 2018 40 commits
-
-
glevin authored
As per crbug.com/788025 and various other discussions: - Replace "Learn more" link with (?) button - Button has a11y text and is Tab stop - Update text to match crbug.com/721969 - Width = 448px - At present, NOT removing X (Close) button - Clean up code Bug: 788025 Test: Try to play HD content that requires device id / verification. Verify Harmoniousness of resultant dialog. Change-Id: Ibcc300a97b6f2edd49d822171467162500d9e859 Reviewed-on: https://chromium-review.googlesource.com/946907Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561560}
-
Sahel Sharifymoghaddam authored
This reverts commit 63049f46. Reason for revert: I missed the nit comments on the test, I will reland the issue after addressing them. Original change's description: > Touchpad fling bubbling doesn't generate extra GSB. > > With browser side touchpad fling, the fling controller processes a GFS > and schedules fling progress. On flingProgress the controller generates > wheel events which get queued in the mouse wheel event queue(MWEQ). > > When we start wheel scrolling on an out of process iframe while it is > already at its extent the wheel events get processed in the MWEQ of the > child view but the generated gesture scroll events including the GFS get > bubbled to the parent view. When the GFS gets processed by the parent > view, the generated wheel events get queued in the MWEQ of the parent. > The MWEQ will generate a GSB for the first wheel event generated from > processing the fling since it is not aware of the GSB that is bubbled to > this view and it causes hitting this DCHECK: > https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=render_widget_host_impl&dr=C&l=1256 > > This cl changes the MWEQ to ask for the state of wheel scrolling from > RWHI rather than keeping its own state, this change will be also useful > for enabling touchpad fling boosting. > > Bug: 249063 > Test: SitePerProcessBrowserTest.TouchpadGestureFlingStart > Change-Id: I0c6faa81faa7f009517393440d6e37c7e7e6a053 > Reviewed-on: https://chromium-review.googlesource.com/1064792 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561550} TBR=kenrb@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I485b5a1dee759ba0760acc4a5210fedd34346f10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 249063 Reviewed-on: https://chromium-review.googlesource.com/1072108Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561559}
-
John Chen authored
Fixes two race conditions in ChromeDriver's websocket code (for connecting to DevTools): * If a connection is made after SyncWebSocketImpl::Core::Connect has timedout and returned, lower level code can access stack variables that have already gone out of scope. * If a connection is closed right after it was opened, ChromeDriver might try to read from a closed socket. Bug: chromedriver:2431 Change-Id: I6895856256f610615f63220bc33c34bacab2eeda Reviewed-on: https://chromium-review.googlesource.com/1070571 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#561558}
-
Pavel Feldman authored
Change-Id: I1411429de9f3bb92eae22c6911a4caeb4a2932f7 TBR: eseckler Reviewed-on: https://chromium-review.googlesource.com/1071874 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561557}
-
Oystein Eftevaag authored
Chrome has seven #ifdefs that decide whether Perfetto tracing is available or not. This change consolidates those into two and then enables Perfetto on Windows. This change also updates two .gn files to enable Perfetto. This change makes no difference unless the command-line option --enable-features=TracingPerfettoBackend is specified. Note that this change will fail to run unless the Assert in Angle's AddTraceEvent function in event_tracer.cpp is removed. This is being investigated. Bug: 844421 Change-Id: Ia978eb69bed77bda68202fdbec7a306fdb9886bc Reviewed-on: https://chromium-review.googlesource.com/1064371 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#561556}
-
Hiroshige Hayashizaki authored
No behavior changes. Bug: 842349 Change-Id: Iebd91d4d0f98441fd613d7bc98e26e06767915cf Reviewed-on: https://chromium-review.googlesource.com/1056415 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561555}
-
John Chen authored
Cleaning up navigation tracker code intended to support old browsers. Change-Id: Ifd1f317574866c9c1a37b7be199e77fad7a06627 Reviewed-on: https://chromium-review.googlesource.com/1066785Reviewed-by:
-
Greg Thompson authored
Instrumentation added in r556859 revealed that some deletes are failing because the thing-to-be-deleted isn't there. This here CL attempts to plug all holes in the delete logic so that this is treated as a condition for success. BUG=599084 R=gab@chromium.org Change-Id: I04e2c22ac49bc0bd7b7850b2d17abc72f3e05e7b Reviewed-on: https://chromium-review.googlesource.com/1071656 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561553}
-
David Trainor authored
Add support for a BatchedListObservable. This is an implementation of ListObservable that incorporates the Android support library's BatchListUpdateCallback. This class has the following behavior: - It batches up all calls to insert, remove, or change based on whether or not the changes occur to adjacent elements. - It automatically flushes the updates when a non-adjacent or different type of operation occurs. - It supports manual flushing for when the batch operation is done by the caller. BUG=842345 Change-Id: I87dcd03ad31952582308a690fb3a3dab3a4fc26b Reviewed-on: https://chromium-review.googlesource.com/1070885 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561552}
-
Raymond Toy authored
The trybots can now run AudioContext with a fake audio device if no audio HW is available. Change the MediaElementAudioSource tests to use an AudioContext instead of an OfflineAudioContext. This is the first step in moving the factory methods from BaseAudioContext to AudioContext. Bug: 845913 Change-Id: Id4fe3d7d1b943db25cf023940c541dfab2a01aed Reviewed-on: https://chromium-review.googlesource.com/1070217Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561551}
-
Sahel Sharify authored
With browser side touchpad fling, the fling controller processes a GFS and schedules fling progress. On flingProgress the controller generates wheel events which get queued in the mouse wheel event queue(MWEQ). When we start wheel scrolling on an out of process iframe while it is already at its extent the wheel events get processed in the MWEQ of the child view but the generated gesture scroll events including the GFS get bubbled to the parent view. When the GFS gets processed by the parent view, the generated wheel events get queued in the MWEQ of the parent. The MWEQ will generate a GSB for the first wheel event generated from processing the fling since it is not aware of the GSB that is bubbled to this view and it causes hitting this DCHECK: https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=render_widget_host_impl&dr=C&l=1256 This cl changes the MWEQ to ask for the state of wheel scrolling from RWHI rather than keeping its own state, this change will be also useful for enabling touchpad fling boosting. Bug: 249063 Test: SitePerProcessBrowserTest.TouchpadGestureFlingStart Change-Id: I0c6faa81faa7f009517393440d6e37c7e7e6a053 Reviewed-on: https://chromium-review.googlesource.com/1064792Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561550}
-
rbpotter authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9b12f216b10de1c4479fb44f25d3e3450b903169 Reviewed-on: https://chromium-review.googlesource.com/1071767Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#561549}
-
Kyle Horimoto authored
This class encapsulates the parameters passed by clients of SecureChannel which are meant to be tightly coupled to an individual connection request. Encapulsulating these within a class makes clients of the relevant classes much less complex and allows PendingConnectionRequest and SingleClientMessageProxy to use the ID associated with the parameters. Bug: 824568, 752273 Change-Id: I9da3824fef3ede7727b5cdccb879ee2b49140807 Reviewed-on: https://chromium-review.googlesource.com/1070990 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#561548}
-
jonross authored
RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface is obsolete once Viz has been enabled by default. This disables it in that state, with a note for me to delete it later. TEST=RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface Bug: 762521 Change-Id: I647b1abe0d88d3b65aef5965dddada1d95b5de42 Reviewed-on: https://chromium-review.googlesource.com/1070215 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561547}
-
John Abd-El-Malek authored
This reverts commit 9fedcd68. Reason for revert: fixed after r560938 Original change's description: > Disabling flaky test TestSBUpdateCookies > > Full test name: > SafeBrowsingDatabaseManagerCookieTest.TestSBUpdateCookies > > Link to failure: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/54 > > Bug: 842195 > Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14 > > TBR=jialiul@chromium.org > > Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14 > Reviewed-on: https://chromium-review.googlesource.com/1055618 > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557905} TBR=tmartino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842195 Change-Id: I1dfc6104223cc0ae27fb912d20befb98d77aa616 Reviewed-on: https://chromium-review.googlesource.com/1071848Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#561546}
-
Fernando Serboncini authored
Implemented with a Mojo sync API. Note that an alternate approach with WaitableEvent was attemped for this, but the fact that we need to wait on two IPCs, added a lot of complexity for thread hops for Mojo, and ends up being much more complicated. Bug: 838133 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id512c86b0df0ecba3ee9965801be916165d4c0cf Reviewed-on: https://chromium-review.googlesource.com/1043008 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561545}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I535a12727501c4a723ef1c0f2754bfcee64b6348 Reviewed-on: https://chromium-review.googlesource.com/1072043Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#561544}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2a12b3d585a8..22a5f5f01f70 $ git log 2a12b3d58..22a5f5f01 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 geofflang Make sure to destroy all resources in DisplayWGL if initialization fails. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I2b4def80be7a23e4163a8806c118dab9c88c6634 Reviewed-on: https://chromium-review.googlesource.com/1071717 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561543}
-
Minh X. Nguyen authored
This would allow the template function to be used in other modules without depending on chrome\browser\. This is a reupload of reverted cl 1070669, which had a compiler error in Linux. Change-Id: I0904635d9ec71e91053962d1bfcc16489a68be43 Reviewed-on: https://chromium-review.googlesource.com/1071007Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561542}
-
Edward Jung authored
Change-Id: I3f76e2ec46f199c1ce905f5a52de66ea67a23459 Reviewed-on: https://chromium-review.googlesource.com/1071516Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#561541}
-
Dmitry Gozman authored
- Provide WebMenuItemInfo directly from ContextMenuProvider. - Combine most methods in ContextMenuController to a single ShowContextMenu. - Do not store ContextMenu instance in ContextMenuController. - Remove ContextMenu and ContextMenuItem classes. Change-Id: Ibb395d304a0a4dfa86087b1d062141f788a00091 Reviewed-on: https://chromium-review.googlesource.com/1068246 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561540}
-
Elly Fong-Jones authored
This test is broken because of the issues with MacViews keyboard event dispatch, as tracked in the linked bug. TBR=rockot@chromium.org Bug: 845503 Change-Id: Ia5aba0918fb16cb5d2271bcbbd7bcc8bab1b015b Reviewed-on: https://chromium-review.googlesource.com/1071693 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Trainor authored
Add an OfflineItemList to wrap an OfflineItemFilterSource. This list will (1) sort the items and (2) add date headers for each day items are seen. BUG=842345 Change-Id: Ib1b0ee15b7431416934ee8e037f58ed055d090b5 Reviewed-on: https://chromium-review.googlesource.com/1069677Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/18f7fbca4612..5bf772bade61 $ git log 18f7fbca4..5bf772bad --date=short --no-merges --format='%ad %ae %s' 2018-05-24 npm Do some variable cleanup in CJBig2_Context Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1bd7fa9ad94994c7ec36c68700382144163deb9d Reviewed-on: https://chromium-review.googlesource.com/1071715Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561537}
-
Ella Ge authored
This is a reland of ec54e1ca Original change's description: > Adapt scroll-visual-viewport-send-boundary-events.html to run with a compositor > > Since this test uses chrome.gpuBenchmarking.pinchBy, we need to have > it run with a compositor. As part of issue 787924, we will no longer > handle gesture pinch events on the main thread. > > Bug: 787924 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I0127028f246ae72a772ef8c9f163b4403b6c3036 > Reviewed-on: https://chromium-review.googlesource.com/1068625 > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560831} Bug: 787924 Change-Id: I1d662bb8855ac32226cfd149c58b80d318e9adb7 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1071807Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#561536}
-
Alexander Timin authored
Enable wake-up based throttling by default with 3ms wake-up window. R=alexclarke@chromium.org BUG=699541 Change-Id: I9c8c273e43f812e1b296368cd227813c795d4d8d Reviewed-on: https://chromium-review.googlesource.com/1070142 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#561535}
-
Moe Ahmadi authored
Bug: 841758 Change-Id: Ice6932221f401e20251926fe2cb41ba6f9061f52 Reviewed-on: https://chromium-review.googlesource.com/1070622Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561534}
-
Dominic Mazzoni authored
Bug: 845143, 843511 Change-Id: I87afc7235692c52502048dcf7ae6036ae8551e51 Reviewed-on: https://chromium-review.googlesource.com/1067491Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#561533}
-
Moe Ahmadi authored
Bug: 844472 Change-Id: I3a90de7feef9f7f0829e17110f51c5376bc4df1b Reviewed-on: https://chromium-review.googlesource.com/1070514Reviewed-by:
-
v.paturi authored
The change to AttributeModificationParams (http://crrev.com/2623513005) has changed the use of the local variable |value| to params.new_value without noticing that the local variable was shadowing the function parameter. Since AltText() looks at both alt and text attributes, and we don't know which of the two is being parsed in this block, we should compare text->textContent to AltText(), and not params.new_value. The local variable |value| is being renamed to a more appropriate |alt_text_content|.This variable containing AltText() can be used for both comparison and setting which will save one extra function call. Bug: None Change-Id: I7f27ab77f1877c6e405aa41b4e912d826ace0fbf Reviewed-on: https://chromium-review.googlesource.com/1049425 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#561531}
-
Jérôme Lebel authored
In the unified user consent dialog, if there is no Google account on the device, then the Settings should not be shown since the user cannot sign-in yet. Once an account is added the Settings link should visible and usable. A DCHECK and a comment has been added for -[UnifiedConsentViewController updateIdentityPickerViewWithAvatar:] to make sure -[UnifiedConsentViewController updateIdentityPickerViewWithUserFullName: email:] is always called before to set an avatar to the identity view. With the Settings link: https://drive.google.com/open?id=1NjIsfv47GP_y2yMtxAvQcqVqGF-20USb Without the Settings link: https://drive.google.com/open?id=1pD0QFHNjki1OoC1ztW6CgPfW6iLWOdZf Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4c90c5e85790f0b0b3baa8974a7abc87c1dbf26 Reviewed-on: https://chromium-review.googlesource.com/1070663 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#561530}
-
Sigurdur Asgeirsson authored
This allows mocking it for testing the upcoming PerformanceMeasurementManager, which will be a RenderProcessProbe user. Bug: 755840 Change-Id: I7188529a106eb66044d71a514e26a6d6bd0b65ae Reviewed-on: https://chromium-review.googlesource.com/1071725Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561529}
-
Bence Béky authored
Do not check if callback is null in test-only AsyncSocket subclasses in RunCallback(). If the method was supposed to handle the case of null callback, it should be called MaybeRunCallback() instead. Add DCHECKs on callback at call sites to document expectations. Also, avoid double move when unnecessary. Also, fix GCMConnectionHandlerImplTests. Calling MockTCPClientSocket::Connect() with null callback on ASYNC mock data is not consistent with the async idiom used in //net. Sure it didn't use to blow up, because MockClientSocket::RunCallback() special-cased null callbacks. :( Also, use make_unique instead of new throughout google_apis/gcm/engine/connection_handler_impl_unittest.cc. Bug: 807724 Change-Id: I3adb8d2a09c87fa004b1b4e7a8cf6f0edff064a6 Reviewed-on: https://chromium-review.googlesource.com/1064193 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#561528}
-
Guido Urdaneta authored
std::function is banned by the style guide. No behavior change intended. Bug: 846327 Change-Id: I7bd3c0bf082147491e5784626a8f74beb1c06719 Reviewed-on: https://chromium-review.googlesource.com/1071517Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#561527}
-
Chris Nardi authored
A bug was reported where ::first-line broke ::placeholder styling, which seems to have been fixed in https://crrev.com/550589. However, we don't currently have a test for this bug. Add in a test to make sure we don't regress with this bug. Bug: 806247 Change-Id: I5bbcda1ccf5b3ea08a7b66a68071a802f42e9228 Reviewed-on: https://chromium-review.googlesource.com/1071126 Commit-Queue: Chris Nardi <cnardi@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#561526}
-
Sahel Sharify authored
This cl adds new metrics for GSU events that are generated from a touchscreen fling progress. We want to keep the latency of these GSUs separate from GSU events generated from touch move events since the latency for handling the GSU events from fling doesn't include the time needed for handling a touch event. Bug: 249063 Test: RenderWidgetHostLatencyTrackerTest.TestInertialToScrollHistograms Change-Id: Iba4664d19e5218cae4886ee543b709d4c2152fa4 Reviewed-on: https://chromium-review.googlesource.com/1062806Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
-
Ethan Kuefner authored
This CL switches the v8.browsing_* benchmarks to the histogram pipeline. NOTRY=true Bug: 744736 Change-Id: Ied3d2bc472251e875e45b2d932d2951ff1cba06b Reviewed-on: https://chromium-review.googlesource.com/1048849 Commit-Queue: Ethan Kuefner <eakuefner@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#561524}
-
Elly Fong-Jones authored
This is a new name that seems to alias the existing Turkish layout. Bug: 845389 Change-Id: Ie7cfb42589644ff410f044d1420fbeb196de2289 Reviewed-on: https://chromium-review.googlesource.com/1071727Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#561523}
-
Aaron Leventhal authored
This code does not have tests and is likely unnecessary. HandleActiveDecendant is called on the item with @aria-activedescendant, therefore to invalidate something, followingthe forward relation is correct. Using the reverse relation would make sense if something was pointing at the element with @aria-activedescendant that needed updating. TBR=nektar@chromium.org NOTRY=true Bug: None Change-Id: Ifc2e3d71a2089e5fbeb58c1bc6e020811ad9b1d6 Reviewed-on: https://chromium-review.googlesource.com/1070806 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#561522}
-
Scott Violet authored
This is needed as KeyEvents are sent directly to the focused window, where as LocatedEvents consider the WindowTargeter of each window. BUG=837692 TEST=covered by tests Change-Id: I935aaa1aaea6a8ea0339e99cc076ee7d459d9034 Reviewed-on: https://chromium-review.googlesource.com/1070857 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#561521}
-
