GitLab

BUG=none
TEST=Chrome builds and runs on ChromeOS

Review URL: http://codereview.chromium.org/7779004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98705 0039d316-1c4b-4281-b951-d872f2087c98

temporary file so that the subsequent rename always operates
with data in disk.

BUG=89356
TEST=none
Review URL: http://codereview.chromium.org/7695014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94642
TEST=BUILD

Review URL: http://codereview.chromium.org/7790012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98703 0039d316-1c4b-4281-b951-d872f2087c98

Add chromeish button style
Fix dialog gradient and transitions
Fix harness file creation
Fix task button rendering
Make list header gradient not leak outside of list
Show checkmark even when only a single item is selected (multi-select mode only).
Add a delay to the mock tasks callback to better simulate the real world.

BUG=chromium-os:17028, chromium-os:19373, chromium-os:19693
TEST=manual testing

Review URL: http://codereview.chromium.org/7764011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98701 0039d316-1c4b-4281-b951-d872f2087c98

of BookmarkBarView changes. My last patch added the plumbing, this
wires it up.

BUG=92994
TEST=make sure bookmark menus still work; covered by tests too.
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7787001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98700 0039d316-1c4b-4281-b951-d872f2087c98

These changes enable save and restore of minimized window state on Windows.  (Mac and Linux came prior).  The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).

BUG=43274
TEST=Manual.  Launch Chrome on Windows, create two browser windows, minimize "a" window, quit.  Relaunch, expect "a" to be minimized.


Review URL: http://codereview.chromium.org/7748036

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/7790010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98699 0039d316-1c4b-4281-b951-d872f2087c98

as though a TabSTripModel is getting notified that has a NULL in
contents_data_. That doesn't seem possible though, so something weird
must be happening.

BUG=93747
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/7767010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98698 0039d316-1c4b-4281-b951-d872f2087c98

in Beta channel and XP. We will crash the browser
if UI/IO threads don't respond within 24 secs
(instead of 12 secs) in Beta channel and Windows XP.

BUG=90095
R=jar
TEST=thread_watcher unit tests

Review URL: http://codereview.chromium.org/7744015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98697 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98355 (was semantically incorrect, caused assertion failures in Debug builds with some apps) - Further attempted workarounds for Mac- and NVIDIA-specific crash. Can
not reproduce this crash in house any more, so adding more code along
the lines of the earlier fix which was known to work on some hardware.

BUG=94103
TEST=none (tested manually to verify no regression)
Review URL: http://codereview.chromium.org/7756001

TBR=kbr@google.com
Review URL: http://codereview.chromium.org/7795006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98694 0039d316-1c4b-4281-b951-d872f2087c98

OptionMenuModel::translate_infobar_delegate_ has been deleted. This
may be possible if BeforeTranslateInfoBar is deleted while the menu is
showing. Changing the code like I'm doing makes sure the menu is
deleted if BeforeTranslateInfoBar is deleted too.

BUG=93314
TEST=none
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/7745057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98693 0039d316-1c4b-4281-b951-d872f2087c98

Also increase the time the test is allowed to wait for a video frame. 

TEST= 
BUG=94134

Review URL: http://codereview.chromium.org/7757002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7748038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98690 0039d316-1c4b-4281-b951-d872f2087c98

Also adds a skeleton for testing compositor API changes.

BUG=none
TEST=see unittest
Review URL: http://codereview.chromium.org/7769001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98689 0039d316-1c4b-4281-b951-d872f2087c98

bug=94454
r=pkasting
Review URL: http://codereview.chromium.org/7801001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98688 0039d316-1c4b-4281-b951-d872f2087c98

  - Call Core->ReleaseResource() on multiple graphics3d resources.
Fix for NaCl ppapi graphics 3d resource, so it can be released without
crashing the untrusted plugin.
Add a few more debug prints for future use.
BUG= none
TEST= ppapi_ppb_graphics3d.cc (included)
Review URL: http://codereview.chromium.org/7736006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94095
TEST=open ntp and chrome://extensions, spam disable/enable on something that's both an app and an extension (such as weatherbug). NTP should not start creating multiple copies of the icon.


Review URL: http://codereview.chromium.org/7764013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98685 0039d316-1c4b-4281-b951-d872f2087c98

Since I didn't land this before the NaCl proxy move to chrome, I had to incorporate the proxy changes that were in http://codereview.chromium.org/7714041/

After PDF lands, I should be able to remove backwards-compat code.

BUG=80696
TEST=ppapi tests, manual test of PDF plugin

Review URL: http://codereview.chromium.org/7718004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98684 0039d316-1c4b-4281-b951-d872f2087c98

This allows symbolization of Google Chrome Canary, Google Chrome Helper EH,
and Google Chrome Helper NP. The practical effect of this is that _main and
start will be properly symbolized by Breakpad.

BUG=94540
TEST=Look at the Breakpad crash reports for the canary browser process,
     plug-in process, and NaCl loader process. The bottom of each stack should
     show ChromeMain being called by main, which is in turn called by start.
Review URL: http://codereview.chromium.org/7799005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7790007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:19010
TEST=Manual: open user image selection dialog, move to the last image and press the right arrow.


Review URL: http://codereview.chromium.org/7784003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98680 0039d316-1c4b-4281-b951-d872f2087c98

These changes enable save and restore of minimized window state on Windows.  (Mac and Linux came prior).  The window state is now saved whenever size-changed notifications fire (in addition to the original activation and close cases).

BUG=43274
TEST=Manual.  Launch Chrome on Windows, create two browser windows, minimize "a" window, quit.  Relaunch, expect "a" to be minimized.


Review URL: http://codereview.chromium.org/7748036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7793005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98678 0039d316-1c4b-4281-b951-d872f2087c98

Use the job object to prevent the GPU from spawning child processes on Windows.

BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/7768004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98677 0039d316-1c4b-4281-b951-d872f2087c98

 * Call OnTextInputTypeChanged from Mock class (which is used when ibus is not present)
 * Don't create InputMethod in desktop window.
 * Fix comment on RWHVV to be more accurate.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7761008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98676 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timurrrr@chromium.org
BUG=28439
TEST=none

Review URL: http://codereview.chromium.org/7790004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94308
TEST=Run unit tests - I don't have any way to reproduce the corrupted DB this CL works around.


Review URL: http://codereview.chromium.org/7747040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98673 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98672 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apavlov@chromium.org

Review URL: http://codereview.chromium.org/7798001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98670 0039d316-1c4b-4281-b951-d872f2087c98

Also adding myself to chromeos watchlist.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7753026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98669 0039d316-1c4b-4281-b951-d872f2087c98

An upcoming libcros change adds a header dependency on glib, so we need an entry in system.gyp for cros_api.gyp to reference.

BUG=chromium-os:19576
TEST=none

Review URL: http://codereview.chromium.org/7799001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98668 0039d316-1c4b-4281-b951-d872f2087c98

I need to use this function in content/rendeder/p2p.

TEST=None
BUG=None

Review URL: http://codereview.chromium.org/7714027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98666 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98665 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7789001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98664 0039d316-1c4b-4281-b951-d872f2087c98

The language index in the dump referred by the crbug is left to -1, meaning that the language passed to TranslateInfoBarDelegate's constructor...

The call stack showed that the call came from an auto translate preference, so my only guess would be that a preference was saved for a language that is not available anymore, so I added code to protect against that.

BUG=93291
TEST=TranslateManagerTest.UnsupportedSavedLanguage

Review URL: http://codereview.chromium.org/7764003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98661 0039d316-1c4b-4281-b951-d872f2087c98

Revert 98656 - Make a new integer field in sql::MetaTable (a per-profile db) containing a counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs.
Make DownloadManager read this field to initialize its next_id_ counter in Init().
Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread.
Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods.
This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere.
Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler.
The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread.
Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager.
When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs.
See also http://codereview.chromium.org/7192016
LMK what to write a test for if anything.

Review URL: http://codereview.chromium.org/7237034

TBR=benjhayden@chromium.org
Review URL: http://codereview.chromium.org/7793003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98660 0039d316-1c4b-4281-b951-d872f2087c98

* Disable underlining for links
* Add more padding between the button and the title.
* Discard the button gradient in favor of white.
* Move favicons two lower-left. 
* Display favicons at natural size (TODO: they need to be size constrained)
* Other bookmarks folder will be hidden if empty.

BUG=92921
Review URL: http://codereview.chromium.org/7749029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=93144
Review URL: http://codereview.chromium.org/7713026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98657 0039d316-1c4b-4281-b951-d872f2087c98

Make a new integer field in sql::MetaTable (a per-profile db) containing a counter for the next download id, so that this id is unique across sessions. This id will allow us to merge download id with db_handle and merge most/all of the maps in DownloadManager in future CLs.
Make DownloadManager read this field to initialize its next_id_ counter in Init().
Put a fine-grained mutex in DownloadManager::GetNextId() so that it can be called directly from any thread.
Define a thunk wrapping DM::GNI() to be passed around between threads to guard against other threads calling any other DM methods.
This thunk owns a scoped_refptr<DM> to manage life-time issues. This pattern is implemented for DM elsewhere.
Store this thunk in ResourceContext to be called by ResourceDispatchHost/DownloadThrottlingResourceHandler on the IO thread. Pass the returned DownloadId into DownloadResourceHandler.
The alternative way to obtain ids on the IO thread is to jump over to the UI thread and back. This way would add significant latency to a critical path. GetNextId() should be fast and easily accessible from any thread.
Now that ids are per-profile, define a class DownloadId containing a per-profile id and an indication of which profile, currently the DownloadManager*. DownloadIds are hashable, comparable, globally unique, not persistent, and are used by DownloadFileManager.
When the download is added to the history, MetaTable.next_download_id will be set to the new download's id +1 if that number is greater than MT.next_download_id. Increasing this counter at the same time as the download is added to the db prevents the counter from desyncing from the db, which was the primary concern re storing the counter in the BrowserPrefs.
See also http://codereview.chromium.org/7192016
LMK what to write a test for if anything.

Review URL: http://codereview.chromium.org/7237034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=avayvod@chromium.org


Review URL: http://codereview.chromium.org/7784002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98655 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7736005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98654 0039d316-1c4b-4281-b951-d872f2087c98