- 12 Oct, 2018 40 commits
-
-
Jochen Eisinger authored
Instead, require an email to opensource-licensing@ again until we figured out the new process. R=jam@chromium.org Change-Id: I352bd17e42cc1500994ba39368d25a0d91271f9c Reviewed-on: https://chromium-review.googlesource.com/c/1275846Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599122}
-
yiyix authored
Bug: 879379 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I43e957955103e5b2d6e4ae80b296655f1b2aa5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1277953Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#599121}
-
Maksim Sisov authored
This CL fixes a fullscreen state changes before the surface is activated. That is, Wayland may ignore fullscreen changes before the surface is activated. Thus, store a pending state, and once the surface is activated, trigger the change. Change-Id: I8c0b995eb9f282f6be16e82d094d9dd93821a60a Bug: 843018 Reviewed-on: https://chromium-review.googlesource.com/c/1275885Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#599120}
-
Christopher Cameron authored
Fix a few places where we would dereference a BridgedNativeWidgetImpl which is null when out-of-process. This doesn't guarantee correct behavior, but avoids a crash. Make WebContentsNSViewBridge::Show resize the web contents view and also all of its children. Bug: 859152 Change-Id: I948de1e4f79db4a51c5b86e7960356133eff4342 Reviewed-on: https://chromium-review.googlesource.com/c/1278533Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#599119}
-
Trent Apted authored
atomicops.h uses `volatile` which inhibits some compiler optimisations without contributing to threading correctness. Define AtomicFlag::IsSet() in the header, rather than out-of-line. Without this, WeakPtr overheads in ObserverListPerfTest_*.CheckedObserver in base_perftests are up to 70% greater. Bug: 891536 Change-Id: Ibc733042bf0027738b49c70ccbbcefc4cde3289d Reviewed-on: https://chromium-review.googlesource.com/c/1278425 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#599118}
-
Sam McNally authored
Bug: 891197 Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113 Reviewed-on: https://chromium-review.googlesource.com/c/1277133Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#599117}
-
Alexandre Courbot authored
The Tegra V4L2 library has a bug in its handling of VIDIOC_QUERYBUF that makes it fail if the number of planes of the passed v4l2_buffer does not exactly match the number of planes of the currently set format. This CL implements a workaround by first running a VIDIOC_G_FMT ioctl in AllocateBuffers(), and then passing the returned number of planes to the buffer constructor so the correct value can be passed to VIDIOC_QUERYBUF. And since we have this value, we also use it in VIDIOC_DQBUF. BUG=893661 TEST=Checked that VDA unittest was passing on hana (Tegra devices have another bug that is fixed in the next CL). Change-Id: I830334de1cf322302fd476ac5535313ebc65900d Reviewed-on: https://chromium-review.googlesource.com/c/1275726 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#599116}
-
Trent Apted authored
These functions are currently in file_manager/file_manager/common/js/unittest_util.js which has a lot of files-app specific stuff that media apps shouldn't depend on. - Move MockAPIEvent to the only unittest (in gallery) that uses it. - Delete the redundant copy of waitUntil in list_thumbnail_loader_unittest.js - Updates the remaining handcrafted foo_unittest.html files in the files app * combination sed-script and manual edit. Bug: 879035 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7d54cec253384b46d1cdb7c51f8ff0eb9596ebf1 Reviewed-on: https://chromium-review.googlesource.com/c/1275545 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#599115}
-
Yuki Yamada authored
This CL renames some ambiguous name of scope and context in JSBasedEventListener::handleEvent(). Split from another one: https://chromium-review.googlesource.com/c/chromium/src/+/1270300 Bug: 872138 Change-Id: I8e772ecdc283fd1585566cf56a52170b777f4608 Reviewed-on: https://chromium-review.googlesource.com/c/1277135Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#599114}
-
rajendrant authored
This CL does a bunch of steps to make the servicification easy to do. 1. Removes the usage of ServiceName in data_use_measurement 2. Refactors the data use update to metrics service to not take service name and instead send if the data use is from metrics component. 3. To remove the UpdateUsagePrefCallback from DataUseMeasurement(), ChromeDataUseMeasurement is introduced that does the posting to UI thread (from io_thread.cc). This helps in servicification since there won't be thread hop. This also helps when CDUA classes are removed, and ChromeDataUseMeasurement can be there without dependency. Bug: 808498 Change-Id: I7a4421c9798447c1ca4d39698f69b227cc773d48 Reviewed-on: https://chromium-review.googlesource.com/c/1272256 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599113}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/89e4bf93b1a1..e2727ef6f5dc git log 89e4bf93b1a1..e2727ef6f5dc --date=short --no-merges --format='%ad %ae %s' 2018-10-12 dgarrett@google.com builder_status_lib: Fix logging lint error. 2018-10-12 vapier@chromium.org paygen: paygen_payload_lib: convert to gs.LS 2018-10-12 vapier@chromium.org paygen: urilib_unittest: convert mox to mock Created with: gclient setdep -r src/third_party/chromite@e2727ef6f5dc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2f3527661843ab9aafccf5f4f58b19fdde879453 Reviewed-on: https://chromium-review.googlesource.com/c/1278301Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599112}
-
Patti authored
This reverts commit 86da6573. Reason for revert: This patch may be causing failures in browser_tests, on chromium.win/Win7 Tests (dbg)(1) https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29 Findit found culprit 598844 with 75% confidence, so reverting this to try and fix. Original change's description: > [Tango->FCM] Do not perform bulk unregistering on shutdown and on handler unregistering. > > * The service shouldn't unregister from the topics, when handler > the Handler is unregistering from topic (as stated in the documentation > for for UnregisterHandler). > * Sync shouldn't unregister on browser shutdown > > Bug: 801985, 876274 > Change-Id: I857da7b0fbfa0a0f2e1ad05708cc24cdc9386a76 > Reviewed-on: https://chromium-review.googlesource.com/c/1196522 > Commit-Queue: Tatiana Gornak <melandory@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598844} TBR=gab@chromium.org,pavely@chromium.org,melandory@chromium.org Change-Id: I70fa87c3476925814408665644acb23c3c1f1614 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 801985, 876274, 894715 Reviewed-on: https://chromium-review.googlesource.com/c/1278273Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599111}
-
Yuki Yamada authored
This is the bug fixing for previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1253317 v8::HandleScope was not named. Bug: 894069 Change-Id: Ib9111275bad434b1968a4bd674a0b8932b8c1533 Reviewed-on: https://chromium-review.googlesource.com/c/1278548 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
-
Jinsuk Kim authored
TabWebContentsObserver is TabWebContentsUserData which is created for the first active WebContents for a given Tab, and finally destroyed together with the Tab. There was a bug creating multiple instances of the observer for every new active WebContents. This left an instance for old WebContents undestroyed, and caused a reported bug for already nulled out WebContents references while handling an event that should not have been triggered. This CL makes sure there will be a single TabWebContentsObserver for Tab. Bug: 894353 Change-Id: Ie2cbe5c79b4d1e9f68d1be045c4d7e88d91c5312 Reviewed-on: https://chromium-review.googlesource.com/c/1278426Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#599109}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8f4bc41c4231..a54daf162fac git log 8f4bc41c4231..a54daf162fac --date=short --no-merges --format='%ad %ae %s' 2018-10-11 benwright@webrtc.org Reland "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h" 2018-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9d052f4b..37b6d53f (598839:598967) Created with: gclient setdep -r src/third_party/webrtc@a54daf162fac The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3d22153c1dd390398aa7dda8a0f8a00d032fc627 Reviewed-on: https://chromium-review.googlesource.com/c/1278298Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09c355ef00f4..aebffd21b13f Created with: gclient setdep -r src-internal@aebffd21b13f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I816f02425f0557bf4030f14078bb453721cca6fe Reviewed-on: https://chromium-review.googlesource.com/c/1278300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599107}
-
Kunihiko Sakamoto authored
This fixes a bug where Resource Timing for prefetched Signed Exchange had negative duration value. Bug: 803774 Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8 Reviewed-on: https://chromium-review.googlesource.com/c/1278546Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599106}
-
Mohamed Amir Yosef authored
At startup, the persisted sync metadata (if available) are loaded and tracked. This CL adds some integrity checks and makes sure that corrupted metadata are ignored, and that Sync starts clean in such case. Bug: 516866 Change-Id: Idf42cce2306f18a94941d40caa1816f737732156 Reviewed-on: https://chromium-review.googlesource.com/c/1274106Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#599105}
-
Yuki Yamada authored
This adds a comment for the previous change: https://chromium-review.googlesource.com/c/chromium/src/+/1276406 Bug: 893951 Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c Reviewed-on: https://chromium-review.googlesource.com/c/1278070 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
-
Kouhei Ueno authored
Bug: 890180 Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd Reviewed-on: https://chromium-review.googlesource.com/c/1275746 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599103}
-
Justin Cohen authored
This bot was erronously moved from Xcode 10 beta 4 all the way to Xcode 10.1 beta. Now that Xcode 10 GM is in goma, roll to Xcode 10. Note: This rolls to 10a254a, which is slightly different than the package goma installed, but it has the same compiler (clang-1000.11.45.2) so it should work the same. If not, we'll have to investigate why and upload a new package to CIPD. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I46e90d60eb562f69d1848df3ff48db3d82cf1cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1278331Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599102}
-
John Z Wu authored
1. Disable feature SyncUserConsentSeparateType for now. 2. Use ReloadCredentials since LoadCredentials DCHECKs and fix up the tests. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3a9af1b353b3138b411ee9fdab6cc67c447ee109 Reviewed-on: https://chromium-review.googlesource.com/c/1278471Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599101}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c4533eae082f..671809e62e80 git log c4533eae082f..671809e62e80 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D 2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d. Created with: gclient setdep -r src/third_party/angle@671809e62e80 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ie918b1391ee226eb39be833dc7768cec9bdbee65 Reviewed-on: https://chromium-review.googlesource.com/c/1278299Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a72c51a329f..89e4bf93b1a1 git log 9a72c51a329f..89e4bf93b1a1 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 derat@chromium.org chromeos_config: Run Tast on {amd64-generic,betty}-paladin. Created with: gclient setdep -r src/third_party/chromite@89e4bf93b1a1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I29f302fb260fcd75ce3d9d3b538f0eed2c2a1f21 Reviewed-on: https://chromium-review.googlesource.com/c/1278493Reviewed-by:
-
Joel Hockey authored
Split crostini UI tests from crostini.js into test files: * crostini_mount.js * crostini_share.js * crostini_tasks.js The existing tests are getting a bit too large and pushing the bot testing time limits. Bug: 878324 Change-Id: I882a38e3f644916e3c904709f3bfc540034b1383 Reviewed-on: https://chromium-review.googlesource.com/c/1278429Reviewed-by:
-
Keiichi Watanabe authored
Use prefix "UsingRealWebcam_" for names of tests that require real webcam and add checking whether webcam is found or not. Accordingly, exclude such test cases from test suites for devices that have no camera. Bug: 893494 Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado) and it failed. Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado) and it passed. Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin) and it passed. Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7 Reviewed-on: https://chromium-review.googlesource.com/c/1276407 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by:Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#599097}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/616feb1a7c2c..09c355ef00f4 Created with: gclient setdep -r src-internal@09c355ef00f4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I31399eb2e92dae352d53dc7fcde8bf49c0966418 Reviewed-on: https://chromium-review.googlesource.com/c/1278531Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 10421 10431 10436 10446 10458 10478 10484 10489 10494 10496 10498 10499 10503 10509 10514 10516 10519 10523 10525 10530 10541 10549 10550 10552 1 lines were removed and 3 lines were deflaked by consecutive results since 10503. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I937b189ec5c0061d7c1607828b6ac5fc0bfe71b4 Reviewed-on: https://chromium-review.googlesource.com/c/1270498 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#599095}
-
Findit authored
This reverts commit a12ef847. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516 Sample Failed Step: content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Fling bubbles from OOPIF properly. > > While we are bubbling a scroll sequence GFS is sent to the fling controllers > of both the oopif and the bubbling target. The fling controller of the oopif > calls progressFling and generates a GSU with inertial phase, the GSU gets acked > immediately before getting sent to the renderer since we are in bubbling mode. > Then the oopif's fling controller receives the unconsumed GSU ack and generates > a GSE to complete the scrolling sequence on the oopif. The bubbling target's > fling controller receives and processes the GFS and generates GSUs which are > sent to the target's renderer. > > If the GSE generated by the oopif's fling controller gets bubbled before > the GFS, the bubbling target gets reset and the target does not receive the > GFS. This cl fixes the issue by making sure that the events generated by the > oopif's fling controller are not bubbled to the target. Also in case of > GFS bubbling, the GFC should also get sent to the bubbling target to make > sure that the fling controller in charge of flinging receives the GFC. > > > Bug: 884728, 249063 > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/1274193 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599001} Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884728, 249063, 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1278536 Cr-Commit-Position: refs/heads/master@{#599094}
-
Leon Han authored
Currently some modules (push_messaging, background_fetch etc.) are calling blink::SWRegistration::WebRegistration() to get a pointer to blink::WebSWRegistration to continue their work there. However, they use that blink::WebSWRegistration just to retrieve the service worker registration id, i.e. what they really want is not blink::WebSWRegistration, but just the registration id. So, this CL removes blink::SWRegistration::WebRegistration() and provides a new function blink::SWRegistration::RegistrationId() for those users instead. This CL is in preparation for https://crrev.com/c/1275300 which plans to merge content::WebSWRegistrationImpl into blink::SWRegistration and remove the public interface blink::WebSWRegistration completely. BUG=789857,879019 Change-Id: Iafb245ec6f978dfaa294f58ee800d80c5ba60fac Reviewed-on: https://chromium-review.googlesource.com/c/1275298 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599093}
-
Fergal Daly authored
Make the state transitions more clear and document which transitions consume a character. Bug: 805271 Change-Id: I363cb6c9d459b560d0ec1b4cb6649cce981deffc Reviewed-on: https://chromium-review.googlesource.com/c/1275747Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599092}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1cd39fa9ea0c..8f4bc41c4231 git log 1cd39fa9ea0c..8f4bc41c4231 --date=short --no-merges --format='%ad %ae %s' 2018-10-11 oprypin@webrtc.org Revert "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h" Created with: gclient setdep -r src/third_party/webrtc@8f4bc41c4231 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I926d7ea870bf3c7c76c519c12806778129e89659 Reviewed-on: https://chromium-review.googlesource.com/c/1277843Reviewed-by:
-
Tommy Steimel authored
This change adds a UI affordance that the window is resizable and draggable on ChromeOS. This adds a ResizeHandleButton made specifically as the affordance. This icon is on the edge of the window that points to the center of the workspace screen. For example, if the window is on the bottom right quadrant, the icon will be on the top left. In the case where the window is on the bottom left quadrant, the icon replaces the close button. The close button is then shifted to the top left corner. Bug: 890113 Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2 Reviewed-on: https://chromium-review.googlesource.com/c/1275526 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599090}
-
Gang Wu authored
Wired most of the UMA logging, there are two methods in the bridge not connected since it is new UMA, will do in next CL. Bug: 831641 Change-Id: I154261aa3266d1f6d0af07ccb7510b3879f2744e Reviewed-on: https://chromium-review.googlesource.com/c/1275130 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599089}
-
Aga Wronska authored
Logging demo setup steps will help to determine at what point problems occured for example in case of infinite loading. Change-Id: I04725e4c9d0de12553f6f14fb3d8ee7d106e9699 Reviewed-on: https://chromium-review.googlesource.com/c/1277957Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#599088}
-
Ian Clelland authored
This queues a report through the Reporting API whenever the Generic Sensor API is used in a frame in which the specific sensor is not allowed according to feature policy. Bug: 867471 Change-Id: I9c50f4a331b2b2230890ee0c357047704af8425a Reviewed-on: https://chromium-review.googlesource.com/c/1263041Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#599087}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d23bbdb87b57..9a72c51a329f git log d23bbdb87b57..9a72c51a329f --date=short --no-merges --format='%ad %ae %s' 2018-10-12 vapier@chromium.org paygen: download_cache_unittest: convert to lib.gs & delete gslib.Cat 2018-10-12 vapier@chromium.org paygen: gslib: drop unused Stat Created with: gclient setdep -r src/third_party/chromite@9a72c51a329f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5c3d6623dd88c54fd144213025257ecc157d0565 Reviewed-on: https://chromium-review.googlesource.com/c/1278489Reviewed-by:
-
Roger Tawa authored
Bug: 893874 Change-Id: Id07fb2e9d67403cb77d571df41b4b2aef11bb46d Reviewed-on: https://chromium-review.googlesource.com/c/1278475 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599085}
-
Ryan Hansberry authored
Links can't be opened like they usually would be in OOBE, because there's no browser to open them in. This CL creates a webview modal which is displayed when the user clicks on one of the two "Learn More" links in the MultiDevice OOBE screen, and loads it with the appropriate URL. Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png Bug: 893349 Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127 Reviewed-on: https://chromium-review.googlesource.com/c/1275296 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599084}
-
Dominick Ng authored
This will allow WebAPKs to be bounced to the desktop browser on Chrome OS devices. BUG=893927 Change-Id: Ic70b58d2ab2b23960cc894dd3420174b523908e6 Reviewed-on: https://chromium-review.googlesource.com/c/1272756Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#599083}
-
