- 18 Feb, 2018 9 commits
-
-
Dave Tapuska authored
Shadowed variables can make code harder to read. Don't support them in the content layer. BUG=794619 This CL was uploaded by git cl split. R=dalecurtis@chromium.org Change-Id: Ida89064c5c1c68cf24708d2f6536569812507186 Reviewed-on: https://chromium-review.googlesource.com/924169Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537562}
-
Miguel Casas authored
This CL adds a new Gpu FeatureInfo::FeatureFlags and command buffer Capabilities to signal support for image_xb30, in parallel to the existing image_xr30. The new flag is used on platforms supporting glTexImage2D() with data format GL_RGB(A), namely >=gles3, >=gl3.3 or those with the appropriate GL extension. This CL also adds a new GpuMemoryBuffer format RGBX_1010102 to be used where image_xb30 is signalled. With all this, Mac will use image_xr30 <-> BGRX_1010102, and the GLES3+/GL3.3+ platforms will use image_xb30 <-> RGBX_1010102. Bug: 803975, 776093, 803451, 808172 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I00c834b68ce81d93e0f55694d891186ed3b75611 Reviewed-on: https://chromium-review.googlesource.com/920361Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#537561}
-
Bin Wu authored
Merge internal change: 185728670 R=rch@chromium.org Change-Id: I333dd3d85a4a3e47a34d5e5fdf59fa2143e70c68 Reviewed-on: https://chromium-review.googlesource.com/923533Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#537560}
-
Mostyn Bramley-Moore authored
This fixes the following jumbo build error: In file included from gen/third_party/WebKit/Source/platform/blink_platform_unittests_sources_jumbo_3.cc:26: In file included from ./../../third_party/WebKit/Source/platform/graphics/paint/DrawingRecorderTest.cpp:8: ../../third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.h:19:23: error: target of using declaration conflicts with declaration already in scope using blink::testing::DefaultPaintChunkProperties; ^ ../../third_party/WebKit/Source/platform/testing/PaintPropertyTestHelpers.h:29:36: note: target of using declaration static inline PaintChunkProperties DefaultPaintChunkProperties() { ^ ./../../third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositorTest.cpp:43:22: note: conflicting declaration PaintChunkProperties DefaultPaintChunkProperties() { ^ 1 error generated. Followup to https://chromium-review.googlesource.com/c/chromium/src/+/922391 TBR=chrishtr@chromium.org Bug: 811269 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icb472581bb3b9fc46c82d21b0566572b61732876 Reviewed-on: https://chromium-review.googlesource.com/924863 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#537559}
-
John Chen authored
Add most of the ChromeDriver tests into the chromedriver_py_tests target that is run in the commit queue. Some tests are skipped for various reasons: not reliable enough, not adding enough value for commit queue, or requiring additional setup not yet available. Bug: 793370 Change-Id: Iec581b24e155b2dfb926cdba4899f26c173d2023 Reviewed-on: https://chromium-review.googlesource.com/919488Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537558}
-
Xiaocheng Hu authored
TranslateHelper uses a sample of the page text to determine the page language. This patch eliminates content of NOSCRIPT elements from the text dump, so that non-text contents in NOSCRIPT elements are not passed to TranslateHelper. Bug: 813009 Change-Id: Icf1781a69d17538103574bd149cb3d5851852a08 Reviewed-on: https://chromium-review.googlesource.com/924111Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#537557}
-
https://webrtc.googlesource.com/src.git/+log/80dd7b5d683c..707ca31ea4b5 $ git log 80dd7b5d6..707ca31ea --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7fa49b2063866446c793ce2c1e30de3af60ee39d Reviewed-on: https://chromium-review.googlesource.com/924765 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537556}
-
Chris Harrelson authored
incorrectly null. Bug: 811269 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ia8f0a8d1ec9c95df5e540cfb66a4310f59e6d97c Reviewed-on: https://chromium-review.googlesource.com/922391 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537555}
-
Erik Chen authored
The re-entrancy flag was missing for PartitionAlloc and Oilpan hooks. There was an extra call to AllocatorShimLogFree() in HookFree(). Change-Id: Ida86b9e0e3ba33679ba353baccd47f5fcf93685c Bug: 813117 TBR: primiano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/924885 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537554}
-
- 17 Feb, 2018 31 commits
-
-
Miguel Casas authored
There's only a few instances of "video" as TRACE_EVENT category [1], so it doesn't have a strong reason to exist. This CL folds them back into "media" sed -i -e 's/"video"/"media"/' `grep -rn 'TRACE_EVENT.("video"' media/ content/ | cut -d: -f1 | uniq` [1] https://cs.chromium.org/search/?q=TRACE_EVENT.%5C(%22video%22&sq=package:chromium&type=cs Change-Id: Id2a164986d0cbabd465ba69b59b365668ac80777 Reviewed-on: https://chromium-review.googlesource.com/922401Reviewed-by:Yuri Wiitala <miu@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#537553}
-
https://chromium.googlesource.com/angle/angle.git/+log/0cbfa5866f43..9fdaa497b489 $ git log 0cbfa5866..9fdaa497b --date=short --no-merges --format='%ad %ae %s' 2018-02-16 jmadill Don't no-op draw calls for zero count in validation. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I7f9eaf07868bd7c40ccb2297f23ae4af1760efd3 Reviewed-on: https://chromium-review.googlesource.com/923439 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537552}
-
Wenzhao Zang authored
This CL makes the new wallpaper picker fully usable. There're some corner cases that haven't been determined by UX and they are explicitly marked as 'TODO'. Mock: goo.gl/kGgEVr Spec: https://drive.google.com/file/d/1nxrxAmlXOMp50IkGFGNobmIS-QpkYtLY/view Bug: 800945 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I396e5727e2f564623163424de05e86be8ecb4cb0 Reviewed-on: https://chromium-review.googlesource.com/917215Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#537551}
-
Bin Wu authored
Merge internal change: 185535210 R=rch@chromium.org Change-Id: I8430f9039098ed922a4cdf724dbd99dd98b5ad1d Reviewed-on: https://chromium-review.googlesource.com/924728Reviewed-by:
-
Ryan Hamilton authored
so that callers do not have to compute it. Change-Id: I6b9270073337c9a5827fadc6eefe169e057e43d1 Reviewed-on: https://chromium-review.googlesource.com/917330 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#537549}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1811bfa..016d6b24 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iea600374c02e69a216543a3440e6015626e8f522 Reviewed-on: https://chromium-review.googlesource.com/924921Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#537548}
-
Alexander Yashkin authored
Fix for incorrect handling of encodings used for search terms. TemplateURL::EncodeSearchTerms function was always using first passed codepage instead of trying to use passed codepages in the order provided, as stated in online docs for DefaultSearchProviderEncodings policy. Bug: 582756 Change-Id: I659f82f0e777c950a888e2ceff8726c4fdcf0378 Reviewed-on: https://chromium-review.googlesource.com/922621 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#537547}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6c7abd8c..d1811bfa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iec94584397bcbecf0f9fea3ea01df80ca6d505e4 Reviewed-on: https://chromium-review.googlesource.com/924882Reviewed-by:
-
Ned Nguyen authored
Bug:717744 Change-Id: I26bc36a78f951b9152e299863d7ff85398b75384 TBR=eyaich@chromium.org Change-Id: I26bc36a78f951b9152e299863d7ff85398b75384 Reviewed-on: https://chromium-review.googlesource.com/924583Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#537545}
-
https://webrtc.googlesource.com/src.git/+log/8b815cddcad8..80dd7b5d683c $ git log 8b815cddc..80dd7b5d6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia8d568c6d247cb1ee2a8fd0bd7ed38868a7325f4 Reviewed-on: https://chromium-review.googlesource.com/924843Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3d393910..6c7abd8c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I82a63280be3cfd0756a0f5f96c1ef915c5549af6 Reviewed-on: https://chromium-review.googlesource.com/924359Reviewed-by:
-
Qiang Xu authored
changes: - Move major logic of chromeos::AccessibilityHighlightManager to ash. - Move caret, cursor, focus highlight controls to ash. On --mash, focus highlight feature works. Caret and cursor highlight relies on mash's global cursor manager. Bug: 594887 Test: ash_unittests and emulator tests. Change-Id: Ib95f3f6b8c3bed40199247bda68cbdb384a1b964 Reviewed-on: https://chromium-review.googlesource.com/923707 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#537542}
-
Kenneth Russell authored
There's only one such bot in the Swarming pool so this is necessary to prevent webgl2_conformance_tests' shards from timing out. NOTRY=true TBR=jmadill@chromium.org, ynovikov@chromium.org Bug: 764803 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I59cbb467c8df0050235d5c7f11408870d31b1ad5 Reviewed-on: https://chromium-review.googlesource.com/924570 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537541}
-
Wei Li authored
This reverts commit 39d52aa5. Reason: The original CL was reverted just to revert https://chromium-review.googlesource.com/c/chromium/src/+/924245 cleanly. Context is in https://bugs.chromium.org/p/chromium/issues/detail?id=813246 TBR=thestig@chromium.org, alexmos@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ibfdb1571cd7fd4d78f9b8ff6c710c587e3cf3464 Reviewed-on: https://chromium-review.googlesource.com/924566 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#537540}
-
Tarun Bansal authored
Previous CL did for frames and requests that start from Blink. This CL additionally does it for frames or requests that start in the browser. Bug: 800035 Change-Id: Id31dafa267a54971aa175077b017f5ee26d20d44 Reviewed-on: https://chromium-review.googlesource.com/922886 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#537539}
-
Ryan Hamilton authored
instead of dependent_stream_id to match the language in the HTTP spec and to make it clear which direction the dependency points. Change-Id: I715b9f87a8ca614efd7d816c9f4229c52747e142 Reviewed-on: https://chromium-review.googlesource.com/917203 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Mark Cogan authored
This CL sets up stub implementations for the Tabb Grid transition animators and helper objects/protocols. Bug: 804537 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie030f3222a93774e9da6a90b02cd865350f2dd37 Reviewed-on: https://chromium-review.googlesource.com/924756 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#537537}
-
https://skia.googlesource.com/skia.git/+log/1701ecea23b0..cad0acf4db5b $ git log 1701ecea2..cad0acf4d --date=short --no-merges --format='%ad %ae %s' 2018-02-16 jvanverth Fix thrashing issue with multitextured atlas. 2018-02-16 reed add decal tilemode to shaders Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I27b429d518168970caec3ba6f91303b9c782f355 Reviewed-on: https://chromium-review.googlesource.com/924748Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537536}
-
Nicolas Pena authored
This CL is the second step in merging the Performance and WorkerPerformance idls. The following are the full set of steps: 1. Rename Performance.h to WindowPerformance.h. 2. Rename PerformanceBase.h to Performance.h. 3. Merge Performance.idl and WorkerPerformance.idl. The following is roughly how it would look like after all steps are completed: https://chromium-review.googlesource.com/c/chromium/src/+/919983 Bug: 707392 Change-Id: I1d9d91b29be2910d5a733e685bbccea9180d1d67 Reviewed-on: https://chromium-review.googlesource.com/924276 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#537535}
-
Ian Kilpatrick authored
Bug: 726125 Change-Id: Ieb60376042e6caaa82c9aab005a41ce626bdb33b Reviewed-on: https://chromium-review.googlesource.com/923378 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537534}
-
https://webrtc.googlesource.com/src.git/+log/b95324531121..8b815cddcad8 $ git log b95324531..8b815cddc --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5d67cd9e9b1181114e64398ce82268941d4da256 Reviewed-on: https://chromium-review.googlesource.com/924822Reviewed-by:
-
Bret Sepulveda authored
Previously the icons would use the active colors, which is confusing. See screenshot in the associated bug. Bug: 812920 Change-Id: I35e11e1b5ec8e1fc95b40ef27e5819b9dd9db008 Reviewed-on: https://chromium-review.googlesource.com/923209Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#537532}
-
Alexander Alekseev authored
This reverts commit 53ccd0b5. Reason for revert: broke build for devices without CUPS. Original change's description: > ARC Print > > This allows container to use native printers. > > Bug: 625126 > Change-Id: Idb1b1de9a11877fdfa9e9eb4e9ec87d4bf089ef7 > Reviewed-on: https://chromium-review.googlesource.com/648979 > Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> > Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: Mattias Nissler <mnissler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536784} TBR=thestig@chromium.org,lhchavez@chromium.org,vkuzkokov@chromium.org,mnissler@chromium.org,skau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 625126, 813246 Change-Id: I271836252c755f2586a2869d2770eb065426920d Reviewed-on: https://chromium-review.googlesource.com/924245 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
A wrong test was disabled in https://chromium-review.googlesource.com/c/chromium/src/+/923572. (It skipped CQ for the last Patch Set because linux-chromeos-rel was very flaky). Bug: 813221 TBR: alemate@chromium.org Change-Id: I014d846a01f36366b14d7701b1ebd72cbfd51efb Reviewed-on: https://chromium-review.googlesource.com/924395Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#537530}
-
Francois Doray authored
This CL: - Adds content::Visibility {VISIBLE, OCCLUDED, HIDDEN}. - Replaces bool WebContents::IsVisible(); with Visibility WebContents::GetVisibility(); - Replaces void WebContents::WasShown(); void WebContents::WasHidden(); with void WebContents::OnVisibilityChanged(Visibility); FAQ: - What is the meaning of VISIBLE, OCCLUDED or HIDDEN? https://chromium-review.googlesource.com/c/chromium/src/+/867511/17/content/public/browser/visibility.h - What should I consider when reviewing an updated call site? Before, WasShown()/WasHidden() were called for these transitions: visible or occluded -> hidden hidden -> visible or occluded Now, OnVisibilityChanged() is called for each of these transitions: VISIBLE -> OCCLUDED OCCLUDED -> VISIBLE HIDDEN -> VISIBLE: HIDDEN -> OCCLUDED VISIBLE -> HIDDEN OCCLUDED -> HIDDEN - Why a single OnVisibilityChanged observer method instead of WasShown/WasHidden/WasOccluded? Having a single method makes it clearer that visibility states are mutually exclusive. - Why do we need an OCCLUDED state? We plan to use it for metrics recording and to reduce resource usage in occluded tabs. This is important to improve the experience of users that use many windows. https://groups.google.com/a/google.com/d/msg/chrome-desktop/3Qp1857tqw4/E8Qp-YgoDQAJ Bug: 668690 Change-Id: I7a6aa905619f51f5d5463f583bdb4640d57aff00 Reviewed-on: https://chromium-review.googlesource.com/867511 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#537529}
-
James Cook authored
Components must declare all of their dependencies explicitly. Fix quick_launch deps to comply. Bug: 812299 Test: buildtools/checkdeps/checkdeps.py ash Change-Id: I2de1491e28566f2be9afe9bb1756084ef0641310 Reviewed-on: https://chromium-review.googlesource.com/924313Reviewed-by:
-
Wez authored
This adds supports for building Cronet as a native shared library which can be used through the C API generated from cronet.idl. This is based on jamesr@'s work-in-progress to bring up the Cronet library for Fuchsia: https://chromium-review.googlesource.com/c/chromium/src/+/896389 Bug: 808075 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I598a8d1ca049e8c166e57546b7bdbf53e4659831 Reviewed-on: https://chromium-review.googlesource.com/914805 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537527}
-
Douglas Creager authored
We now generate NEL reports for successful requests, rate limited by the `success-fraction` field of the NEL configuration header. We have to handle HTTP errors (i.e., those with 4xx and 5xx status codes) specially, since they show up as "successful" according to the network stack, but NEL considers that to be a special `http.error` failed request. Bug: 748549 Change-Id: I1a0a01fd52a4782855ba410be1301b0ccb81ee30 Reviewed-on: https://chromium-review.googlesource.com/893679 Commit-Queue: Douglas Creager <dcreager@google.com> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#537526}
-
https://webrtc.googlesource.com/src.git/+log/85904f4ee8b4..b95324531121 $ git log 85904f4ee..b95324531 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5aa3d5e5718488d138d41fd1fac0f2611bcd7955 Reviewed-on: https://chromium-review.googlesource.com/924392Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/22ef1d88..3d393910 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id9058223a28082a16ce52e92f98901a3421a8a1b Reviewed-on: https://chromium-review.googlesource.com/924724Reviewed-by:
-
Reilly Grant authored
This is a follow-up to r537429 which fixes a crash introduced in PlatformSensorReaderWin::SetReportingInterval because of a missing return after logging the failure to instantiate an instance of IPortableDeviceValues. The log message is also tweaked to remove an extraneous space. TBR=cco3@chromium.org Bug: 756986 Change-Id: I5e07d365f93dc4d9df75d0ac743138ba3c7437ab Reviewed-on: https://chromium-review.googlesource.com/924563Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537523}
-
