GitLab

The current logic to add accessibility description
for tabs was not very read-able and did not match
existing code style of the project.

This change cleans up the complex if-else conditions
to a much simpler ternary assignment format.

BUG=0
TEST=Re-run junit tests for StripLayoutHelperTest suite.

Review-Url: https://codereview.chromium.org/2179043002
Cr-Commit-Position: refs/heads/master@{#408229}

BUG=612331
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2182443005
Cr-Commit-Position: refs/heads/master@{#408228}

BUG=629217

Review-Url: https://codereview.chromium.org/2191473004
Cr-Commit-Position: refs/heads/master@{#408227}

Switch to SetAccessor, this adds a Getter where the Usage counter will be added subsequently.

A side effect of SetAccessor is that it subtly changes the  behavior: previously loadtimes data fields were mutable and persisted modifications that updated the value programmatically (from javascript).
With this change, such modifications will not be persisted.
We think this is fine -- as we cannot think of scenarios where it makes sense to modify the values returned by chrome.loadtimes. Moreover this is a necessary step to get usage counts and move the deprecation further.

BUG=621512

Review-Url: https://codereview.chromium.org/2149933003
Cr-Commit-Position: refs/heads/master@{#408226}

Review-Url: https://codereview.chromium.org/2184683003
Cr-Commit-Position: refs/heads/master@{#408225}

* Convert from Shelf to WmShelf
* Move to //ash/common/shelf

BUG=632071
TEST=ash_unittests

Review-Url: https://codereview.chromium.org/2187953002
Cr-Commit-Position: refs/heads/master@{#408224}

BUG=418195
TEST=tested "Clear Browsing Data" dialogs manually
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2180383002
Cr-Commit-Position: refs/heads/master@{#408223}

BUG=610521

Review-Url: https://codereview.chromium.org/2189443004
Cr-Commit-Position: refs/heads/master@{#408222}

Fixes toy server crash described here:
https://groups.google.com/a/chromium.org/forum/#!topic/proto-quic/ziwUgZbV2Wk

BUG=

Review-Url: https://codereview.chromium.org/2180003004
Cr-Commit-Position: refs/heads/master@{#408221}

https://chromium.googlesource.com/chromium/src/+/a9a9eebea

BUG=632000
TBR=xidachen@chromium.org

Review URL: https://codereview.chromium.org/2185143002 .

Cr-Commit-Position: refs/heads/master@{#408220}

This is needed for mash as we asynchronously set the shelf, which is not expected. The async creation is temporary while we support sysui. Once sysui goes away this code shouldn't be needed.

BUG=632099
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2184223002
Cr-Commit-Position: refs/heads/master@{#408219}

SetDefaultDeviceScaleFactor is deprecated in favor of --force-device-scale-factor

GetDPIScale and GetSystemMetricsInDIP are deprecated in favor of their equivalent per-HWND DPI aware replacements in ScreenWin.

BUG=426656

Review-Url: https://codereview.chromium.org/2182333005
Cr-Commit-Position: refs/heads/master@{#408218}

This CL:

1. Removes the uses of build and builder objects in main and get_failing_results_dict.

2. Returns a new dictionary with merged_keys in merge_same_valued_keys.

3. Adds more test failure types to get_expectations to return more accurate expectations.

4. Modifies create_line_list to only create a line if the test name starts with 'imported'.

5. Changes variable names in main.

6. Adds unit tests to cover multiple actual and expected results in get_expectations.

BUG=625254

Review-Url: https://codereview.chromium.org/2183913002
Cr-Commit-Position: refs/heads/master@{#408217}

This CL enables the Core Animation compositor's implementation of CSS filter
effects.

BUG=581526
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2183333002
Cr-Commit-Position: refs/heads/master@{#408216}

BUG=418060

Review-Url: https://codereview.chromium.org/2170103002
Cr-Commit-Position: refs/heads/master@{#408215}

Revert of Auto-rebaseline for r407959 (patchset #1 id:1 of https://codereview.chromium.org/2185923002/ )

Reason for revert:
This appears to have destabilized the fast/images/paint-subrect-grid.html test

First failure:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7644

Selected subsequent failures:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7677
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7686
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11/builds/7691

Original issue's description:
> Auto-rebaseline for r407959
>
> https://chromium.googlesource.com/chromium/src/+/1bda333fb
>
> BUG=355305
> TBR=xidachen@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f77ba46336ef79e85208ceab5cfef305de40ef2a

TBR=xidachen@chromium.org,blink-rebaseline-bot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=355305

Review-Url: https://codereview.chromium.org/2183313005
Cr-Commit-Position: refs/heads/master@{#408214}

This CL implements the GlRenderer class for rendering remote desktop frame
and cursor on the current OpenGL surface. This is part of the project of
using OpenGL ES to render host desktop on Android/iOS client.

BUG=385924

Review-Url: https://codereview.chromium.org/2175963002
Cr-Commit-Position: refs/heads/master@{#408213}

This allows MetricsProviders to log any histograms for data that's
buffered. For example, The page load metrics subsystem buffers some
metrics data until the end of the page load. These metrics should
also be logged when the app enters the background, in order to avoid
data loss.

https://codereview.chromium.org/2189543002 is a follow up change that
makes use of this new callback when tracking page load metrics.

See https://groups.google.com/a/google.com/d/topic/uma-users/BcJRPxNlJ4E/discussion
for additional context on this change.

BUG=608360

Review-Url: https://codereview.chromium.org/2175743002
Cr-Commit-Position: refs/heads/master@{#408212}

This is the second attempt to roll the support library. The first
attempt was https://codereview.chromium.org/2175513002 and it was
reverted in https://codereview.chromium.org/2175763003 due to downstream
bots failure.

BUG=629768

Review-Url: https://codereview.chromium.org/2185133002
Cr-Commit-Position: refs/heads/master@{#408211}

These only provide #defines for the IDs of relevant strings.  The values are the
same as in the corresponding "xxx_chromium_strings.h" files, so only one is
necessary, regardless of whether the files will be compiled branded as Chromium
or Google Chrome.  The canonical #include is the "chromium" one, so leave only
that .h everywhere.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2187473003
Cr-Commit-Position: refs/heads/master@{#408210}

To be followed up with gfx::ColorTransform which will actually do something with the data.

BUG=622133

Review-Url: https://codereview.chromium.org/2183953002
Cr-Commit-Position: refs/heads/master@{#408209}

This CL removes the last reference of NetPrefObserver from the codebase.  This
is a follow-up to https://crrev.com/2172543003.

Review-Url: https://codereview.chromium.org/2179403003
Cr-Commit-Position: refs/heads/master@{#408208}

Summary of changes:
. Move RasterThreadHelper into the client lib, since it's used by mus
  clients (views).
. Remove the --use-mojo-gpu-command-buffer-in-mus flag, which means
  chrome gpu command buffer is now used on Windows for mus.
. Delete the rest of the code in services/ui/gles2, and
  OzoneGpuMemoryBuffer from services/ui/surfaces.

BUG=623157, 630893

Review-Url: https://codereview.chromium.org/2176303002
Cr-Commit-Position: refs/heads/master@{#408207}

BUG=630718
R=kozyatinskiy

Review-Url: https://codereview.chromium.org/2184193003
Cr-Commit-Position: refs/heads/master@{#408206}

AcceleratorControllerRegistrar is responsible for registering
accelerators known to ash (in AcceleratorController) with the wm. In addition
AcceleratorRegistrarImpl now registers keyboard accelerators with
AcceleratorController.

Accelerators are now registered for pre and post. This better matches
how ash/chrome interact to process accelerators. See comment in
AcceleratorControllerRegistrar for details on this.

BUG=612331,631545
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2187703003
Cr-Commit-Position: refs/heads/master@{#408205}

BUG=631825

Review-Url: https://codereview.chromium.org/2181183003
Cr-Commit-Position: refs/heads/master@{#408204}

The change made in r406557 caused a 12% regression on the grid layout
performance tests. The root cause is that as part of the changes
required to implement the orthogonal flows support we decided to use
physical directions to determine whether a grid item overflows its
grid area or not. Since we store the logical sizes in a HashMap, we
implemented some utility methods that, based on the grid container's
writing mode, retrieve the stored width or height from the HashMap.

Since the previous logic was reusing the already computed logical
value, the change introduced a considerable performance regression.

This patch address the issue by removing the utility methods and
determine the physical sizes directly inside the layout logic.

BUG=630448

Committed: https://crrev.com/2cf9f05031414616d3d1eb1e5ffa5013e396d61b
Review-Url: https://codereview.chromium.org/2176633002
Cr-Original-Commit-Position: refs/heads/master@{#407762}
Cr-Commit-Position: refs/heads/master@{#408203}

BUG=610521

Review-Url: https://codereview.chromium.org/2176393004
Cr-Commit-Position: refs/heads/master@{#408202}

BUG=474273

Review-Url: https://codereview.chromium.org/2192543002
Cr-Commit-Position: refs/heads/master@{#408201}

BUG=590036

Review-Url: https://codereview.chromium.org/2184203002
Cr-Commit-Position: refs/heads/master@{#408200}

This CL implements the logic to track TextInputState in TextInputManager
for OOPIF structure on Mac. A similar implementation was landed on Aura
here: https://codereview.chromium.org/1948343002.

The CL also activates the corresponding TextInputManager tests on Mac.

BUG=578168,602723,602427

Review-Url: https://codereview.chromium.org/2166573003
Cr-Commit-Position: refs/heads/master@{#408199}

Revert of On Linux rework driver_version/vendor extraction from gl version (patchset #9 id:160001 of https://codereview.chromium.org/2153373002/ )

Reason for revert:
Still breaks tests on Linux Intel:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28New%20Intel%29/builds/2661

Original issue's description:
> On Linux rework driver_version/vendor extraction from gl version
>
> Previously it could not extract them from the gl version
> "3.3 (Core Profile) Mesa 10.5.9" because of the presence
> of '(Core Profile)'.
>
> BUG=628929
>
> R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> TEST=gpu_unittests --gtest_filter=*CollectDriverInfoGL*
>
> Committed: https://crrev.com/e5fdc90d17a40a9166a335a0d7c8fd8b2ccf40cd
> Cr-Commit-Position: refs/heads/master@{#407804}

TBR=piman@chromium.org,zmo@chromium.org,patyag0814@gmail.com,cwallez@chromium.org,j.isorce@samsung.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628929

Review-Url: https://codereview.chromium.org/2182993004
Cr-Commit-Position: refs/heads/master@{#408198}

BUG=629275,

Review-Url: https://codereview.chromium.org/2185823004
Cr-Commit-Position: refs/heads/master@{#408197}

By default, when you specify typemap entry "T=CustomT", T (non-nullable) will be mapped to CustomT; while T? will be mapped to base::Optional<CustomT>. You could use attribute "nullable_is_same_type" if you want to map T/T? to the same type: "T=CustomT[nullable_is_same_type]". In this case, the corresponding StructTraits<> should implement IsNull()/SetToNull() methods.

BUG=624146

Review-Url: https://codereview.chromium.org/2179273002
Cr-Commit-Position: refs/heads/master@{#408196}

This patch updates the code to prevent auto deducing to a raw pointer.

R=rogerta@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2184913002
Cr-Commit-Position: refs/heads/master@{#408195}

Doing this in a single step to preserve history and make subsequent
diffs easy.

BUG=612331
TEST=none
R=sadrul@chromium.org
TBR=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2186093002
Cr-Commit-Position: refs/heads/master@{#408194}

This patch updates the code to prevent auto deducing to a raw pointer.

R=rsesek@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2189483002
Cr-Commit-Position: refs/heads/master@{#408193}

https://chromium.googlesource.com/skia.git/+log/735109c24892..89da69303550

$ git log 735109c24..89da69303 --date=short --no-merges --format='%ad %ae %s'
2016-07-27 halcanary DEPS: ICU c291cde → ec9c113
2016-07-27 halcanary DEPS:  harfbuzz 1.2.7 → 1.3.0
2016-07-27 halcanary DEPS:  sfntly 130f832 → 468cad5
2016-07-27 borenet Include "revision" tag for all Swarming tasks
2016-07-27 brianosman Fix ParseConfigs_ViaParsing test when skia_angle=1
2016-07-27 bsalomon Fix leak of srgb/adobesrgb colorspace objects
2016-07-27 borenet Fix Perf data upload
2016-07-27 bsalomon SW backend for viewer on Windows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2182273002
2016-07-27 caryclark fuzz wednesday
2016-07-27 mtklein Clean up some unused atomic routines.

BUG=631564,631992

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2187903002
Cr-Commit-Position: refs/heads/master@{#408192}

This patch updates the code to prevent auto deducing to a raw pointer.

R=yoshiki@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2183283002
Cr-Commit-Position: refs/heads/master@{#408191}

This patch updates the code to prevent auto deducing to a raw pointer.

R=grt@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2183033003
Cr-Commit-Position: refs/heads/master@{#408190}