- 07 Apr, 2011 40 commits
-
-
enne@google.com authored
[chromium] Unreviewed, rebaseline progress element tests. * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed. * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: * platform/chromium-mac-leopard/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added. * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed. * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: * platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83202 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aestes@apple.com authored
Reviewed by Darin Adler. REGRESSION (r64712): Microsoft Outlook 2011: original message contents not included when replying to an email. https://bugs.webkit.org/show_bug.cgi?id=57794 * WebKit.xcodeproj/project.pbxproj: 2011-04-07 Andy Estes <aestes@apple.com> Reviewed by Darin Adler. REGRESSION (r64712): Microsoft Outlook 2011: original message contents not included when replying to an email. https://bugs.webkit.org/show_bug.cgi?id=57794 Outlook populates a reply message by creating an empty WebView and using DOM API to populate the WebView's empty document with content from the original message. It expects the initial empty document to simply be "<html></html>", and it proceeds to dynamically create and append a BODY node and add the original message content as a child of that node. Outlook then takes the innerHTML of the frame's first body element and copies it into a *new* document that is displayed and edited in the reply message window. Due to implementing the HTML5 tree building algorithm in r64712, initial empty documents went from being "<html></html>" to being "<html><head></head><body></body></html>". Outlook still dynamically creates a BODY node to parent the original message content, but this BODY node duplicates the one created by the tree builder. When Outlook then takes the innerHTML of the first body element to populate the reply message window it gets the empty body element created by the parser, not the one it created with the original message content. Fix this by injecting a user script into the initial empty document that removes the HEAD and BODY nodes created by the parser. This ensures that the BODY created by Outlook is the only BODY in the document. * Misc/OutlookQuirksUserScript.js: Added. * WebView/WebView.mm: (leakMailQuirksUserScriptContents): (-[WebView _injectMailQuirksScript]): (needsOutlookQuirksScript): (leakOutlookQuirksUserScriptContents): (-[WebView _injectOutlookQuirksScript]): (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): 2011-04-07 Andy Estes <aestes@apple.com> Reviewed by Darin Adler. REGRESSION (r64712): Microsoft Outlook 2011: original message contents not included when replying to an email. https://bugs.webkit.org/show_bug.cgi?id=57794 * WebCore.exp.in: * loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts() before checking if the FrameLoader is parsing the initial empty document. This allows user scripts to be injected at the end of document parsing (if the setting is enabled). * page/Frame.cpp: (WebCore::Frame::injectUserScripts): Do not inject scripts if this feature is disabled on the initial empty document. * page/Settings.cpp: (WebCore::Settings::Settings): * page/Settings.h: Add a setting for injecting user scripts into the initial empty document (defaults to false). (WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument): (WebCore::Settings::injectUserScriptsInInitialEmptyDocument): * platform/mac/RuntimeApplicationChecks.h: * platform/mac/RuntimeApplicationChecks.mm: (WebCore::applicationIsMicrosoftOutlook): Check if the embedding application is Microsoft Outlook. git-svn-id: svn://svn.chromium.org/blink/trunk@83201 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
jeffm@apple.com authored
* Shared/WebString.h: (WebKit::WebString::getCharacters): Add explict cast when using std::min(). git-svn-id: svn://svn.chromium.org/blink/trunk@83200 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jer.noble@apple.com authored
* platform/mac-wk2/media/controls-without-preload-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83199 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jeffm@apple.com authored
Reviewed by Adam Roben. Replace WKStringGetCharactersPtr() with WKStringGetCharacters() https://bugs.webkit.org/show_bug.cgi?id=58058 * TestWebKitAPI/Tests/WebKit2/WKString.cpp: (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr(). 2011-04-07 Jeff Miller <jeffm@apple.com> Reviewed by Adam Roben. Replace WKStringGetCharactersPtr() with WKStringGetCharacters() https://bugs.webkit.org/show_bug.cgi?id=58058 WKStringGetCharactersPtr() exposes the internal implementation of WKString, so change this to WKStringGetCharacters(), which makes a UTF-16 copy. * Shared/API/c/WKString.cpp: (WKStringGetCharacters): Added, replaces WKStringGetCharactersPtr(). * Shared/API/c/WKString.h: Replaced WKStringGetCharactersPtr() with WKStringGetCharacters(). * Shared/WebString.h: (WebKit::WebString::getCharacters): Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83198 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
bweinstein@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=58065 <rdar://problem/9244367> Reviewed by Adam Roben. Make gestureDidScroll synchronous, as once we scroll, we need to know whether or not we are at the beginning or end of the scrollable document. If we are at either end of the scrollable document, we call the Windows 7 API to bounce the window to give an indication that you are past an end of the document. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it. * UIProcess/WebPageProxy.h: * UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): Inititalize a new variable. (WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to an end of the document, and if we have, bounce the window. * UIProcess/win/WebView.h: * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync. * WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical scrollbar and if we are at the beginning or the end of the scrollable document. git-svn-id: svn://svn.chromium.org/blink/trunk@83197 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jer.noble@apple.com authored
Reviewed by Maciej Stachowiak. AVF: MediaPlayerPrivateAVFoundation never reaches playable state. https://bugs.webkit.org/show_bug.cgi?id=57962 Add support for a new AVPlayerItem API which will notify clients when their seek completes. This requires a new Notification type to be passed to the main thread in MediaPlayerPrivateAVFoundation. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added. (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new overloaded functions which take a Notification; and a Notification::Type and boolean. (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted Notification type. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: (WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor. (WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API. (-[WebCoreAVFMovieObserver seekCompleted:]): Added. git-svn-id: svn://svn.chromium.org/blink/trunk@83196 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Darin Adler. WebKitTestRunner needs layoutTestController.isPageBoxVisible https://bugs.webkit.org/show_bug.cgi?id=42695 Unskip passed tests. * platform/mac-wk2/Skipped: * platform/qt-wk2/Skipped: 2011-04-07 Chang Shu <cshu@webkit.org> Reviewed by Darin Adler. WebKitTestRunner needs layoutTestController.isPageBoxVisible https://bugs.webkit.org/show_bug.cgi?id=42695 * WebProcess/InjectedBundle/API/c/WKBundle.cpp: (WKBundleIsPageBoxVisible): * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: * WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::isPageBoxVisible): * WebProcess/InjectedBundle/InjectedBundle.h: 2011-04-07 Chang Shu <cshu@webkit.org> Reviewed by Darin Adler. WebKitTestRunner needs layoutTestController.isPageBoxVisible https://bugs.webkit.org/show_bug.cgi?id=42695 * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::isPageBoxVisible): * WebKitTestRunner/InjectedBundle/LayoutTestController.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83195 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
enrica@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=58055 <rdar://problem/8862023> Reviewed by Oliver Hunt. Adding support for execCommand('undo') and execCommand('redo') in WebKit2 for Mac. * UIProcess/API/mac/PageClientImpl.h: * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::canUndoRedo): Added interaction with undomanager. (WebKit::PageClientImpl::executeUndoRedo): Added interaction with undomanager. Added new empty PageClient methods for other platforms. * UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::canUndoRedo): (QWKPagePrivate::executeUndoRedo): * UIProcess/API/qt/qwkpage_p.h: * UIProcess/PageClient.h: * UIProcess/gtk/WebView.cpp: (WebKit::WebView::canUndoRedo): (WebKit::WebView::executeUndoRedo): * UIProcess/gtk/WebView.h: * UIProcess/win/WebView.cpp: (WebKit::WebView::canUndoRedo): (WebKit::WebView::executeUndoRedo): * UIProcess/win/WebView.h: * UIProcess/WebEditCommandProxy.cpp: (WebKit::WebEditCommandProxy::unapply): Added flag to allow dispatching of asychronous messages while waiting for a sync message reply. (WebKit::WebEditCommandProxy::reapply): Same as above. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::canUndoRedo): (WebKit::WebPageProxy::executeUndoRedo): * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * WebProcess/WebCoreSupport/WebEditorClient.cpp: Added missing implementation. (WebKit::WebEditorClient::canUndo): (WebKit::WebEditorClient::canRedo): (WebKit::WebEditorClient::undo): (WebKit::WebEditorClient::redo): LayoutTests: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac). https://bugs.webkit.org/show_bug.cgi?id=58055 <rdar://problem/8862023> Reviewed by Oliver Hunt. * platform/mac-wk2/Skipped: Remove skipped tests related to undo/redo. git-svn-id: svn://svn.chromium.org/blink/trunk@83194 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
rdar://problem/9250368https://bugs.webkit.org/show_bug.cgi?id=58062beidson@apple.com authored
Reviewed by Maciej Stachowiak. * UIProcess/API/C/WKIconDatabase.cpp: (WKIconDatabaseClose): * UIProcess/API/C/WKIconDatabase.h: * UIProcess/WebIconDatabase.cpp: (WebKit::WebIconDatabase::close): * UIProcess/WebIconDatabase.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83193 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
barraclough@apple.com authored
Reviewed by Geoff Garen. And remove some uncalled functions from JSImmediate.h * jit/JITInlineMethods.h: (JSC::JIT::emitTagAsBoolImmediate): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_not): * runtime/JSImmediate.h: (JSC::JSImmediate::makeInt): (JSC::JSImmediate::makeBool): (JSC::JSImmediate::intValue): (JSC::JSImmediate::boolValue): (JSC::JSImmediate::asInt32): (JSC::JSImmediate::toDouble): (JSC::JSValue::asInt32): (JSC::JSValue::isUInt32): (JSC::JSValue::asUInt32): git-svn-id: svn://svn.chromium.org/blink/trunk@83192 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Eric Carlson. Add tests for parsing codecs parameter in video-can-play-type.html https://bugs.webkit.org/show_bug.cgi?id=53275 * media/video-can-play-type-expected.txt: * media/video-can-play-type.html: 2011-04-07 Nancy Piedra <nancy.piedra@nokia.com> Reviewed by Eric Carlson. Parse quotes from content type parameters https://bugs.webkit.org/show_bug.cgi?id=53275 This functionality is tested in video-can-play-type.html layout test where I've added codecs parameter with good and bad formatting. * platform/ContentType.cpp: (WebCore::ContentType::parameter): git-svn-id: svn://svn.chromium.org/blink/trunk@83191 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: remove "enabled" from the setBreakpoint protocol. https://bugs.webkit.org/show_bug.cgi?id=58047 * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::hasBreakpoint): * bindings/v8/DebuggerScript.js: (): * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setBreakpoint): * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::buildObjectForBreakpointCookie): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::continueToLocation): (WebCore::InspectorDebuggerAgent::didParseSource): * inspector/InspectorDebuggerAgent.h: * inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpoint::ScriptBreakpoint): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger): (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._reset): (WebInspector.PresentationBreakpoint): git-svn-id: svn://svn.chromium.org/blink/trunk@83190 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=58059 Adding this test to the mac-wk2 skipped list to get the bots green. * platform/mac-wk2/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83189 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
jberlin@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=57862 Reviewed by Adam Roben. Part 3: Implement checkSpellingOfString In WebCore, checkTextOfParagraph is only defined and used on platforms where WTF_USE_UNIFIED_TEXT_CHECKING is defined (which right now is only non-Leopard and non-Tiger Mac builds). On other platforms, checkSpellingOfString and checkGrammarOfString (coming in a separate patch in an attempt to keep things easier to review) are used. * UIProcess/API/C/win/WKTextChecker.h: * UIProcess/TextChecker.h: Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add checkSpellingOfString. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::checkTextOfParagraph): Surround this by #if USE(UNIFIED_TEXT_CHECKING). (WebKit::WebPageProxy::checkSpellingOfString): Call through to the client. * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add checkSpellingOfString. * UIProcess/win/TextCheckerWin.cpp: (WebKit::TextChecker::checkSpellingOfString): Call through to the WebTextCheckerClient. * UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::checkTextOfParagraph): Surround this by #if USE(UNIFIED_TEXT_CHECKING) for clarity. (WebKit::TextChecker::checkSpellingOfString): Add a call to notImplemented. * UIProcess/qt/TextCheckerQt.cpp: (WebKit::TextChecker::checkSpellingOfString): Ditto, and remove the implementation for checkTextOfParagraph. * UIProcess/gtk/TextCheckerGtk.cpp: (WebKit::TextChecker::checkSpellingOfString): Ditto. * UIProcess/win/WebTextCheckerClient.cpp: (WebKit::WebTextCheckerClient::checkSpellingOfString): * UIProcess/win/WebTextCheckerClient.h: * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::checkSpellingOfString): Send a sync message to the UI Process (similar to the sync message used for checkTextOfParagraph). git-svn-id: svn://svn.chromium.org/blink/trunk@83188 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
enne@google.com authored
[chromium] Unreviewed, now that bug 57975 is fixed, mark test as passing. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83187 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
bweinstein@apple.com authored
* platform/mac-leopard/fast/blockflow/text-orientation-basic-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83186 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
kov@webkit.org authored
Reviewed by Martin Robinson. [GTK] Need a way to get the path to a WebKitWebPlugin https://bugs.webkit.org/show_bug.cgi?id=57968 Expose the path of the plugin through the WebKitWebPlugin object. * webkit/webkitwebplugin.cpp: (webkit_web_plugin_get_path): * webkit/webkitwebplugin.h: * webkit/webkitwebpluginprivate.h: git-svn-id: svn://svn.chromium.org/blink/trunk@83185 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Benjamin Poulain. [Qt] QWebFrame::setUrl works only from second time if url fragment is present https://bugs.webkit.org/show_bug.cgi?id=32723 When clearing the frame, instead of using the URL passed to QWebFrame::setUrl(), use an invalid URL (the begin() without arguments). Clearing the document with the same URL was causing problems when we had a fragment because it assume that only scrolling was enough and did not loaded the document again. When setUrl() is called but fails, url() is expected to return the requested value. The begin(url) guaranteed that before. This patch adds a member to track the URL, which is updated when the URL changes and also when setUrl() is called. KURL was used for the member so that when setUrl() is called, and then url() is checked before the page gets loaded, we perform the same conversion that will be performed by a successful load, e.g. add trailing '/' to an address. This behavior is checked by tst_QWebFrame::requestedUrl() test. For the record: the second QWebPage::setUrl() worked because the load was considered a FrameLoadTypeSame, and because of that, was not fit for just scrolling, a reload was needed. See FrameLoader::shouldScrollToAnchor() for details on this classification. * Api/qwebframe.cpp: (QWebFramePrivate::emitUrlChanged): update our URL member and emit the signal. (clearCoreFrame): (isCoreFrameClear): (QWebFrame::setUrl): (QWebFrame::url): (QWebFrame::baseUrl): look in the document for the baseURL since its contents can change the baseURL, e.g. by using the <base> tag. * Api/qwebframe_p.h: * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientQt::dispatchDidCommitLoad): * tests/qwebframe/tst_qwebframe.cpp: (tst_QWebFrame::setUrlWithFragment): unskip test. git-svn-id: svn://svn.chromium.org/blink/trunk@83184 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
enne@google.com authored
[chromium] Unreviewed, rebaseline tests changed in r82947. * platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added. * platform/chromium-linux/svg/text/text-midpoint-split-bug-expected.png: Added. * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added. * platform/chromium-mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added. * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added. * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added. * platform/chromium-win/svg/text/text-midpoint-split-bug-expected.png: Added. * platform/chromium-win/svg/text/text-midpoint-split-bug-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83183 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
scheib@chromium.org authored
Flagging platform/chromium/compositing/huge-layer-rotated.html a bug. * platform/chromium/test_expectations.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83182 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Reviewed by Eric Seidel. editing/inserting/6633727.html should be renamed and converted into a dump-as-markup test https://bugs.webkit.org/show_bug.cgi?id=58037 Renamed 6633727.html to insert-paragraph-at-end-of-line.html and converted it to a dump-as-markup test. * editing/inserting/6633727-expected.txt: Removed. * editing/inserting/6633727.html: Removed. * editing/inserting/insert-paragraph-at-end-of-line-expected.txt: Added. * editing/inserting/insert-paragraph-at-end-of-line.html: Copied from LayoutTests/editing/inserting/6633727.html. * editing/inserting/script-tests/6633727.js: Removed. git-svn-id: svn://svn.chromium.org/blink/trunk@83181 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
mitz@apple.com authored
Reviewed by Adam Roben. * rendering/RenderInline.cpp: (WebCore::RenderInline::updateAlwaysCreateLineBoxes): No need to compare line gap values, as this is covered by the earlier hasIdenticalAscentDescentAndLineGap() check. git-svn-id: svn://svn.chromium.org/blink/trunk@83180 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
commit-queue@webkit.org authored
Reviewed by Laszlo Gombos. [Qt][Symbian] Enable webkit build with GCCE on Symbian. https://bugs.webkit.org/show_bug.cgi?id=57841 * wtf/MathExtras.h: GCCE compiler doesn't support those std static functions. 2011-04-07 Liang Qi <liang.qi@nokia.com> Reviewed by Laszlo Gombos. [Qt][Symbian] Enable webkit build with GCCE on Symbian. https://bugs.webkit.org/show_bug.cgi?id=57841 * WebCore.pri: Thanks for Norbert Leser <norbert.leser@nokia.com> who checked RVCT part. --rw-base value in QMAKE_LFLAGS.ARMCC and -Tdata value in QMAKE_LFLAGS.GCCE are updated to 0x1000000 together. They need to be updated in the future when WebKit grows. git-svn-id: svn://svn.chromium.org/blink/trunk@83179 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
commit-queue@webkit.org authored
Reviewed by Laszlo Gombos. [Qt][WK2][Symbian] Temporary build fix until native Symbian IPC is done. Implement fake socketpair() as it's not available. https://bugs.webkit.org/show_bug.cgi?id=57877 * UIProcess/Launcher/qt/ProcessLauncherQt.cpp: (WebKit::socketpair): socketpair() which returns -1 git-svn-id: svn://svn.chromium.org/blink/trunk@83178 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
msaboff@apple.com authored
Reviewed by Maciej Stachowiak. WebKit2: Memory leak in decodeResourceError https://bugs.webkit.org/show_bug.cgi?id=58004 Release the local NSError after it is used to create a ResourceError object assigned to the reference argument. * Shared/mac/WebCoreArgumentCodersMac.mm: (CoreIPC::decodeResourceError): git-svn-id: svn://svn.chromium.org/blink/trunk@83177 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: get rid of Breakpoint.js. https://bugs.webkit.org/show_bug.cgi?id=57949 * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * inspector/front-end/Breakpoint.js: Removed. * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint.didLoadSnippet): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.updateBreakpoint): (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel): (WebInspector.DebuggerModel.prototype._debuggerWasDisabled): (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpoint): (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype.removeBreakpoint): (WebInspector.DebuggerModel.prototype._breakpointResolved): (WebInspector.DebuggerModel.prototype.reset): * inspector/front-end/DebuggerPresentationModel.js: (WebInspector.DebuggerPresentationModel): (WebInspector.DebuggerPresentationModel.prototype._refreshBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit): (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.didSetBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled): (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint): (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping): (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded): (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved): (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoint): (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints): (WebInspector.DebuggerPresentationModel.prototype._reset): (WebInspector.PresentationBreakpoint): (WebInspector.PresentationBreakpoint.prototype.get sourceFile): (WebInspector.PresentationBreakpoint.prototype.get url): (WebInspector.PresentationBreakpoint.prototype.get resolved): (WebInspector.PresentationBreakpoint.prototype.loadSnippet): * inspector/front-end/ResourceTreeModel.js: (WebInspector.ResourceTreeModel): (WebInspector.ResourceTreeModel.prototype._onResourceStarted): (WebInspector.ResourceTreeModel.prototype._addResourceToFrame): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype._breakpointUpdated): (WebInspector.ScriptsPanel.prototype.reset): * inspector/front-end/WebKit.qrc: * inspector/front-end/inspector.html: git-svn-id: svn://svn.chromium.org/blink/trunk@83176 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: console messages names should adhere to the common naming style https://bugs.webkit.org/show_bug.cgi?id=58042 * inspector/protocol/console-agent-expected.txt: 2011-04-07 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. Web Inspector: console messages names should adhere to the common naming style https://bugs.webkit.org/show_bug.cgi?id=58042 * inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole): * inspector/Inspector.json: * inspector/InspectorConsoleAgent.cpp: (WebCore::InspectorConsoleAgent::clearConsoleMessages): * inspector/front-end/ConsoleView.js: (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageAdded): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messageRepeatCountUpdated): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.messagesCleared): (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher): git-svn-id: svn://svn.chromium.org/blink/trunk@83175 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import. git-svn-id: svn://svn.chromium.org/blink/trunk@83174 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
philn@webkit.org authored
Unreviewed, unskip a fast/xmlhttprequest test passing on GTK. * platform/gtk/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83173 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
ossy@webkit.org authored
* platform/qt-wk2/Skipped: git-svn-id: svn://svn.chromium.org/blink/trunk@83172 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
loislo@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: migrate Inspector protocol messages format to JSON-RPC. https://bugs.webkit.org/show_bug.cgi?id=57957 There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec. Also JSON-RPC has a pretty clear specification for error descriptions which we haven't. It was decided that we will use it. the list of renames: 1) type-> /dev/null 2) domain + '.' + event => method // for events 3) domain + '.' + command => method // for requests 4) requestId => id // for responses 5) arguments => params // for requests 6) data => params // for events 7) body => result // for responses protocolErrors and error properties will be converted to JSON-RPC error format. The order of properties in messages also will be adjusted. The only thing that looks unnecessary is jsonrpc property. * inspector/protocol/console-agent-expected.txt: * inspector/protocol/runtime-agent-expected.txt: * inspector/report-API-errors-expected.txt: * inspector/report-API-errors.html: * inspector/report-protocol-errors-expected.txt: * inspector/report-protocol-errors.html: 2011-04-06 Ilya Tikhonovsky <loislo@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: migrate Inspector protocol messages format to JSON-RPC. https://bugs.webkit.org/show_bug.cgi?id=57957 There is not a significant difference between inspector messages spec and and JSON-RPC 2.0 messages spec. Also JSON-RPC has a pretty clear specification for error descriptions which we haven't. It was decided that we will use it. the list of renames: 1) type-> /dev/null 2) domain + '.' + event => method // for events 3) domain + '.' + command => method // for requests 4) requestId => id // for responses 5) arguments => params // for requests 6) data => params // for events 7) body => result // for responses protocolErrors and error properties will be converted to JSON-RPC error format. The order of properties in messages also will be adjusted. The only thing that looks unnecessary is jsonrpc property. * inspector/CodeGeneratorInspector.pm: git-svn-id: svn://svn.chromium.org/blink/trunk@83171 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks]. (Unfortunately the buildbot documentation does not make this clear.) finished() is the only hook we have, so we have to do our work there. I added a new addCustomURLs method which can be overridden by subclasses to provide extra URLs before we call up to the base class (after which adding more URLs is no longer possible). Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page Reviewed by John Sullivan. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here... (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that method is never called for MasterShellCommands. (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called) with this method (which is). git-svn-id: svn://svn.chromium.org/blink/trunk@83170 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Not reviewed: rolling chromium DEPS 80421:80767. * DEPS: git-svn-id: svn://svn.chromium.org/blink/trunk@83169 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
aroben@apple.com authored
This matches how most of our other build steps work, so is good just for improving consistency between build steps. It should also make it possible for ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were trying to do this in finished() after we had called up to the base class, but that was apparently too late to add more URLs.) Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page Reviewed by John Sullivan. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (ExtractTestResults): Added a descriptionDone property so that we don't have to manually call setText to get the right text to show up for this step. This matches how most of our other build steps work. (ExtractTestResults.commandComplete): Replaced our override of finished with this function. This is how most of our other build steps work. (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this function, to match the base class. git-svn-id: svn://svn.chromium.org/blink/trunk@83168 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
pfeldman@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Chromium] Rename didReceiveData2 to didReceiveData as part of enabling transfer size support. https://bugs.webkit.org/show_bug.cgi?id=58036 Renamed didReceiveData2 to didReceiveData. * public/WebURLLoaderClient.h: (WebKit::WebURLLoaderClient::didReceiveData): * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): * src/ResourceHandle.cpp: (WebCore::ResourceHandleInternal::didReceiveData): git-svn-id: svn://svn.chromium.org/blink/trunk@83167 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
pfeldman@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: [Chromium] Migrate didReceiveData in upstream for plugins as part of enabling transfer size support. https://bugs.webkit.org/show_bug.cgi?id=58034 Migrated didReceiveData to support new lengthReceived parameter. * src/AssociatedURLLoader.cpp: (WebKit::AssociatedURLLoader::ClientAdapter::didReceiveData): git-svn-id: svn://svn.chromium.org/blink/trunk@83166 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
rniwa@webkit.org authored
Reviewed by Eric Seidel. Add functions to update left and right offsets to LineOffsets https://bugs.webkit.org/show_bug.cgi?id=58028 Added update() and shrinkWidthForNewFloatIfNeeded(FloatingObject*) to LineOffsets, which are used to update m_left and m_right. Also added m_block and m_isFirstLine member variables to LineOffsets so that users of LineOffsets don't have to pass them around. * rendering/RenderBlock.h: * rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::skipLeadingWhitespace): No longer passes firstLine to positionNewFloatOnLine. (WebCore::LineOffsets::LineOffsets): Takes RenderBlock* and isFirstLine instead of left and right offsets. (WebCore::LineOffsets::update): Extracted from findNextLineBreak and positionNewFloatOnLine. (WebCore::LineOffsets::shrinkWidthForNewFloatIfNeeded): Extracted from positionNewFloatOnLine. (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine. (WebCore::RenderBlock::positionNewFloatOnLine): Calls shrinkWidthForNewFloatIfNeeded and update and no longer passes firstLine around. git-svn-id: svn://svn.chromium.org/blink/trunk@83165 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: migrate debugger domain to the unified breakpoint location notion. https://bugs.webkit.org/show_bug.cgi?id=57928 * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::buildObjectForBreakpointCookie): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::resolveBreakpoint): (WebCore::InspectorDebuggerAgent::didParseSource): * inspector/InspectorDebuggerAgent.h: * inspector/front-end/Breakpoint.js: (WebInspector.Breakpoint): * inspector/front-end/DebuggerModel.js: (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId): (WebInspector.DebuggerModel.prototype._breakpointResolved): git-svn-id: svn://svn.chromium.org/blink/trunk@83164 bbb929c8-8fbe-4397-9dbb-9b2b20218538 -
tkent@chromium.org authored
[Chromium] Move Leopard-specific images to chromium-mac-leopard, and unify text results common in chromium-mac. * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.checksum: Added. * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png: Added. * platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.txt: Removed. * platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.checksum: Added. * platform/chromium-mac-leopard/fast/speech/input-appearance-searchandspeech-expected.png: Added. * platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt: git-svn-id: svn://svn.chromium.org/blink/trunk@83163 bbb929c8-8fbe-4397-9dbb-9b2b20218538
-
