- 07 Feb, 2019 24 commits
-
-
Nigel Tao authored
BUG=826982 Change-Id: I12fd7ed12431a8d89c0fd3f7070cbeb8b1bd3ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1455837 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#629811}
-
Leo Zhang authored
Export 2 functions so the XKB extension can handle messages in text or protobuf format from Engine side. Bug:837156 TBR=shuchen Change-Id: I5cdd77818f4e0692d99743d02436f0e00d63edd0 Reviewed-on: https://chromium-review.googlesource.com/c/1448082Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#629810}
-
Ahmed Fakhry authored
We used to use default sunset / sunrise times (6pm to 6am) whenever we couldn't retrieve a valid geoposition. This led to a bad user experience and confusion, especially in the event when there's no connectivity. Now we store the most recent valid geoposition in the user's prefs, and use it only until a valid geoposition is available. We make sure that these cached values don't leak from one user to another. BUG=923713,928994 TEST=Added a new test. Change-Id: I613df0ced6f474d11ec52dba3a3766582ed3d02e Reviewed-on: https://chromium-review.googlesource.com/c/1450838Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#629809}
-
Justin Cohen authored
Sometimes the underlying ios/web page used for the NTP (about://newtab) takes a long time to load. Loading any page before the newtab is committed will leave ios/web in a bad state. Instead, block any most visited and content suggestion taps until the underlying NTP is committed. See: crbug.com/925304 for more context. Remove this when ios/web supports queueing multiple loads during this state. Bug: 929148 Change-Id: I78bf8c58127c19f96432e68510c1565ad4b6d973 Reviewed-on: https://chromium-review.googlesource.com/c/1456645Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#629808}
-
Jun Mukai authored
Bug: 826614 Test: exo_unittests Change-Id: Ia2fe9a39c38b0ea93d1f0a0f5aa820536a656a08 Reviewed-on: https://chromium-review.googlesource.com/c/1399722 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#629807}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/971e4cb2b43d..f0a00cd7f17b git log 971e4cb2b43d..f0a00cd7f17b --date=short --no-merges --format='%ad %ae %s' 2019-02-06 dhanyaganesh@chromium.org build_status_lib: Replace cidb handle with buildstore argument 2019-02-06 dhanyaganesh@chromium.org BuildStore: add an optional argument 'for_service' to __init__ 2019-02-06 evanhernandez@chromium.org cros_branch_unittest: Comment tests. 2019-02-06 evanhernandez@chromium.org cros_branch_unittest: Simplify all tests. 2019-02-06 evanhernandez@chromium.org cros branch: Support create from local manifest. 2019-02-06 evanhernandez@chromium.org cross branch: Sync happens in BranchCommand class. Created with: gclient setdep -r src/third_party/chromite@f0a00cd7f17b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7528b9f3c338eae12af8ff69ee41a40a326836a5 Reviewed-on: https://chromium-review.googlesource.com/c/1456611Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#629806}
-
Garrett Beaty authored
Bug: 925575 Change-Id: Ia337a7a22f1b60523257e6eb037536b7ef55bf15 Reviewed-on: https://chromium-review.googlesource.com/c/1457220 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#629805}
-
Alex Khouderchah authored
Prior to chromeos CL:1452314, shill used kFailureUnknown to represent both unknown failures and no failure. Consequently, the metrics we collect on connection failures suffer from this ambiguity as well. This change modifies the ConnectionFailureReason enum such that these two cases can be distinguished. In order to preserve historical data for of other failure values, we deprecate the existing unknown failure value and create two new values, rather than simply renaming the enum entirely. BUG=chromium:596197 Change-Id: Icdcc91365a1fd5c26a0ddd999e81b99a7a984a84 Reviewed-on: https://chromium-review.googlesource.com/c/1457123Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Alex Khouderchah <akhouderchah@chromium.org> Auto-Submit: Alex Khouderchah <akhouderchah@chromium.org> Cr-Commit-Position: refs/heads/master@{#629804}
-
Steven Bennetts authored
This CL moves the logic in network_icon::GetDefaultNetworkImageAndLabel, which currently makes multiple calls to fetch the active networks when a default icon is required (tray and feature pod) and moves it to a separate ActiveNetworkIcon class owned by the system tray model. Note: There should be no behavior changes with this CL. Bug: 923444 Change-Id: I79c3d6a30c2d48079dd3f237c9e2ff27fdae38fe Reviewed-on: https://chromium-review.googlesource.com/c/1447318 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#629803}
-
Dmitry Gozman authored
This patch makes RenderFrameImpl load the full mhtml response body before trying to commit it. This is required for synchronous commit (see doc linked to the bug, steps 8.a and 8.b), because we have to parse the archive to retrieve the main resource and its mime type and commit a correct document type. Brief summary: - Introduced MHTMLBodyLoader which consumes data from existing NavigationBodyLoader and puts it all to WebNavigationParams. - Split RenderFrameImpl::CommitNavigationWithParams from CommitNavigationInternal so that we can commit mhtml after loading the response asynchronously. Most of the time we just call CommitNavigationWithParams synchronously. - DocumentLoader now tries to commit mhtml synchronously, and loads empty document if that fails (similarly to archive parsing failure). Bug: 855189 Change-Id: Id27a4e593c1586e1f48591ee0685fdb93aaf8827 Reviewed-on: https://chromium-review.googlesource.com/c/1408351 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629802}
-
Zhongyi Shi authored
Currently when running with --v=1, all the flags are printed whenever QUIC_RELOADABLE_FLAG_COUNT* is hit, a single flag may be printed multiple times and is not very useful most of the time. Change-Id: Icc8e702a4b5855b243a1d72337d03e924e7d2756 Reviewed-on: https://chromium-review.googlesource.com/c/1456952 Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#629801}
-
Zhenyao Mo authored
They become obsolete after https://chromium-review.googlesource.com/c/chromium/src/+/1448518 BUG=924148 TEST=bots R=piman@chromium.org,dcheng@chromium.org Change-Id: I0ad5995caf4ea94c76712d76380072a28a5daeed Reviewed-on: https://chromium-review.googlesource.com/c/1450836Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
The test was added in crrev.com/c/1446869 but has been flaky on Mac. Also add "Pass" as an acceptable outcome for RTCPeerConnection-track-stats.https.html. TBR=rtoy@chromium.org Bug: 929435 Change-Id: I37ef496d7d6f382ffad5dc8d75935d9faba8e225 Reviewed-on: https://chromium-review.googlesource.com/c/1457222 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#629799}
-
Clark DuVall authored
This reverts commit 11f8a9d4. Reason for revert: The crash still showed up in canary, and I have a better (simpler) fix for this. Original change's description: > Fix webRequest issues with redirects and extraHeaders listeners > > This is an alternative fix for http://crbug.com/918761, since the > original fix in http://crrev.com/c/1409915 caused some other issues and > had to be reverted (see http://crbug.com/926606). > > There are two issues that this fixes, both have regression tests in > this CL: > > (1) If a request using extraHeaders was redirected, it's possible the > OnBeforeSendHeaders event can come in from //net before > OnBeforeRequest has finished running on the newly redirected URL. This > was the cause of the crash, because it could cause situations like: > - request made to a.com > - redirect to b.com > - blocking listener running for OnBeforeRequest on b.com > - //net sends OnBeforeSendHeaders for b.com > - OnBeforeSendHeaders listener runs for b.com <- bad, should wait until > we know if OnBeforeRequest will cancel/redirect the request > - OnBeforeRequest finishes for b.com, may redirect the request and run > OnBeforeSendHeaders again before the bogus one is done > > This is fixed by holding the OnBeforeSendHeaders event until we know > OnBeforeRequest is finished, and canceling the old request if there is > a redirect. > > (2) If a request without a listener using extraHeaders redirects to a > request with a listener using extraHeaders, the listeners for the > redirected request will not get the additional headers. > > This is fixed by always using the extraHeaders path if there is any > extraHeaders listeners registered for the context. > > Bug: 918761 > Change-Id: I879ee6a78d34348fc15a80c27613b7ffbe66e749 > Reviewed-on: https://chromium-review.googlesource.com/c/1446367 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628905} TBR=rockot@google.com,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 918761 Change-Id: Ie054dc4a84d05a69f982d41f158e7bfe23bb12ff Reviewed-on: https://chromium-review.googlesource.com/c/1457216Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629798}
-
Kevin McNee authored
We believe that this issue is now fixed, so we'll re-enable this DumpWithoutCrashing to confirm that there are no more occurrences of this. Bug: 828422 Change-Id: I3ab2b9b949ee50bf15d883b86a938bde46eafa9c Reviewed-on: https://chromium-review.googlesource.com/c/1456875 Commit-Queue: Nasko Oskov <nasko@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#629797}
-
Alan Cutter authored
The methods BrowserNonClientFrameView::ShouldPaintAsThemed() and BrowserFrame::ShouldUseTheme() are used for the same purpose and have equivalent behaviour. This CL replaces ShouldPaintAsThemed() with ShouldUseTheme() to avoid divergence in behaviour. This is a follow up clean up CL to https://chromium-review.googlesource.com/c/chromium/src/+/1453558. There are no changes in behaviour in this patch. Bug: 927381 Change-Id: I2f4f28a79d0b24395057cb13f58ef8f56508ad20 Reviewed-on: https://chromium-review.googlesource.com/c/1453217 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#629796}
-
Jazz Xu authored
Enable native controls in Cros player by default. Remove integration tests for old controls. Bug: 909963 Change-Id: I40a08bfd51ab757ac74c14dbbf80129764670c19 Reviewed-on: https://chromium-review.googlesource.com/c/1427575Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#629795}
-
Lei Zhang authored
Change-Id: I7cca1653fff5f990785d7c1cf28e83a6d96ba26e Reviewed-on: https://chromium-review.googlesource.com/c/1456981 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Wez authored
Migrate callsites from ComponentContext/zx::channel to strongly-typed APIs and ServiceDirectoryClient. Bug: 920920 Change-Id: I8fe642112562e3e75ad7230d55415d05e35b6cf8 Reviewed-on: https://chromium-review.googlesource.com/c/1450587 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#629793}
-
kyle Ju authored
This CL creates a WPT WebDriver Test Runner that is able to run WPT Webdriver tests against ChromeDriver. This allows us to detect whether the chromedriver current APIs and any future change to chromedriver consistently meet standardized WebDriver specifications. Design doc: https://docs.google.com/document/d/1VvVmKbr-AKJa4pl_hORStJe0r6IM6AbzbP2sCtKgibk/edit?ts=5be0d7e7# No-Export: True Change-Id: If8491519c81a2284d8c1e873f3461383879072d3 Bug: 881513 Reviewed-on: https://chromium-review.googlesource.com/c/1368404Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#629792}
-
Alexei Filippov authored
It was accidentally disabled by r627247. Change-Id: I847a40d3350cad56c4967af850a93e854ae15614 Reviewed-on: https://chromium-review.googlesource.com/c/1457007 Auto-Submit: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629791}
-
Karan Bhatia authored
This CL changes the install warnings and errors to use the rule id whenever possible (instead of the rule index). Also, now the rule index is one-based. BUG=926609 Change-Id: Ie7046aa328817cf9cf45c4e0171d31fcec9efcc6 Reviewed-on: https://chromium-review.googlesource.com/c/1455642 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#629790}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/10ef8b33f128..82f670fd3d37 git log 10ef8b33f128..82f670fd3d37 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 primiano@google.com Merge "Add notify_traceur option" Created with: gclient setdep -r src/third_party/perfetto@82f670fd3d37 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic9ccb7fc28e455d9a67c8d9ce3baf2f28a742f10 Reviewed-on: https://chromium-review.googlesource.com/c/1456764Reviewed-by:
-
Karan Bhatia authored
This CL improves the install warnings for manifest rules which can't be parsed. To do this enable error generation for the Declarative Net Request API. Another side effect of this is that rules with unknown keys are now ignored (with an install warning), instead of being parsed correctly. Generate code diff- https://www.diffchecker.com/9d55eAZ5 BUG=926609 Change-Id: I695225f8dd8e96366d6462d31414402d0b14c4f4 Reviewed-on: https://chromium-review.googlesource.com/c/1454085 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#629788}
-
- 06 Feb, 2019 16 commits
-
-
Jamie Walch authored
The old behaviour was to give the user a link directly to the auth page, I think because that page used to display the auth code once the user completed the OAuth flow. It doesn't do that any more, so although a user could technically work it out from the redirect URL parameters, it's not very useful, so I've just made code a mandatory command-line option, and provide a link to the website if it isn't present. Change-Id: Ibbf56da86762688f7015cf2f09d499686e04f184 Reviewed-on: https://chromium-review.googlesource.com/c/1457224Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#629787}
-
chaopeng authored
Users report touchpad sometime stop working. But it can not reproduce on our side. I suspected the issue maybe: 1. Direct Manipulation failed at initialize 2. Direct Manipulation on incorrect state similar to issue 847611 3. Chrome does not cover some state transition for Direct Manipulation In this patch, we add logs behind feature flag PrecisionTouchpadLogging to help us debug. We use feature flag instead of VLOG because VLOG is not working on Windows (issue 440172). Bug: 914914 Change-Id: I02a28418914f18558667666f9e0779cb8d4d2eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1450612 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#629786}
-
Dale Curtis authored
All bugs reported from the first landing are now fixed. Fingers crossed that covers all of them! BUG=924370 TBR=liberato Change-Id: I26b178a07b8b08b13f7946a327e36eee9e8c7372 Reviewed-on: https://chromium-review.googlesource.com/c/1457021Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#629785}
-
Akihiro Ota authored
Bug: 927910 Change-Id: Ie38157fb762da4963bba213caad1db3cbfabc515 Reviewed-on: https://chromium-review.googlesource.com/c/1450227 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#629784}
-
Noel Gordon authored
The C++11 standard provides a portable high-resolution monotonic clock for time duration measurements, and it has worked well for zlib_bench. Use that steady clock [1] for image_decode_bench. [1] https://en.cppreference.com/w/cpp/chrono/steady_clock Bug: 601198 Change-Id: I60903a1b11a5481621815df586ddfb49822b2e67 Reviewed-on: https://chromium-review.googlesource.com/c/1453396Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#629783}
-
Kim Paulhamus authored
Three error states (timeout, keyNotRegistered, and keyAlreadyRegistered) were previously considered 'postmortem' states. This meant that dialogs corresponding to these states would be shown after a request was finished and after a DOMException was sent to the RP. This CL changes those states to instead block resolution of the request until the user acknowledges the dialog, and then close the request. Reworded 'postmortem' references to 'awaiting user acknowledgement' to better reflect this behavior. Bug: 897757 Change-Id: I04330f5a87ebbc960cd4c1e8d2c1b65fe97d9cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1428879 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#629782}
-
Sunny Sachanandani authored
This reverts commit 311d14e9. Relanding after fixing some color space issues in crrev.com/c/1389504, and adding pixel tests for the now disabled code paths. Original change's description: > Revert "Enable decode swap chain feature on waterfall" > > This reverts commit e1f01a15. > > Reason for revert: Makes video pixel tests flaky: crbug.com/917399 > > Original change's description: > > Enable decode swap chain feature on waterfall > > > > Enables DirectCompositionUseNV12DecodeSwapChain and D3D11VideoDecoder > > features on waterfall. > > > > Bug: 848093 > > Change-Id: I561f5910a32cbe2adb1c47bd9c35df355bdce1a4 > > Reviewed-on: https://chromium-review.googlesource.com/c/1364341 > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Reviewed-by: Ilya Sherman <isherman@chromium.org> > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#618447} > > TBR=isherman@chromium.org,sunnyps@chromium.org,liberato@chromium.org > > Change-Id: I13cb41b59140475eb46e789e8c94fc4e610ab614 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 848093, 917399 > Reviewed-on: https://chromium-review.googlesource.com/c/1388645 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#618549} TBR=isherman@chromium.org,sunnyps@chromium.org,liberato@chromium.org Bug: 848093, 917399, 927901 Change-Id: Iae0e57e4d2abb0332a42d37b51763e2a19bb5190 Reviewed-on: https://chromium-review.googlesource.com/c/1453576Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#629781}
-
Bruce Dawson authored
The 17763 version of d3dcompiler_47.dll requires ucrtbase.dll. Change crrev.com/c/1450414 switched to this new version of d3dcompiler_47.dll and adjusted the DLLs we ship in isolates but in the debug case it only shipped ucrtbased.dll, not ucrtbase.dll. This fixes that. Local testing shows that angle_end2end_tests.isolate now always contains ucrtbase.dll. Bug: 929295, 920704 Change-Id: I3bb64dde923407e94404073b8f8f9bfd57692eac Reviewed-on: https://chromium-review.googlesource.com/c/1457018Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#629780}
-
Kevin Strohbehn authored
Bug: 929430 Change-Id: I9718e3b37672bd53915479cbec43c03509efee16 Reviewed-on: https://chromium-review.googlesource.com/c/1457418Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#629779}
-
Emircan Uysaler authored
This CL adds more tests to WebRtcGetDisplayMediaBrowserTest covering audio cases. Bug: 896333 Change-Id: I6124237ceb43d18c3e3ecf9f2adc59b86952c19a Reviewed-on: https://chromium-review.googlesource.com/c/1450853Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#629778}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/117a1fd11f11..9b6ba4d1c57e git log 117a1fd11f11..9b6ba4d1c57e --date=short --no-merges --format='%ad %ae %s' 2019-02-06 33432579+alan-baker@users.noreply.github.com Allow arrayed storage images for NonWritable decoration (#2358) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9b6ba4d1c57e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If6816e4b22b1990c56d54e002acdfbf7305f620e Reviewed-on: https://chromium-review.googlesource.com/c/1456610Reviewed-by:
-
khachatryan authored
With the updated Java tests window maximize tests are now passing. Enabling these tests. Change-Id: I01c701564b8f668b9d660126d373e36df24c0a34 Reviewed-on: https://chromium-review.googlesource.com/c/1457204Reviewed-by:
-
Boris Sazonov authored
This CL updates margins in signin_view.xml to match the mocks. Bug: 927425 Change-Id: Ibe93a7768a041f8d93fe2d802e1097d2e4d3b81f Reviewed-on: https://chromium-review.googlesource.com/c/1456059 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#629775}
-
Miguel Casas authored
H264 GetNumReferenceFrames() was increased by 1 [1] for all platforms to circumvent a limitation during introduction of the kReduced mode; this CL: - Renames VaVDA::BufferAllocationMode::kReduced to kSuperReduced. - Takes that +1 out of h264_decoder - Introduces kReduced to represent this H264 case where we +1 the amount of media pipeline frames allocated. Note that this CL doesn't change ToT: there's an extra allocation in the # codec reference frames _and_ in the amount of pipeline buffers. Test results ToT: https://pastebin.com/YG1Tcgya With this change: https://pastebin.com/JgER07id and https://paste.googleplex.com/5473272024006656 (2nd round) - similar. This way, we can have all buffer amount calculations in one place, specially with a view to introducing kReduced for platforms < SkyLake. [1] https://cs.chromium.org/chromium/src/media/gpu/h264_decoder.cc?dr=C&sq=package:chromium&g=0&l=1428 TBR=hiroh@chromium.org (bc of http://crrev.com/c/1455302#message-3083834c541894c42a630b7fd73b6cd5095ce67e) Test: tast run DEVICE_IP video.PlaybackPerfH2642160P60FPS on a SkyLake device (cave) Bug: 912295, 920510 Change-Id: Ice286b1bd4db21f353d86cb9c65467e1322963be Reviewed-on: https://chromium-review.googlesource.com/c/1455302Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#629774}
-
Matt Menke authored
The link opens up the system diagnostics tool, if there is one. On Windows, URLs the diagnostics tool is used on is logged to disk. Bug: 929141 Change-Id: I4130279eec02e932cf846017bab2e8956d9b79f8 Reviewed-on: https://chromium-review.googlesource.com/c/1456685 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#629773}
-
Tatiana Buldina authored
Bug: chromedriver:2080 Change-Id: I9bbf0cdaf79c26ea6e83043b11698d39b0151579 Reviewed-on: https://chromium-review.googlesource.com/c/1457176Reviewed-by:
-
