GitLab

BUG=245025

Review URL: https://codereview.chromium.org/147613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248637 0039d316-1c4b-4281-b951-d872f2087c98

WebContentsImpl now owns ColorChooser instances. We shouldn't
reuse the instances.

BUG=none
R=keishi@chromium.org
TEST=none

Review URL: https://codereview.chromium.org/148203008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248636 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329549

Review URL: https://codereview.chromium.org/121343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248635 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248634 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=166324:166335&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/144483011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248633 0039d316-1c4b-4281-b951-d872f2087c98

R=nona@chromium.org
BUG=5027

Review URL: https://codereview.chromium.org/142193006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248632 0039d316-1c4b-4281-b951-d872f2087c98

The AppCacheHost is an object that persist across the lifetime of a document. It's created prior to the document and prior to the initiation of the resource load for the documents main resource. Today, when a cross-site xfer occurs the host is deleted and a new host is created that knows nothing of whats going on... so not surprisingly things are broken.

Either state of the old host that gets deleted needs to be saved and restored into a new host that gets created... or the old host should not get deleted and instead get transferred along as well.

I chose the latter because there's some state that can't be saved/restored so easily and moving the whole object is less tedious.

BUG=331270

Review URL: https://codereview.chromium.org/137883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248631 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338413
R=sky@chromium.org, sky

Review URL: https://codereview.chromium.org/130893009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248630 0039d316-1c4b-4281-b951-d872f2087c98

Print preview renderer expects valid integer in print ticket.

According https://developers.google.com/cloud-print/docs/cdd#Copies
  "copies" :{ }
is the same as 
  "copies" :{ "default": 1 }

BUG=340342

Review URL: https://codereview.chromium.org/144483010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248629 0039d316-1c4b-4281-b951-d872f2087c98

ChildFrameCompositingHelper had a raw pointer to WebPluginContainer, and
BrowserPluginManager, which is not safe. In another patch,
see https://codereview.chromium.org/140073002/, there is an access to the
container after it is deleted, which is causing a use-after-free
crash on the win_rel bot.

BUG=334531

Review URL: https://codereview.chromium.org/133233012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248628 0039d316-1c4b-4281-b951-d872f2087c98

Some websites can easily blow through the current 4096 limit. Instead of
imposing an arbitrary limit, let Skia attempt to allocate and handle
potential failures.

BUG=338865
R=nduca@chromium.org,pdr@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/145243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248627 0039d316-1c4b-4281-b951-d872f2087c98

No longer needed since non-aura is gone.

BUG=330735
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/145103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248626 0039d316-1c4b-4281-b951-d872f2087c98

The comments were not updated when the code changed, so they were
confusing.

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/138133015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248625 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves files that depend on the now-componentized data_type_controller.h
and data_type_manager.h into the sync_driver component. For the most part these
files are moved as-is. The only exception is sync_model_association_manager,
which had a DCHECK about being on BrowserThread::UI; this DCHECK is removed.

BUG=339726
TBR=joi

Review URL: https://codereview.chromium.org/133503011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248621 0039d316-1c4b-4281-b951-d872f2087c98

to ShelfID, ShelfItem and ShelfItems.


BUG=248353
TEST=None
R=jamescook@chromium.org,harrym@chromium.org

Review URL: https://codereview.chromium.org/152223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248619 0039d316-1c4b-4281-b951-d872f2087c98

For the error case:
- Hide the "You're now signed in to Chrome" title.
- Change "OK, got it!" to just "OK"

XIB changes:
- Connected the close (OK) button to the closeButton_ outlet, which was for some reason missing before.

Screenshots (disregard text of errors; samples were used):
- Mac: http://i.imgur.com/hPDAY8i.png
- Views: http://i.imgur.com/ZM9ktga.png
BUG=333988

Review URL: https://codereview.chromium.org/137563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248618 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248617 0039d316-1c4b-4281-b951-d872f2087c98

This picks up a fix needed for Telemetry's --netsim option.

BUG=
TBR=slamm@chromium.org

Review URL: https://codereview.chromium.org/131453004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248616 0039d316-1c4b-4281-b951-d872f2087c98

R=aedla@chromium.org
BUG=

Review URL: https://codereview.chromium.org/147533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248615 0039d316-1c4b-4281-b951-d872f2087c98

MemorySanitizer is confused by assembly code.

BUG=178409
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/139783016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248614 0039d316-1c4b-4281-b951-d872f2087c98

Update WebNode::getElementsByTagName() callers to use a WebNodeCollection
instead of a WebNodeList. The WebNode::getElementsByTagName() public API was
updated in Blink r166263 to return a WebNodeCollection instead of a
WebNodeList.

Callers need to be updated so that we can get rid of the current workaround
allowing a WebNodeList to be implicitly converted into a WebNodeCollection.

BUG=235008

Review URL: https://codereview.chromium.org/152133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248613 0039d316-1c4b-4281-b951-d872f2087c98

gpu::Mailbox by itself can hold only a texture id, but in common usage it comes
with texture target and syncpoint information for cross-context sharing.  To
reduce repetition of this pattern, gpu::MailboxHolder holds:

* a gpu::Mailbox
* a GL texture target
* a syncpoint index

Refactor other classes to use a gpu::MailboxHolder instead of separate
gpu::Mailbox and associated state.

Syncpoints are created with uint32 indices; make sure all uses of syncpoints
use the appropriate type.

BUG=None
TEST=local build, unittests on CrOS snow, desktop Linux
TBR=piman@chromium.org, enn@chromium.orge, cevans@chromium.org, scherkus@chromium.org

Review URL: https://codereview.chromium.org/132233041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248612 0039d316-1c4b-4281-b951-d872f2087c98

For reasons described in crbug.com/338016, I changed my mind on explicit
time tracking.  This is an attempt to clean up my mistake.

This new approach has the NudgeTracker keep track of the time when the
next retry GU is scheduled, and a flag that is set to true when we
should perform a retry GU at the next possible opportunity.  Before a
sync cycle, the NudgeTracker is provided with a TimeTicks::Now() value
and asked to update the flag accordingly.

This does a better job of ensuring the value of
NudgeTracker::IsRetryRequired() is consistent.  After this CL, we can
guarantee that its value will be the same before, during, and after the
sync cycle.  The previous implementation relied on a call to
TimeTicks::Now() in download.cc, so it did not have this property.

There is one tricky part to this patch.  We need to be careful that we
the call to RecordSuccessfulSyncCycle() after a sync cycle does not
overwrite pending retry state that may have been set by that sync
cycle's SyncSessionDelegate::OnReceivedRetryDelay() function.  To avoid
that problem, we store the value from that call in the SyncScheduler and
act on it only after we've updated the NudgeTracker's state when the
sync cycle is complete.

BUG=338016

Review URL: https://codereview.chromium.org/146113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248611 0039d316-1c4b-4281-b951-d872f2087c98

- the old profile button was too keen to update when the ProfileInfoCache
changed, and updated the incognito icon to the profile's avatar
- using the new avatar button, too many tabs overlapped the button
- leftover refactoring to do from https://codereview.chromium.org/117533002/

BUG=340246

Review URL: https://codereview.chromium.org/139343016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248610 0039d316-1c4b-4281-b951-d872f2087c98

With the addition of Linux support for rich notifications, we can turn on
Google Now for all desktop platforms.

BUG=164227
R=skare@chromium.org

Review URL: https://codereview.chromium.org/147273005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309844

Review URL: https://codereview.chromium.org/147273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/145913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248606 0039d316-1c4b-4281-b951-d872f2087c98

Executable bits are wonky on Windows, so checking them doesn't get us anything
and incorrectly disallows uploading of, e.g., python scripts.

R=maruel@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/142973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248605 0039d316-1c4b-4281-b951-d872f2087c98

Now when NPAPI plugin is not present the host setup wizard detects
when the host is not installed and asks the user to install it.

BUG=339626

Review URL: https://codereview.chromium.org/132793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248604 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/150163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248602 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334379

Review URL: https://codereview.chromium.org/153083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248600 0039d316-1c4b-4281-b951-d872f2087c98

This fixes an issue around field alignment when the dialog displays
scroll bars. Previous scroll would not only display the currently
active field, but also scroll the entire view 15 pixels to the side,
thus truncating the left edge. Since the scroll view is meant to scroll
only in y-direction, this simply forces the X coordinate to 0.

BUG=332678
R=estade@chromium.org

Review URL: https://codereview.chromium.org/141813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248599 0039d316-1c4b-4281-b951-d872f2087c98

The current height of the feedback page is causing the bottom of the page to get pushed off the boundary on certain screen sizes. The problem is now worse on other platforms due to the System Information link also being available there. Decrease some of the unnecessary padding on the feedback page to make sure it fits on the screens of machines with smaller displays.

R=xiyuan@chromium.org
BUG=334235

Review URL: https://codereview.chromium.org/151873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248598 0039d316-1c4b-4281-b951-d872f2087c98

I somehow forgot to change the style of this constant along with the
others way back when (in the original commit r233638).

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/133213012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248597 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=existing
R=darin@chromium.org, darin

Review URL: https://codereview.chromium.org/135683007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248596 0039d316-1c4b-4281-b951-d872f2087c98

Also untangle clearView implementation from picture listener enabled.
Add some comments and removed some error logs.

BUG=

Review URL: https://codereview.chromium.org/136753015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248595 0039d316-1c4b-4281-b951-d872f2087c98

Previously, I had only checked that you can't write a message with a
handle to itself. I also need to check that you can't write the handle's
"peer" to the handle (which is actually worse).

R=darin@chromium.org

Review URL: https://codereview.chromium.org/145483009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248594 0039d316-1c4b-4281-b951-d872f2087c98

BUG=336793
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/149213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248593 0039d316-1c4b-4281-b951-d872f2087c98

This CL eliminates the forwarding that PasswordManagerDelegateImpl was
previously doing to ContentPasswordManagerDriver. Instead,
PasswordManagerDelegate has a new GetDriver() method that returns the
PasswordManagerDriver that the core PasswordManager code should use. Tests are
updated to reflect this change.

BUG=335096

Review URL: https://codereview.chromium.org/152693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248592 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248591 0039d316-1c4b-4281-b951-d872f2087c98