- 12 Jun, 2017 40 commits
-
-
floppymaster authored
Update instructions to generate ICU header lists Update header list for unbundling ICU 59 Bug: https://bugs.gentoo.org/619796#c2 Review-Url: https://codereview.chromium.org/2935603002 Cr-Commit-Position: refs/heads/master@{#478662}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5143f2f3763b..fc3341632fc0 $ git log 5143f2f37..fc3341632 --date=short --no-merges --format='%ad %ae %s' 2017-06-12 mtklein port encode_bitmap_for_png() to SkRasterPipeline 2017-05-15 halcanary SkPDF: consolodate glyph runs on BUILD_FOR_WIN 2017-06-09 ethannicholas added SPIR-V RelaxedPrecision 2017-06-09 ethannicholas fixed issue with SkSL dead code elimination 2017-06-12 mtklein only SkHalfToFloat_finite_ftz(uint64_t hs) is called Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Ic832bc9bbf5c0ca20b9b6cd57a3b34d4a07a368c Reviewed-on: https://chromium-review.googlesource.com/531264Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478661}
-
domlaskowski authored
The cursor scale and rotation must be updated on pointer enter, even though neither the surface nor the hotspot changed. BUG=730843 TEST=caroline: Cursor is not stale on pointer enter. Review-Url: https://codereview.chromium.org/2935753002 Cr-Commit-Position: refs/heads/master@{#478660}
-
marq authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2932333002 Cr-Commit-Position: refs/heads/master@{#478659}
-
nednguyen authored
BUG=chromium:728177 Review-Url: https://codereview.chromium.org/2932213002 Cr-Commit-Position: refs/heads/master@{#478658}
-
khushalsagar authored
We already skip these layers during UpdateDrawProperties to prevent crashes. Mark these layers as non-drawing so they are skipped by the rest of the system. BUG=730020 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2925213002 Cr-Commit-Position: refs/heads/master@{#478657}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/982f6e0..0492d44 BUG= TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie238aa7b0f34193e94a5c86da50bcb9b9764d971 Reviewed-on: https://chromium-review.googlesource.com/531106Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#478656}
-
Mike Baxley authored
A lot of underlying helpers have been updated. I ran this 150 times locally with no failures. Setting to FLAKY_ to confirm on the bots. Bug: 631078 Change-Id: I12667d8dd2751c7fe2e8472b94c5f8386f259a1d Reviewed-on: https://chromium-review.googlesource.com/530097Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#478655}
-
horo authored
BUG= Review-Url: https://codereview.chromium.org/2936543002 Cr-Commit-Position: refs/heads/master@{#478654}
-
Dave Tapuska authored
Ensure implementations that cast InputRouter to InputRouterImpl are only doing it where necessary. Add an additional virtual interface to InputRouter so the touch action can be accessed without a cast to the implementation class. The LegacyInputRouterImpl is largely tied to Chrome IPC. With moving Input messages to be based on mojo messages this class needs to be rewritten. BUG=722928 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I97496956bb1547bff5abb145a1a015fec8d0fcb1 Reviewed-on: https://chromium-review.googlesource.com/529408 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#478653}
-
sebmarchand authored
BUG=689520 Review-Url: https://codereview.chromium.org/2888743002 Cr-Commit-Position: refs/heads/master@{#478652}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a77d640..f1ec7517 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2928403002 Cr-Commit-Position: refs/heads/master@{#478651}
-
stkhapugin authored
Returning scoped_nsobjects is against the philosophy of autoreleased objects being passed around. Refactoring methods and functions vending scoped_nsobjects allows for a cleaner transition to ARC later. This is CL 1/5. BUG=None TEST=None Review-Url: https://codereview.chromium.org/2934843002 Cr-Commit-Position: refs/heads/master@{#478650}
-
Luke Zielinski authored
TriggerManager will now store ThreatDetails that it creates in a map keyed by the WebContents that data collection is happening on. In the future this map will be multi-level, so other types of data collectors can run on a given tab. Also added unit tests for trigger manager BUG=730646 Change-Id: Iec6ef3c59fcd7b838f929fc7fe43e99c3c745cc7 Reviewed-on: https://chromium-review.googlesource.com/525854 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#478649}
-
Javier Fernandez authored
We need to add a new case for breaking out empy list items when they are at the start of an editable area. Since list items can be also inside table cells, we need to consider this kind of elements as well. Bug: 731621 Change-Id: If2cfc2bd926dc30004e92b18712d8167db7241fe Reviewed-on: https://chromium-review.googlesource.com/530224 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#478648}
-
jinho.bang authored
According to the spec[1], |methodData| and |modifiers| attributes should be FrozenArray instead of sequence. [1] https://w3c.github.io/payment-handler/#the-paymentrequestevent BUG=661608,720027 Review-Url: https://codereview.chromium.org/2934703002 Cr-Commit-Position: refs/heads/master@{#478647}
-
tzik authored
This CL flips `use_once_callback` flag on the Mojo code generator, and fixes all compile errors after it. After this CL, Mojo interfaces in //url starts using base::OnceCallback instead of base::Callback on its return value handling. The migration recipe was: - Convert pass-by-ref callback objects to pass-by-value. - Use std::move() to forward it to other consumer, or to invoke it with Callback::Run(). - Handle wherever copies are required manually. - Check if the conversion doesn't change the semantics. As the transfer and invocation clobber the callback object, care about use-after-move. It's considered safe to consume almost scoped-out callback. Bug: 714018 Change-Id: Ic41ddd3bae3a566e27ab0035e55d7a4f479d81a0 Reviewed-on: https://chromium-review.googlesource.com/527838Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#478646}
-
hlundin authored
The feature has been launched. BUG=672476 Review-Url: https://codereview.chromium.org/2931083002 Cr-Commit-Position: refs/heads/master@{#478645}
-
Ben Wagner authored
Set the SK_FREETYPE_MINIMUM_RUNTIME_VERSION build flag when the use_system_freetype gn flag is false. Currently the build flag is only set when is_win or is_mac, but this needs to be set any time it is known that FreeType will be built into the resulting binary. In particular this is desired for Android and WebView, but also for desktop Linux. BUG=chromium:715429 Change-Id: Ie5e425b0b347caf51400c5522a42e8a88605c147 Reviewed-on: https://chromium-review.googlesource.com/524185Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#478644}
-
Devlin authored
This reverts commit 51e98fac. Reason for revert: New tests (MediaStreamConstraintsUtilAudioTest.ValidGeometry) are failing: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F60774%2F%2B%2Frecipes%2Fsteps%2Fcontent_unittests%2F0%2Flogs%2FMediaStreamConstraintsUtilAudioTest.ValidGeometry__x2f_0%2F0 Original change's description: > SelectSettings algorithm for audio constraints. > > This is intended to be used in getUserMedia to implement spec-compliant > audio constraints processing. > > BUG=657733 > > Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd > Reviewed-on: https://chromium-review.googlesource.com/517782 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#478607} TBR=miu@chromium.org,hbos@chromium.org,guidou@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=657733 Change-Id: I9c9e9f6a9b0ad464c550443e273409feb4bd6ec7 Reviewed-on: https://chromium-review.googlesource.com/531126Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#478643}
-
Luke Halliwell authored
CHECK macro strings are dropped in official builds to save space. BUG=594632 Change-Id: Ic53faaa7480fa3c72a75e9af9c4a658cf05b4cc4 Reviewed-on: https://chromium-review.googlesource.com/530103Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#478642}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/5c4d199..f75b6fa $ git log 5c4d199..f75b6fa --date=short --no-merges --format=%ad %ae %s 2017-06-12 danilchap@webrtc.org Use rtp_header_extension_map.h instead of rtp_header_extension.h 2017-06-08 danilchap@webrtc.org Update expectation of OneBitrateObserverTwoRtcpObservers test: Use different media ssrcs for different RtcpBandwidthObservers 2017-06-12 henrik.lundin@webrtc.org ACM tests: separate checksums for Android ARM64 clang and non-clang 2017-06-12 perkj@webrtc.org Split rtc_task_queue target. Add separate target for sequenced_task_checker and weak_ptr. This is to make it possible to override the rtc_task_queue target only. 2017-06-09 andersc@webrtc.org List all device resolutions in AppRTCMobile settings 2017-06-07 magjed@webrtc.org Update Android video buffers to new VideoFrameBuffer interface 2017-06-12 eladalon@webrtc.org s/WebRtcVideoChannel2/WebRtcVideoChannel and s/WebRtcVideoEngine2/WebRtcVideoEngine 2017-06-12 ilnik@webrtc.org Make rtc_event_log2text output header extensions 2017-06-11 tschumim@webrtc.org Reland Refactored incoming bitrate estimator. 2017-06-07 magjed@webrtc.org Update webrtc/test to new VideoFrameBuffer interface 2017-06-10 magjed@webrtc.org Revert "Revert "Update video_coding/codecs to new VideoFrameBuffer interface"" 2017-06-09 kjellander@webrtc.org Enable webrtc_nonparallel_tests on iOS simulator 2017-06-08 aleloi@webrtc.org Remove default impl of Attach/DetachAecDump. 2017-06-09 ossu@webrtc.org Fix Channel::GetSendCodec when used together with SetEncoder. 2017-06-09 magjed@webrtc.org ObjC: Rename VideoToolbox/decoder.cc to VideoToolbox/decoder.mm 2017-06-09 stefan@webrtc.org Use the configured remote ssrc instead of relying on the first received packet RtpStreamReceiver. 2017-06-09 adam.fedor@gmail.com Ensure the openGLContext is current before trying to reshape the viewport 2017-06-09 nisse@webrtc.org Rename class RtpStreamReceiver --> RtpVideoStreamReceiver. 2017-06-09 kthelgason@webrtc.org Create a UIApplication when running tests on iOS. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2933843002 Cr-Commit-Position: refs/heads/master@{#478641}
-
Alexander Timin authored
Turn on ExpensiveBackgroundTimerThrottling by default, but leave the ability to turn it off quickly via Finch. This patch also removes now-unneeded plumbing, given that now we can access field trial parameters from a renderer process. BUG=639852 R=jochen@chromium.org,haraken@chromium.org,alexclarke@chromium.org,skyostil@chromium.org Change-Id: I8e3e342dd5f15a7f011fbe5d815f83b6fa46e124 Reviewed-on: https://chromium-review.googlesource.com/529109Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#478640}
-
rsleevi authored
As noted on https://groups.google.com/a/chromium.org/forum/#!topic/ct-policy/M-rhwDQ1h9E , the log has failed to abide by the uptime requirement. BUG=731836 TBR=eroman@chromium.org Review-Url: https://codereview.chromium.org/2932093002 Cr-Commit-Position: refs/heads/master@{#478639}
-
Jochen Eisinger authored
Bug: 730050 Change-Id: Ia11ab0e17995339fa2a620837a0bbb29b789512a Reviewed-on: https://chromium-review.googlesource.com/528235 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#478638}
-
tommycli authored
Makes the narrow Omnibox follow the same paint pattern as other Chrome bubbles -- until UI provides customizations. BUG=728844 Review-Url: https://codereview.chromium.org/2923073004 Cr-Commit-Position: refs/heads/master@{#478637}
-
jam authored
BUG=729849 NOTRY=true TBR=yzshen Review-Url: https://codereview.chromium.org/2933863002 Cr-Commit-Position: refs/heads/master@{#478636}
-
marq authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935683002 Cr-Commit-Position: refs/heads/master@{#478635}
-
Ian Vollick authored
This was missed in the patch that introduced the Quaternion. Unittests have been updated to reflect the change (and I've made a minor refactor to avoid so many component-wise comparisons). Bug: 718004 Change-Id: Ife5618aadf33c9908ffa13e3ffabad9ae419fa3e Reviewed-on: https://chromium-review.googlesource.com/530325Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#478634}
-
Mike West authored
We've shifted from an explicit JSON dictionary to a list of quoted strings (that can be parsed as JSON for forward-compatibility). That is, rather than `Clear-Site-Data: { "types": [ "cookies", "cache" ] }`, we'll use `Clear-Site-Data: "cookies", "cache"` to mean the same thing. Spec change in https://github.com/w3c/webappsec-clear-site-data/issues/27. BUG: 607897 Change-Id: I051dcc49f9ed108e117347ccd7e249781433302b Reviewed-on: https://chromium-review.googlesource.com/530748Reviewed-by:Martin Šrámek <msramek@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#478633}
-
Marc Treib authored
This essentially reverts crrev.com/2897523004. The split introduced there doesn't work: The "Google vs. non-Google" check is based on the URL, but the local NTP URL is always the same. Bug: 583292 Change-Id: Ia7854a0c694c11d86ebaa853849a29e04dd81dde Reviewed-on: https://chromium-review.googlesource.com/527794Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#478632}
-
Geoff Lang authored
TBR=zmo@chromium.org BUG=602688 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4b7bf4b3e28c79fb2c64d730ea063fac0b7821cf Reviewed-on: https://chromium-review.googlesource.com/531105 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#478631}
-
Takayoshi Kochi authored
Using wpt-import in Chromium 91aff562. Reason for manual import: WPT autoroller seems failing to merge for a few days. NOEXPORT=true Change-Id: I0b4438da736d5dbc1b32369c315a1a591a4bc1e8 Reviewed-on: https://chromium-review.googlesource.com/530608 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#478630}
-
Lucas Furukawa Gadani authored
guests. The OOPIF-based guests are already destroyed by the WebContentsImpl when the FrameTreeNode is detached (in WebContentsImpl::WebContentsTreeNode::OnFrameTreeNodeDestroyed). Bug: 730041 Change-Id: Ica33f1f289babae30293ee6ae6446936e2136b04 Reviewed-on: https://chromium-review.googlesource.com/528392Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Lucas Furukawa Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#478629}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/36e1cdaf2d99..1c02d65fcbf3 $ git log 36e1cdaf2..1c02d65fc --date=short --no-merges --format='%ad %ae %s' 2017-06-12 ashleymarie Add names to stories used in unittests Created with: roll-dep src/third_party/catapult BUG=720002 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iccf75155d0e2ecc31f91681a8d1cc764fe4d0169 Reviewed-on: https://chromium-review.googlesource.com/531064 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478628}
-
magjed authored
Speculative fix for WebRTC test failures. See issue for more information. BUG=732345 TBR=emircan Review-Url: https://codereview.chromium.org/2934793002 Cr-Commit-Position: refs/heads/master@{#478627}
-
Mohamed Amir Yosef authored
Bug: 732161 Change-Id: I57dd0dd8029fd83fabdab063040fc5163059afc9 Reviewed-on: https://chromium-review.googlesource.com/530371 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#478626}
-
arthursonzogni authored
Remove the TODO and enable the disabled test expectation. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2933803002 Cr-Commit-Position: refs/heads/master@{#478625}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/b83d870b007f..c6fd58d69bd8 $ git log b83d870b0..c6fd58d69 --date=short --no-merges --format='%ad %ae %s' 2017-06-09 hnakashima Trimming brackets and quotes outside URLs. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ie2fb5b271a9b0e1f3f514b88522a02fe50332d62 Reviewed-on: https://chromium-review.googlesource.com/531124 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478624}
-
Primiano Tucci authored
This reverts commit 31b78339. Reason for reland: Fixed TestBackgroundTracingSetup flakiness, this time for real. In the last reland I forgot to git stash pop the actual fix and ended up just relanding the original CL as-is. Original change's description: > Revert "Reland: memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest" > > This reverts commit 05755b0f. > > Reason for revert: Failing frequently on linux_chromium_asan_rel_ng on the CQ. Has failed once so far on CI: https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/36356 > > Original change's description: > > Reland: memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest > > > > This reverts commit ac66f89e. > > > > Reason for reland: Fixed race in the test > > > > Original change's description: > > > Revert "memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest" > > > > > > This reverts commit 16e17888. > > > > > > Reason for revert: MemoryDumpManagerTest.TestBackgroundTracingSetup fails under LSAN: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ASan%20LSan%20Tests%20%281%29/36339 > > > > > > Original change's description: > > > > memory-infra: Stop using RequestGlobalDump in MemoryDumpManagerTest > > > > > > > > This CL changes the memory-infra unittests to not depend on > > > > the RequestGlobalDump() API. From a logical viewpoint, > > > > the RequestGlobalDump() is not needed for an in-process-only > > > > test like MemoryDumpManagerTest. > > > > From a more practical viewpoint, this refactoring is required > > > > in preparation of the next CLs that will remove > > > > MemoryDumpManager::RequestGlobalDump() method and move all the > > > > clients to directly use the service. > > > > > > > > This CL doesn't cause any behavior change in memory-infra. > > > > > > > > BUG=720352 > > > > TBR=thakis > > > > > > > > Change-Id: I82ee1bf94dab55798be727f0ae70a1fede6634ca > > > > Reviewed-on: https://chromium-review.googlesource.com/525534 > > > > Reviewed-by: Primiano Tucci <primiano@chromium.org> > > > > Reviewed-by: siddhartha sivakumar <ssid@chromium.org> > > > > Reviewed-by: Helen Li <xunjieli@chromium.org> > > > > Reviewed-by: Hector Dearman <hjd@chromium.org> > > > > Commit-Queue: siddhartha sivakumar <ssid@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#477851} > > > > > > TBR=thakis@chromium.org,primiano@chromium.org,hjd@chromium.org,xunjieli@chromium.org,ssid@chromium.org > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > BUG=720352 > > > > > > Change-Id: I7088bd3549c3a8a733d4b87226593209bd40c42e > > > Reviewed-on: https://chromium-review.googlesource.com/528032 > > > Reviewed-by: Sam McNally <sammc@chromium.org> > > > Commit-Queue: Sam McNally <sammc@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#477875} > > > > TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org > > > > Change-Id: Ic6439b97024d65d19012133171249dddd2de8b88 > > Reviewed-on: https://chromium-review.googlesource.com/528098 > > Commit-Queue: Primiano Tucci <primiano@chromium.org> > > Reviewed-by: Primiano Tucci <primiano@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#477988} > > TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > > Change-Id: I0e9f5a6f930e096406ac0d46ac310ef2fae99370 > Reviewed-on: https://chromium-review.googlesource.com/528513 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#478109} TBR=thakis@chromium.org,jam@chromium.org,primiano@chromium.org,fmeawad@chromium.org,hjd@chromium.org,sammc@chromium.org,xunjieli@chromium.org,ssid@chromium.org,chromium-reviews@chromium.org,jbudorick@chromium.org Change-Id: I7493014373569281e84049cb6fdca987fc9ee83e Reviewed-on: https://chromium-review.googlesource.com/530311 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#478623}
-