GitLab

Show the hint as the first item on the dropdown.
This way, when the hint is clicked on, and we move
on the items on the list, we see the items on the top
first. This is specially important for the Billing Addresses
on the Card Editor, where the most relevant item is on the
top.


Refactor:

Use two different adapters for hinted adapters:
1. The ones with '+' icon for their last item,
2. The ones without an icon.

Tests were modified for the Card Editor, because now
the first item on the dropdown list is the "Select" option,
and not the first address.

Bug: 795031
Change-Id: Ibccdd1256aa093e661890ea6ef11949c7d074766
Reviewed-on: https://chromium-review.googlesource.com/826005
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526874}

The override is set in LockWindow now.
Test that keyboard does not overlap with lock screen UI.

Bug: 791817
Change-Id: Ic789efd897fcfd60f3c6bfe6189e22f6140bbda2
Reviewed-on: https://chromium-review.googlesource.com/828027
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526873}

This test hasn't been marked as flaky yet, but it's quite flaky because
there's a race condition on when the console messages are printed:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=%20http%2Ftests%2Fdevtools%2Fconsole-xhr-logging-async.js

The XHR loaded console message should be suppressed, but it's used
to notify when the XHR is loaded.

Bug: none
Change-Id: If76c37e0e9c31fa2fce033ec440a5c8b580e15bc
Reviewed-on: https://chromium-review.googlesource.com/847699Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526872}

seconds.

This applies to both fetches for WPAD, as well as explicit PAC URLs.

30 seconds should be comparable to Microsoft Edge's defaults (based on
some testing on Windows 10).

Bug: 251682
Change-Id: Id2cbe60d4d27946de043946a7aad8f926b40c9d9
Reviewed-on: https://chromium-review.googlesource.com/849116Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526871}

TBR=xidachen@chromium.org
NOTRY=true

Bug: 798735
Change-Id: Ic222eca158f094d52bcb09bbf959d0d6572d2ce8
Reviewed-on: https://chromium-review.googlesource.com/849640Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526870}

Chromium Embedded Framework [1] is a project that requires a Gtk2 build.

[1] https://bitbucket.org/chromiumembedded/cef

BUG=610428
R=erg

Change-Id: Iefecaccdc026cd5ab4bd692f15926e7410909fc7
Reviewed-on: https://chromium-review.googlesource.com/849482Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526869}

ErrorPageOfflineTestWithAllowDinosaurFalse.CheckEasterEggIsDisabled requires
http://mock.request.failed to be handled. This CL installs a default interceptor
which handles this request.

Bug: 776589
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic5b2dca7b3d46b20368094c677ea85456a39b016
Reviewed-on: https://chromium-review.googlesource.com/847917
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526868}

Fuchsia exe runner script waits for "ping google.com" to succeed
before launching the target to ensure it's launched after network is
configured. Due to bug in Fuchsia (see NET-336) ping never succeeds.
Workaround this bug by running ping with -c0. This allows to wait for
DNS resolion to succeed without sending any pings.

Also added a sleep 1 to avoid log noise caused by bug 798801

Bug: 798801
Change-Id: I2fb9f2a8e1608304ebf7007f767c6deb2b43b295
Reviewed-on: https://chromium-review.googlesource.com/848516Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526867}

Bug: 586475, 733703
Change-Id: Id8a08fefff1af4f80fd5520a18cc1c9417147552
Reviewed-on: https://chromium-review.googlesource.com/848301Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526866}

Test for cross-origin frames.
Test for content security policy.

Bug: chromium:787197
Change-Id: Ice5fc749edad052ceecd4bb8251a89198271fd89
Reviewed-on: https://chromium-review.googlesource.com/846612
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526865}

This patch uses idlharness.js to test the CSSStyleValue interface.

Bug: 774887
Change-Id: I20e487e2ec0e733e5ab152e1f9e9fa6bc2c5a605
Reviewed-on: https://chromium-review.googlesource.com/848116Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526864}

After earlier re-factoring, these tests no longer actually test
any code in display_preferences.cc.

Bug: none
Change-Id: Ie8d81f6efafb23918cda3af892ab48ee63cbfb29
Reviewed-on: https://chromium-review.googlesource.com/848247Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526863}

This cl cleans up some of the tab favicon handling code in preparation
for swapping in the new Material Design spinner. In particular, it
preserves a tab's iconView when not visible rather than remove the
iconView from the view hierarchy.

Bug: 602558
Change-Id: I357054ae0f383880d64be3de2e024c634880b99a
Reviewed-on: https://chromium-review.googlesource.com/822179
Commit-Queue: Jayson Adams <shrike@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526862}

The tools menu item animation that is triggered after the dismissal of
the Incognito In Product Help Bubble flickers at the end. This happens
because there is a gap between the end of the autoreversed animation
(where the item has a highlighted background) and the completion handler
(which sets the item to a white background). The fix is to use a
CABasicAnimation instead of |animateWithDuration|.

Bug: 767202
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I79d57ecf7e77281e9d6d112a66e8e7d20efcccef
Reviewed-on: https://chromium-review.googlesource.com/849176
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526861}

https://webrtc.googlesource.com/src.git/+log/35d2b7e9de9d..8e126fca476a

$ git log 35d2b7e9d..8e126fca4 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic779de68a3bb6e5ecd52f0a0815e079e0ae64613
Reviewed-on: https://chromium-review.googlesource.com/849198Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526860}

Only call onAttachedToWindow during init, not every time
WebContentsAccessibility is retrieved.

Bug: 798629
Change-Id: I5a7036dc1e6dac00b1a0bb250eefc18e36cebf72
Reviewed-on: https://chromium-review.googlesource.com/849393Reviewed-by: Dmitry Skiba <dskiba@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526859}

** This change may cause significant performance and binary size
differences. **

This is our first (external) attempt to turn on AFDO for Chromium on
Android. AFDO, in short, is a feature that lets us feed profiles into
the compiler to help it make better optimization decisions. The default
AFDO configuration in Chromium also instructs the compiler to make size
optimization decisions based on this profile, so code that's built with
-O2 but isn't present in the profile will get optimized for size
instead.

Internal builds and benchmarks look very promising, and indicate that
this is a win in both binary size and Chrome's speed. We have many
external bots that might disagree, so I guess we'll see. ¯\_(ツ)_/¯

Bug: 794750
Test: apks/ChromePublic.apk builds using the provided profile.
Change-Id: I79e3fdb47fb653661a73e9317163d032d6c8b8d9
Reviewed-on: https://chromium-review.googlesource.com/847902Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526858}

This CL moves the HTTP-Bad from outdated field trial groups to the Feature API
with parameters to control the UI treatment. It adds three new UI treatments for
nonsecure  pages:

- mark all nonsecure pages as Not Secure
- mark all nonsecure pages as Not Secure and treat them as actively dangerous when
  a form field is edited
- mark all nonsecure pages as Not Secure and treat them as actively dangerous for
  passwords and credit card fields

This doesn't implement any DevTools or Page Info changes for these configurations.

Bug: 797437,740395
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I646502a05967b63d3c34015d0d597ce5382248f9
Reviewed-on: https://chromium-review.googlesource.com/843456Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526857}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/73cec2c8..f294c56d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I0bcc7099075e954c0cf5e4afab04b081583b48f9
Reviewed-on: https://chromium-review.googlesource.com/849075Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526856}

This patch adds an empty target for mojom_java. This breaks a cycle of
dependencies between an upstream and downstream patch: the upstream
patch introduces this target but breaks downstream ToT, and the
corresponding downstream patch which updates the BUILD.gn file needs
to point to this target.

See also:
Upstream: https://chromium-review.googlesource.com/c/chromium/src/+/738515
Downstream: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/538307

Bug: 795007
Change-Id: Iae00dc7d282d7119d7bb90bf3d791b294f00154c
Reviewed-on: https://chromium-review.googlesource.com/848085Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526855}

* Adds human-friendly loading message to audits
* Adds loading progress bar to audits
* Extracts status view out of main audits panel

BUG=https://github.com/GoogleChrome/lighthouse/issues/3098

Change-Id: Icf5a666d99f3d0415b8f74fccd287cda2427b3c6
Reviewed-on: https://chromium-review.googlesource.com/809912
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526854}

This should be fixed in the new hardware/drivers.

Bug: 666392
Tbr: zmo@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic3672fa248c211b6af0b1eeb0e049230d61ed205
Reviewed-on: https://chromium-review.googlesource.com/849373Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526853}

http://mock.failed.request is a special testing url load which allows us to
simulate error codes. The implementation is suppose to return the error code
referenced in the query part of the request to OnComplete().

This CL moves this handling from one of the ErrorPageTests to the
URLLoaderInterceptor::Interceptor class so that it can be shared.

Bug: 776589
Change-Id: Id6da78e4a3e62b9165d2fe30876b7bbafcf0e8b0
Reviewed-on: https://chromium-review.googlesource.com/847916
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526852}

https://chromium.googlesource.com/catapult.git/+log/19e11600d3a9..2de84c0d21c2

$ git log 19e11600d..2de84c0d2 --date=short --no-merges --format='%ad %ae %s'
2018-01-03 dtu [pinpoint] Skip comparisons if there are no Executions for the given Quest.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Icfd9fb844b7be5da8e03564d23bc9b401009d446
Reviewed-on: https://chromium-review.googlesource.com/849175
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526851}

BUG=682093
R=msw@chromium.org

Change-Id: I4f905746fac4c48ca99c183d824967f7f4f3ba80
Reviewed-on: https://chromium-review.googlesource.com/848495Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526850}

BUG=796932

Change-Id: I7ce6be0b361162573430020d4b7a2de7cf1fc644
Reviewed-on: https://chromium-review.googlesource.com/848241Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526849}

Update views based shelf visibility check in web UI
to include both cases lock and login.

Bug: 792656
Change-Id: I38c2ce0bed6c7ef5545e0ccd7d18266d0c2fa97b
Reviewed-on: https://chromium-review.googlesource.com/834049Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526848}

For a touchpad based gesture event, we want to know whether the source
wheel event was handled blocking or non-blocking, and we can flush the
vsync queue immediately if it was blocking.

Bug: 526463
Test: InputHandlerProxyEventQueueTest.TouchpadGestureScrollEndFlushQueue
Change-Id: I051f042dc7da6f901d135a5f7785a97d25581d8e
Reviewed-on: https://chromium-review.googlesource.com/849313Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526847}

PerfUI.FilmStripView.Dialog is a first user of x-widget.

Bug: none
Change-Id: I8c98d82239d6a64472a9ec1cb825600992ee143e
Reviewed-on: https://chromium-review.googlesource.com/848292Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526846}

Change-Id: Ifadd4ccf1b407f9fcecbd4b1f3598227b2af2c19
Reviewed-on: https://chromium-review.googlesource.com/848998Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526845}

Fix a bug where WKBasedNavigationManager is not setting the
ui::PAGE_TRANSITION_FORWARD_BACK bit in an existing NavigationItem in
history navigation.

The legacy navigation manager doesn't set this bit for same-document
back-forward navigation. This seems to be a bug, but will be fixed in
a separate CL to make possible bisecting easier.

Bug: 798832
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2967256a32027384e16b03c24fdc0ee899a3d61d
Reviewed-on: https://chromium-review.googlesource.com/849352Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526844}

We're gradually breaking app list search logic into a chrome part and an
ash part, which will be bound via a model updater and an observer.
Specifically, this commit:
- moves all search box references in SearchResourceManager into the
  model updater;
- removes some unused "ash/app_list/*" inclusions in chrome codes.

Bug: 733662
Change-Id: Ied882c477a53aef70c94465a00420e363d974a9c
Reviewed-on: https://chromium-review.googlesource.com/845138
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526843}

TexStorage2DImageCHROMIUM should create an immutable texture like the
TexStorage function it's modelled after.

Change-Id: I8cde40d64df307d863974401c8eeaff69d5b56ae
Reviewed-on: https://chromium-review.googlesource.com/847966Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526842}

AppsGridView::EndDrag() animates the dragged view at the end. This
causes test flakes in MouseDragFlipPage, where the test attempts
a second drag. If the animation does not finish in time, the second
drag fails because the view is not at its expected location. Fix
this by forcing a layout after EndDrag.

Bug: 798753
Change-Id: Ibd12d665d01d36699023dbc57b7aacf463f04f05
Reviewed-on: https://chromium-review.googlesource.com/848423Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526841}

Instantiation of typed_url_sync_bridge_ in HistoryBackend is controlled by Finch
experiment, when experiment is disabled typed_url_sync_bridge_ is nullptr. In my
previous change (https://crrev.com/c/815880) I introduced call to notify
TypedURLSyncBridge about SQL error, but the call happens regardless if
experiment is enabled or not. This caused crashes described in corresponding
bug.

In this change I check typed_url_sync_bridge_ to be valid before dereferencing
it to call a function.

BUG=796138
R=skym@chromium.org

Change-Id: I08b45479c6d6bce42709ccaad76491ca76bfb232
Reviewed-on: https://chromium-review.googlesource.com/849192Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526840}

Bug: 755727
Change-Id: Id47d8d9da0a50c9eb16173f6ab6dd70adff6ec84
Reviewed-on: https://chromium-review.googlesource.com/846648
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526839}

NOTRY=true
TBR=true

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Icb50d9e6d955e3c4f1f5b2a7af2c1b07faccd355
Reviewed-on: https://chromium-review.googlesource.com/849333Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526838}

Bug: 755727
Change-Id: I05c8894ef3016166257f2b264fe3d4a60a20648b
Reviewed-on: https://chromium-review.googlesource.com/846602
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526837}

Change-Id: Ie56a9e3ffe97734143bfb4602f5bd03ed1c1108d
Bug: skia:7271
Reviewed-on: https://chromium-review.googlesource.com/849314Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Yuqian Li <liyuqian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526836}

Also, pass the paint offset independently of the bounds.
The two callsites of CreateDragImageForFrame paint in different
coordinate spaces. Also, the callsite in DragController is already
clipping.

This fixes two issues: that the bounds rect did not match the
coordinate space of the clip applied in CreateDragImageForFrame,
and that the coordinate space is not necessarily the LayoutView.

Bug: 798182
Change-Id: Ie792095806613cd1e6238bbb0d1b8335350ede01
Reviewed-on: https://chromium-review.googlesource.com/848499Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526835}