GitLab

Bug: 865260
Change-Id: Ied9a9068518cdbc9e05a42cace066c110c0c0e05
Reviewed-on: https://chromium-review.googlesource.com/1147494Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578476}

BUG=789232

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic142b7099f0a813764e750b23236822b53f894fa
Reviewed-on: https://chromium-review.googlesource.com/1151906
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578475}

This reverts commit 2ae89dce.

Reason for revert: net_unittests seems to be consistently failing after your patch landed. First failure is here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/35922 . net_unittests hangs when it gets to MultiThreadedProxyResolverTest.CancelCreate

Original change's description:
> Change ProxyResolutionService API to use std::unique_ptr<Request> instead of raw pointers.
> 
> Bug: 479898
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I3d1b89fc33ebae27f6ab4007eceffb9eb6134ef6
> Reviewed-on: https://chromium-review.googlesource.com/887598
> Commit-Queue: Matt Menke <mmenke@chromium.org>
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578436}

TBR=stevenjb@chromium.org,sky@chromium.org,eroman@chromium.org,boliu@chromium.org,mef@chromium.org,mmenke@chromium.org,lilyhoughton@chromium.org

Change-Id: I17026b358225cc01884be96ca5b69dcd9f885e5d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 479898
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1152368Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578474}

The existing code updates the text input caret highlight by observing
input method state. This works in classic ash because the input method
is shared globally across ash and browser code. This doesn't work with
remote apps because ash can't see the input method in the remote
process. The caret doesn't work in mash because the ash process can't
see the browser's input method.

Add support for a11y to observe the input method objects created by the
browser's input method driver / bridge. Explicitly forward the
text caret bounds to ash, which then updates the highlight.

Bug: 867110
Test: added to ash_unittests and browser_tests
Change-Id: I27058e091ad5a597de4ab644654df8d535e95b72
Reviewed-on: https://chromium-review.googlesource.com/1151897
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578473}

Some users complain about background audio player being muted by the app.
This CL overrides some settings in the AudioSession to allow audio from
the app to be mixed with sounds from other apps.

Bug: 868088
Change-Id: I10af925e3eb488498ab83df25cbd77cea8ebd186
Reviewed-on: https://chromium-review.googlesource.com/1152182Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578472}

The above mentioned function is supposed to enter a line box child to
find positions in inline descendants. In some situations, the inline
formatting context have have direct non-inline child (e.g., abs-pos
float), which should be ignored.

This patch removes the existing redundant branch that enters non-line-
box children, to fix failure in
fast/shapes/shape-outside-floats/shape-outside-clip-path-selection.html.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I834544692d6cc8d9fc4340fb55ffb1bbe53f1276
Reviewed-on: https://chromium-review.googlesource.com/1151947
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578471}

This CL updates HID detection screen with new style.

Bug: 852046
Change-Id: Ibba68ae848efeb7518ec1942719da666f5f92f24
Reviewed-on: https://chromium-review.googlesource.com/1150970Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578470}

This CL rejects cross-origin redirects in top-level scripts of
module dedicated workers in WorkerModuleScriptFetcher,
to ensure that the response and request URLs of
a worker top-level script are same-origin in successful cases.

Bug: 861965, 861564
Change-Id: I5969020480aeb0e1f108b0393199bb04b19419b6
Reviewed-on: https://chromium-review.googlesource.com/1147664
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578469}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: I3660a7c2497124f18168d4e8f24495feb21b2818
Reviewed-on: https://chromium-review.googlesource.com/1150525Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#578468}

Change-Id: I5fecd9eae4a18621051f144df4669d8827a044ec
Reviewed-on: https://chromium-review.googlesource.com/1150526Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#578467}

This CL just adds an empty mojo interface that will be used for
implementing portals. The interface will be exposed by the browser in a
follow-up CL.

Bug: 865565
Change-Id: I1cd93aa19f83562b5f9dccfe3eb75c93433e6770
Reviewed-on: https://chromium-review.googlesource.com/1144054Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578466}

Revert "Referencing SurfaceManager::GetLatestInFlightSurface in surface activation instead of fallback surface."

This reverts commit 8dc96162.

Reason for revert: This causes jitter during resize.

Original change's description:
> Referencing SurfaceManager::GetLatestInFlightSurface in surface activation instead of fallback surface.
> 
> Use SurfaceManager::LatestInFlightSurface in Surface::ActivateFrame to use the latest in-flight
> surface as the active reference instead of fallback. This allows for better garbage collection
> of surfaces and optimize the notion of fallback surface.
> 
> Bug: 857575
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
> Change-Id: I4f597e431866b3a9886c04b982101199fd4011d7
> Reviewed-on: https://chromium-review.googlesource.com/1149092
> Commit-Queue: Andre Kaba <akaba@google.com>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Saman Sami <samans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578429}

TBR=fsamuel@chromium.org,samans@chromium.org,akaba@google.com

Change-Id: I53bd4bf7b7ecc1db79e3ac2e4a535fc49269b858
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 857575
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1152309Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578465}

This is a reland of fa8e9207

Original change's description:
>Reland "[scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController"
>
>This is a reland of e2d89968
>
>Original change's description:
>> [scheduler] Refactor FrameSchedulerImpl to use FrameTaskQueueController
>>
>> This CL moves all task queue management and creation to
>> FrameTaskQueueController and adds the appropriate interface for
>> accessing queues in FrameTaskQueueController. TaskType to QueueTraits
>> management is handled by FrameSchedulerImpl since it embeds policy, and
>> FrameTaskQueueController exposes an interface to get non-loading task
>> queues by QueueTraits, as well as accessing loading and loading
>> control task queues.
>>
>> Bug: 859963
>> Change-Id: I7db5aaaa148d0dc4f3f70e517e088a205e502db8
>> Reviewed-on: https://chromium-review.googlesource.com/1142390
>> Commit-Queue: Scott Haseley <shaseley@google.com>
>> Reviewed-by: Alexander Timin <altimin@chromium.org>
>> Cr-Commit-Position: refs/heads/master@{#576619}
>
>Bug: 859963
>Change-Id: Id2c9179b580759b815602d61b98c99d1f3f5253d
>Reviewed-on: https://chromium-review.googlesource.com/1144608
>Commit-Queue: Scott Haseley <shaseley@google.com>
>Reviewed-by: Alexander Timin <altimin@chromium.org>
>Cr-Commit-Position: refs/heads/master@{#578008}

Bug: 859963
Change-Id: I57e49ea8a7c60b2f0e33905a6701fcb96b5b28bf
Reviewed-on: https://chromium-review.googlesource.com/1150910
Commit-Queue: Scott Haseley <shaseley@google.com>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578464}

Rename happened in
https://chrome-internal-review.googlesource.com/c/infradata/config/+/653789

R=vadimsh@chromium.org

Change-Id: Ib895fad1ca339cacec836fffeefe5f3bfc32c57f
Reviewed-on: https://chromium-review.googlesource.com/1150844Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578463}

This CL removes unused strings for download location feature.

Bug: 840464
Change-Id: I06f4113dc06224645fa625d2ce38fd48868a184a
Reviewed-on: https://chromium-review.googlesource.com/1150509Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578462}

The new version understands CIPD packages that use SHA256 as identifier. Such
packages soon will start to appear (and the old version won't be able to handle
them).

Relevant changes:
https://chromium.googlesource.com/infra/luci/luci-go/+log/9449d18..75f8e8f/cipd

R=dpranke@chromium.org, maruel@chromium.org
TBR=bsheedy@chromium.org
BUG=821194

Change-Id: Ic11a8cb822e4574f7709588dc566f15badaa12a6
Reviewed-on: https://chromium-review.googlesource.com/1152103Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578461}

This CL is adding an instant event to put the histogram value into the trace.
The UMA histogram is not part of the trace and it is making it hard to
figure out what happened in a reported trace.

The instant message is also giving an hint at which time the histogram
triggered the corresponding rule.

R=oysteine@chromium.org

Change-Id: I34fdf84c5b6d54ec4b8cd35dff8799d786a85334
Reviewed-on: https://chromium-review.googlesource.com/1151965Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578460}

We introduce a ScopedHighResUsHistogramTimer which only records samples
if we have a high resolution timer. This is done to avoid a bunch of
samples falling into the 0us bucket when we don't have a high
resolution timer.

Change-Id: Ic57cd34bcd5ceada96fe8f69f9267ce21aef07a7
Reviewed-on: https://chromium-review.googlesource.com/1150020Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578459}

Before this patch, the Offline Prefetch feature was controlled by the
"network prediction" setting, which is shared with other features. As we
want to add specific control over this feature, this CL updates code to
add a prefetch-exclusive setting, dissociating it from the previously
shared one. It also exposes helper methods to get and set its value.

Bug: 850588
Change-Id: I45832234f3c1478f1dbde43a9cb86d7899cdb8d6
Reviewed-on: https://chromium-review.googlesource.com/1145476Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578458}

This reverts commit 1748ac49.

Reason for revert: Cause of the flakiness has already been fixed

Original change's description:
> Disable flaky ChromeDriverTest
> 
> TBR: khachatryan@chromium.org
> Bug: 865842
> Change-Id: I33180c2c852a8da94cf735a1437eac3748203153
> Reviewed-on: https://chromium-review.googlesource.com/1151027
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Commit-Queue: Yoichi Osato <yoichio@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578210}

TBR=yoichio@chromium.org

Change-Id: Ib630eb7748189190c9e49809f1730ca0ca5f04ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 865842
Reviewed-on: https://chromium-review.googlesource.com/1152307Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578457}

Currently when using VizDisplayCompositor, Arc doesn't work. There's ongoing
work for Exo+Viz which is needed to enable it.

Until then I'm adding an early exit to ArcAccessibilityHelperBridgeBrowserTest
so that we can get ride of the filter files associated with viz_browser_tests

TEST=ArcAccessibilityHelperBridgeBrowserTest

Bug: 807465
Change-Id: Iae350792c4fcedd23561e524cc7d269c50846e5e
Reviewed-on: https://chromium-review.googlesource.com/1151760Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578456}

OpenVR and Oculus devices may be destroyed before the render loop is
created.  If this happens we may crash because we call render_loop_->IsRunning().

Next, if we don't call render_loop_->Stop(), the render_loop_'s bindings will be
destroyed on the main thread rather than the render loop thread.

BUG=868072

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibf12af3c38cfa8ed8edf1aebe431a3606476bba7
Reviewed-on: https://chromium-review.googlesource.com/1151952Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578455}

After getting an NG-specific rebaseline [1] due to whitespace only
difference, the layout tests's generic baseline was changed [2],
cause failure on NG bot.

This patch rebaselines it to make it pass again.

[1] https://crrev.com/c/942646
[2] https://crrev.com/c/992322

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib81eb9ce05cc36c11496be895434248aa9318c19
Reviewed-on: https://chromium-review.googlesource.com/1151958
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578454}

Add a bottom border to the title bar of the selection dialog.

When an attribution contains a link change the cursor on mouse-over.

Bug: 867765, 867764
Change-Id: I1357b005154c1c3d685e584422fdaa6e424057b6
Reviewed-on: https://chromium-review.googlesource.com/1151620
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578453}

Bug: 865063
Change-Id: I1b13da06c4f3e8ef6d15cb087f37ffa3394361ef
Reviewed-on: https://chromium-review.googlesource.com/1150522Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578452}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icc5fba4db5602e546629bca3ab4d55214356f007
Reviewed-on: https://chromium-review.googlesource.com/1152237Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578451}

RecursiveDumpAXPlatformNodeAsString in accessibility_ui.cc should check
that the node is not null (it previously checked only child nodes). On
Chrome OS, this was causing a crash in RequestNativeUITree when
AXPlatformNode::FromNativeWindow returned null.

Bug: 792232
Change-Id: Iac07412484b6304ef43906976cb687316b171a21
Reviewed-on: https://chromium-review.googlesource.com/1152109
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578450}

Bug: 867717
Change-Id: I85bd1f1c0404e536236a6b08787da499a5d7da41
Reviewed-on: https://chromium-review.googlesource.com/1152107Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578449}

This is a reland of dab9cc04

Original change's description:
> Picture-in-Picture: show buttons when the mouse is hovering.
> 
> This is fixing a Windows specific bug where the ENTER event isn't fired.
> 
> Bug: 867646
> Change-Id: I79daf4679bdfaff00aadcf087bc89c27995fe0d9
> Reviewed-on: https://chromium-review.googlesource.com/1150892
> Reviewed-by: apacible <apacible@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578212}

Bug: 867646
Change-Id: I84dc563d7339b6146803a84b73deddbf720662c8
Reviewed-on: https://chromium-review.googlesource.com/1150704Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578448}

This is the last of CRWWebDelegate methods used by CRWWebController, removing it
will allow deleting the CRWWebDelegate entirely.
Also removed it from Tab and from PreloadController which were implementing them.
The logic of handling external apps is now entirely moved to AppLauncherTabHelper
which is a policy decider and is attached to the web state used by the CRWWebController.

Bug: 850760, 681867, 674991
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2df6282ae561eef2e1da8fac605f42dbfe4cb97b
Reviewed-on: https://chromium-review.googlesource.com/1124942
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578447}

https://skia.googlesource.com/skia.git/+log/897f256413c1..c4db8708c903


git log 897f256413c1..c4db8708c903 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 ziadb@google.com SkAR Java: refactored SkARUtil (now PaintUtil)
2018-07-26 ziadb@google.com SkAR Java: refactored SkARMatrix.java (now CanvasMatrixUtil.java)
2018-07-26 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 203b26f27d00..dbd1612782f5 (1 commits)
2018-07-26 ziadb@google.com SkAR Java: better UI for finger painting
2018-07-26 herb@google.com Centralize bitmap glyph positioning
2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-26 brianosman@google.com Correctly distinguish hairline paths in the SW path renderer's cache
2018-07-26 fmalita@chromium.org Update android_build_app Gradle output location
2018-07-26 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@c4db8708c903

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: Ib7d3c4cb282503e528c14ef0043b74b49a95b03e
Reviewed-on: https://chromium-review.googlesource.com/1151968Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578446}

https://webrtc.googlesource.com/src.git/+log/e4db6a151806..ed1dcf9f2327


git log e4db6a151806..ed1dcf9f2327 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for call/ (part 1).


Created with:
  gclient setdep -r src/third_party/webrtc@ed1dcf9f2327

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8ee83b94330beb6325018cb012ba3ff22c674eb9
Reviewed-on: https://chromium-review.googlesource.com/1151847Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578445}

Make the APIPermission enum more difficult to break by adding explicit
numbers to each entry (to avoid having anyone insert something anywhere
but the bottom) and add a unittest to verify the contents match the
enums.xml file.

Also fix the enums.xml file, which was missing the kSystemPowerSource
entry.

Bug: None

Change-Id: I12e6e0deb7221d7a96524e972f7039b43bdb317f
Reviewed-on: https://chromium-review.googlesource.com/1150405
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578444}

Required for network servicification.

BUG=844965

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If09ae972d4e4c0d0015f862774410d99bbe9b876
Reviewed-on: https://chromium-review.googlesource.com/1143709
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578443}

Bug: 867594
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6e3b94e187996b7b153932041074704bd2fb5895
Reviewed-on: https://chromium-review.googlesource.com/1150805Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578442}

Builds on the highlighting code to display highlights in the pie chart.
The hightlights appear as bars along the chart, similar to the diff
view.

Bug: 847599
Change-Id: I5dc0f163ebaa5d46b331b084391e6e09645e5dd3
Reviewed-on: https://chromium-review.googlesource.com/1152090Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#578441}

Most compositing properties should follow the activation flow
instead of being plumbed directly from LayerTreeHost to LayerTreeHostImpl.
This CL is one of many to move properties over to following the activation
flow.

This CL moves the viewport_visible_rect property used to determine how much
to raster to follow the activation flow.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I05ac2b28b8d593eee01904b0bba7f3809cc0492e
Reviewed-on: https://chromium-review.googlesource.com/1150734Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578440}

OnLostResources() was being used in two different ways. First, it was
used when the shared main thread context provider was lost. Second, it
was used to tell when the GPU process was lost (with OOP-D only). This
CL splits this into two different functions, as the actions required in
both cases are different.

OnLostVizProcess() is only needed for OOP-D where we want to let
DelegatedFrameHost know the renderer surface has been destroyed.

The only functional change here is that sometimes
DelegatedFrameHost::OnLostResources() would get called without OOP-D on
Chrome OS. This is because Chrome OS is the only platform that uses the
shared main thread context without OOP-D. Even on Chrome OS shared main
thread context didn't always exist because it's created on demand for
exo/fastink. Not doing anything in OnLostSharedContext() shouldn't be a
problem, if we had to evict the renderer surface on GPU crashes it would
cause problems on all other platforms that use DelegatedFrameHost where
OnLostResources() was never called.

Bug: 827242
Change-Id: Ideebba3c712a2e1ebaf3c852d9aa7721cb1d40d3
Reviewed-on: https://chromium-review.googlesource.com/1150456Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578439}

Using kSystem means it conflicts with other system level landers, such as
the laser pointer.

BUG=867483
TEST=covered by tests

Change-Id: I40581e6ae8716e333d1e64ecd2ae8ebbcbf1936d
Reviewed-on: https://chromium-review.googlesource.com/1151546Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578438}

The LazyLineBreakIterator::IsBreakable method works by comparing a given
position with the next following breakable position. This is inefficient
as well as unnecessary. Instead limit the scan to the given position + 1
as that still allows comparsion of the supplied and the resulting value.

Similarly, the LazyLineBreakIterator::NextBreakOpportunity method always
scans until the end of the string, even if that is past the threshold of
the section of the string processed. By introducing a version that takes
a length parameter, and changing ShapingLineBreaker::ShapeLine to use it
instead of the unbounded one, the scope of the forward scan can therefor
be limited to the length of the line being processed.

These two changes dramatically speed up line breaking both in legacy and
LayoutNG, especially for large text blocks with few break opportunities.

Test: perf_tests/paint/appending-text.html, perf_tests/layout/long-line-nowrap.html

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7a4186510f4451219dd026e8f3ab1ed0c86fa3c2
Reviewed-on: https://chromium-review.googlesource.com/1150853Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578437}