- 24 Jan, 2020 40 commits
-
-
Andres Calderon Jaramillo authored
(See the diff since PS1 for the changes since the original change). This CL relands https://crrev.com/c/1637737. That CL broke Android Q compositing of some mixed WebGL/Canvas2D content. The root cause was an incorrect assumption: that when the framebuffer for the root render pass is bound, we wouldn't try to bind it again before swapping it. This assumption was wrong in the case of drawing a render pass quad onto the root render pass. See [1]. The aforementioned CL would call BeginSharedImageAccessDirectCHROMIUM() upon binding the root render pass' framebuffer and would call EndSharedImageAccessDirectCHROMIUM() only when the buffer is swapped. So, binding the framebuffer multiple times would result in the shared image system thinking that we wanted concurrent access to the SharedImage. This CL fixes that assumption: in case BindFramebuffer gets called more than once before swapping, we just rebind the GL framebuffer without requesting to begin access to the shared image. Additionally, the following changes are made since the original change: - We cache the textures that are produced by consuming the SharedImages from the buffer queue. That way, we don't have to call CreateAndTexStorage2DSharedImageCHROMIUM() for the same SharedImage. - We make sure to delete those textures. - GpuSurfacelessBrowserCompositorOutputSurface no longer exists, so the changes in the original CL for that component are discarded. - We add some unit test coverage to GLOutputSurfaceBufferQueue to avoid this regression in the future. The GLOutputSurfaceBufferQueue interface is changed to make it possible to inject a mock buffer queue for testing. This in turn, requires a change in the BufferQueue interface: instead of passing a SyncTokenProvider on construction, we provide a setter method. That way the BufferQueue can be constructed before the GLOutputSurfaceBufferQueue (and the latter sets itself as the SyncTokenProvider). There are also, unfortunately, some #include changes to satisfy the bots. Original change's description: > This CL migrates the BufferQueue to use SharedImage in order to get > rid of direct GL dependencies (necessary to eventually be able to use > Vulkan). > > Stencil buffer management depends on the specific graphics API (e.g., > GL), so it is moved out of the BufferQueue into its user classes > GpuSurfacelessBrowserCompositorOutputSurface and > GLOutputSurfaceBufferQueue. Note that we don't need to have one > stencil buffer per color buffer: we can reuse the same stencil buffer > across all the color buffers. > > Bug: 958670 > Test: Compositing and overdraw feedback works normally on a nocturne. > Change-Id: Ia85ea8fea81e125b49a3ce2be195873e77397237 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637737 > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723697} Bug: 958670,1033279 Test: visit https://toji.github.io/dinosaurs-static/ on Android Q. Change-Id: I176af87749c90b775f95c54e2155f27ea9177a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977969 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#735022}
-
Francois Doray authored
[sheriff] Disable BookmarkPersonalizedSigninPromoDismissTest#testPromoImpressionCountIncrementAfterDisplayingSigninPromo. TBR=twellington@chromium.org Bug: 1045480 Change-Id: I8b1695e93a1ad7d226795546bcf263fc9f15c82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019703Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#735021}
-
Sigurdur Asgeirsson authored
Also test the counters for sanity, turns out nothing's so simple that it can't be messed up. While it's possible to retrieve the value of the counters from a minidump with a debugger, it's quite awkward in practice. Bug: 1011441 Change-Id: I049eec2e668f61e8c2a7faa200fbde83441944d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019405 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#735020}
-
John Chen authored
First rebaseline for MacOS 10.14, covering all failures under compositing and css* directories. Bug: 1028242 Change-Id: I796720be073022e7c78f0397e6965cfb2a218b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019463 Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735019}
-
Francois Doray authored
R=mustaq@chromium.org TBR=mustaq@chromium.org Bug: 1043985 Change-Id: I16beb5001a913863a03b6670b303e935a9f5ae80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019606Reviewed-by:
-
Stepan Khapugin authored
Remove the OmniboxBasePopupVC class that was necessary with HL behind a flag. Merge its contents to OmniboxPopupViewController. Bug: 943521 Change-Id: I202f388c1ad098766f7addfdcfbce032ffac9a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007710 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735017}
-
Owen Min authored
ExtensionRequestObserver observers the extension policy change. Once an extension in the request list is put into whitelist, blacklist or forcelist, pop-up an notification and remove the request from the pending list once the notification is closed by user. If there are multiple notifications approved or rejected or installed, there will be one notifications for each decesion. If there are new update when the notification is opened, the notification will be refreshed. Screenshot: https://drive.google.com/file/d/1PW5w0grWBKfTWL4HZ7ilimyjlrn7s81w/view?usp=sharing Bug: 1006899 Change-Id: I4ef0f68f4d171addb2d28de1ebfe6fc2baeb71e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018149 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#735016}
-
Aaron Vaage authored
Rather than requiring Chrome to sign the Mac dylib, Widevine will upload signed binaries to Chrome. To stop Chrome from signing the library, this change removes it from the list of dylibs to be signed. Bug: 702834 Change-Id: I4295b12329f863856e6482f17b633710d3f2112b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967606Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Aaron Vaage <vaage@google.com> Cr-Commit-Position: refs/heads/master@{#735015}
-
Michael van Ouwerkerk authored
Bug: 1035433 Change-Id: Ib04f5413245aced84f5fea526841014ce6219459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019022 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#735014}
-
Mark Yacoub authored
If the device supports atomic APIs, use drmModeAtomicCommit to modeset and disable instead of drmModeSetCrtc. Abstracted Modeset and Disabled code to HDPM to handle both atomic and legacy call. Updated tests to support Connector and CRTC props. BUG=987274 TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps, HardwareDisplayPlaneManagerLegacyTest.Modeset, HardwareDisplayPlaneManagerLegacyTest.DisableModeset, HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on Nautilus(Intel), Grunt(AMD) and Cave(Legacy). Change-Id: Ic307c04df4e22d1696abb31ebcd820f6bdcb542a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715751 Commit-Queue: Mark Yacoub <markyacoub@google.com> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#735013}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5ef91b82cbed..e37f2ef6bd6e git log 5ef91b82cbed..e37f2ef6bd6e --date=short --first-parent --format='%ad %ae %s' 2020-01-24 bclayton@google.com Regres: add cmd/run_testlist 2020-01-24 bclayton@google.com Regres: Restructure directories for main packages Created with: gclient setdep -r src/third_party/swiftshader@e37f2ef6bd6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I42b0f7e5bb82b556ed94ecb406733a9e2720fe9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735012}
-
Vladislav Kuzkokov authored
Also merge the definition of secure protocol with one used in printers_map.cc and exclude kUnknown (i.e. "other") from that list. Bug: 848942 Change-Id: I14894d2775c0d6b251866bb0c09b02efc94c3cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005229Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#735011}
-
Mohamed Amir Yosef authored
This a purely mechnical CL that renames some classes to better represent their semantics Bug: 1044034 Change-Id: Ie3135591ca3cb9a8313fa40a81ca38b227ccb93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019029 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735010}
-
Maggie Chen authored
The purpose is to observe the events of monitor plugged-in/unplugged for Direct Composition overlays so we can update the hardware overlay caps upon display change. DisplayAdded() and DisplayRemoved() are added to DirectCompositionSurfaceWin. The display observer goes through the GPU data manager in the browser process first. It will then notify the GPU switch observer in the GPU process through Mojo. This CL is limited to Windows only. The display observer might work (not tested yet) for Mac if we need it later. (But no code support for Linux.) Bug: 1042989 Change-Id: I53dc1689795d569ea60290c13dacfcc7f3ee9152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011134 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Peter Boström authored
This reverts commit e533973d. Reason for revert: Caused regression in LTR. This issue should be fixed by rewriting DownloadItemView to not do manual layout. Bug: chromium:1045314 Original change's description: > Shrink drop-down button in DownloadItemView > > This more closely matches the button size for the close-x at the end of > the downloads shelf. The focus ring and ink-drop highlight was > significantly larger than intended, likely after r619533. > > This change also adds padding left of the drop-down button so that the > "Discard" button doesn't get laid out edge-to-edge next to it with > overlapping focus rings. > > Bug: chromium:1042633 > Change-Id: I3aac0b77846020e0fe3eb612d35f67bf307dbd6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006136 > Auto-Submit: Peter Boström <pbos@chromium.org> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732821} TBR=ellyjones@chromium.org,pbos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1042633 Change-Id: Ie9de1a823eab8dbf1d67ab0573e4801fc60c119c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019467Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#735008}
-
Etienne Pierre-Doray authored
This is a reland of f5886456 Reason for revert: Causes slow renderers on startup with bit9 (See issue 1021701). The revert was merge in M80. This relands as-is to target M81. We're hoping the issue will be fixed on bit9's side by then. Original change's description: > [Setup]: Use memory mapped files in LzmaUtilImpl. > > This CL removes usage of LzmaFileAllocator and tries to write unpack > result directly in the output file. > When uncompressing a folder that maps directly to a file, this is > possible and a memory mapping is used. In practice, this is always > the case. Support for folder containing multiple files is kept as > fallback and uses a pre-allocated file buffer, which is then copied in > individual files. > > For running full setup install from chrome.packed.7z (Kb) > Before: > Setup.Install.PeakPagefileUsage 19748 > Setup.Install.PeakWorkingSetSize 250528 > GetCumulativeDiskUsageInBytes 761134 > After: > Setup.Install.PeakPagefileUsage 19720 > Setup.Install.PeakWorkingSetSize 250512 > GetCumulativeDiskUsageInBytes 297818 > > The difference in memory is not significant, but improvement > are expected mostly for disk usage. > > Bug: 933975 > Change-Id: I26c1b118fc512d2caaa8112d3da37e6db460486b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845956 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709940} Bug: 933975 Change-Id: Iff873de23ce8b8ea9f2600ec2d78e001c7ba7b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018062Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#735007}
-
David Bokan authored
Programmatic smooth scrolls should also be instant if the smooth scroll flag is explicitly disabled. Previously landed in https://crrev.com/c/1536759 To reland, this CL force enables the scroll animator in Blink web tests. Without this, the usual flow for determining if the animator is enabled is followed, which leads to inconsistencies. On Mac, the animator is enabled in Chrome but not in content shell. This leads to inconsistencies with other platforms (Mac tests ran without smooth scroll while Linux/Windows ran with) and ensuring we test what we ship. This change required some minor fixes to tests that assumed instant scroll on Mac (and uncovered one real bug). Bug: 944583 Change-Id: I114d8b882d9855fbe0c43645575a1cdd7c3b6e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009842Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735006}
-
Lukasz Anforowicz authored
Bug: 966223 Change-Id: Ia0f454a6041e5dae6f70b660095f10fcf7429507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008591 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#735005}
-
Donn Denman authored
Removes the chrome://flags feature EphemeralTab but leaves the EphemeralTabUsingBottomSheet feature in place. Also updates the code to only need the one flag. Still TODO: Remove the dead code for the Overlay panel version of the Preview Tab (aka Ephemeral Tab). BUG=1044723, 1043677 Change-Id: Ia1ff10957a1e2bd2cfc304bf09c428635bad2645 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015743 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#735004}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/241fe49617e2..7a319697e3aa Created with: gclient setdep -r src-internal@7a319697e3aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:973101 Tbr: jbudorick@google.com Change-Id: I76bc33f12347702c8c24e0f911c814d437541eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019842Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735003}
-
Scott Haseley authored
Adding UseCounters for postTask, TaskController, and TaskSignal now that the IDLs have settled a bit and we have something we want to OT. Bug: 979017 Change-Id: I265bfdf9f6ef3217ec2b65abf62f0af0fd2c0da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017677Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Scott Haseley <shaseley@chromium.org> Cr-Commit-Position: refs/heads/master@{#735002}
-
Khushal Sagar authored
Ensure that the original usage flags a shared image is created with are retained if its transformed via an ImageBitmap. Bug: 1036142 Change-Id: I86ac384ab4ceefd9f581115e722b42b44bc3756d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970589 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735001}
-
Yusuke Sato authored
When it is enabled, the CL mounts the squashfs image as /dev/vdd. BUG=b:143780893 TEST=manually place the image file in /run/imageloader as Omaha side is not ready yet, manually modify the UpgradeParams, then start ARCVM and run 'mount /dev/block/vdd /odm' in android-sh. Change-Id: I7744ad8d3d2d79b5a2efa21384fa8ea256c0df23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016290 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#735000}
-
Michael Ludwig authored
Bug: 1045050 Change-Id: Iad5a53d2053b6a27bd08ac6824319af4450c15fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019604 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#734999}
-
Sami Kyostila authored
Change-Id: I16e729f7c0dcc994cb691345b05832ec70621641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019344Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#734998}
-
Sylvain Defresne authored
In preparation of moving ios::ChromeBrowserState to the global namespace, fix the indentation in app_launcher_tab_helper.mm as "git cl format" wants to fix it when updating the type of the browser_state variable. Fixing the indentitation in a separate CL allow to make the CL performing the move easier to review. Bug: none Change-Id: I7a54bc3c13510c5bfd39b4de7f83bb0512fac056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014933 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734997}
-
Alexander Timin authored
R=rockot@chromium.org Change-Id: Iba556a1d642d1dc4fb78e6960af104861396f54e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019364 Auto-Submit: Alexander Timin <altimin@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
-
Klaus Weidner authored
The barebones XR sample was missing a negation, keeping the start button disabled unexpectedly. Copy the (fixed) barebones XR sample to create a barebones AR sample with an optional DOM Overlay. Also add a bit of CSS to make the barebones "enter XR" button a bit easier to hit (and less ugly). Change-Id: Ia2750b4c83d75d3f1faf3628a8593c9c78960442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016357 Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#734995}
-
Francois Doray authored
TBR=rsleevi@chromium.org Bug: 1045472 Change-Id: Ic4d076cf953355b8bd816af4712542d52264f21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019408 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=marq@chromium.org Bug: 1042208 Change-Id: I84a18e74598f0cdabaa1b04a4953cc49903e060e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017511 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Updating testSignInOpenSettings to make it more clear, and to simplify the code. Change-Id: I07420ced98606498b4e15722776b07e6f934b09e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015248 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734992}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I32d97be235c917b49a3bcb7866cf5083f4b0175f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005975Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=noyau@chromium.org Bug: 1042208 Change-Id: I60e6158956d7e37747845e8ee68d06b97b2eecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017428Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734990}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=noyau@chromium.org Bug: 1042208 Change-Id: Ic10c1f5b1f65ac65d14cea64f0ad688aef5eb971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014973Reviewed-by:
-
John Budorick authored
Mistakenly updated the system image package instance ID rather than the avd package instance ID in crrev.com/c/2003563. Bug: 922145 Change-Id: Id7535607acc4e73415b5f39a1ba08262c92897ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017822 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#734988}
-
yilkal authored
WebTimeNavigationObserver is used to notify its event listeners when a navigation finishes. Bug: 1034551 Change-Id: Ic233f11bbf17b6c0c6eccda9b9f52c8ded3feea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004994Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#734987}
-
Koji Ishii authored
Following bot results are included. 1101 1105 1108 1111 1112 1114 1115 1116 1118 1119 1120 52 lines were removed and 12 lines were deflaked by consecutive results since 1094. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ia243b17fbe6214e126ceaf5c47f94e4d4835975a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016682Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734986}
-
Marian Fechete authored
This CL merges client memory into user data; removing parts of the client memory and parts of the former user data. In a previous CL, user data ownership was moved to the controller to allow it to be retained across multiple collect user data actions. With this CL, client memory is removed/merged into user data so that all the user values retained on the client will eventually be kept in a single place. Also in this change, selected_profile, billing_address and shipping_address are no longer separate/individual fields on the user data, rather they are stored in the autofill profiles map. Note that the action delegate can now provide the user data instead of the client memory. This is plumbed through from the controller via the script tracker. Bug: b/148132177 Change-Id: Ife130d7537680fd214459bc2d80610cd8c3dfea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014450 Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#734985}
-
Jan Wilken Dörrie authored
Similarly to r733548 this change migrates the remaining base::PostTaskAndReplyWithResult APIs to use base::OnceCallback and updates their call sites. TBR=danakj@chromium.org Bug: 714018 Change-Id: I50d1038be0efc180313e43556848984ce0a42720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016624 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#734984}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d87e67684558..fa06dd0b6210 git log d87e67684558..fa06dd0b6210 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 cwallez@chromium.org Fix Vulkan Swiftshader build on macOS Created with: gclient setdep -r src/third_party/dawn@fa06dd0b6210 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I1c6cca7a1f55424e81a508c642a4d61e3096f3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019078Reviewed-by:
-
