GitLab

Because Declarative Web Request lacks an active owner at the moment, this CL adds a warning notice to the API's documentation site:
"this API is currently on hold, without concrete plans to move to stable"

Staged at https://chrome-apps-doc.appspot.com/_patch/276483005/extensions/declarativeWebRequest, but http://crbug.com/371402. Screenshots in my GDrive: https://drive.google.com/a/google.com/folderview?id=0Bx9cneu-k1RNeUZnRk5NWERObE0&usp=sharing (Google only, but let me know if you come from outside and need them).

Original at https://developer.chrome.com/extensions/declarativeWebRequest

BUG=112155

Review URL: https://codereview.chromium.org/276483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269567 0039d316-1c4b-4281-b951-d872f2087c98

Navigating directly to chrome://settings/syncSetup in guest mode is causing a DCHECK() failure, since the ProfileSyncService is NULL in the guest mode.

This patch adds a NULL check on ProfileSyncService to fix the crash
and also terminates the sync setup if the service is NULL.

BUG=370861

Review URL: https://codereview.chromium.org/277433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364141, 330264

Review URL: https://codereview.chromium.org/261013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269565 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371148

Review URL: https://codereview.chromium.org/278853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269564 0039d316-1c4b-4281-b951-d872f2087c98

Snapping which is intended to snap to existing scale during pinch
is not working. That is, because the snap ratio constant is wrong,
snapping logic do not work and might make extra tiling during pinch.

BUG=368203

Review URL: https://codereview.chromium.org/256343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269563 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/277893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269562 0039d316-1c4b-4281-b951-d872f2087c98

A recent refactoring accidentally removed the code that turns on vsync
for synthetic gestures. This causes the gesture to never start if
nothing else happens to turn on vsync at the same time.

BUG=370967
TEST=tools/perf/run_benchmark rasterize_and_record_micro.key_silk_cases
--browser=android-chrome --page-filter=slide_drawer

Review URL: https://codereview.chromium.org/269343013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269561 0039d316-1c4b-4281-b951-d872f2087c98

Replace DCHECK with conditions and set the connection status as
unencrypted, if the security_style is unknown / HTTPS without a
certificate / not HTTPS.

BUG=344891

Review URL: https://codereview.chromium.org/172173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269560 0039d316-1c4b-4281-b951-d872f2087c98

Under current implementation, extension part of entry name (after the last '.') is not focused even when users rename directories.
For directories, whole entry name should always be focused.

BUG=371676
TEST=manually tested

Review URL: https://codereview.chromium.org/279753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269559 0039d316-1c4b-4281-b951-d872f2087c98

Also revert the temporary change for the sandbox test framework,
which allows fork() with threads.

https://codereview.chromium.org/242383003

TEST=nacl_loader_unittests, components_unittests, and trybots
BUG=364751

Review URL: https://codereview.chromium.org/273623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269558 0039d316-1c4b-4281-b951-d872f2087c98

We don't offer the flag on non-Aura platforms, but it's certainly possible
for a user to enter the CLI flag manually. We'd prefer not to crash in
that case.

BUG=261628

Review URL: https://codereview.chromium.org/276523003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269557 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the app list would be centered only when the virtual
keyboard is enabled. Now it is centered whenever the virtual keyboard
might be enabled, with the following new cases:
- If --ash-enable-touch-view-testing is on.
- If any accelerometer data is detected (as this can trigger virtual
keyboard).

BUG=369382
TEST=Run ChromeOS with --ash-enable-touch-view-testing. App launcher
should be centered and landscape.

Review URL: https://codereview.chromium.org/264523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269556 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/274473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269555 0039d316-1c4b-4281-b951-d872f2087c98

This test assumed that the ExtensionDownloader schedules its fetchers
in the order that StartUpdateCheck() is called, when downloading more
than one ManifestFetchData. However, the ExtensionDownloader was updated
in http://crrev.com/171540 to use a RequestQueue, which schedules the
fetchers using a heap.

That heap sorts the requests by time to the next retry, which is 0
for all requests initially. The test didn't break before because
std::push_heap and std::pop_heap in all STL implementations used
happen to keep the same order when all requests have the same
priority (!). This assumption broke under TSAN/MSAN builds because
they use libc++, whose std::pop_heap changes the order of the
execution of the fetches.

This fix makes the test support its fetches in any order.

BUG=358712

Review URL: https://codereview.chromium.org/271873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269554 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Update DomDistillerJsUpdater and Roll DomDistillerJs (https://codereview.chromium.org/277563002/)

Reason for revert:
check_licenses failure: http://build.chromium.org/p/chromium/builders/Linux/builds/49667

Original issue's description:
> Update DomDistillerJsUpdater and Roll DomDistillerJs
> 
> The update script should build `ant package` and copy the entire
> out/package directory.
> 
> This moves the path to domdistiller.js to .../package/js so update
> that reference.
> 
> The old (non-proto) API is still supported, so this keeps using that.
> 
> Picked up changes:
> fdb023d Fix Proto module's path
> 44e9366 This adds two simple protoc plugins.
> 
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269485

TBR=yfriedman@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/278143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269553 0039d316-1c4b-4281-b951-d872f2087c98

They're only used as a synchronous signal to start/stop the audio sink.

BUG=144683

Review URL: https://codereview.chromium.org/275673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269552 0039d316-1c4b-4281-b951-d872f2087c98

In RTL languages, entry names (file names, directory names, volume names,...) look strange around the neutral characters (' ', '.', ')'...).
This can be avoided by keeping base direction of bidi algorithm 'ltr' consistently and it is same behavior as Windows 8.

BUG=371232
TEST=manually tested

Review URL: https://codereview.chromium.org/273983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269551 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue with the experimental app launcher's buttons being laid
out above the app grid due to the contents view being re-added on profile
switch. This has been fixed by ensuring the contents view is always added to
the same position.

BUG=371695

Review URL: https://codereview.chromium.org/272923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269550 0039d316-1c4b-4281-b951-d872f2087c98

-[NSWorkspace setIcon:] has a bug (rdar://16129816) handling
premultiplication when using named NSImages. This is most noticeable for
the small assets, since there is a higher proportion of pixels with an
alpha component.

We still want to use a named image for the larger icons because the
folder asset is textured and doesn't compress well. This CL changes the
16x16 and 32x32 assets to use a pre-rendered icon, rather than an
overlay.

BUG=305373

Review URL: https://codereview.chromium.org/270623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269549 0039d316-1c4b-4281-b951-d872f2087c98

This merges the PDFMessagingHost functionality into PDFViewer and renames
PDFMessagingClient to PDFScriptingAPI. PDFMessagingHost provided an extra
layer of indirection between the page communicating with the PDF viewer
and the viewer itself which made it difficult to add new functionality.

BUG=303491

Review URL: https://codereview.chromium.org/266413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269548 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334149
R=ager@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/278513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269547 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes task items' layout problem in action button (as combobutton) and default task (in context menu).
In the screenshot attached in issue 371232, these problems are pointed as "Icon position of task menu is strange.". 
For margin and padding, I used -webkit-margin-start etc..
For background position, I used separate selector for html in 'rtl'.  

BUG=371232

Review URL: https://codereview.chromium.org/278793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269546 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366354
TBR=kinuko@chromium.org

Review URL: https://codereview.chromium.org/268363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269545 0039d316-1c4b-4281-b951-d872f2087c98

In Debug build:

$ gn gen out/Debug --args='os="android" cpu_arch="x86"'

$ ninja -C out/Debug ui_base_jni_headers

In Release build:

$ gn gen out/Debug --args='is_debug=false os="android" cpu_arch="x86"'

$ ninja -C out/Release ui_base_jni_headers

BUG=None
TEST=see above
R=brettw@chromium.org
TBR=ben

Review URL: https://codereview.chromium.org/266153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269544 0039d316-1c4b-4281-b951-d872f2087c98

cursor_mac.mm is never included on any Mac build because it's removed for all non-aura builds, which includes Mac. This file just seems to be stubs anyway.

Also fixes a missing comma in the GN Mac build.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/267013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371469

Review URL: https://codereview.chromium.org/277683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269542 0039d316-1c4b-4281-b951-d872f2087c98

Instead, perform stricter error checks.

Stop calling EnoughDiskSpaceIsAvailableForDBOperation() in ResourceMetadata::Initialize().
To distinguish serious failures from not-found cases, change the return type of  ResourceMetadataStorage's methods to FileError.

BUG=319410
TEST=unit_tests

Review URL: https://codereview.chromium.org/265833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269541 0039d316-1c4b-4281-b951-d872f2087c98

There is no need to keep the file descriptor open in net_internals_ui.cc as libdbus duplicates the FD when appropriate.

Use base::File instead of PlatformFile.
Use blocking pool instead of WorkerPool.

BUG=369183
TEST=Can save debug logs in "Chrome OS" section of chrome://net-internals on a Chromebook.

Review URL: https://codereview.chromium.org/270853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269540 0039d316-1c4b-4281-b951-d872f2087c98

These were writing to the current user's downloads directory instead of
a unique temporary directory.

BUG=372017
R=asargent@chromium.org, jamescook@chromium.org
TBR=asargent

Review URL: https://codereview.chromium.org/276133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269538 0039d316-1c4b-4281-b951-d872f2087c98

These browser_tests were writing to the current user's downloads
directory. While this is bad in itself, it is also suspected as the
cause of test failures on the waterfall.

BUG=372017
R=jamescook@chromium.org
TBR=jam

Review URL: https://codereview.chromium.org/274273003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269536 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Linux Asan is failing with this patch: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2483/steps/unit_tests/logs/stdio

Original issue's description:
> Resubmit: Add real file for AdNetworks DB
>
> This is a resubmit of https://codereview.chromium.org/268063004/.
>
> The previous version was reverted because it caused a memory leak. This was a
> problem with RefCounting from ui::ResourceBundle::LoadDataResourceBytes(), which
> has been fixed.
>
> Details:
> Even though the method returns a non-refcounted ptr to a RefCountedStaticMemory
> (which according to the class comment, "the ref counting does not matter" [1]),
> the ref-counting _does_ matter. The fix for this went in as part of a refactor
> in https://codereview.chromium.org/263953003/.
>
> [1] http://src.chromium.org/viewvc/chrome/trunk/src/base/memory/ref_counted_memory.h?revision=267321 line 44
>
> BUG=357204
>
> TBR=jhawkins@chromium.org (previously approved)
> TBR=felt@chromium.org (very minor changes)
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269494

TBR=jhawkins@chromium.org,felt@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=357204

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269512

Review URL: https://codereview.chromium.org/277133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269535 0039d316-1c4b-4281-b951-d872f2087c98

Surface/buffer lifetimes are no longer bound by the controller. In addition,
it is possible for multiple controllers to be linked against the same surface,
making it impossible for a controller to know if the framebuffers need to be
unregistered. Thus move framebuffer initialization into the buffer object.

NOTRY=true

Review URL: https://codereview.chromium.org/276753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269531 0039d316-1c4b-4281-b951-d872f2087c98

Now that we use RecvMsgWithPid to find the PIDs for zygote children,
we no longer need to plumb the chrome-sandbox path down into and
through the renderer host code.

BUG=357670
NOTRY=true

Review URL: https://codereview.chromium.org/276763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269530 0039d316-1c4b-4281-b951-d872f2087c98

GetCurrentConnectionType (in NetworkChangeNotifier.java) gets actual connection type if the value is CONNECTION_UNKNOWN.

BUG=370292

Review URL: https://codereview.chromium.org/264973019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269529 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns at:
Error: Call requires API level 18 (current min is 14):
    android.hardware.usb.UsbDeviceConnection#bulkTransfer [NewApi]

So we need to add @TargetApi to suppress this lint error.

BUG=327768

Review URL: https://codereview.chromium.org/276943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manually
R=asvitkine@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/269343008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269527 0039d316-1c4b-4281-b951-d872f2087c98

R=xiyuan@chromium.org
BUG=368004

Review URL: https://codereview.chromium.org/270973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269525 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a crash in the app list where a NULL AppListItemView
wasn't checked.

BUG=371309

Review URL: https://codereview.chromium.org/271753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046

Review URL: https://codereview.chromium.org/270703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269523 0039d316-1c4b-4281-b951-d872f2087c98

The inner loop in MergePacketEvent should be using j to access the
BasePacketEvents.

Also improved merging logic in MergeFrameEvent a bit.

Review URL: https://codereview.chromium.org/263293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269522 0039d316-1c4b-4281-b951-d872f2087c98