- 30 Nov, 2020 40 commits
-
-
Michael Thiessen authored
The CCT doesn't always have a tab by the time the Activity is resumed (not yet with native). Bug: 1153703 Change-Id: I1315d32b8b8ec635b865a9d661a661d3ed3f0061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564690Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#831937}
-
Peter McNeeley authored
When the path for the accelerometer "/dev/cros-ec-accel/" is inaccessible this error reporting will spam the log many times per second. Here we simply add a backoff to throttle how often this logging will occur. The reason for the inaccessibility of this path is likely due to incorrect group setting. Some dev-only specific changes may be required to the file below in order to apply these group settings in a dev/debug specific context. https://source.corp.google.com/chromeos_public/src/third_party/ chromiumos-overlay/chromeos-base/chromeos-accelerometer-init/ files/udev/99-cros-ec-accel.rules?q=mems_setup&ss= piper%2FGoogle%2Fchromeos_public:src%2F&start=31 Change-Id: I12ad7d27e5710c86292ca08dee0f5680a2ddb153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563700Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#831936}
-
Peter Wen authored
When d8 is used for desugaring instead of bazel's desugar, lambdas may not have a .dex suffix. This CL accounts for lambda normalization where apkanalyzer's output does not have .dex suffixes. This CL also fixes output for supersize html_report. Bug: 1015559 Change-Id: I5e81f4b03562047bfcfadcfa91a73339cf21850b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562792 Auto-Submit: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#831935}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/41e380345098..e177dd9adffc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1131960 Tbr: rogerta@google.com Change-Id: I933b5d6a0bdedf184199e62615a1de2d7b89386c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564484Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831934}
-
Illia Klimov authored
Bug: 1149393 Change-Id: I185c8e76078af0137d9d82b1dbbb78b67928cd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564762Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Illia Klimov <elklm@chromium.org> Cr-Commit-Position: refs/heads/master@{#831933}
-
Patrick Noland authored
Bug: 1153875 Change-Id: I050d43c1faaa07e21746fa1e0c58f498e18d8593 TBR: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565733Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#831932}
-
Akihiro Ota authored
The reason this test was flaking is because the tutorial opens whenever ChromeVox is started in OOBE. As a result, a speech expectation would fail periodically. Out of 10 initial test runs, 2 failed. After this patch, all 10 test runs succeeded. Bug: 1153710 Change-Id: I680ea42859414bd8c94a10a8c1f586c11cb381ce AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563877Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#831931}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/services Bug: 1113033 Change-Id: I77be505bd5f33ee1bd83a594ec09aa64cac21420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560823Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831930}
-
Joshua Pawlicki authored
Bug: 1149863 Change-Id: Idd49249653a3b5d845dd4bc9a87601de35cfbc05 Fixed: 1149863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563876 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#831929}
-
Regan Hsu authored
ChromeVox will also verbalize the updated tooltip text when the user navigates to the icon. screenshot: https://storage.cloud.google.com/chromium-translation-screenshots/82bd6c8d6f97a440125bbac1610cc42331efeca6 Fixed: 1152778 Change-Id: Iab5de3cb6024f7151aea3c5632de7f6679080763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560996 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#831928}
-
Tamir Duberstein authored
This is a reland of 1bef8501 Original change's description: > [fuchsia] Enable UDPSocketTest.JoinMulticastGroup > > Assert after each send call to better pinpoint future problems. > > The test passes locally. > > Fixed: 1125855 > Change-Id: I30d5c7bd2bc14fbd9547b1eb6d309d7556274891 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404483 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Tamir Duberstein <tamird@google.com> > Cr-Commit-Position: refs/heads/master@{#806111} Fixed: 1127298 Change-Id: I8d20c8247d9729511963eff35a6f276e0a82ae78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405934Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#831927}
-
Clemens Backes authored
We currently use the existing v8 inspector tests as seed for the inspector fuzzer. They don't work well for a couple of reasons though: 1) The inspector tests use utilities defined in the 'protocol-test.js' file, which is preloaded automatically by the inspector test runner. That file is part of the corpus, so the fuzzer might get lucky and combine 'protocol-test.js' with another corpus file, but in most cases it won't. 2) The inspector fuzzer does not provide all utils that the inspector-test executable provides. In particular, file access is prohibited, i.e. `utils.read` and `utils.load` are not available. 3) Some tests load more files as prerequisite, e.g. all wasm tests load the 'wasm-inspector-test.js' file which defines wasm-specific utilities. 4) The current corpus also includes the '*-expected.txt' files, which is not a big problem, but adds files to the corpus which are not interesting for the fuzzer. This CL fixes all these issues by generating the corpus via a small python script. The script scans the v8/test/inspector directory for '*.js' files, and generates a respective fuzzer corpus file in the output directly. This file includes a copy of the 'protocol-test.js' file, and all `utils.load` calls are resolved as well. R=mbarbella@chromium.org CC=machenbach@chromium.org, szuend@chromium.org Bug: chromium:1142437 Change-Id: I1f15182b7afcc7741c9daf96af8e734af3325f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563552Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831926}
-
Patrick Noland authored
PasswordSettingsTest#testSearchTextInOverflowMenuVisibleWithFeature Bug: 1153707 Change-Id: I75a24aa1600c3625c70b9166886bfd9b88f2f645 TBR: fhorschig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564216Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#831925}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I5753fffa991af72c48e0ca175a794040b0637b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562144 Commit-Queue: Peter Williamson <petewil@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#831924}
-
Jose Dapena Paz authored
Fix compilation error: ../../base/compiler_specific.h:97:28: error: attributes are not allowed on a function-definition 97 | #define WARN_UNUSED_RESULT __attribute__((warn_unused_result)) | ^~~~~~~~~~~~~ ../../media/gpu/vaapi/vaapi_wrapper.h:322:36: note: in expansion of macro ‘WARN_UNUSED_RESULT’ 322 | const T* data) WARN_UNUSED_RESULT { | ^~~~~~~~~~~~~~~~~~ Bug: 819294 Change-Id: I24e2e10a96182f8705fed96164550357acdb55a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534931 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#831923}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/gcm_driver Bug: 1113033 Change-Id: Ief65b636329b792885a00dd81201361da28e0ee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543585Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831922}
-
David Van Cleve authored
This is a revert of crrev.com/c/2451571, which added short-term logging to propagate resource blocks caused by extensions to the Fetch API surface and expanded the TrustTokens.FetchFailedReason enum to include this case. Now that we've finished the investigation for which we added this instrumentation, we can clean up the logging changes. This is the first of two cleanup CLs; the next CL will remove the remaining FetchFailedReason logging in FetchManager. Bug: 1133944 Change-Id: I24ddbf366eb288f4b3c7cd1dbd3cc324918bc644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561742Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#831921}
-
Maciej Pawlowski authored
Sometimes cursorPosition computed based on mUrlBarEditingTextProvider would be larger than the size of textWithoutAutocomplete given to onTextChanged(). This happened when typing really fast on a slow device, in Debug builds. To ensure this situation doesn't trip a DCHECK within AutocompleteControllerAndroid, use the up-to-date value of mUrlBarEditingTextProvider's text when passing a computed cursor position. Bug: 1142817 Change-Id: Id6ef48d561461fd711cbc9a4abab8851b8406a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503693Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Maciej Pawlowski <m.pawlowski@eyeo.com> Cr-Commit-Position: refs/heads/master@{#831920}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/9dff6a3bb595..7cbb98085a26 2020-11-30 bclayton@google.com SpirvShaderDebugger: Fix crash when attempting to display nullptrs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1e4920746a2b6151dbce8a3604c7e81d47e1ae0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565101Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831919}
-
Fabrice de Gans-Riberi authored
Bug: 1023510 Change-Id: Iaa28b3b7eb61add4708a94fdca86e1def919c35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545878Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#831918}
-
Peng Huang authored
libxshmfence has two implementations (futex and pthread), It depends on the build environment and build flags in build time. The Xserver and X clients must use the same implementation to work. So we cannot put libxshmfence in //thrid_party/ and link it in statically. Chrome has to use system provided libxshmfence.so which is used by the Xserver to work. Bug: 1153156 Change-Id: I0c9f9f6d716fa7cd5fc389f887618adc9eea206f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563871Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#831917}
-
Maksim Ivanov authored
Fix bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I3420b6c260b9fa94847b9b63df0438a9bce0b1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556838 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#831916}
-
Robert Kroeger authored
conformance/extensions/s3tc-and-rgtc.html is persistently failing on NVidia Shield on GPU FYI. Suppress the test. Bug: 1153676 Change-Id: Ia7fb0cc2779c3fffd58bf081349e32c55fccc560 TBR: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564056Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#831915}
-
Norman Rosas authored
Added DIR_METADATA files to a batch of subfolders in //components/a… and //components/b... , also removed duplicated metadata from OWNERS files Bug: 1113033 Change-Id: I167e955eb480a5ef21bd482f588640dd5ad1323c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560063Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831914}
-
manukh authored
|TryEncoding()| invokes |base::UTF16ToCodepage()|, |net::EscapeQueryParamValue()|, and |net::EscapePath()|. All 3 create strings of 3 times the length of the input. This is suspected to be causing about 50 crashes per month. Invocations to |TryEncoding()| that have resulted in crashes have originated from different sources; e.g. omnibox & autocomplete, extensions, and on startup. This CL truncates the input string to 1,000,000 chars. Bug: 1137686 Change-Id: I16e997666c07611d24472bcbee99893138e9c5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559284 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#831913}
-
Sajjad Mirza authored
Bug: 1141727 Change-Id: I763275bb48fd368cbb7ce7bfe5f9979c81201042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560835 Auto-Submit: Sajjad Mirza <sajjadm@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#831912}
-
Christian Dullweber authored
Avoid crashing if favicon is loaded after dialog is dismissed. Hide permissions section if site settings are not available. Also show JS in permissions section if non-default. Tbr: eokoyomon@chromium.org Bug: 1153619, 1153623 Change-Id: I6c65f197abdfc97a1d1c7478ac91d259fc9f735a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563670Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#831911}
-
Francois Doray authored
These histograms gave an approximate idea of the latency between when a task is posted and when the ThreadPool starts executing it. However, they were imperfect: - If the task is posted just before the system sleeps, it may run after the system wakes up from sleep, resulting in a long latency being reported. - The task is more likely to be posted just after the system wakes up from sleep. - The task can be posted in a background renderer. The latency will be high because the process priority is low. We have no way to distinguish this case. - The task can be posted when the user is not actively using Chrome. The latency will be low because there are no other tasks. We have no way to distinguish this case. Fixed: 1089861 Change-Id: Ibc4c8dc6c4e2ce38e69e7ccfd9ddcda0218dd20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526173 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#831910}
-
Robert Sesek authored
This is a reland of 4f35dbaf Original change's description: > mac: Update LSMinimumSystemVersion from 10.10 to 10.11 > > Bug: 1148931 > Change-Id: Ic0cdded0c1c4821689486cacd5790fce82c40c87 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537057 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827937} Bug: 1148931 Change-Id: Iffeecf8cde404f389f5b868000ef18e58598caac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551317Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#831909}
-
kylechar authored
Small code improvements after spending a bit of time looking at the class functionality. Bug: none Change-Id: I60109c1c8a13e59219f728449926899ddcc686c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563377Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#831908}
-
Charlene Yan authored
Test is flakey on all platforms, but causing Mac10.11 Builder to fail. TBR=rogerta@chromium.org Bug: 1153702 Change-Id: Ie3088761021783e2c8d84bfda29dd8bfea1525e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564215Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#831907}
-
Norman Rosas authored
Generate DIR_METADATA files and remove metadata from OWNERS files for //components/search... Bug: 1113033 Change-Id: Iecba1f8b63600b3be28eb9884ee492286ce0fafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560822Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Norman Rosas <normando@google.com> Cr-Commit-Position: refs/heads/master@{#831906}
-
Roman Aleksandrov authored
This is a reland of 6a91223c It was reverted because of test flakiness which caused by race condition while entering pin. Original change's description: > PinSetupScreen: Cover screen by user action metrics. > > > Bug: 1134354 > Change-Id: Ib18683e1b442af48bf180305e60258a28bce8439 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546003 > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831359} Bug: 1134354 Change-Id: I6df9f46c9aec51d70d19324fdaa87e8e255ad4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562384Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#831905}
-
Christoph Schwering authored
Bug: 896689 Change-Id: I137748f61115fdef07519a10017411ca592799fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564858 Auto-Submit: Christoph Schwering <schwering@google.com> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#831904}
-
Xiaoqian Dai authored
In current implementation, if a snapped window with a transient child window gets unsnapped from splitview, it was not removed from SplitViewDivider's observed transient window list, which may cause crash later. Bug: 1140115 Change-Id: I7f3b6b76a3e4a3f6b8605a19e4671b4c11fd29e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553151Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#831903}
-
Greg Thompson authored
FilePathWatcher::Watch(bool) is going away. No functional changes. BUG=1147071 This CL was uploaded by git cl split. R=tommycli@chromium.org Change-Id: I763198654ce1410bbff030223d28f982e6f3a132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550791 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#831902}
-
Joey Scarr authored
Bug: 1145769,1145768,1071344 Change-Id: I5005d7db18d8fd7393e301da6854a7269d3b9727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560524 Auto-Submit: Joey Scarr <jsca@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#831901}
-
Khushal authored
This reverts commit 158b87d2. Reason for revert: Fix for crbug.com/1148995 which caused a crash in the old overlay path has landed. Original change's description: > Revert "gpu: Disable SurfaceControl on Samsung devices running Q." > > This reverts commit c8c22806. > > Reason for revert: crbug.com/1144660 > > Original change's description: > > gpu: Disable SurfaceControl on Samsung devices running Q. > > > > A platform bug can result in transaction acks getting dropped which > > stalls all rendering. A fix for this will be released in an R update > > soon so this changes disables using this API in Q. > > > > This also reverts an earlier workaround which was added for samsung dex > > mode since its not necessary after this change. > > > > TBR=skyostil@chromium.org > > > > Bug: 1131081 > > Change-Id: I8d053f160fd8ad5bf6ce47d5e6e295c322bace69 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491401 > > Commit-Queue: Khushal <khushalsagar@chromium.org> > > Reviewed-by: Bo <boliu@chromium.org> > > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > > Auto-Submit: Khushal <khushalsagar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#820511} > > TBR=nyquist@chromium.org,boliu@chromium.org,khushalsagar@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1131081 > Change-Id: I55a3a9e8329b062ffbd506650fd7aca483172908 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538417 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827533} TBR=nyquist@chromium.org,boliu@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1131081 Change-Id: I3f40ae5ee1142d061aa2e4ae18d22b9019a28878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564943Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#831900}
-
Jeremy Roman authored
Change-Id: I53d62db14db0ff6908726c9fc9e61492f9cb1276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2561751 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#831899}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca92424e21e5..dc75a97b8010 2020-11-30 johnstiles@google.com Add global struct definitions to SkSL. 2020-11-30 johnstiles@google.com Add unit test for function dead-stripping. 2020-11-30 johnstiles@google.com Add support for enums in Metal code generator. 2020-11-30 johnstiles@google.com Migrate dedicated SPIR-V tests to golden outputs. 2020-11-30 johnstiles@google.com Remove ^^ operator from Metal codegen. 2020-11-30 reed@google.com Don't force linear when extracting miplevel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I391278da0c5cf319fa049d447f354c5ec1c5dbc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565100Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#831898}
-