GitLab

Previously, Video Player tried loading even if it's not installed. This patch checks the status of load and if the load is failed, installs the extension in background and tries loading again.

BUG=399557
TEST=manually tested
R=hirono@chromium.org, kinaba@chromium.org
TBR=mkearney@chromium.org
# TBRing for adding argument to private API in the idl file.

Review URL: https://codereview.chromium.org/437593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287280 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
R=brettw
TBR=sky

Review URL: https://codereview.chromium.org/433603006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287279 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/439113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287278 0039d316-1c4b-4281-b951-d872f2087c98

These buffer interfaces will allow SerialIoHandler to support both the
existing SerialConnection implementation and one implemented using Mojo
data pipes.

BUG=389016

Review URL: https://codereview.chromium.org/423373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287277 0039d316-1c4b-4281-b951-d872f2087c98

Change WebAnimation to WebCompositorAnimation
Change WebAnimationCurve to WebCompositorAnimationCurve
Change WebAnimationDelegate to WebCompositorAnimationDelegate

This is patch 2 of 3. This builds on http://crrev.com/414643002

BUG=396358

Review URL: https://codereview.chromium.org/413983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287276 0039d316-1c4b-4281-b951-d872f2087c98

Original code review: https://codereview.chromium.org/436753002/

TBR=agl@chromium.org,rch@chromium.org
BUG=399457

Review URL: https://codereview.chromium.org/439133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287275 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287272 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179454:179454&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/439663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287271 0039d316-1c4b-4281-b951-d872f2087c98

Previously it ran as part of Chrome's unit_tests. This requires factoring out
the usage of TestingProfile and swapping in a MockExtensionSystem.

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/428953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287267 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397066
TBR=earthdok@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/437083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287266 0039d316-1c4b-4281-b951-d872f2087c98

If |db_iterator_->Valid()| was false AND |map_iterator_ != db_->pending_.end()|,
|Iterator->Next()| did nothing.

BUG=None
TEST=./unit_tests --gtest_filter="LevelDBWrapperTest.*"

Review URL: https://codereview.chromium.org/426063008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287265 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287264 0039d316-1c4b-4281-b951-d872f2087c98

465c2a8  Fix buffer size boundary check offset by 1
90d1f9b  Add more |bpc| value check in GetValidBpc()
b7e2af9  Fix for min/max compile error on Windows
d4ca3b4  Revert 'gn: cross-platform exception disable'
4923e3c  gn: cross-platform exception disable
ecc73b9  remove .gitattributes to prevent automatic CRLF conversions
515c26b  Correct the names of the FX_SAFE_* typedefs.
09363c8  Fix a few more -Wreorder warnings.
c2df91c  Remove CPDFSDK_Annot::ResetAppearance().
2fd400c  Fix integer overflow when stretch bitmap
10ec7ca  Fix uninitialized coords and one of infinite loops
55681f9  Remove a few unused variables, functions, and member variables.
ec570e5  Fix a few -Wreorder warnings.
96608b3  Add missing braces for aggregate initializers.
f04bd76  Fix potential integer overflow in fpdf_render_loadimage.cpp
f1d18bb  Attempt to fix some -Woverloaded-virtual warnings.
fe08482  Fix incorrect override of GetLayoutOrder().
8dee6ca  Fix the potential integer overflow from 'offset+size' in extension.h and fpdfview.cpp
0d3b5cc  Speculative fix for uninitialized value in CFX_ByteString().
cc96527  Fix the typo of "Resources" keyword
621d4de  Tidy up app::response().
6c55495  Fix a few more warnings in chromium_code mode.
c77e8f7  Remove a few unused variables, functions, and tables.
3b07e75  Remove 'inline' from two methods.
e7e6ca4  CalRGB color correction
3414a64  This change is for fixing the potential integer overflow from "offset + size"

BUG=382667,392956,391929,387854,395636
TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/432173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287263 0039d316-1c4b-4281-b951-d872f2087c98

BUG=290435
TBR=rtoy@chromium.org

Review URL: https://codereview.chromium.org/433353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287262 0039d316-1c4b-4281-b951-d872f2087c98

This prevents --install-chrome-app from being used to install
malicious extensions.

BUG=341353

Review URL: https://codereview.chromium.org/434843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287261 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287260 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179452:179453&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/439083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=388515
TEST=build

Review URL: https://codereview.chromium.org/437793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287258 0039d316-1c4b-4281-b951-d872f2087c98

Before, if NSS version was < 3.15.1, then the ScopedTempDir was destructed without ScopedAllowIO and lead to a thread restriction violation.

Now, the temp dir is not deleted in this case as the NSS DB is left open.

BUG=210525
TBR=rsleevi@chromium.org

Review URL: https://codereview.chromium.org/423363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287257 0039d316-1c4b-4281-b951-d872f2087c98

Repeated longpress and tap gestures were resetting the cached handle positions
in anticipation of receiving updated values from the renderer.  However, if the
gesture failed to change the selection position, no update was received, and
subsequent taps on the handle would improperly position the paste popup at the
reset position. Fix this by avoiding cached position resets when the insertion
or selection is already active.

BUG=399222

Review URL: https://codereview.chromium.org/434583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287256 0039d316-1c4b-4281-b951-d872f2087c98

Previous patch leaked interstitial_page_ in SSLBlockingPage and
SafeBrowsingBlockingPage because the interstitial was never shown even
though it was instantiated. This CL fixes that.

BUG=389749
TBR=felt@chromium.org,palmer@chromium.org,noelutz@google.com,mattm@chromium.org

Review URL: https://codereview.chromium.org/427723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287255 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287254 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179450:179451&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/429183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287253 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/436113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287252 0039d316-1c4b-4281-b951-d872f2087c98

updated the UMA histograms.

Fixed wtc's comments in https://codereview.chromium.org/416983005/diff/20001/net/quic/crypto/quic_crypto_client_config.cc

R=asvitkine@chromium.org, wtc@chromium.org, jar@chromium.org

Review URL: https://codereview.chromium.org/431483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287251 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398712

Review URL: https://codereview.chromium.org/435583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287250 0039d316-1c4b-4281-b951-d872f2087c98

Also, clean up the disable mechanism a bit.

BUG=243912

Review URL: https://codereview.chromium.org/429453009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287249 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/434253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64887,122457,222883,340752,364821,388013,399916,399924,399925
NOTRY=true
TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/429183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287247 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287246 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179444:179449&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/434283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287245 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287239 0039d316-1c4b-4281-b951-d872f2087c98

In addition to disabling warnings, this does turn on a few warnings that weren't
on before (-Wheader-hygiene, -Wstring-conversions). I'll see how our bot copes,
if it's too horrible I might revert this again for a bit.

BUG=82385
NOTRY=true

Review URL: https://codereview.chromium.org/419963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287237 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287233 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179443:179443&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/437653003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287232 0039d316-1c4b-4281-b951-d872f2087c98

Threw in a bonus refactor, because noone was passing the BackgroundHoverButton
and alternate image that was different than the default image.

BUG=399693
TEST=Start Chrome with --new-avatar-menu. The signin promo for local profiles
should not have a white background (i.e. its background should match the
bubble background)

Review URL: https://codereview.chromium.org/440493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287231 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287229 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13563: (petarj) [MIPS] Disable the PNaCl ABI verifier when building the IRT
r13564: (dschuff) Update PNaCl binutils COMPONENT_REVISIONS to bring in merge to 2.24
r13565: (mseaborn) Tweak copyright notices to pass presubmit checks: src/trusted/
r13568: (mseaborn) Tweak copyright notices to pass presubmit checks: remaining files
r13569: (dschuff) Build subzero with LLVM autoconf build.
r13570: (hamaji) Non-SFI Mode: Add sigaction and signal
r13571: (dyen) Fixed an issue where directory renames were not reliable on windows.
r13572: (mseaborn) Clean up machine/_types.h: Remove NACL_PRI*NACL_OFF{,64} macros
r13573: (mseaborn) Non-SFI Mode: Centralise test whitelists; move to Scons
r13574: (jvoung) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13575: (hans) Disable exceptions on Windows in all builds
r13576: (dyen) Interlocked allocations between mmap and code_data_allocation.
r13577: (sbc) Add missing check to nacl_bootstrap_munge_phdr.py.
r13578: (asvitkine) Update nacl enum comment to point to correct histograms.xml file.
r13579: (sbc) Enable building with platform=arm on Ubuntu/Trusty.
r13580: (mseaborn) Windows: Make MapViewOfFileEx() failure fatal to reduce risk of mmap hole

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk_build
TBR=bradnelson@google.com

Review URL: https://codereview.chromium.org/436583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287228 0039d316-1c4b-4281-b951-d872f2087c98

All existing tests are run with the system token disabled and again with the system token enabled. Also are they applied once to the user token and once to the system token.

Additional tests ensure that the tokens don't affect each other.

BUG=210525,387606

Review URL: https://codereview.chromium.org/428223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287227 0039d316-1c4b-4281-b951-d872f2087c98

TCMalloc is very slow in debug mode. This may have a substantial improvement
on test cycle time. Theoretically, we shouldn't need to debug TCMalloc
very often.

BUG=388949

Review URL: https://codereview.chromium.org/438963007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287226 0039d316-1c4b-4281-b951-d872f2087c98