- 13 Jul, 2020 40 commits
-
-
Chris Thompson authored
This bumps the expiration for various security-related histograms and adds second owners where needed. Bug: 1102466, 1102467, 1102468, 1102469, 1102470, 1102471, 1102472, 1104987, 1104988, 1104989, 1104990, 1105022, 1105023, 1105024, 1105025, 1105027, 1105028, 1105029, 1105030, 1105031, 1105032, 1105033, 1105034, 1105035, 1105036, 1105037, 1105038, 1105039, 1105040, 1105041, 1105042, 1105043, 1105044, 105045, 1105046, 1105047, 1105048, 1105049, 1105050, 1105051, 1105052, 1105053, 1105054, 1105055, 1105056, 1105057, 1105058, 1105059, 1105060, 1105061, 1105062, 1104991 Change-Id: I3da4cc28654621d499f02dcb83664eb2d3b2f53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295807 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Auto-Submit: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#787922}
-
Peter Kotwicz authored
This CL: - Fixes strict mode detection on Android P - Imports list of "unfixable strict mode violations" from other google apps - Avoids reporting strict mode violation (uploading stack trace) or preforming penalty if the strict mode violation is whitelisted. BUG=1038384 Change-Id: Ib125d08104225af0e1dafb1be1afc5ef8d8e128e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258578Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#787921}
-
David Black authored
Previously, AssistantSuggestions only supported remote icons. Now, they will optionally support local icons as well. These will be specified by use of resource links (a similar concept to deep links which instead of pointing to some action to be performed point to some resource to be used). This will be utilized in a follow up CL to provide local icons to Assistant onboarding suggestions. Bug: b:157510970 Change-Id: I488865044c1485b1e431cd843f2d0ea0ad146be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289074Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#787920}
-
Lei Zhang authored
Switch to the 1-parameter version, or switch to base::DeletePathRecursively(). Bug: 1009837 Change-Id: Iab8258f3d8b29c308758096299a8e6702230484a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293282Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#787919}
-
Peng Huang authored
When context is lost, the SharedContextState::gr_context_ could be nullptr, we should check it is not nullptr, before using it to avoid crashes. Bug: 1103726 Change-Id: I50a84d3cd2ffff05095ce682f80ddf31d5304d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295683Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787918}
-
Sebastien Marchand authored
There's some concern that the cost of the Segment heap doesn't justify its cost (see crbug.com/1102281). This CL disable it by default and put this feature behind a GN flag to let us keep experimenting with it. Bug: 1102281, 1014701 Change-Id: I411b61efc6927ba5d9f1496990a44c44ab8ea6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292824Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#787917}
-
karandeepb authored
One of the files in the GCS webstore bucket doesn't seem to be updating. Bump the server version as a short term fix. Skipping presubmits since they seem to be timing out. BUG=1105212 TBR=rdevlin.cronin@chromium.org No-Presubmit: true Change-Id: I26250426eb7ff47c553591c5475f066b15f4157e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295933Reviewed-by:
-
David Trainor authored
Disabling flay test. Tbr: ckitagawa@chromium.org Bug: 1105164 Change-Id: I837fb6a37360eff3aa78fe10b94b146c46d2bf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295923Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#787915}
-
Jeffrey Cohen authored
TBR=tkent@chromium.org Bug: 1104910 Change-Id: I6ea5dc45a621267cec58f8eabacf8b3a5f388f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295930Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787914}
-
Stephen Roe authored
Add fuchsia-fyi-arm64-dbg to chromium_tests configuration. Bug: 1048769 Change-Id: I5d8130d716f7c15c259dec1561c69bdf0e159d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290951 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#787913}
-
Xida Chen authored
This CL clears some resources in the destructor of FrameSequenceTrackerCollection class. No behavior change is expected. Bug: None Change-Id: Ib6af1f21e1ce19c31645e50f0009941dc7303d8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292922Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#787912}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1594648594-97cb9ce3cb39a74bf15fa7f9f08c38efdf753597.profdata to chrome-win32-master-1594658282-c322bca3a92b7a4e05f128aebc7fcd315086b865.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If8eb4e4b46053aeecb6ef0c031c13ec1111f7ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295879 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787911}
-
Sinan Sahin authored
This CL builds upon crrev.com/c/2119610 and updates the top margin every time the offsets change instead of doing so only on height changes. Bug: 1102898 Change-Id: Ibb2a5b0a185dc84d3b937f9ed7a624087bdfd151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285248Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#787910}
-
Sinan Sahin authored
Currently, VTS and a11y tab switcher adapt to the top controls height changes. This CL updates places that use the browser controls height to use the content offset instead. This will make these surfaces animate smoothly with the height change animations since the browser controls animations are driven with offset updates. Bug: 1102650 Change-Id: If11f697900faac6323dee10dfb61e25ec17599d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284205 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#787909}
-
Guillaume Jenkins authored
With this change, ProfileReportGenerator is passed a delegate factory during construction, and takes its delegate directly from it instead of receiving the delegate as constructor argument. #Squeegee Bug: 1091936 Change-Id: Iecc53e7b30a6f2bcb39f6c248ce40c94ae448fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290056Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#787908}
-
Justin Cohen authored
This is currently causing a number of EG2 tests to spin. Temporarily disable while we investigate. Bug: 1103822 Change-Id: I5b1bffe2b679b2970566e6d2687c37aca63d2670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295746 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#787907}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I8ef7e3041c931ccadbf2cb4021ddfcdddc410ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294028Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#787906}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c4187c19b8f8..71d4c9e8433b 2020-07-13 khokhlov@google.com devil: Add unittests for GetTracingPath() If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1102378 Tbr: nuskos@google.com Change-Id: If80d8ff56bb01da9490fd42456dce1f1531c435d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295643Reviewed-by:
-
chrome://managementXinghui Lu authored
Screenshot: http://screen/WwTrA49aG1F Strings reviewed in the doc linked in https://crbug.com/1085264#c4. Bug: 1085264 Change-Id: Id149ee2bc09709dabd9948fcf8f1e77fdb8464c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290565Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#787904}
-
Reilly Grant authored
This change converts base::Callback types in Bluetooth test code to base::OnceCallback or base::RepeatingCallback as appropriate. Bug: 834319 Change-Id: I8119b9e3087226f50aa1bf109bd31cb42aa64aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293260Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#787903}
-
Anastasia Helfinstein authored
The automation API's setDocumentSelection only supports selections within a webpage. For native UI, we are directed to use AutomationNode's setSelection method. Because this will work within a webpage as well as for native UI, we use this function any time the start and end objects are the same. AX-Relnotes: n/a. Bug: 982004 Change-Id: I5e5c4847c754c97b77662d865a55969b8728c379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291232 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#787902}
-
Yuly Novikov authored
Flaky on all platforms, skipped on Fuchsia. TBR=kbr Bug: 1105129 Change-Id: I22a465e31a23425474d1659ba01b0fcf3bbcb173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295685Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#787901}
-
Daniel McArdle authored
This CL also deletes an unnecessary std::vector local variable from HttpssvcExperimentDomainCache::IsControl. Bug: 1052476 Change-Id: Ic160ad593028be880246861f328ec287723958b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295322Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#787900}
-
Alex Chau authored
- Nearby Connections is imported to Chrome in parent CL (https://crrev.com/c/2214535) - The library will only run in utility process (services/sharing/nearby) - This CL implements the platform specific portion of the library, for classes like Executor, Mutex, ConditionVariable etc. - ScopedAllowBaseSyncPrimitives is used for allowing blocking code when using Executor - only run in utility process - shared_ptr is used by Nearby Connections API, which requires platform specific portion to return shared_ptr - Dependencies - absl dependency is from Nearby Connections - base is used to implement platform specific portion of the library - test is for unit tests - Design doc: go/nearby-chrome Bug: 1091190 Change-Id: I9df6cac80563e1d7e639b7153c6824d0dc88bc30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228543Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#787899}
-
Alison Maher authored
Update the constraint space used when positioning fragmented OOF positioned elements. This involved: 1) Updating the layout code in this case to use the writing mode of the containing block rather than of the fragmentation context root. 2) Setting up the constraint space for fragmentation. This required access to the fragmentainer constraint space. As a result, I added a map to cache the fragmentainer constraint spaces to avoid creating these multiple times. Bug: 1079031 Change-Id: I31a666ebf3acf61f28eb54bfb3fcd70436ebf1b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274246 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#787898}
-
Daniel Nicoara authored
The caller may need to perform operations after the display is enabled/disabled. Since the display configuration API is async, provide the callbacks such that callers can use them to schedule dependent work. BUG=b/156411764 TEST=Compiled Change-Id: I044767c922eabbec123e4399a5774ccd12d1742d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296000Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#787897}
-
Anastasia Helfinstein authored
Switch Access' error recovery depends on being able to construct a desktop node. If a problem occurs during that process, do not try to recover, as it leads to an infinite loop. AX-Relnotes: n/a. Bug: None Change-Id: I660fe226ffdbf2e9baa2c41e3d63389bce500e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292698Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#787896}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ecc9f3494ee9..ed68cfb7fd66 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jeffreycohen@google.com,ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1061592,chromium:1101531,chromium:1102972,chromium:1104213,chromium:1104916 Tbr: jeffreycohen@google.com,ftirelo@google.com Change-Id: I0a6976767359c19b30c008e7ce146e3780205fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295644Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787895}
-
spdonghao authored
Bug: 1097003 Change-Id: I88d396f8217edd9b073a06c353dc1fb5fce423d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290255Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
TBR=tkent@chromium.org Bug: 1104910 Change-Id: I5615018edde813949898695919b2533a4b993eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295981Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#787893}
-
Tom Anderson authored
Fix CL fixes a copy-paste error. |configure| is nullptr based on the conditional. I meant to use |screen| instead. R=nickdiego Change-Id: I99f7d04a0519379115eeecc3fd57ca97e582e8aa Bug: 1102059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295805 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#787892}
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: I1ca8769887aef5b95426b8b784ce099c2fa3aa8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293113Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/522b34c810c5..4f438a5a6738 2020-07-13 sugoi@google.com Image dirtiness If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9923dc792d7924e0cd41db66d56cef0a00344601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295944Reviewed-by:
-
Stephanie Kim authored
Bug: 1072012 Change-Id: I8165afcd56cc792e89721c398c7e9a6fb4b64832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295829Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#787889}
-
Saurabh Nijhara authored
This CL adds a switch for Auto Update Expiration state reached for device policy MinimumChromeVersionEnforced. This is useful for testing the policy behaviour in AUE use case on a DUT. Bug: 1104823 Change-Id: Ic60b3cca7bb1b3a305bf1471ec7b5aa4b2b9b4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294860 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#787888}
-
Jun Mukai authored
This new function disables the accessibility feature of ChromeOS. Bug: 1096719 Test: tast ui.DragTabInClamshellPerf ui.OverviewScrollPerf Change-Id: I3d9e60d15522ca54251fd532712a04cf9c204b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293183 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#787887}
-
David Trainor authored
Just going to disable SearchActivityTest#... tests that are flaking on the bots. Tbr: gangwu@chromium.org Bug: 1100967 Change-Id: Ia8abe36da611cf2206f5a1edb893ce8930411df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295828Reviewed-by:
-
Sahel Sharify authored
This cl changes the ShippingOption bundle to match web payments spec[1]: 1- "ShippingOptionId" key has been changed to "id" 2- shipping cost is kept as a PaymentCurrencyAmount bundle rather than being flattened to string values with "amountValue"/"amountCurrency" keys. [1] https://www.w3.org/TR/payment-request/#dom-paymentshippingoption-id Bug: 1103686 Change-Id: I05d0983a54e8795904dd5b1278c49bd858706b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289992Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#787885}
-
Filip Gorski authored
This patch adds CallbackController that can wrap Callbacks and Runnables in order to protect them from being invoked after an object they refer to has been destroyed. This late invocation can come for example from a UI which has received a callback to signal UI events, like changing focus. Detailed documentation in JavaDoc. Change-Id: I012f647c4b93ca378a1987da593d77a5890dafef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267409Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#787884}
-
Tina Wang authored
Change the setting's UI when the default search engine is disabled by policy. Bug: 1093172 Change-Id: Ic900c5e086ce5df3d5cb2cb12ce7e04c6a92a1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264586Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#787883}
-
