- 13 Aug, 2020 40 commits
-
-
Jacques Newman authored
This CL adds the logic for grid-auto-*, bringing the values from style and using them to build ranges. * This change fixes an issue in ConvertGridTrackSizeList where the GridNG computed style was not updated correctly. * The GridPositionResolver has been updated to take only styles, removing the dependency on LayoutBox so it can be used for both legacy grid and GridNG. * As the GridPositionsResolver is 0-based for tracks, and as we intended to switch to start tracks at 0, this change does exactly that. This caused changes in the test expectations. Bug: 1045599 Change-Id: I505baa6a4737400068a1bd81a12492317aace712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321221Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#797597}
-
Bret Sepulveda authored
This reverts commit 2ea83bd2. Reason for revert: Multiple failing tests on Mac ASAN, see for example https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/64426 Original change's description: > [base] Fail test batches if they leak processes, under POSIX. > > Under Windows and Fuchsia the TestLauncher runs test batch processes in > their own jobs, allowing any leaked sub-processes leaked by tests to be > cleaned up. > > Under POSIX platforms each batch is run in its own process group, but the > group was only being kill()ed if the test batch failed or crashed. > > TestLauncher now proactively kill()s each test batch's process group. The > result of the call is also checked, and the test batch marked as failed > unless kill() reports that the process-group was already gone. > > Note that this will still miss processes launched into new process groups > by tests. > > Bug: 1094369 > Change-Id: If379d200953a823b2020766cda73f8cf27bfdb7f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346388 > Commit-Queue: Wez <wez@chromium.org> > Auto-Submit: Wez <wez@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797277} TBR=wez@chromium.org,tikuta@chromium.org Change-Id: I340068b6f84583af89fa7c75d43566acc2b61537 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1094369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352811Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#797596}
-
Yuchen Liu authored
Changing refresh rate may cause display mode switch. This will lead to black screen flicker on ATV devices. Bug: internal b/162380755 Test: Play YT Change-Id: Icd8d5286fcc27c1b42c53190d9f43b1f99c42957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353711 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797595}
-
Minoru Chikamune authored
This CL introduces an empty blink::scheduler::AgentGroupSchedulerImpl so that we can land per-AgentSchedulingGroup task queues / runners based on this class. Tentatively, this CL creates an AgentGroupSchedulerImpl per page. This is because we need to initialize AgentGroupSchedulerImpl from the browser side later. [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A/edit#heading=h.csqx36qhymx0 Bug: 1105403 Change-Id: Ib563f77e4b24a8a72a408735dbc6af5aec26e47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329950 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#797594}
-
Friedrich Horschig authored
In canary builds (and infrequent on Emulators or very new Android versions), the LifeCycleObserver does not trigger even if the observer is added properly. Although the failure reason is unclear, the fix is simple: forward the corresponding Fragment events through the already existing delegate interface. Bug: 1115124, 1092444 Change-Id: I2fa45d31eba7830fc2a73d6999a2864b6408eeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352892 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#797593}
-
Rune Lillesveen authored
Trying to add DCHECKs to avoid StyleResolver::StyleForElement() and PseudoStyleForElement() caused a few unit tests to break. This CL advances the lifecycle to allow StyleForElement() to be called on a style-dirty tree in style_resolver_test.cc. Change-Id: Ice81c60cd704f6b718b2a781adf93bc069294446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352732Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797592}
-
Yuki Shiino authored
Changes the execution context for reporting / measurements from the receiver object's execution context to the current context's execution context. Bug: 839389 Change-Id: Iab09ad3a27df7038d56b9661343dead1d41cb499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352949Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797591}
-
Christian Dullweber authored
Change-Id: Ia4aa9b7760eba459877c4e10206d4c3eb20a9e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339995Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#797590}
-
Mike Dougherty authored
Links containing Javascript strings can’t be executed in the source frame with WKWebView APIs (pre-iOS14) so removing the option from the context menu is preferable. The user can still copy the javascript from the link. Fixed: 1109120 Change-Id: I7744871aeddbf461b9a1d4ea480c5d9bcd02beed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352639 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797589}
-
Jiewei Qian authored
A generalized OS Settings approach for capturing navigations to SWA. This CL adds support to capture the following navigations, and navigate in a standalone SWA window. - Omnibox: Navigate; Open in new window - Anchor link in a tab, click and context menu - Anchor link in a different SWA, click and context menu - location.href = swa_url - window.open from a different SWA - window.open from the current SWA A followup CL will support capturing navigations in incognito browsers. Currently, these navigations will open SWA in the incognito profile. Bug: 1096345 Change-Id: I4223b8a7dd406229bca793127218d52b625ac0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321912 Commit-Queue: Jiewei Qian <qjw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#797588}
-
Matthew Mourgos authored
This change updates the positioning and sizing of the notification app badge to better match the spec. Bug: 1080827 Change-Id: I9fcbde21694e6b054a71c4ef46aeb7b4d3282b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351456Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797587}
-
Karel Král authored
Refactor python code responsible for generating C++ function parameter tracing of mojo methods into a standalone module. Bug: 1103623 Change-Id: I39dff196c8227534a6141b0984559e2323ceaaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346808 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797586}
-
chrome://media-appTrent Apted authored
Rethrowing MessagePipe exceptions only makes sense when a particular side of the pipe should _never_ throw an exception. Exceptions that propagate to the other side to be handled should not be re-thrown on the server side. Currently any trusted-context exception will trigger a crash report due to new handling for the `unhandledrejection` event that was added in r790636. Bug: b/163927591, b/158135844 Change-Id: I0d01058b2e34dbf2742ddd05ce54a45007863f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352582Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#797585}
-
Tsuyoshi Horo authored
This reverts commit 7be16f97. Reason for revert: Lack of policy::cookies_allowed, policy::cookies_store in NetworkTrafficAnnotation. Bug: 1115855 Original change's description: > Adding network fetcher for fetching images. > > Change-Id: If4d19d6ba2367f7770c4e77c8f885767171bebe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350148 > Commit-Queue: Jonathan Freed <freedjm@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797494} TBR=freedjm@chromium.org,iwells@chromium.org,harringtond@chromium.org Change-Id: I3fee310723f20f394e177d8a1b5d08c27687991e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353971Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#797584}
-
Klaus Weidner authored
This replaces the three currently-used fullscreen request types with a bitmap class, uses it in various places that had used an ad-hoc for_cross_process_descendant boolean, and also adds a mojo field for prefixed/unprefixed mode. Additional background and motivation for the change: https://docs.google.com/document/d/1ER6oBIZKSx6rgoRzg1a1TE4lL7v4AKklxxr8xutOLas/edit# This should not cause any visible behavior changes. The logic is now present to distinguish prefixed/unprefixed mode for OOPIF, but this isn't enabled yet. Bug: 1101193 Change-Id: I8aa74df9be60aaee04d82427b2bc903dc3f12a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335661Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797583}
-
Yuki Shiino authored
NVT<IDLInterface> was optimized for size, but it turned out that it causes a regression on Android (arm), so changes NVT<IDLInterface> to be more inline-friendly. blink_perf.bindings/append-child improves by ~5%. Bug: 839389 Change-Id: I5ce5cef3ac16062f2580e00c1e535afb2011df4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342235 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#797582}
-
Kunihiko Sakamoto authored
Running loading benchmarks on Pinpoint with a valid configuration is a bit tricky, so this adds some guides for providing correct arguments for Pinpoint. Bug: 1114724 Change-Id: I64e3919b1e3d3e94b8c815e8a747f392f3da4854 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352291Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797581}
-
Meera Srinivasan authored
The guidance is to not use Sha1 for obfuscation. There is no security concern for hostname since it is generally considered to be public info. Change-Id: If587d9e9480606ec9df0b164313026ed49a4a4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351453 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#797580}
-
Peter Kasting authored
Bug: none Change-Id: I48a4c36c96f3c92afa5e34cf43b9901af358d2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350133Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797579}
-
Alexander Dunaev authored
The menus should show mnemonics if Alt is pressed. This did not work in Ozone because the platform didn't expose the current status of control keys (which is delivered with input events as so called modifiers). This CL introduces a new method that returns the current state of modifier keys from the platform, and allows the menu mnemonics for two Ozone platforms. In addition, one unit tests of the menu controller has been enabled for all platforms where Aura is available. Bug: 1085700, 1113086 Change-Id: Ie2857c763d325f85c7f464e69cc22a18bcbf6f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333833Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#797578}
-
Julie Jeongeun Kim authored
This CL moves printing::PrintHostMsg_DidPrintDocument_Params to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy PrintHostMsg_DidPrintDocument. Bug: 1008939 Change-Id: I953c8066e9acfc9e3802a7a28f491c44059ac171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341028 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797577}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b36c8eb3e1c..62f669be69c5 2020-08-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I584725f9be4beeaf1ff6738378b5cdfb5d0c5be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797576}
-
Rachel Carpenter authored
This is based on the feature HelpAppReleaseNotes. It will have a different launch URL and message than the Help App normally does. Has the same logic for when it displays as the Release Notes PWA. Bug: b/161755085 Change-Id: Ie3778178411001b8e9c99deffbae7231387b7ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351480 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797575}
-
Aleks Totic authored
Collapsed borders are computed by NGTableBorders::ComputeTableBorders NGTableBorders used to store table_writing_direction. This meant that cache would have to be invalidated when table_direction changes. This felt awkward, and table_writing_direction was available elsewhere, so I removed it from NGTableBorders LayoutNGTableSection/Row had a few methods that were left out of the initial row/section patch because they depended on data structures that were not landed yet. They are in this patch by accident, call me out on it, and I'll remove them. Bug: 958381 Change-Id: I254087934be120b0998886ce0ce2d35d7cc72204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347225 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#797574}
-
Yuki Shiino authored
Ports https://crrev.com/c/2351950 to the new bindings generator. Bug: 839389 Change-Id: Ia3bab7ba01b527acb550b40a7178563f70edd88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352571Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797573}
-
Alexander Dunaev authored
This CL pays a bit of technical debt in the clipboard implementation. First, it updates a test that verifies that putting text into clipboard registers the proper set of MIME types, as had been suggested in [1]. Second, it enables for Ozone the test that verifies selection buffers. Third, it de-duplicates some string constants. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2306252 Change-Id: I6beb6b5b3827f0ec09cf19bc1868e7955141f680 Bug: 911992, 1105892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346338Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#797572}
-
danielng authored
Implementing an installer for borealis, based on the install flow of Plugin VM and Crostini. Currently there is no way of accessing the installer (during testing I attached it to a dummy app entry I created). Whilst the install process is quite lean right now, I left in some structures, inspired by the other installers, that will be useful when the installation flow gets more complex and/or when tests are added. I haven't added any tests since things may be scrapped when proper UX is decided, the installer is only being used internally and it exists in a vacuum. For more context into the installer, and Borealis, please see the attached bug. Tests: Tested manually on my machine. Bug: b:161650651 Change-Id: I552c39f2ff4e0da86bc0f113bef6c4129e671a51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338275 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#797571}
-
Minggang Wang authored
This patch moves function GetDefaultNetReferrerPolicy() into Blink, so we could call it inside Blink directly. Meanwhile, NetToMojoReferrerPolicy() is moved to referrer_utils.h/cc, where is more suitable for it. Bug: 860403 Change-Id: I078abe32181cfe02e3594c3f1d33dde04a2da170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337894 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#797570}
-
tby authored
There are three container views within the launcher search box: app tiles, results list, and answer card. Currently, the order of these containers in the UI is dynamic: it changes depending on the display scores of the results within each container. In practice though, we always want one ordering: app tiles, answer card, then results list. But the dependence on result scores is a source of bugs, because ML ranking can significantly change the UI. This CL fixes the container scores to prevent these kinds of bugs in future. Bug: 1028447 Change-Id: I2217fc9c1f8715b7073f1afd976e1a1b87343e04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345924Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#797569}
-
Mike Wasserman authored
Check for permission on cross-screen window.open|moveTo|resizeTo|etc. Do not prompt users, fall back to the current screen on failure. Perform rough clamping for screen selection in WebContentsImpl. Perform fine clamping with known frame sizes in BrowserView. Plumb the window.open requesting RenderFrameHost into WebContentsImpl. (needed to make the appropriate origin-specific permission check) Extend popup window placement browser tests. TODO: Refine and clarify window placement patterns... TODO: Test cross-screen placements, app window/popup placements. TODO: Refine browser testing pattern, add/extend WPTs as possible. Bug: 1080690 Change-Id: I74ee149f6ae42c7ddcedd75ac832fee6d40dcc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227190 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#797568}
-
Charlie Hu authored
Previously we allow PolicyValue to always represent certain strictness, i.e. comparable. However, with the incoming introduction of enum type PolicyValue, this will no longer hold true. There is no logical ordering of strictness for some enums, e.g. Enum.RED > Enum.BLUE does not make sense. This CL adds the support for non-comparable PolicyValue. Change-Id: I1f260d6e357e5e09c4577d5cd08af87e2df5f21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343606Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#797567}
-
Chris Harrelson authored
This logic is controlled by the CompositingOptimizations feature. Bug: 1115577 Change-Id: Ia6f666ed9c78b0a9a2ad3a58229561889ac6b93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353419Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797566}
-
Brian Malcolm authored
This is intended to replace the NativePrintersBulkConfiguration policy. The old policy will still be used in the absence of the new one for at least a few releases of Chrome. BUG=chromium:1113366 Change-Id: If7fb1a53180874a5bd12f081129aed5ffadad443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340741 Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797565}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I63fa2aeb58b2488112ecc04f38b295a00676f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797564}
-
John Delaney authored
What: This CL adds an additional check in the restricted navigation ad tagging code that only deletes FrameDatas if the navigation successfully committed. Why: This prevents us from triggering Frame deletion when the frame and subframes still exist. There is a followup change: https://crrev.com/c/2324603 which intends to make these types of errors less problematic. Bug: 1108511 Change-Id: I6b35c65b325ea96ca8bb4de58f946306ae9cdaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341160 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic0498846a6d49139123b3fb515daffa8cb7d6d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797562}
-
Melissa Zhang authored
Bug: 1097623 Change-Id: I773d2e6b88b580520da0265e0a6c9761f85fdf0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352578Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#797561}
-
Rachel Wong authored
This is intended to allow selection to remain on the selected action if the launcher is updated with new results. Bug: 1114969 Change-Id: I25f7153da7cdf25d4f9ccdf70e0f3ac85036911e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348244 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797560}
-
Matt Falkenhagen authored
This CL blocks prefetching to private IP addresses, so that CORS-RFC1918 is not bypassed. It adds a URLLoaderFactory option to accomplish this. We can't just use CORS-RFC1918 as-is because the security state of the client and in fact the client's URL is not known at prefetching time, as redirects can happen after this time. Bug: 1114064 Change-Id: I74bdbb078d3b3ed41e9fbbc809f68b43499b6040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351102 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#797559}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f3ce85bab94..338597ba8c41 2020-08-13 wuwang@google.com Convert downloader to be lazy load. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1060399 Tbr: sadrul@google.com Change-Id: Ifa3f7e6144ca13e5fda1208eaf183fb0bd8bdfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352042Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797558}
-