GitLab

Under certain conditions, we used to have a cross-like image
taking the entire canvas instead of several rows of markers.

BUG=

Review URL: https://codereview.chromium.org/235913011

git-svn-id: svn://svn.chromium.org/blink/trunk@171483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=171457

BUG=81415
TBR=sudarshan.p@samsung.com

Review URL: https://codereview.chromium.org/237113003

git-svn-id: svn://svn.chromium.org/blink/trunk@171482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/225113003

git-svn-id: svn://svn.chromium.org/blink/trunk@171481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously, only 10 channels were supported for an
OfflineAudioContext. Although the WebAudio specification doesn't explicitly say
what the limit is, generally at least 32 channels are required to be
supported for all nodes.

Added a test that creating an offline context with 32 channels works.

BUG=362133

Review URL: https://codereview.chromium.org/232843004

git-svn-id: svn://svn.chromium.org/blink/trunk@171480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pfeldman
BUG=363113

Review URL: https://codereview.chromium.org/235893007

git-svn-id: svn://svn.chromium.org/blink/trunk@171479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves the null-check out into generated bindings code.
The non-standard method drawImageFromRect(...) keeps the null-check,
and has its first argument marked nullable because of that.

Review URL: https://codereview.chromium.org/232313004

git-svn-id: svn://svn.chromium.org/blink/trunk@171477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Follow up to https://codereview.chromium.org/236403002/

BUG=362927

Review URL: https://codereview.chromium.org/236353003

git-svn-id: svn://svn.chromium.org/blink/trunk@171476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Otherwise it also iterates through invisible records.

BUG=
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/236683006

git-svn-id: svn://svn.chromium.org/blink/trunk@171475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

'null' should not be allowed per current spec. so modify tests accordingly.

BUG=363148

Review URL: https://codereview.chromium.org/237063002

git-svn-id: svn://svn.chromium.org/blink/trunk@171474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/235933007

git-svn-id: svn://svn.chromium.org/blink/trunk@171473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman, vsevik

Review URL: https://codereview.chromium.org/236683004

git-svn-id: svn://svn.chromium.org/blink/trunk@171472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves the null-check out into generated bindings code. Since there's
no longer a need to throw (explicitly) the ExceptionState argument can be
dropped from the signatures.

Review URL: https://codereview.chromium.org/232913004

git-svn-id: svn://svn.chromium.org/blink/trunk@171471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

OptGroup since it is a label, if selected should not deselect selected item. In updateStateSelected, it is checked if optGroup, no UI changes are triggered.

R=keishi1, tkent
BUG=342189
TEST=On selecting optGroup label, selectedIndex should not be deselected.

Review URL: https://codereview.chromium.org/204433002

git-svn-id: svn://svn.chromium.org/blink/trunk@171470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=jochen@chromium.org
BUG=363103

Review URL: https://codereview.chromium.org/237083002

git-svn-id: svn://svn.chromium.org/blink/trunk@171468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When text is selected inside input element, it should change the
color and background color according to the ::selection pseudo
element.

BUG=167676

Review URL: https://codereview.chromium.org/220343006

git-svn-id: svn://svn.chromium.org/blink/trunk@171467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes heap-use-after-free error (regression caused by r171246)
in the 'MutableStylePropertySet::setProperty' method. This error turned
up as the 'setProperty' method argument contained a pointer from the vector
buffer which had been previously freed (as we started to use 'Vector::swap'
instead of assignment operator).

BUG=362310

Review URL: https://codereview.chromium.org/234823004

git-svn-id: svn://svn.chromium.org/blink/trunk@171466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=344583

Review URL: https://codereview.chromium.org/171263004

git-svn-id: svn://svn.chromium.org/blink/trunk@171465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=332630
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/230533002

git-svn-id: svn://svn.chromium.org/blink/trunk@171464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=pfeldman, vsevik
BUG=160510

Review URL: https://codereview.chromium.org/225873004

git-svn-id: svn://svn.chromium.org/blink/trunk@171463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we have a lot of DOMRequestStates in IndexedDB code. However, the only object where we really need a script state is IDBRequest. Other objects just need v8::Isolate. Thus:

- This CL replaces DOMRequestState in IDBRequest with NewScriptState.
- This CL replaces other DOMRequestState with v8::Isolate.

BUG=357144

Review URL: https://codereview.chromium.org/236773003

git-svn-id: svn://svn.chromium.org/blink/trunk@171462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/236973002

Review URL: https://codereview.chromium.org/236973002

git-svn-id: svn://svn.chromium.org/blink/trunk@171461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

we don't do actions that could modify v8 heap so we can report GC events synchronously. Otherwise these GC events would get call stacks of the next event. We will not collect call stacks for gc event at all because it could be triggered even a single small allocation and the call stack will mislead the developer. If someone would like to know what code allocates memory then he needs to use our allocation profiler with allocation stacks.

BUG=361045
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/235043002

git-svn-id: svn://svn.chromium.org/blink/trunk@171460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=ager@chromium.org, haraken@chromium.org, jochen@chromium.org, mikhail.pozdnyakov@intel.com, vegorov@chromium.org, wibling@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/223373002

git-svn-id: svn://svn.chromium.org/blink/trunk@171459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=359977

Review URL: https://codereview.chromium.org/235703007

git-svn-id: svn://svn.chromium.org/blink/trunk@171458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The <select> element does not ignore the <option>/<optgroup> children that have "display:none". Conseqently, these children are displayed on the list. Code has been added to detect the change in display property and also to drop <option>/<optgroup> children whenever required.

BUG=81415

Review URL: https://codereview.chromium.org/189543012

git-svn-id: svn://svn.chromium.org/blink/trunk@171457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=357096
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/236023006

git-svn-id: svn://svn.chromium.org/blink/trunk@171456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adds dispatch change event at touchEnd.

R=tkent@chromium.org, keishi1@chromium.org
BUG=361335
TEST=On touch start check input event is dispatched and on touch end check change event is dispatched

Review URL: https://codereview.chromium.org/234933002

git-svn-id: svn://svn.chromium.org/blink/trunk@171455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Old version navigator content utils APIs have been kept since r165458. Because
blink bots might ignore dependency with new content module. However, blink bots
is using updated content module which supports new navigator content utils APIs. Thus,
this cl removes the old navigator content utils APIs.

Review URL: https://codereview.chromium.org/232263003

git-svn-id: svn://svn.chromium.org/blink/trunk@171454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We removed experimental flag -webkit-visual-word 2 years ago:
http://src.chromium.org/viewvc/blink/trunk/Source/core/page/DOMSelection.cpp?r1=89440&r2=102252
Selection.modify("-webkit-visual-word") does nothing.
However, there are still tests using the flag.
They confirm that scripts don't crash when they call Selection.modify("-webkit-visual-word").
It doesn't make sense.

BUG=

Review URL: https://codereview.chromium.org/236733005

git-svn-id: svn://svn.chromium.org/blink/trunk@171453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/236893002

git-svn-id: svn://svn.chromium.org/blink/trunk@171452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Calling a navigator method leads to a crash when:
 - The navigator is associated with an iframe, 
 - The iframe has some contents and
 - The iframe is detached.

This CL fixes the crash.

BUG=358800
R=abarth

Review URL: https://codereview.chromium.org/234583004

git-svn-id: svn://svn.chromium.org/blink/trunk@171451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://heycam.github.io/webidl/#es-operations states that an API returning
a Promise should return a rejected Promise when an error occurs rather than
throwing an exception.

BUG=359386, 362992
R=nbarth@chromium.org, eroman@chromium.org

Review URL: https://codereview.chromium.org/232563003

git-svn-id: svn://svn.chromium.org/blink/trunk@171450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/236203006

git-svn-id: svn://svn.chromium.org/blink/trunk@171449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL enables Oilpan for WorkerPerformance by default. This CL doesn't enable Oilpan for SharedWorkerPerformance and WorkerGlobalScopePerformance because they are supplementing off-heap objects.

BUG=340522

Review URL: https://codereview.chromium.org/236613005

git-svn-id: svn://svn.chromium.org/blink/trunk@171448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- This CL is one of incremental steps to remove DOMRequestState from IDB code base.

- The essence of this CL is to remove DOMRequestState from idbAnyToScriptValue() and idbKeyToScriptValue(). For that goal, this CL passes NewScriptState around in a bunch of places.

- This CL implements [CallWith=NewScriptState] for DOM attributes.

- This CL caches NewScriptState onto ExecutableWithDatabase objects, IndexPopulator and OpenDatabaseCallback.

BUG=357144

Review URL: https://codereview.chromium.org/236783002

git-svn-id: svn://svn.chromium.org/blink/trunk@171447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Overriding overflow values to VISIBLE if they are different.

BUG=362510

Review URL: https://codereview.chromium.org/235043003

git-svn-id: svn://svn.chromium.org/blink/trunk@171446 bbb929c8-8fbe-4397-9dbb-9b2b20218538

CPUFlameChartDataProvider is made to not depend on CPUProfileView.

Review URL: https://codereview.chromium.org/235453008

git-svn-id: svn://svn.chromium.org/blink/trunk@171445 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/236203009

Review URL: https://codereview.chromium.org/236203009

git-svn-id: svn://svn.chromium.org/blink/trunk@171444 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some of the StyleBuilderFunctions handlers were being defined in
StyleBuilder.cpp. This patch cleans moves them to the correct place and
makes some minor clean-ups inside (removing the unused condition check
and a redundant isPrimitiveValue check).

Review URL: https://codereview.chromium.org/236763002

git-svn-id: svn://svn.chromium.org/blink/trunk@171443 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Flakiness dashboard link:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=http%2Ftests%2Fxmlhttprequest%2Fxmlhttprequest-responseXML-exception.html

TBR=leviw@chromium.org
BUG=362503

Review URL: https://codereview.chromium.org/228663015

git-svn-id: svn://svn.chromium.org/blink/trunk@171442 bbb929c8-8fbe-4397-9dbb-9b2b20218538