- 24 Sep, 2019 40 commits
-
-
Benjamin Beaudry authored
This change is an optimization of AsTextPosition(). It's part of the larger performance improvement related to the expensive calls to MaxTextOffset(). AXposition::CreatePositionAtStartOfDocument() calls repetitively AxTextPosition() to allow converting from a tree position and to a text position and back, but this required calling MaxTextOffsetInParent() a lot. In a simple navigate-by-word situation, every call to AsTextPosition() would call MaxTextOffsetInParent uselessly. This change fixes it. There is no need to get the MaxTextOffset of an AXPositionInstance when the |text_offset_| will be positioned at the beginning of the anchor. We expect to position the text_offset_ of a Text Position at the beginning of the anchor when |text_offset_| is either invalid, already at 0 or less than the actual new_offset. All I did was adding a check for these conditions before calling MaxTextOffsetInParent(). I measured the perf difference with a trace captured with WPR and analyzed with WPA. In both cases, the traces consist of 10 words read by Narrator with navigate-by-word navigation. Without patch: ExpandToEnclosingUnit: 2,169 ms CreatePositionAtStartOfDocument: 103 ms With patch: ExpandToEnclosingUnit: 1,851 ms CreatePositionAtStartOfDocument: <1 ms Bug: 928948 Change-Id: I41d896dd25519eaba6a8c82d0ffacd3fbdedd909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811221 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#699478}
-
Renjie Tang authored
Change-Id: I092ee4860dc1de33dcb0ed1171e5acbbe17b8471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819841 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#699477}
-
Steven Bennetts authored
This adds GetNetworkCertificates to the mojo API. A follow-up CL will use the new api in the Settings WebUI. Bug: 1001598 Change-Id: If754a6955f10ee23264dd2a4e976922928258b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817201 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#699476}
-
Connie Wan authored
Change-Id: Ia11827685185902bfd443f64af48cb2fca5b1fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822028Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#699475}
-
Shakti Sahu authored
For cancelled downloads, we unregister DownloadController as an observer, before the download is cancelled. Hence the infobar doesn't get the onDownloadUpdated callback. We need to cancel the infobar right before cancelling the download. Bug: 1007167 Change-Id: I3d1e186b63515320fddeef9c567668a8a9a437e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822817Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699474}
-
Sam McNally authored
On ChromeOS, PlatformUtilTest tests indirectly result in the global SystemNetworkContextManager instance being set, initialized with the local state PrefService owned by the TestProfileManager managed by BrowserWithTestWindowTest. When the second test in the fixture runs, the retained PrefService pointer is dangling, resulting in a use-after-free. Add a conditional SystemNetworkContextManager cleanup to BrowserWithTestWindowTest::TearDown() to avoid leaking it between tests. Re-enable PlatformUtilTest.OpenFolder now that it passes reliably. Bug: 1004639 Change-Id: I03c9d06cb98c258a3db8741e6f2576f887cdb705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821697 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#699473}
-
Tom Anderson authored
R=pkasting BUG=None Change-Id: Ife6d481a840fc23b7aac527de332e4185d744ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822841 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699472}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f07a36341330..4c2146f2ca2a git log f07a36341330..4c2146f2ca2a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 brianosman@google.com Interpreter: Add bitwise shift operators Created with: gclient setdep -r src/third_party/skia@4c2146f2ca2a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: I11904cab592f3b121153932a66e6e8ea2153394f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821963Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699471}
-
Eugene But authored
The tests are flaky on iPhone/iPad, device/simulator. Flakiness was not observed on iOS 12. TBR=danyao@chromium.org Bug: 1007432 Change-Id: I0f6ce5d20b2bee9eb550d60036124033038cb1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822844Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#699470}
-
Sasha McIntosh authored
Part of an ongoing cleanup of unused format uyvy. Bug: 988538 Change-Id: I327b4a3931cc16a51ccc370ed1730aad36f2ae75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810801Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#699469}
-
Adam Ettenberger authored
|LowestCommonAnchor| is always cheaper than |LowestCommonAncestor| when the ancestor position data is not needed. I made some low-hanging optimizations to AXPosition after adding |CreateAncestorPosition|, since in many cases the position was being discarded after calling |LowestCommonAncestor|. Note that |LowestCommonAncestor| is equivalent to calling |CreateAncestorPosition| with the result of |LowestCommonAnchor|, so this is an improvement whenever |LowestCommonAnchor| is not the same as the anchor of the initial position. In any other case, there will be no difference in performance. The methods that took this optimization are : * CreateNextWordStartPosition * CreatePreviousWordStartPosition * CreateNextWordEndPosition * CreatePreviousWordEndPosition * CreatePreviousFormatStartPosition * CreateNextFormatEndPosition * CreateBoundaryStartPosition * CreateBoundaryEndPosition Bug: 928948 Change-Id: Ie25f5dfb293c604e0c34f348d276edac14d35ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814670 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by:
-
Alex Cooper authored
xrWebGLLayer_constructor was mistakenly updated to require user activation though the spec does not explicitly require it in this case since the inline session does not request any features. Even were it to require this, the way that it was structured caused there to not be a promise set when the ".then" was caused, giving a script error. This change essentially reverts WPT Commit 16d4388, and was discussed with Mozilla when deciding which way to fix it. Bug: 1007304 Change-Id: I824f63cb172aed5928c55224b31c00803b5ddaa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822821 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#699467}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/67309ef93c4f..af3fdc069d52 git log 67309ef93c4f..af3fdc069d52 --date=short --no-merges --format='%ad %ae %s' 2019-09-24 gustaf@webrtc.org AEC3: Suppression filter handles multiple channels Created with: gclient setdep -r src/third_party/webrtc@af3fdc069d52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I66bd0e276abd212e4b99ab28b0843d211ad6d4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821962Reviewed-by:
-
Christian Biesinger authored
As per this intent to implement: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/blink-dev/hbhKRuBzZ4o Spec: https://github.com/WICG/intrinsicsize-attribute/issues/16 Bug: 979891 Change-Id: I0f9ffa1584fa12a41393ef05daffb7238c97e990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790472 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#699465}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iae0d597135571893f290ecd20c284aceee68d750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822282Reviewed-by:
-
Yi Gu authored
crrev.com/c/1787118 skipped kHitTestAsk for root_view. However, it did not reset the flag and async_hit_test_reasons when the target is returned. Bug: 999576 Change-Id: I9ba111af29687b2c86b0a69c8cd7e3df83686de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818432Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699463}
-
Peter Kasting authored
Bug: 82078 Change-Id: I3bbe1dbbf33aaf3c700b35b55576a8f41334aab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820538 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#699462}
-
Eugene But authored
The flakiness was observed on iOS 13/13, iPhone/iPad, device/simulator. TBR=javierrobles@chromium.org Bug: 1007421 Change-Id: I75ee2ff2f2c6fc8c04be7d6307db03445c28fc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822979Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/59ab7b718b08..b87974eebeaa git log 59ab7b718b08..b87974eebeaa --date=short --no-merges --format='%ad %ae %s' 2019-09-24 ahassani@chromium.org Revert "chromeos_config: disable lakitu builders" Created with: gclient setdep -r src/third_party/chromite@b87974eebeaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I684e7c6d6eb9629d053d93087929a39674aa5eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822281Reviewed-by:
-
Mustapha Jaber authored
This change adds support for navigation-controls media feature, which will initially be used to detect if the user agent supplies a back button present in its UI. This media feature will allow apps to avoid the "double back button" problem by letting them conditionally display a back button depending on whether the user agent is already displaying one. The logic for updating navigation-controls from its default state has not yet been implemented. Spec: https://github.com/fallaciousreasoning/backbutton-mediaquery Bug: 822944 Change-Id: If8bc5054c0591f7e822277a83119273b69aef0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802195 Commit-Queue: Mustapha Jaber <mustjab@microsoft.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#699459}
-
Aaron Leventhal authored
See intent to implement and ship on feature dashboard: https://www.chromestatus.com/feature/4666935918723072 TBR=kinuko@chromium.org Bug: 1006767 Change-Id: I1b5eb7d2f324c4008578e7f7e1cb08a9288520f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816803 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#699458}
-
Gavin Williams authored
Bug: 1001056 Change-Id: I326b21b3e25e472fa15dc9bd9d9c97feb688ad4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815542Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#699457}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e3a5983705da..645a8dea641a git log e3a5983705da..645a8dea641a --date=short --no-merges --format='%ad %ae %s' 2019-09-24 capn@google.com Claim Vulkan 1.1 conformance 2019-09-24 capn@google.com Implement VK_KHR_driver_properties 2019-09-24 sugoi@google.com Revert "Do not call Scheduler destructor in libVulkan." Created with: gclient setdep -r src/third_party/swiftshader@645a8dea641a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/129792032,chromium:b/129792032,chromium:b/141380274 Change-Id: I7cb72632e505463bfabaf31870a124d6500c7c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821966Reviewed-by:
-
Boris Sazonov authored
Removes the sign-out dialog implementation from ConfirmManagedSyncDataDialog and calls to it from AccountManagementFragment, as the correct sign-out dialog for managed accounts is implemented by SignOutDialogFragment. Bug: 1007250 Change-Id: I73fad2459efac5b0a2f27575a2e63adcf8cdf3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738698 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#699455}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0accebb4. With Chromium commits locally applied on WPT: d4ca0e6e "Add missing worklet referrer tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jrummell@chromium.org: external/wpt/encrypted-media jsbell@chromium.org: external/wpt/storage NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I9aff044501f4fa5d78c3a04b7d9323a4a34b64da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822102Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699454}
-
David Bienvenu authored
This disables the background Native Window Occlusion calculation for WindowOcclusionTrackerTest tests, because it can interfere with the expectations of the tests. Bug: 1007338 Change-Id: Ia4e91a9b5ea748f5ed7e243175a020f69d4d59a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822897Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#699453}
-
Renjie Tang authored
A sample netlog that I captured inter-opting with quic.rocks:4433 https://drive.google.com/file/d/1kad8a5-7Rxow-o1eEwckKWLipeLR0as9/view?usp=sharing Search HTTP3 for entries. Change-Id: I3ab02c9b49ebc82ee8ceb040beaacac1a4dea32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816823 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/696ceeee0ff2..61918356b65e git log 696ceeee0ff2..61918356b65e --date=short --no-merges --format='%ad %ae %s' 2019-09-24 treehugger-gerrit@google.com Merge changes Ie37dbea4,Id0cd4617 2019-09-24 nicomazz@google.com Merge "Enable traces download and opening in catapult" 2019-09-24 nicomazz@google.com Merge "Improve adb socket detection logic" 2019-09-24 taylori@google.com Merge "perfetto-ui: Persist timespan highlight" 2019-09-24 lalitm@google.com perfetto: remove license comment 2019-09-24 treehugger-gerrit@google.com Merge "args_tracker: use stable_sort when ordering by row id" Created with: gclient setdep -r src/third_party/perfetto@61918356b65e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I30bcf2652a242e67603eb52bffac46f968fbf3c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822279Reviewed-by:
-
Tao Bai authored
PageLoadMetricsEmbedderBase registers common observers for the embedders, the embedders shall derive the implementation from PageLoadMetricsEmbedderBase and initialize its specific observers. Bug: 995880 Change-Id: Ie60163f3191394a63fd144d52f3433a9ec513e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816801 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#699450}
-
Kurt Horimoto authored
This eliminates the boilerplate code of UIViewController setup in the coordinator, as well as the delegate and datasource capabilities provided to the mediator. Bug: 990070 Change-Id: Id0a385a7ebc171f7ff103b9bda1928d1a813eac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809515 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#699449}
-
Mason Freed authored
Prior to this CL, an invalid color filter would cause a renderer crash in software_renderer. This is now fixed. Bug: 1004054 Change-Id: I0182b1dd475d2aab909611aa9a01351863e0632d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819960 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#699448}
-
Yu Han authored
Added NOTREACHED so that in debug build, we'll get the error thrown if this case is encountered. Bug: 625676 Change-Id: If4802d387eba4b4c66488620dd61520ad7a5d78f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822326Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Yu Han <yuzhehan@google.com> Cr-Commit-Position: refs/heads/master@{#699447}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4f7741ee65c..eb4818bc4652 Created with: gclient setdep -r src-internal@eb4818bc4652 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ibc38b5c11eff9fbf7f19918143acd2380cab12ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#699446}
-
Kurt Horimoto authored
This eliminates the boilerplate code of UIViewController setup in the coordinator, as well as the delegate and datasource capabilities provided to the mediator. Bug: 990070 Change-Id: Ia0c4514476dd7f34770a649816e049c32d26c34a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809898 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Akihiro Ota authored
Change-Id: I2181ab6f31d0f2a36cf46df6c0439e77d526a8fc Bug: 1007368 Change-Id: I2181ab6f31d0f2a36cf46df6c0439e77d526a8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815158 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Switches use of PrintResult in net_perftests to PerfResultReporter and whitelists net_perftests for conversion to histograms before uploading to the perf dashboard. The majority of tests in net_perftests didn't actually use PrintResult, instead just logging to stdout in a format not usable by the parsing script. These have all been changed to use PerfResultReporter as well so that results from these tests actually show up on the perf dashboard. Bug: 923564 Change-Id: I172cd364bdc00a8f59666d8c822c0a3c6482fb8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809116Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
Adam Ettenberger authored
This change is an optimization for AXPosition<>::CompareTo. 1. AXPosition<>::CreateParentPosition There was 1 low-hanging optimization here to reduce the number of times |MaxTextOffset| is called. Storing the results of |MaxTextOffset| in a local variable and adding a new virtual method |IsEmbeddedObjectInParent| which can replace the call of |MaxTextOffsetInParent| for this method. So |MaxTextOffset| doesn't need to be computed 3-4x, now only 1x. 2. AXPosition<>::CompareTo Simplifying logic using the recently added |LowestCommonAnchor|. Instead of always computing the TREE position |LowestCommonAncestor| will only do so if one or both positions are tree positions. This reduces the cost for comparing 2 TEXT positions slightly. --- For AXPosition<>::CompareTo, I measured the perf difference with std::chrono::high_resolution_clock on an unoptimized debug build. The document had 2 columns of 100 divs each, each div had a single kStaticText child, and each column had an additional leaf kStaticText. I measured about a 30% perf improvement for comparing text positions. Both when comparing the leaf text positions in each column, and when comparing a leaf text position to a root anchored text position. Comparing tree positions was negligible compared to text positions. Before : a. LHS Branch (this->GetAnchor() == common_anchor) 169.102ms b. RHS Branch (this->GetAnchor() == common_anchor) 164.94ms c. Fallthrough) 313.984ms After : a. LHS Branch (this->GetAnchor() == common_anchor) 111.249ms b. RHS Branch (this->GetAnchor() == common_anchor) 114.441ms c. Fallthrough) 218.247ms --- Bug: 928948 Change-Id: I610f4b5157e85f2a523edf6efa793bbc306b372d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814628 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by: -
Ben Kelly authored
Bug: 1006546,1005983,1004041 Change-Id: Ic50205176c645a4ea77948a30b7535908cb41286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819804 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#699441}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 211 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-03-22. Change-Id: Ie04b919e56dfb2877234ccadbe46567f8e743985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822237 Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#699440}
-
Ankit Kumar 🌪️ authored
Document links or bookmarks may have horizontal scroll offsets defined in the PDF. Currently the horizontal scroll offsets are not taken into account during navigation of document links or bookmarks. This CL adds the horizontal scroll offset for document links and bookmarks. Tests have been modified to validate the scroll value. Bug: 982176 Change-Id: I80d227b1455db49d35294835dd6ed07f6154ca9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803941Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#699439}
-
