GitLab

Production AppEngine doesn't emit the proper mimetype for SVG automaticallly, requiring handling it in app code. To fix this bug, I just converted the CC logo to PNG.

BUG=330040
NOTRY=true

Review URL: https://codereview.chromium.org/119983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243961 0039d316-1c4b-4281-b951-d872f2087c98

rather than automatically; this allows them to be treated like web contexts
rather than extension contexts, which allows the more complex bindings rules
for making the messaging APIs (chrome.runtime.connect/sendMessage) available.
Make them available.

BUG=326250
R=koz@chromium.org

Review URL: https://codereview.chromium.org/114803007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243959 0039d316-1c4b-4281-b951-d872f2087c98

Based on initial patch by rdevlin.cronin@chromium.org

BUG=308355

Review URL: https://codereview.chromium.org/130393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313716

Review URL: https://codereview.chromium.org/123383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243957 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a second test case for inbox_app's navigation drawer that toggles
the drawer open and closed using the toolbar button.

R=nduca@chromium.org
BUG=332439

Review URL: https://codereview.chromium.org/130433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243956 0039d316-1c4b-4281-b951-d872f2087c98

> Enable all ESC-Fullscreen tests (Chrome Apps) for all platforms.
> 
> There were three issues:
> 1. a silly bug in the fullscreen change check;
> 2. there was no guarantee that the window would be actually focused;
> 3. changing the fullscreen state might come with an animation during which key events will not be received.
> 
> Note that 2 and 3 are a problem on MacOS only.
> 
> BUG=None
> 
> Review URL: https://codereview.chromium.org/116023002

TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/131343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243955 0039d316-1c4b-4281-b951-d872f2087c98

We're now enabling unwind tables for all linux architectures rather than just
x64. Update the performance expectations for ia32 linux.

TEST=none
BUG=180975
NOTRY=True
TBR=dtu@chromium.org

Review URL: https://codereview.chromium.org/132443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327999

Review URL: https://codereview.chromium.org/116363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243952 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323847
TEST=browser_tests.exe
TBR=lushnikov
NOTRY=TRUE

Review URL: https://codereview.chromium.org/131973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243950 0039d316-1c4b-4281-b951-d872f2087c98

instead of notifications in server_thread. Testing only.

Merge internal change: 59322530

Reversed pause/resume changes of server_thread in the following CL:
https://codereview.chromium.org/127503002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/132073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243948 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly boilerplate to get the OnSessionRouteChange notification up to the web-app. The web-app then includes it in the stats panel. In the common case where all channels have the same type, it displays it as "connection: <type>"; if the types differ they are displayed individually.

BUG=134528

Review URL: https://codereview.chromium.org/126123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243947 0039d316-1c4b-4281-b951-d872f2087c98

LanguageUsageMetrics is moved to its own component because it is used
both in the translate component and directly in the browser.

TranslateBrowserMetrics is moved to the translate component.

BUG=331509
TBR=jochen

Review URL: https://codereview.chromium.org/131203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243946 0039d316-1c4b-4281-b951-d872f2087c98

Now metrics are recorded only when a state of a particular network is
changed. If several consecutive checks indicate the same state for a
network, only the first one is recorded. The purpose of this fix is to
remove noize from so-called "lazy detection" from metrics.

BUG=231758
TEST=unit_tests:NetworkPortalDetectorImplTest*

Review URL: https://codereview.chromium.org/99223009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243945 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243944 0039d316-1c4b-4281-b951-d872f2087c98

Includes the following change:

r243334 | agl@chromium.org | 2014-01-07 13:08:41 -0500
OpenSSL: add support for the TLS padding extension.

This works around a bug in some versions of F5 devices that causes the
connection to hang when the ClientHello record is between 256 and 511 bytes
long.

https://tools.ietf.org/html/draft-agl-tls-padding-02

Based on the upstream patch to do the same thing:
0467ea68624450ecece4cde0d5803499aaff19c2

BUG=none

https://codereview.chromium.org/112933006

Review URL: https://codereview.chromium.org/110523007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243942 0039d316-1c4b-4281-b951-d872f2087c98

It's MIT licensed. We'll put it at third_party/fontconfig.

See https://chromium.googlesource.com/external/fontconfig/+/master/COPYING

R=phajdan.jr@chromium.org

BUG=332244

Review URL: https://codereview.chromium.org/127213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243941 0039d316-1c4b-4281-b951-d872f2087c98

Currently it's anything equal or newer than 9.2.1

BUG=332596
TEST=
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/130153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243940 0039d316-1c4b-4281-b951-d872f2087c98

Removing GetDefaultProfileOrOffTheRecord and GetDefaultProfile(<path>) from ProfileManager's (public) functions.

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/129293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243939 0039d316-1c4b-4281-b951-d872f2087c98

There were three issues:
1. a silly bug in the fullscreen change check;
2. there was no guarantee that the window would be actually focused;
3. changing the fullscreen state might come with an animation during which key events will not be received.

Note that 2 and 3 are a problem on MacOS only.

BUG=None

Review URL: https://codereview.chromium.org/116023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243938 0039d316-1c4b-4281-b951-d872f2087c98

Some components of a 32 bit build of chrome for Windows need to be built
as Win64 Dlls.  To allow those components to use base, we make a Win64
build of the base library even when building chrome 32 bit.

This is needed by the Chrome Desk Band code. crbug.com/327435.
https://codereview.chromium.org/79173004/

BUG=327435

Review URL: https://codereview.chromium.org/103333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288562, 332034

Review URL: https://codereview.chromium.org/128373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243933 0039d316-1c4b-4281-b951-d872f2087c98

If the sync point is retired, the scheduler already executed all gl calls before
the sync point, so OnWaitSyncPoint() does not need to do anything. Currently,
OnWaitSyncPoint() always sets the scheduler off and then on. This CL makes
OnWaitSyncPoint() be able to return early.

BUG=332401

Review URL: https://codereview.chromium.org/128123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243932 0039d316-1c4b-4281-b951-d872f2087c98

This fails on other configurations. The new behavior matches the GYP build.

R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/130923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243930 0039d316-1c4b-4281-b951-d872f2087c98

Apply aria-haspopup attribute to actions buttons.

BUG=320753
TEST=ctrl+alt+z, tab to actions button and hear "action pop-up button".
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/130093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243929 0039d316-1c4b-4281-b951-d872f2087c98

BUG= none
TEST= none

Review URL: https://codereview.chromium.org/124523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243925 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243924 0039d316-1c4b-4281-b951-d872f2087c98

r1833 Speculative fix for OOM on win ninja builders

TBR=robertshield@chromium.org

Review URL: https://codereview.chromium.org/131463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243923 0039d316-1c4b-4281-b951-d872f2087c98

Arguably more importantly, make data pipe producers not writable during
two-phase writes and consumers not readable during two-phase reads. This
allows multiple threads to simultaneously use the two-phase APIs in a
sane way; they can respond to a "busy" error by waiting. (Why not
"should wait" instead of "busy"? Because waiting is only an appropriate
response if you know that someone else is going to end the two-phase
read/write -- e.g., if a two-phase read/write is happening on another
thread.)

Also refactor the waiter-awakening stuff so that it's taken care of by
the DataPipe superclass, rather than the LocalDataPipe implementation
subclass.

Note that a two-phase write will only discard if "all-or-none" is
requested. Otherwise, as usual, it'll provide as much space as
available.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/129163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243920 0039d316-1c4b-4281-b951-d872f2087c98

This makes unwind support consistent on Linux (used by
base::debug::StackTrace). A combination of arch-specific toolchain defaults
and arch-specific cflags made the previous behavior inconsistent.

Unwind tables are useful for development and much cheaper than
debuginfo, so enable them for all non-official builds.

TEST=build for ia32, x64, arm (compared defaults & official)
BUG=180975

Review URL: https://codereview.chromium.org/129283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243919 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243918 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243917 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243908 0039d316-1c4b-4281-b951-d872f2087c98

- Remove GetNext* methods.
- Add GetAll* methods, returning a vector of Params/Msg pairs.

BUG=

Review URL: https://codereview.chromium.org/127243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243907 0039d316-1c4b-4281-b951-d872f2087c98

> Android: moves jni_generator samples to use long for JNI.
> 
> BUG=317523
> 
> Review URL: https://codereview.chromium.org/131543003

TBR=bulach@chromium.org

Review URL: https://codereview.chromium.org/131913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243905 0039d316-1c4b-4281-b951-d872f2087c98

The video muting test didn't force iSAC correctly. Also added some
lightweight log statements to make it easier to see how far we get when
the test fails.

BUG=332765
TBR=wjia@chromium.org

Review URL: https://codereview.chromium.org/131613005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243904 0039d316-1c4b-4281-b951-d872f2087c98

Missed updating the MockSurfaceFactoryOzone implementation in content_unittests
when I modified the GetVSyncProvider function.

TBR=piman@chromium.org
NOTRY=true

BUG=

Review URL: https://codereview.chromium.org/131893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243903 0039d316-1c4b-4281-b951-d872f2087c98

There can be multiple streams calling OnData() when the users setup multiple getUserMedia with WebAudio and microphone. We have no way to avoid this situation since it is a valid user cases from the JS perspective.
But unfortunately webrtc does not support it since it has one global transmit mixer, and it will crash when more than 1 stream getting into its resampler.

This CL introduces a lock to sequence the calls to avoid the racing, which should fix the crash.


BUG=332126
TEST=https://devpool-13.talkgadget.google.com/hangouts, go to setting page and play the rington, verify no crash and sound good.
Or go to https://x20web.corp.google.com/~xians/multiple_sources.html, start the call, AddWebAUdio, then Playout a clip, verify the audio sounds good and no crash.

Review URL: https://codereview.chromium.org/131213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243902 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/120693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243900 0039d316-1c4b-4281-b951-d872f2087c98