GitLab

For more information, please refer to this doc:

https: //docs.google.com/document/d/1jaUv28xBPrOrkZV9gck9btEKvgM8u_awO83SXraPbQ4/edit?usp=sharing
Bug: 716565
Change-Id: I040ecc5e44df15768649684b4f5ee8d5e828c209
Reviewed-on: https://chromium-review.googlesource.com/534133
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487612}

Before this patch, parsing a web app manifest with multiple
"related_applications" would return an empty manifest. Multiple
different "fingerprints" would return the first fingerprint multiple
times. These bugs occurred because of incorrect usage of index "i"
instead of "j" for "fingerprints". The "i" index is used only for
"related_applications".

This patch adds tests TwoRelatedApplicationsWellFormed for parsing two
"related_applications" and TwoDifferentSignaturesWellFormed for parsing
multiple different "fingerprints" in the web app manifest. Before the
fix, the tests fail. The tests pass after the fix, which is to use "j"
instead of "i" index for "fingerprints".

After this patch, parsing a web app manifest with multiple
"related_applications" returns a manifest with two sections. Parsing
multiple different "fingerprints" returns different parsed fingerprints.

Bug: 745765
Change-Id: I43953748a405e5d3ef2329e22ba3ff449b10f104
Reviewed-on: https://chromium-review.googlesource.com/575715Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487611}

The tests added are:
1.) Search google for this image not shown in context menu
    (and doesn't crash).
2.) Search engine preference is disabled in settings (also
    doesn't crash).

BUG=720504

Change-Id: Ib481169f83c789a4aa23aac37d13d5fe512c443f
Reviewed-on: https://chromium-review.googlesource.com/576387Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487610}

Requested by the speed releasing team.

Bug: 
Change-Id: I87228f82856a0fce7034023e90ca18d524af0db1
Reviewed-on: https://chromium-review.googlesource.com/576237
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487609}

Now with unittests!

Also do not try to put non-UTF8 strings into NetLog,
because a DCHECK files as soon as a TestBoundNetLog is used.

Also remove a solitary DVLOG() statement,
since other failure modes do not have one.

Change-Id: I67e82c09a4e73a8561973c3db432e4364d05ad55
Reviewed-on: https://chromium-review.googlesource.com/570627
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487608}

Bug: 
Change-Id: I09d909e626db4212a572d0d854c4af0cebcc9633
Reviewed-on: https://chromium-review.googlesource.com/574905
Commit-Queue: Lukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: David Sehr <sehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487607}

https://pdfium.googlesource.com/pdfium.git/+log/fe1c8e616680..56725242559d

$ git log fe1c8e616..567252425 --date=short --no-merges --format='%ad %ae %s'
2017-07-18 dsinclair Fix CONTINUED spelling
2017-07-18 rharrison Add documentation for code coverage support
2017-07-18 dsinclair Add missing STDCALL annotations

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib38277f1ad87f579aa2de35ecbfe2f40110c024f
Reviewed-on: https://chromium-review.googlesource.com/576332
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487606}

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG=662543
This CL was uploaded by git cl split.

R=sehr@chromium.org

Review-Url: https://codereview.chromium.org/2980653003
Cr-Commit-Position: refs/heads/master@{#487605}

According to crbug.com/714303, testPostFormToSamePage was disabled on
devices due to flakiness, however, I couldn't repro locally as of
today, so I'm marking it as flaky on devices and see if it's still
reproducible on FYI bots.

Bug: 714303
Change-Id: I68bfc9d9771cbb00ac8161eb024cd8c52ee40244
Reviewed-on: https://chromium-review.googlesource.com/576290Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487604}

This allows the Chrome Cleanup WebUI to be consistent when the settings
page is refreshed. It also works around https://crbug.com/740629 by
having the state change immediately rather than the next time a settings
page is opened.

Previously, if a settings page was opened before transition to kInfected,
refreshing the page would not show the card. However, if a new settings
page was opened, refreshing the original one would start showing the
card. This caused some re-layout issue in some edge cases.

Bug: 690020
Change-Id: Ib56c372bbe3f5b63c050abbd26bf7e6e4958eb8a
Reviewed-on: https://chromium-review.googlesource.com/568907
Commit-Queue: proberge <proberge@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487603}

There is an option to configure the maximum size of the NetLog. The
default is 100MiB.

Bug: 679030
Change-Id: I9260d7ee895d589c4789a350ca4fe1dfc8617b65
Reviewed-on: https://chromium-review.googlesource.com/571514
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487602}

Bug: None
Test: pass
Change-Id: I97c70f276ccfe7edc5aaa698893e5860bdc4ef6e
Reviewed-on: https://chromium-review.googlesource.com/575025
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487601}

Also give a consistent team mailing list for threaded-rendering-dev@chromium.org

R=flackr@chromium.org, vollick@chromium.org

Change-Id: I1a80a98715af27baf8839caef6ecb4b3b2b25ff6
Reviewed-on: https://chromium-review.googlesource.com/576331Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487600}

Adds a variations param to allow experimentation on tap
suppression after a recent scroll.  This suppression
is on by default, but we may want to increase the value
in a general tap-suppression experiment. This param
existed in a previous version so we're using the same
param name as before to avoid confusion.

Bug: 745970
Change-Id: Ie73f354f5ed799c00034e1d206fffa9e0746c25c
Reviewed-on: https://chromium-review.googlesource.com/576347Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487599}

Bug: 730692
Change-Id: Ia5133f2f31e0411e374a051e6f907df570c252c4
Reviewed-on: https://chromium-review.googlesource.com/576373Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487598}

This CL introduces an alternative rendering thread for WebAudio.
Note that there is no change when the user opt-outs the AudioWorklet
runtime flag*.

When the AudioWorklet runtime flag is set, AudioDestination runs on
the AudioWorkletThread object's backing thread which is the same
thread used for all the other AudioWorklet infrastructure.
(e.g AudioWorkletGlobalScope + V8)

This change will significantly help the future AudioWorklet CLs to
land.

* flag from command line: --enable-blink-features=Worklet,AudioWorklet

Bug: 469639
Change-Id: I43be54ff04fd51d88253fd879a6a5dff566fc4dc
Reviewed-on: https://chromium-review.googlesource.com/565442Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487597}

Adds a HeadlessQuotaPermissionContext.

When the ContentBrowserClient did not return a valid QPC, nullptr
crashes were possible.

Bug: 733569
Change-Id: I082e3953580620b84802dc3330dbae3c113301c4
Reviewed-on: https://chromium-review.googlesource.com/574545Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487596}

- Replace 2 instances of WeakPtr usage in DialServiceImpl with a
CancelableTaskTracker to track thread-hopping calls to obtain network
interfaces.
- Replace the callbacks bound to DialServiceImpl using WeakPtr passed
to DialSocket with a raw pointer DialServiceImpl. This is safe because
DialServiceImpl owns DialSockets.
- Remove WeakPtrFactory from DialServiceImpl.

Bug: 735590
Change-Id: I4965a33a7a706b057ee7d0f4c5cb6fb98b06dbc2
Reviewed-on: https://chromium-review.googlesource.com/574993Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487595}

If the token service has already a refresh token for the authenticated
account before this account is signed in to Chrome, then |OnRefreshTokenAvailable|
notification will not be called after |OnActiveAccountLogin|.

This CL changes the TiclInvalidationService to handle the case when the
refresh token is already present when |OnActiveAccountLogin| is fired.

See bug for the link to the design document.

Bug: 733226
Change-Id: I205e522ebe75c059b9125e113f451cf328a2f564
Reviewed-on: https://chromium-review.googlesource.com/559537Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487594}

After this change, users can define a repeated field in protobuf,
message Message {
  repeated <type> foo;
}

and use
    GetParamSize(sizer, p.foo())
    WriteParam(m, p.foo())
and
    ReadParam(m, iter, r->mutable_foo())
to serialize and deserialize the field.

Serializing and deserializing a RepeatedField / RepeatedPtrField are needed in
change https://codereview.chromium.org/2964613002/.

BUG=650926

Review-Url: https://codereview.chromium.org/2968003005
Cr-Commit-Position: refs/heads/master@{#487593}

Changes:
1. Make the dots of pagination switcher centered vertically on
AppsGridView no matter their number.

Spec: https://screenshot.googleplex.com/QHkyJRGmz46
Screenshot: https://screenshot.googleplex.com/MLduTvsXwcf

BUG=741007

Change-Id: I5305267af35b21ba3446424c3bedc8d2eab8615d
Reviewed-on: https://chromium-review.googlesource.com/576249Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487592}

Only read 64KiB of the events file at a time.

Bug: 679030
Change-Id: If063b547d547240f79024350c1cead13e0f6426e
Reviewed-on: https://chromium-review.googlesource.com/572185
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487591}

BUG=734199

Review-Url: https://codereview.chromium.org/2978443002
Cr-Commit-Position: refs/heads/master@{#487590}

BUG=706512

Change-Id: Ib252b2e692f36494e829eeefdb9664fb82f34909
Reviewed-on: https://chromium-review.googlesource.com/576309Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487589}

zap_timestamp.exe doesn't support the 64-bit binaries.

the build_bitness function comes from https://cs.chromium.org/chromium/src/chrome/test/chromedriver/util.py?l=45&rcl=ffe66181996a36f5d64e507dbd3dcd78dc1ebecb

Bug: 705133
Change-Id: Ie17e963d62bd3ac508b0de8a853f6d653ef2454b
Reviewed-on: https://chromium-review.googlesource.com/576188
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487588}

easier comparison.

Before this change, MemoryKillsMonitor only reports kill events when it
happens. So it is hard to compare sessions with kill events and those
not.

Before this CL, the monitoring starts when session manager starts (e.g.,
when the login screen is present but not logged in). So simply report a
zero kill event at that time is not ideal because it would bloat the
actual number of user sessions.

In this CL, the monitoring starts when user has logged in. So it
reflects actual user sessions.

Bug=b:62499558
TEST=manual + cheets_LowMemoryKiller

Change-Id: I98cc14e4346e6883dacfe063366c78bc771750cc
Reviewed-on: https://chromium-review.googlesource.com/541200
Commit-Queue: Cheng-Yu Lee <cylee@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Yusuke Sato (in China Mon-Thurs, may be offline) <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487587}

This includes:
mojo_system_unittests
mojo_test_apk
services_unittests
components_unittests (2 shards)
content_unittests
content_shell_test_apk (3 shards)
net_unittests (3 shards)
unit_tests (2 shards)
... and also all the dbg browserside-navigation versions of the tests.

Increased device pool with https://chrome-internal-review.googlesource.com/c/412868/
Will increase more if needed.

Bug: 670879
Change-Id: I6da4efe9588c9eae06eb26d5cbe1d62da4f27a65
Reviewed-on: https://chromium-review.googlesource.com/575360Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487586}

Bug: 736249
Change-Id: Id69d62b7f0d3f6e7f41bf8d2fe713e3296b6e496
Reviewed-on: https://chromium-review.googlesource.com/567260
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Zhen Wang <zhenw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487585}

This reverts commit f4c20b08.

Now that gles2_cmd_decoder deletes the group before |surface_|, we
shouldn't need to handle this case.

Bug: 718117
Change-Id: Ia2808674fc91d7b1d43525397d6e598f483d0909
Reviewed-on: https://chromium-review.googlesource.com/576060Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487584}

Also remove the deprecated files from polymer_resources.grdp since
they are not needed anymore.

Bug: 744902
Change-Id: I35ab3bbbb2e9d42758430672aba4736393e6056d
Reviewed-on: https://chromium-review.googlesource.com/575388
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487583}

Also add the logic to skip the redirect to itself if such old data
was found in the metadata store.

BUG=741197
TEST=new tests added

Change-Id: I006104b2716baf68303f99c035ea628d45dffdc0
Reviewed-on: https://chromium-review.googlesource.com/572601
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487582}

- All classes under extensions/browser/api/cast_channel/ use namespace extensions
- Auto generated code (cast_channel.h) from cast_channel.idl uses namespace extensions::api

Bug: 731189
Change-Id: I8b658f909296ecab8dd9c99e3845adf1ff1389d8
Reviewed-on: https://chromium-review.googlesource.com/574968Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Bin Zhao <zhaobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487581}

TBR=tedchoc

Bug: 744962
Test: browser_tests
Change-Id: I3d1c8aa4f782aad1a64b5478095868c3b6704c45
Reviewed-on: https://chromium-review.googlesource.com/575396
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487580}

Bug: 742413
Change-Id: I43129261e2c69d32b4e2b31a66d6d4f3bef52a36
Reviewed-on: https://chromium-review.googlesource.com/571417Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487579}

This test is failing on v1 devices. Disable the test temporarily to
get the dashboards green again so this failure doesn't mask other
failures. Should get re-enabled once the test issue is resolved.

BUG=744777
TEST=midi_unittests

Change-Id: I4db7b1fdb7ce9b73f8e9cf161b4080cf9e10f143
Reviewed-on: https://chromium-review.googlesource.com/575197Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487578}

https://skia.googlesource.com/skia.git/+log/0aa492d0f47d..c432b0ca8a50

$ git log 0aa492d0f..c432b0ca8 --date=short --no-merges --format='%ad %ae %s'
2017-07-18 ethannicholas fixed use-after-free in sksl switch statements
2017-07-18 mtklein minor fixes to start_pipeline_lowp
2017-07-18 rmistry Do not move over webpage archives, they are needed for capturing SKPs
2017-07-18 csmartdalton Add two test bots for coverage counting path renderer
2017-07-18 bsalomon Revert "Improvements to GPU dither."
2017-07-18 bsalomon Improvements to GPU dither.
2017-07-18 reed guard references to SkColorTable
2017-07-18 halcanary Commit Queue: add Build-Debian9-GCC-arm-Chromecast
2017-07-18 ethannicholas added sksl support for integerSupport cap
2017-07-18 halcanary Revert "Revert "SkPDF: Non-outline glyphs as images""
2017-07-17 bsalomon Make dither range symmetric about 0

Created with:
  roll-dep src/third_party/skia
BUG=705480


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Id6ec92583056ae097a9c2f3755b844337c5f5a43
Reviewed-on: https://chromium-review.googlesource.com/576075Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487577}

TEST: Unit tested, device tested with --enable-features=EnableFullcreenAppList
Bug: 737611
Change-Id: I05727c4266b69ab33f22a09ecc582ac920d8ec8a
Reviewed-on: https://chromium-review.googlesource.com/572548
Commit-Queue: Maajid <maajid@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487576}

Since network change notifier triggers observer call before we can
establish connection to server when the device comes online, the first
download attempt in download service will always fail.

This CL adds a delay to notify download service to do stuff after the
device becomes online.

Bug: 736046
Change-Id: Ibfb31ed4c993f41a960429b5590e2cc083dbe229
Reviewed-on: https://chromium-review.googlesource.com/567587
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487575}

The directory-based file layout for bounded mode logging is a now an internal detail rather than part of the API contract. The result of logging, whether in bounded mode or unbounded mode, is now a single file using the same format.

This makes it possible to use either bounded or unbounded mode and get a compatible result.

Bug: 679030
Change-Id: I501911678a98c14a3907d1407a91aabcbfa31d62
Reviewed-on: https://chromium-review.googlesource.com/570887
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487574}

Swiping up on the System Tray/ IME/ Stylus/ Notifications buttons in
status area should open the associated bubble.
Swiping down on the opened bubble should close the associated bubble.

Changes:
1.Added the tray_drag_controller to extract the logic of dragging behavior from system_tray.
2.Added help functions in tray_background_view to get the state of associated tray bubble.
3.Added one interface ProcessGestureEventForBubble in TrayBubbleView::Delegate
to help process the dragging that happened on the tray bubble.

BUG=735994,735996

Review-Url: https://codereview.chromium.org/2961313003
Cr-Commit-Position: refs/heads/master@{#487573}