GitLab

Currently, we send an empty string as a resource loading hint to the
renderer when doing previews resource loading hints optimization.
This CL changes the browser's behavior to send the resource loading
hints that are provided by Previews UI service.

The CL also enables browsertest to modify the list of hints that are
sent to the renderer. This will be used in a browsertest in a subsequent
CL to verify that subresources that match the pattern are not loaded.

Bug: 856243,856247
Change-Id: I29a393dd37090fcb8dc5706669e88e0ae91f47db
Reviewed-on: https://chromium-review.googlesource.com/1136885Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575395}

Now webrunner::FrameImpl creates WebContents and a WindowTreeHost.

Also moved FrameImpl and ContextImpl classes to //webrunner/browser
(because they run in the browser process).

Bug: 852145
Change-Id: Ic1f3e453342f182e28bbf971fae011a671bee105
Reviewed-on: https://chromium-review.googlesource.com/1135836Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575394}

One-pager describing this refactoring: https://goo.gl/24gkCb

This is a follow-up to the crrev.com/574691
This patch:
- renames content::PermissionManager into content::PermissionControllerDelegate
- renames BrowserContext::GetPermissionManager() into BrowserContext::GetPermissionControllerDelegate
- renames content::TestBrowserContext::SetPermissionManager into TestBrowserContext::SetPermissionControllerDelegate

R=dgozman
TBR=boliu, scottmg, xunjieli, spang, thestig
BUG=631464

Change-Id: I01ca186635898d250877e7462a731e47ffae31c3
Reviewed-on: https://chromium-review.googlesource.com/1136858
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575393}

Optimization part 2 of ~3

This is in preparation for a follow-on change that will change
RenderTextHarfBuzz::ShapeRun to take a single CommonParams, and a list
of all runs that share these parameters.

To that end, pull out explicit use of RenderTextHarfBuzz::common, and
pass the CommonParams explicitly, wherever possible.

Bug: 862773
Change-Id: Ia349c23ad58ab590c8ec6f05c6a9f1dcc253ab57
Reviewed-on: https://chromium-review.googlesource.com/1137891
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575392}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d75ef78a..4fb310a1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4b3e4572f651fd34977ded01d5a5a301af033ae0
Reviewed-on: https://chromium-review.googlesource.com/1138720Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575391}

Bug: 862163
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ied380807f9f57998d04e2ffddd004048568f0f9f
Reviewed-on: https://chromium-review.googlesource.com/1136724Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575390}

This patch fixes max-content size when the line has floats
outside of its content box.

In such case, ComputeContentSize computes a negative value
for |floats_inline_size|. Such |floats_inline_size| should
not affect max-content size.

This patch applies the same fix as r570350 (CL:1113094) to
NGInlineNode.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5495e56fb3cf6777a4fd308b61f5eb6e484d03af
Reviewed-on: https://chromium-review.googlesource.com/1138594
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575389}

This fixes a failure mode where we shutdownVR after handling the VR NFC
broadcast, and fail to properly cancel VR entry.

Also does some other random cleanup of comments/visibility.

Bug: 862829
Change-Id: Ic382692d7255aa5893391a602a6c949b4b4d498b
Reviewed-on: https://chromium-review.googlesource.com/1138726Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575388}

This comment was added in https://chromium-review.googlesource.com/c/chromium/src/+/834758 but the test has been fixed since then.

Bug: 621126
Change-Id: I22f77f9548bef8741e9aaf7325346c860efca292
Reviewed-on: https://chromium-review.googlesource.com/1138724Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575387}

See https://www.w3.org/TR/webauthn/#sec-authenticator-data. AFAIU, the
spec is not exactly clear whether or not to set this bit from a user
verifying authenticator. It says that the bit should be set if the
user is "present", which is defined as having successfully completed a
"user presence test". User presence test is defined separately from user
verification test (which is what Touch ID does). Logically, a user
verification test always includes a user presence test, but the spec
doesn't say so explicitly.

Regardless of what the spec says, setting both bits seems less likely to
confuse server implementations IMO. A naive server e.g. might *just*
check for the UP bit, and if it is not set reject the response, even
though the UV bit is set. Hence, we should probably set both.

Bug: 678128
Change-Id: I02be366dba324e4f9b83ba0d354a674242fc72dc
Reviewed-on: https://chromium-review.googlesource.com/1137216
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575386}

- Handle the decrypt config passed to SetStream().
- The config is copied to CodecPictures and passed to the accelerator.

Bug: 820192
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib3337b4bc2f972d410a07bc5af6f67a7ef2a9a2d
Reviewed-on: https://chromium-review.googlesource.com/1133974
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575385}

eraser button

When we press an eraser button of a stylus, we should send the missing
pointerdown, pointerup, gotpointercapture and lostpointercapture events.

Bug: 851457
Change-Id: Iff45a897a87ef03d73cc308d84e874dbc1310fa1
Reviewed-on: https://chromium-review.googlesource.com/1129619
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575384}

Bug: 862865
Change-Id: I655432dc051ea9df3a3edb6d4ee54ad1dc2ed48f
Reviewed-on: https://chromium-review.googlesource.com/1135197Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575383}

Bug: 833380
Change-Id: Idc4d24382205ba47b23da686b2b607ca3de0c031
Tbr: kenrb@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1138415Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575382}

https://pdfium.googlesource.com/pdfium.git/+log/bfeb9343ee79..481749905d44


git log bfeb9343ee79..481749905d44 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 tsepez@chromium.org Get rid of some loose allocs/free in CPDF_Document.


Created with:
  gclient setdep -r src/third_party/pdfium@481749905d44

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I918c08d738f94a9de73f0d1d1d0e3dabdc7efcc8
Reviewed-on: https://chromium-review.googlesource.com/1138556Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575381}

Commits:
https://chromium.googlesource.com/external/fontconfig/+log/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde..d1f48f11d5dffa1d954a1b0abe44ce9e4bfc3709

BUG=857511
TBR=dnicoara

Change-Id: Ib3b499aa63d87c2886261ddcfbe692f24f7be59a
Reviewed-on: https://chromium-review.googlesource.com/1138543Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575380}

There are two namespaces named prefs in scope inside media_router code:
The global ::prefs namespace and the local ::media_router::prefs namespace.

If both namespaces are known to the compiler, as happens in jumbo builds,
then the name lookup will be ambigious and the compiler will fail to
compile the code.

Bug: 803406
Change-Id: Ib4be547ffe1ba7a790c2003fd54bd091935c378e
Reviewed-on: https://chromium-review.googlesource.com/1138244
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575379}

1. Added ContextProviderMain() that instantiates ContentProviderImpl.
2. Updated WebRunnerMainDelegate to run WebRunnerBrowserMain() only
   when process is started with --type=web-context
3. Updated WebRunnerBrowserMainParts to instantiate ContextImpl.
4. Updated ContextProviderImpl to pass --type=web-context to the
   web context process.

Bug: 852145
Change-Id: I9740162ad9006df5e254e6ca3d4bed24640c94ce
Reviewed-on: https://chromium-review.googlesource.com/1134585
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575378}

Bug: 860800
Change-Id: I131f5e7a73d435f0d55788cea351f14a34039526
Tbr: geofflang@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1138549Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575377}

Whoops. No test unfortunately since there's no good way to test
this other than hard coding the expected default values in the
test itself, which is generally not a good test.

BUG=779192
TEST=none
TBR=mlamouri

Change-Id: I00d26ef715fac4884017ce295639ee6aab37d777
Reviewed-on: https://chromium-review.googlesource.com/1138648Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575376}

Bug: 841643
Change-Id: I28d6ec0af4aa8ad77eeb9e140a3dac58097002ea
Reviewed-on: https://chromium-review.googlesource.com/1136064Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575375}

Simple cleanup and refactoring from abandoned crrev.com/c/1134423

Bug: None
Test: Child modal example works in ash_shell_with_content
Change-Id: I3d58eb3c5341e42bf6bda99a51d1caa977cf48f9
Reviewed-on: https://chromium-review.googlesource.com/1138412
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575374}

      +591,635 bytes normalized apk size
            +3 zip entries file count
       +25,004 bytes main lib size
      +386,116 bytes main dex size
      +205,519 bytes APK size
 +1,765,427.64 bytes Estimated installed size
InstallBreakdown (+1,764,154.64 bytes):
        +1,572 bytes Non-compiled Android resources size
       +25,004 bytes Native code size
          +183 bytes Package metadata size
 +1,722,871.64 bytes Java code size
       +14,524 bytes Compiled Android resources size
        +1,928 entries fields
        +2,655 entries methods
          +649 entries types
        +1,331 entries strings

Specifics: 
InstallSize: 
Dex: 
Change-Id: Ibe4ff1f2778fb1a885a304f57bfaeb289809894a
Reviewed-on: https://chromium-review.googlesource.com/1135944Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575373}

The original CL for this (https://chromium-review.googlesource.com/1105569)
was reverted because of a null pointer bug. This CL does the same thing
as the reverted CL and fixes the null pointer exception by having
ToolbarManager#getMenuButton() return the bottom toolbar menu button when
the bottom toolbar is enabled.

Bug: 852117

Change-Id: Ic2668a3cac6a552bee4476d1cfb58f8e6c290bfd
Reviewed-on: https://chromium-review.googlesource.com/1135776Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575372}

Adding CHECKs to verify that we did not miss any cases when it's called
for browser-initiated navigation. Will cleanup after a couple of Canaries.

Bug: 789577

Change-Id: I36890e1cb653a7f1795a187be0d80f2a99e10aaf
Reviewed-on: https://chromium-review.googlesource.com/1135934
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575371}

VLOG() has a high overhead due to pattern matching. Calling it per-frame accounts for ~0.3% of all cycles spent in Chrome on ChromeOS devices.

Bug: 489441

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5d6fc6d829601f6ad501e1676fd8114ab99d82c2
Reviewed-on: https://chromium-review.googlesource.com/1132422
Commit-Queue: Chong Jiang <chongjiang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575370}

https://skia.googlesource.com/skia.git/+log/e7e3bb4d2006..b965fcb47296


git log e7e3bb4d2006..b965fcb47296 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 benjaminwagner@google.com Re-add Android Vulkan tryjob to CQ.


Created with:
  gclient setdep -r src/third_party/skia@b965fcb47296

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I29ef3ca7d0ab11c88236e06f432787241cc0daeb
Reviewed-on: https://chromium-review.googlesource.com/1138375Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575369}

When a tab is being dragged, the current instance of TabDragController
calls FocusManager::SetFocusedView()  and passes the tab strip that is
the source of the drag. Since the tab strip is not focusable, the
focus is moved to the next focusable element. In MacViews (when
keyboard accessibility is not turned on), this is the omnibox,
resulting in the omnibox being focused during a drag.

Instead of calling SetFocusedView(), FocusManager::ClearFocus() should
be called. This way, whichever element is currently focused will lose
focus during a drag, as is desired. However, no new element will be
focused, so there is no chance that an undesired focus occurs. When the
drag finishes, TabDragController restores focus to the previously
focused element as it previously did.

On ClearFocus(), the window associated with the top root view gets
focus, so key events are still forwarded properly and hitting Esc
still cancels the drag in progress.

The interactive UI test was slightly modified to check that the window
of the attached tab strip has focus rather than the tab strip itself
to reflect the new behavior.

Bug: 835550
Change-Id: Iff846e24e31428737ae204dd9e68f2f57ee83bad
Reviewed-on: https://chromium-review.googlesource.com/1132133
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575368}

OverlayWindowViews handled KeyEvents as a workaround for a11y
navigation. Now that the buttons are tab navigable, this is no longer
needed.

OnKeyEvent() also causes some issues if the initially focused button
on the window is the close button, rather than play/pause. This is
determined by the built in view::Views keyboard navigation. Keeping
track of this separately in OverlayWindowViews makes no sense.

Change-Id: Ide8cca038452781790d2d80a9545f1a2a7b474e9
Reviewed-on: https://chromium-review.googlesource.com/1136228Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575367}

We are attempting to improve visiblity into why RejectedExecutionExceptions happen. This change includes any Runnable that appears more than 50 times into the exception message.

Bug: 843745
Change-Id: Ifa383cfc0be3b7c58298ff48399d120bd7ab45ba
Reviewed-on: https://chromium-review.googlesource.com/1133776Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575366}

Used this to display the overflow bubble more easily.

R=msw@chromium.org

Test: manual
Bug: 863822
Change-Id: Id7cb6147c5ce4b699ed5c3573ab23388cdb0b465
Reviewed-on: https://chromium-review.googlesource.com/1138404
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575365}

Bug: 853869
Change-Id: Ifa67aef8421b4169d8c34711df72293135ce7f8b
Reviewed-on: https://chromium-review.googlesource.com/1123764
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575364}

Currently when empty allow list is passed on as a parameter to
GetAssertion request, all requests to U2F devices are dropped. This is
in accordance with current version of the CTAP spec, as empty allow list
implies resident key credentials and U2F devices do not support resident
keys.

However, this behavior causes requests to U2F devices to be dropped
without U2F devices blinking, which causes user confusion. In order to
minimize user confusion, sent fake registration call to U2F devices for
GetAssertion request with empty allow list.

Bug: 860062
Change-Id: I8e62d01e46cd90f393035149254286b58a932e78
Reviewed-on: https://chromium-review.googlesource.com/1132456
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575363}

This CL adds a JNI bridge for DownloadMediaParser. Since Android
currently doesn't support browser test, a high level java test needs
this bridge. Also the UI code may call through this routine.

Bug: 826021
Change-Id: I58dfb770fc03bcc567b55a98eb0a8c51d0f02052
Reviewed-on: https://chromium-review.googlesource.com/1136523Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575362}

TouchIdContext implements the Touch ID authorization prompt. After
receiving the OS reply callback from the Security framework it forwards
the result to the user-supplied callback, but doesn't do so on the
original TaskRunner that it was invoked on. As a result, Touch ID
authenticator requests fail some sequence checker tests. This fixes that
by posting the user-supplied callback back on the original runner.

Bug: 678128
Change-Id: I0e7a8730ec898f288cd25323134aa95ef50ddbdf
Reviewed-on: https://chromium-review.googlesource.com/1136496
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575361}

content_browsertests takes almost 7 minutes to run and is currently on the
critical path of the bot since it's not swarmed, so this should reduce
the cycle time of cast_shell_linux by almost 7 minutes.

Bug: 843511,861843
Change-Id: I95dc87ca2b844b2bf0363b4a8b1915aeaed30938
Reviewed-on: https://chromium-review.googlesource.com/1129042
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575360}

- gin_unittests on "Linux - Future (dbg)"
- unit_tests on "Win10 Tests x64 (dbg)"
- telemetry_unittests on "Win10 Tests x64 (dbg)"

Bug: 843511
Change-Id: Iabd54c3330a25b14d0bf4773e4862bfa5d10aabb
Reviewed-on: https://chromium-review.googlesource.com/1138254
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575359}

These tweaks are based on feedback from UX.  See the linked bug
for details.

BUG=863043

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I159c77e16c567b5b670ca727425253fc8a393ebe
Reviewed-on: https://chromium-review.googlesource.com/1135289
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575358}

This patch supports NGLineBreaker to rewind unpositioned
floats.

When rewinding floats occurs, LayoutNG either position them
incorrectly, or hit DCHECK in paint due to duplicated ID.
This patch fixes it for unpositioned foats by matching to
Edge and Gecko.

Blink considers such floats as if it were committed
(positioned in LayoutNG terminologies) and thus the position
is incorrect.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I884879b2034d2f63ae248f70de3edeb27d71cafe
Reviewed-on: https://chromium-review.googlesource.com/1136262
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575357}

This is a reland for 1133315. A global function was mistakenly moved lower, and was not visible to calls that happened before it.

Refactor BrowserDMTokenStorage for easier platform implementations.

This CL refactors BrowserDMTokenStorage & BrowserDMTokenStorageWin to move code that is common to all platforms.

After this CL, adding a new platform requires implementing the following methods:

-  virtual std::string InitClientId();
-  virtual std::string InitEnrollmentToken();
-  virtual std::string InitDMToken();
-  virtual void SaveDMToken(const std::string& token);

Note that this CL keeps the existing Windows implementation, it only refactors the code (no functional change).

BUG=812641

TBR: pastarmovj
Change-Id: I51d6b4efef6066d602a59c514e9db88e414e4337
Reviewed-on: https://chromium-review.googlesource.com/1138539Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575356}