GitLab

This also add check to ensure that legacy system health stories which already
have a newer version must be disabled within smoke testing.

Finally, this CL also shorten the names used in _DISABLED to simplify the job of
disabling a system health story.

Bug: 878390, 893615
Change-Id: Ife447c9e5935c960ea7e1818adfcaef0ccaeb59a
Reviewed-on: https://chromium-review.googlesource.com/c/1289686Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600987}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=jochen@chromium.org

Bug: 681136
Change-Id: I2de6838cb20e249234f820aa84d996311acc58c1
Reviewed-on: https://chromium-review.googlesource.com/c/1288345Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600986}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=chrishtr@chromium.org

Bug: 681136
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib2e84f9aef18ed801d27f74520edeb7e41eda54b
Reviewed-on: https://chromium-review.googlesource.com/c/1288494Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600985}

This CL updates the accessory bar to the newest icons and design.
Currently behind the AutofillManualFallback feature flag.

[Current: https://drive.google.com/file/d/1x60dQkNt0B88Srlo0v-vNyNXHDs_nu_F/view?usp=sharing]
[New: https://drive.google.com/file/d/1Sf_WMeI83g-viW6x065hZXO3PUXcgBj0/view?usp=sharing]

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I4a97a254a1e8c9918c1db23ddfcfb93faf734aec
Reviewed-on: https://chromium-review.googlesource.com/c/1289679
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600984}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=oysteine@chromium.org

Bug: 681136
Change-Id: Ide55f05c47a2572da354617a83c9b6727633f61f
Reviewed-on: https://chromium-review.googlesource.com/c/1288495Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600983}

Bug: chromedriver:1404
Change-Id: Ic4c23921a253584f9b3b29deb7a02398f43f574e
Reviewed-on: https://chromium-review.googlesource.com/c/1289690Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600982}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=zmo@chromium.org

Bug: 681136
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I05d68bcadcd0b152962ae6828fc8af66687e46d3
Reviewed-on: https://chromium-review.googlesource.com/c/1288510Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600981}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fff636607ed5..3102c9b3cef9


Created with:
  gclient setdep -r src-internal@3102c9b3cef9

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I2f9c2ddef9adf37cf4bd3cad425a26becb3a08ba
Reviewed-on: https://chromium-review.googlesource.com/c/1289657Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600980}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=jyasskin@chromium.org

Bug: 681136
Change-Id: I59478d51c2b81e5d856319871ebc76b9d2401697
Reviewed-on: https://chromium-review.googlesource.com/c/1288514Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600979}

This is in preparation of referencing this type from the code
generated by third_party/inspector_protocol/code_generator.py.

My overall WIP change is in here, and happy to explain more:
https://chromium-review.googlesource.com/c/chromium/src/+/1244719

Bug: chromium:891377
Change-Id: I66f75e2b53f30944fecbfdc22c396799c15593b8
Reviewed-on: https://chromium-review.googlesource.com/c/1280555Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600978}

Bug: 883496
Change-Id: If98ab4445ef5ee1a02d7c6bb1e5f4e3e770cfeba
Reviewed-on: https://chromium-review.googlesource.com/c/1287205Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600977}

This fixes a bug that was causing the system to add insets to the table
view when jumping between fields. This inset was the same as the one
other scroll views get when the keyboard appears. Setting
|contentInsetAdjustmentBehavior| to never is not enough, and the
inset gets added anyway.

Bug: 878388
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I305395fc691301a467523755d006277687a35c1d
Reviewed-on: https://chromium-review.googlesource.com/c/1273041Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600976}

This reverts commit adb22130.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 600928 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWRiMjIxMzBjMTI5MTI1NDYxODU3ZWFmZTY2MzQyMjA5OTM5YjcxYgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/linux-xenial-rel/4268

Sample Failed Step: network_service_browser_tests on Ubuntu-16.04

Sample Flaky Test: DataUseMeasurementBrowserTestWithDataSaverEnabled.CheckServicesDataUseRecorded

Original change's description:
> NetworkService: Report data use of URLLoader to browser process
> 
> When the requests complete, the total received and sent bytes are sent
> to browser process. ChromeDataUseMeasurement records metrics on Chrome-services
> data usage and updates metrics service.
> 
> Subsequent CLs will record more metrics and also report this to data
> reduction proxy settings page.
> 
> When NetworkService is disabled, DataUseMeasurement will get network
> delegate callbacks and record metrics.
> 
> Bug: 808498
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I113e480e4e1c67a65ff7461eb5ae2166a6b038d2
> Reviewed-on: https://chromium-review.googlesource.com/c/1274202
> Commit-Queue: rajendrant <rajendrant@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600928}

Change-Id: I6fdfa077e01fb3ae0693be88eb58361a6bb17a13
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808498, 896942
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1290137
Cr-Commit-Position: refs/heads/master@{#600975}

We've seen this test pass intermittently on Linux and now MacOS so
I am adding an expectation for it until the test owner can investigate
and fix.

TBR=npm@chromium.org

Bug: 896765
Change-Id: Icc45010eb16f298a5587404b9530853fca55349a
Reviewed-on: https://chromium-review.googlesource.com/c/1289961Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600974}

BUG=814528

Change-Id: Iacdefc02c01d04079d7c1d62368bd7aaabaf2e8c
Reviewed-on: https://chromium-review.googlesource.com/c/1289707Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600973}

Opt-in dialog should be hide/show correctly when switching users.

Bug: 812010
Test: Manual Test
Change-Id: I2a880974e22d1179c564891fc3f46f562de865f2
Reviewed-on: https://chromium-review.googlesource.com/c/1289685Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600972}

R=kariah@chromium.org

Change-Id: I9b0adc0413e502b9e324ef929b11757c21b68d03
Reviewed-on: https://chromium-review.googlesource.com/c/1289753Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600971}

This is a pure interface so it can inline the dtor and doesn't need to
hide the ctor.

Bug: none
Test: compile
Change-Id: Idbf3cd3ca8397b3c0883f5e7759151ff9d29ab55
Reviewed-on: https://chromium-review.googlesource.com/c/1283476
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600970}

When marking the first line box dirty, this patch checks
if the line box exists.

Normally NGBlockLayoutAlgorithm suppresses box fragment
if no line boxes exist. However, NGColumnLayoutAlgorithm
may generate box fragments for column boxes.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ie5697a524cd6fc1067fc4c03466e88fa8d5da68b
Reviewed-on: https://chromium-review.googlesource.com/c/1288769Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600969}

Input device node names always start with exactly "event".

Bug: none
Test: compile

Change-Id: I7e332f16901fa979eff7b1553ae6439a0806b9fd

Reviewed-on: https://chromium-review.googlesource.com/c/1287103
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600968}

In local testing, there are two separate reasons for flakes:
(i) Histogram tester does not return correct values even though
the relevant code has already logged the histogram values
correctly.
(ii) The via header value is set too late by the unittest.

The first problem is sort of solved by waiting for the histogram
to populate. The second problem is solved by setting the via header
value in the test constructor.

Bug: 760294
Change-Id: I9ae23e4b704f6eaa51fd9c37f76491008c6cb1c6
Reviewed-on: https://chromium-review.googlesource.com/c/1289689Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600967}

Users of Chromevox may need to touch explore the webpage, and for
things to remain consistent, we should disable hiding top-chrome
with gesture scrolls as long as Chromevox is enabled.

R=sky@chromium.org
BUG=857331, 896514
TEST=Added a new browser test.

Reviewed-on: https://chromium-review.googlesource.com/c/1284289Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600408}
Change-Id: I388bc5056f956bea2edffc7127dcab533824e56b
Reviewed-on: https://chromium-review.googlesource.com/c/1287510
Cr-Commit-Position: refs/heads/master@{#600966}

Adds a context menu item to take a "Sneak peek" at a link using the overlay panel.
This provides an ephemeral tab to view a linked page (once fully implemented.
Currently the menu item has no effect when selected.)

See go/ephemeral for a detailed design.

BUG=894619

Change-Id: I3856e1524d37f82d065d9f8322cebda972d269a0
Reviewed-on: https://chromium-review.googlesource.com/c/1286097
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600965}

This CL updates the UI to show a badge icon in the app menu icon
whenever the user is running Chrome on a currently unsupported Android
version.  This badge in the app menu is only displayed once, until the
user taps the app menu icon. If the user does in fact get a new version,
the badge state is reset, and will be shown again. The current behavior
for out of date users stays the same as before (once per cold start).

In addition, a new menu item is displayed at the top of the menu that
explains that Chrome is unable to update. Nothing happens when you tap
the menu item in the case of an unsupported OS version.

The new menu item and the new warning message in About Chrome will
always be displayed when the user is in this state, regardless of
whether the app menu has already been tapped (which removes the badge).

This CL also updates the UI in Settings - About Chrome to show a new
message and a warning icon when the user is running Chrome on an
unsupported version of the Android OS.

By default, Jelly Bean is considered unsupported after this CL, but this
can be overridden from the variations framework.

It is possible to use command line flags or chrome://flags for
testing the different states, though that does not impact the
About Chrome screen.

Binary-Size: This CL adds new assets and the minimal code required.
Bug: 847940
Change-Id: I0d8653c8ac93f80241c70283effe2105e20af190
Reviewed-on: https://chromium-review.googlesource.com/c/1289470Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600964}

We release the reference to _client when ClientConnectionViewController
opens up the HostViewController. When the connection is dropped, the
ClientConnectionViewController pops out without transferring the
ownership of _client to ClientConnectionVC, so user now cannot send
feedback by tapping "report this".

There is no retain cycle between RemotingClient and ClientConnectionVC
or HostVC so it is fine to make ClientConnectionVC keep the reference
to _client after the HostVC is showing. Verified that no RemotingClient
persists in any scenarios after the connection ends.

Bug: 888277
Change-Id: I25940441327f5bf1a77eeb072d6fc45fc991e02f
Reviewed-on: https://chromium-review.googlesource.com/c/1287438Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600963}

Some user feedbacks are overflown this message. This happens after
adding "arc.apps.default" prefs. "default" appeared in arc.apps listing.
Fix to check if this is valid crx id as it done in different places of
this file.

TEST=Manually
BUG=b/117566030

Change-Id: I79384e58ab31593f571b2ce4542dfbfbc3d2447f
Reviewed-on: https://chromium-review.googlesource.com/c/1289992Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600962}

TBR=smut

Change-Id: Ib94e90e40c763771517461fe61d38f2af74b27d2
Reviewed-on: https://chromium-review.googlesource.com/c/1289750Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600961}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: If391adaae4e4970a0d4edd6df913a470c094a43b
Reviewed-on: https://chromium-review.googlesource.com/c/1289658Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600960}

In the collapsed table borders model, all borders (from the table
itself, table sections, table columns, table rows and table cells) are
painted in the background-and-borders phase of the table. We need
special code to prevent the background of a self-painting-layer
table-cell from overlapping with the borders that have already been
painted. Similar code exists for legacy in TableCellPainter.

Bug: 869878
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I190dd6a152e751f6b30409104fb466ca46bb9024
Reviewed-on: https://chromium-review.googlesource.com/c/1289890
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600959}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f94579d3c84c..91031585f0fd


git log f94579d3c84c..91031585f0fd --date=short --no-merges --format='%ad %ae %s'
2018-10-18 yshaul@google.com chromeos_config: Remove _no_unittest_boards from chromeos_config
2018-10-18 dgarrett@google.com Reland "chromeos_config: Move all CQ slaves to swarming."


Created with:
  gclient setdep -r src/third_party/chromite@91031585f0fd

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic8968fe22aa0517ff345553664fbbca932b74534
Reviewed-on: https://chromium-review.googlesource.com/c/1289653Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600958}

Test : Cast CQ / Manual
Bug: internal b/117938330

Change-Id: I96e4ec912548e08f2030213b12d6064b66f98d68
Reviewed-on: https://chromium-review.googlesource.com/c/1288857Reviewed-by: Sergey Volk <servolk@chromium.org>
Commit-Queue: Sunil Kumar <skx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600957}

This CL fixes a java.lang.StringIndexOutOfBoundsException in
HostBrowserLauncherParams#createWebShareTargetUriString() when the WebAPK receives the following
share intent:

Intent intent = new Intent(Intent.ACTION_SEND);
intent.setTyle("text/plain");

BUG=None
TEST=HostBrowserLauncherParamsTest.*

Change-Id: If14cafcb43ed3f7668a7165e071674027713316d
Reviewed-on: https://chromium-review.googlesource.com/c/1285069
Commit-Queue: Ethan Xu <xuethan@google.com>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600956}

The previous one was reverted due to failures on ASAN/LSAN bot
(see crrev.com/600462). Those failures are fixed by crrev.com/600889
so this simply relands the same config.

BUG=883523
TEST=none
TBR=sky@chromium.org

Change-Id: I0d4ee97bf3a446bcae359e7c5bf9125e48a4405a
Reviewed-on: https://chromium-review.googlesource.com/c/1289680
Commit-Queue: Jun Mukai <mukai@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600955}

CreatePositionWithAffinityForBoxAfterAdjustingOffsetForBiDi() expects
an |offset| in range from 0 to box length. However, a call site in
LayoutText::PositionForPoint() incorrectly adds |box->Start()| to it,
causing out of range offsets.

This patch fixes it. Haven't found any incorrect behavior in wild due
to this bug, but it's an obvious bug so let's still fix it...

Change-Id: Id7deb528b18aa4c36d0a18bb564ede3dcc138110
Reviewed-on: https://chromium-review.googlesource.com/c/1289684
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600954}

The current implementation uses a combination of SHBrowseForFolder,
GetOpenFileName and GetSaveFileName, which are deprecated.

The IFileDialog, on the other hand, is the currently supported API
to display a file dialog on Windows.

Bug: 73098,884075
Change-Id: Ifbab2dae5046bf9e38b866d9ae99dbccc1fa9bbe
Reviewed-on: https://chromium-review.googlesource.com/c/1252914Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600953}

Bug: none
Test: none

Change-Id: I8ec80e17c394d68bfb4bdbd4813f58054dee5615

Reviewed-on: https://chromium-review.googlesource.com/c/1284853
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600952}

There is a race condition between when Polymer calls observers and when it
updates a two-way bound variable in the parent element.

Bypass the isuse by using the observers parameter instead.

Bug: 896509
Change-Id: I63b13c858b62214d7973af641f67c659de9ea674
Reviewed-on: https://chromium-review.googlesource.com/c/1289410Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600951}

Before this patch, Android Oreo and newer blacked-out the status bar, so
the time and battery icon, for example, were not visible during
payment.

This patch sets the payment dialogs status bar icon color to be either
white or black, depending on the status bar background color. These
changes apply to Android Oreo and newer only.

After this patch, the status bar icons are always visible during
payment.

Bug: 890183
Change-Id: Ia478ec9461b05bd4cb2993fd11b301a9ec0f4704
Reviewed-on: https://chromium-review.googlesource.com/c/1286744
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600950}

There are several bugs tracking falky tests on this buildbot and this
suite is yet another which has mutliple tests timing out w/ no
discernable cause.  Marking experimental so sheriffs do not need to
retriage/snooze this issue each time the flake occurs.

Bug: 876615, 840369

Change-Id: I9c8bd562a32ef352322f27a93a58c45dd091d91e
Reviewed-on: https://chromium-review.googlesource.com/c/1289574Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600949}

This reverts commit 297fdf47.

Reason for revert: Causes failures single process mash interactive ui tests.

Original change's description:
> adds ability to track when keyevent processed asynchronously
> 
> This adds the ability to register a callback on a KeyEvent that is called
> when async processing completes. This is important for content as key events
> may be handed to the renderer, which means the event is asynchronously
> processed.
> 
> BUG=891489
> TEST=none
> 
> Change-Id: Ifaad1b88b0256ea2c69128663c24b1803e7f7321
> Reviewed-on: https://chromium-review.googlesource.com/c/1262405
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600910}

TBR=sadrul@chromium.org,sky@chromium.org

Change-Id: I0dd537e67aff1ffbc59a89afc0707db0db4ccc3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891489
Reviewed-on: https://chromium-review.googlesource.com/c/1289993Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600948}