- 10 Oct, 2019 40 commits
-
-
Mikel Astiz authored
The abstraction allows injecting platform-specific logic about retrieving locally known encryption keys, as well as the optional ability to store them (independently of sign-out state or sync engine initialization state). The API is designed to be asynchronous in order to support IO or IPCs. SyncServiceCrypto is extended with an intermediate state where keys are being fetched, before actually prompting the user for action. Bug: 1012659, 1012660 Change-Id: Ia8daa317a4fbc1cbb50be7e2c0db40a1705f8b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849381 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#704644}
-
Tommy Li authored
CL is just adding some documentation to mahmadi's fix. Also swaps the conditional a bit to match the comment. Bug: 996516 Change-Id: Id69caa88bf8a243d0ffdc552c19d87080677df1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849042Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#704643}
-
Julie Jeongeun Kim authored
This CL converts URLLoaderFactoryRequest from CreateURLLoaderFactory() in network_context.mojom and ResolveAsURLLoaderFactory() in blob_url_store.mojom using PendingReceiver and ReceiverSet. Bug: 955171 Change-Id: I29c57d82d56464058d5eccca76a5a387c4714b68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844755 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704642}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5fdd5453..c2dc845a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30b76ce8d3c21a54f3474370c1e8bc699f1855b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852904Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704641}
-
Aaron Krajeski authored
For low latency canvases the order of events is important. The resource must get single buffered before it is drawn. Because drawing is something that the rendering context owns, it makes sense to split up the parts of finalizing the frame on the host. Bug: 1002523 Change-Id: Ie57965c4394d25f4197b4683bc238670edf1693d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848934Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#704640}
-
chrome://sync-internalsPeter Wen authored
Moves resources used in chrome://sync-internals out of components_resources.grd into its own GRD file. Also move these resources into the Dev UI Dynamic Feature Module (DFM) to save binary size on Chrome for Android. Update iOS dependency to include the new resource target. Bug: 927131 Change-Id: Ibad6e27d004cc22138b68b615b517a171969c5ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849418 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704639}
-
Marc Treib authored
This is a partial reland of crrev.com/c/1821520 and crrev.com/c/1824261 (or a partial revert of crrev.com/c/1847290). It removed the ModelType enum entries (again), but leaves the actual proto files intact (other than marking related fields as deprecated), since they're still needed by the server for now. Bug: 1012648 Change-Id: Icd963d6e244d424643377f8defb3aedcce81f763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852446 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#704638}
-
Antonio Gomes authored
This is phase 6.4 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ The CL temporarily places webrtc_media_stream_track_adapter_map.h (TODO added), so other files can be migrated next. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I098ed527b3cbbf844eacf39cb300316b21882048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816780 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704637}
-
Gyuyoung Kim authored
This is a reland of 1886f107 Original change's description: > Replace .mojom-blink.h with .mojom-blink-forward.h in blink - 7 > > To reduce pre-processed size of header files have been including > foo.mojom-blink.h, this CL replaces .mojom-blink.h with > .mojom-blink-forward.h in blink header files. > > This CL has no behavior changes and following CLs will > continue replacing them more. > > Bug: 1001360 > Change-Id: Ic627fb1cb10815ee58ba107a9fa4fc98f5884aa6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844527 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#703686} Bug: 1001360 Change-Id: I100b512d4ae188fe687396a7ae0562619bbea0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847694Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704636}
-
Fredrik Söderquist authored
Was missing a few braces. Change-Id: If954d25e1d7bed42fa95b9b36489957dfcd5ab2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852213Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#704635}
-
Miguel Casas authored
Some EDID blobs have HDR information in the extended CEA/CTA tags and we want to parse those to support these monitors/screens/panels. This CL extends the EdidParser code to read the Colorimetry Data block and the HDR Static Metadata, also extending the unit tests. ( Sadly clang-format also unrolls the test cases vector ). Test:./display_unittests --gtest_filter=*Edid* Bug: 1012846 Change-Id: I9937b0933d080f36633a8d2d425d3f4eed8fea0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851284 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#704634}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a441815f4dc3..8e881f105660 git log a441815f4dc3..8e881f105660 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 jrosenth@chromium.org lib/git: open files for SAX parser before calling parse 2019-10-10 jrosenth@chromium.org lib/git: remove __init__ from RemoteRef 2019-10-10 jrosenth@chromium.org Remove contextlib.nested 2019-10-10 jrosenth@chromium.org Remove usage of iter(...).next Created with: gclient setdep -r src/third_party/chromite@8e881f105660 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Iad7272edc475637babcb62fb4bb3f6227897a934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704633}
-
Emircan Uysaler authored
This CL reduces Skia resource usage to address memory issues explained on fxb/36620. Test: Tested cast_runner on device. Bug: 982922, fuchsia:36620 Change-Id: I7af5c5a252c10110abe7b783527b48e933a86807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851127 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704632}
-
Peter K. Lee authored
Default enable the feature "LanguageSettings" for M79. Bug: 1008433 Change-Id: I179da2485bb4b50481c2fea46c2e8216f6e29e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825922Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#704631}
-
Dmitry Gozman authored
Previously, we stored it in InternalDocumentStateData and applied in RenderFrameImpl. This change moves the override to DocumentLoader, to consolidate navigation related parameters in Blink. This corresponds to the step 15.d from the doc linked to the bug. Bug: 855189 Change-Id: Icfabe5cecec3deaab385d3617bc1d9f77c8c13b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846795Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704630}
-
Mehran Mahmoudi authored
This adds support for adaptive icons for legacy web apps that are installed via app_banner_manager.cc. Bug: 977173 Change-Id: I783284b61e29bd9ae1ea24248cb35ed901eafc61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850538Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704629}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0fc9b3829b47..69537d798994 git log 0fc9b3829b47..69537d798994 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 kjlubick@google.com [skottie-perf] Remove beetle from list of tests Created with: gclient setdep -r src/third_party/skia@69537d798994 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I39563e294d0ba6c558985c3b222d4d4b8451d8c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852846Reviewed-by:
-
Andrew Grieve authored
Goal is to have devs be aware that relocations are a thing. Change-Id: Ifd0edf08ff58dd5b7e8879c4f6f32f9b61b55096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846798 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#704627}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=boliu@chromium.org Bug: 1007760 Change-Id: I235ac01f30acce3df1ce9f8a59d6d0a9da73449e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849476Reviewed-by:
-
Dmitry Gozman authored
Load times extension bindings are using some rare response data like "was alpn negotiated". Currently, these fields are stored in DocumentState, but they should be available on WebURLResponse instead. Moving these fields to WebURLResponse almost gets rid of DocumentState, which opens up more opportunities for cleanup around navigation flow. This corresponds to the step 15.e from the doc linked to the bug. TBR=csharrison@chromium.org Bug: 855189 Change-Id: I9c83b88d5d941798be4a851166b8e9894cc82974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844052 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Mike Jackson authored
This change updates the version of axe-core to the latest released version. As part of picking up the latest version, the following additional changes were made: 1) axe-core removed the 'href-no-hash' rule, so that been removed from the test list. 2) Several 'link-in-text-block' tests started failing with axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but are disabled as part of this change. - CrManagementA11yTest.SimpleTest_link_in_text_block - CrManagementA11yTestWithExtension. ExtensionSection_link_in_text_block - CrostiniAccessibilityTest.CROSTINI_link_in_text_block - CrExtensionsA11yTest.NoExtensions_link_in_text_block - MultideviceA11yTest.MULTIDEVICE_link_in_text_block - MultideviceFeaturesA11yTest. MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block 3) One 'heading-order' test started failing in v3.0.0 (and later). This tests does pass in V2.4.2, but is disabled as part of this change. - CrExtensionsA11yTestWithMultipleExensions. WithExtensions_heading_order 4) One color-contrast test started failing. This test has been disabled since there other tests also disabled for this rule - WelcomeA11y.WelcomeFlow_color_contrast 5) Several DevTools a11y tests were failing. This change either updates the baseline or excludes the rule depending upon the test/rule itself. - http/tests/devtools/a11y-axe-core/basic-a11y-test.js - http/tests/devtools/a11y-axe-core/console-a11y-test.js - http/tests/devtools/a11y-axe-core/memory/heap-profiler-a11y-test.js - http/tests/devtools/a11y-axe-core/performance/performance-pane-a11y-test.js - http/tests/devtools/a11y-axe-core/sources/dom-breakpoints-pane-a11y-test.js I spent some time investigating the test failures, and it looks like axe-core is highlighting legitimate product issues. Bug: 984817 Change-Id: I245af601c4f086d96768fa5677e253095fc53087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841834 Commit-Queue: Mike Jackson <mjackson@microsoft.com> Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#704624}
-
Antonio Gomes authored
This CL corresponds to phase 6.3 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ It moves the respective header webrtc_media_stream_track_adapter.h to Blink's public API layer (TODO added). Last, base::Bind instances will be replaced by their corresponding WTF implementations in a follow up. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ifb34c9e62556d46dd917b78c433e7a1f706bad1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816778 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
David Roger authored
TBR=fdoray Bug: 1012601 Change-Id: I9540e12715b4b431af0b886c280f609b51851b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852429Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704622}
-
Olya Kalitova authored
Adds Ansible playbook application step to default Crostini container startup if Ansible is successfully installed to default Crostini container. Test: unit_tests --gtest_filter="Crostini*" Bug: 998124 Change-Id: Id892b5316e2971e4a81ab6d155654c30202d4a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847343Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#704621}
-
Kush Sinha authored
MutableProfileOAuth2TokenServiceDelegate takes a boolean constructor parameter to assess whether token revocation is supported. This was required only on Chrome OS, for supervised users. With the introduction of Chrome OS Account Manager, this code path is no longer used. i.e. revoking all tokens from "Chrome" is no longer supported. This was partially cleaned up in https://crrev.com/c/1833609, which set the aforementioned parameter to |true| by default. Clean it up completely by removing the parameter altogether since it is always set to |true| anyways. Bug: 1010532 Change-Id: Idf585b5e6c2096febce83e641443fce394968319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852427Reviewed-by:
-
Kush Sinha authored
Refactor Chrome OS Mirror header processing to make the cases more obvious. Bug: 1010532 Change-Id: Ieb2ed44152c34d2519e08e4b6684598fd9339aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852210 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#704619}
-
David Roger authored
TBR=fhorschig Bug: 1012221 Change-Id: I3b3f8f7fd9eb4c4a30db55410b9cda4a932c4590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851710Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704618}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/1e9229f0fcb4..545a481a74a3 git log 1e9229f0fcb4..545a481a74a3 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 wl@gnu.org * src/sfnt/sfwoff2.c (reconstruct_glyf): Check `triplet_size'. Created with: gclient setdep -r src/third_party/freetype/src@545a481a74a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I0f36a66a8fa7a1cb871ad188e0cb00dd0c0aed44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852186Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#704617}
-
Bill Budge authored
This is a reland of d99ef40d Patchset #8 modifies the original to handle Write and Fetch completions in any order, which should fix the UAF crashes. diff: https://chromium-review.googlesource.com/c/chromium/src/+/1846336/1..8 Original change's description: > [code caching] Handle small data with a single read/write > > - Many small reads and writes are observed, especially with the JavaScript > code cache. Detect these and write all data into the entry's stream 0, > and clear stream 1. When reading, detect the entry size and for small > data, skip the stream 1 read and copy the data from the stream 0 read. > - Changes the stream 0 data (again) to a header with response time and > data size. The data size, while not strictly necessary right now, will > be needed if we implement de-duplication of identical entries stored by > multiple origins. We can add the code hash to this header, and the size > field will disambiguate between small entries and large de-duplicated > entries where we use the hash as a key to the data. > - This change should make small reads faster than before, as synchronous > completion of stream 0 reads is observed. Otherwise, there should be no > change in performance. > - Renames the buffers and completion callbacks to reflect small/large data > distinction. > > Bug: chromium:992991 > Change-Id: I6fb5337ef1e4148dd9f300f0a8c85acb401be62e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834562 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mythri Alle <mythria@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702667} Bug: chromium:992991,chromium:1011879 Change-Id: I9d589c45f567d93841536bb327381223be489928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846336Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#704616}
-
Dominik Röttsches authored
This reverts commit dcdf3924. Reason for revert: Flaky on linux-chromeos-rel, see https://crbug.com/1013148 Original change's description: > arc: Provide replacement for deprecated PlayStoreShown UMA > > This rolls new set of UMA that replaces derpecated PlayStoreShown UMA > DD: > https://docs.google.com/document/d/1vfJMzoYsXtH-HWYydbb5VJvpT6WeJrfvaO81RHI5v2M/edit > > BUG=b:142251935 > TEST=Locally + unit tests. > > Change-Id: Ie2ec139b41e702dda604d92324b426782ed494ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845935 > Commit-Queue: Yury Khmel <khmel@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704384} TBR=xiyuan@chromium.org,yusukes@chromium.org,isherman@chromium.org,khmel@chromium.org Change-Id: Ie870309e4d2b879679e79d3b468736e51bab096f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:142251935, 1013148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852785Reviewed-by:
-
Elly Fong-Jones authored
This is now a property of an instance rather than a delegate method. This change introduces one minor behavior change: on Windows, HungRendererDialogView used to use a custom frame when Aero Glass was enabled; it will now use a custom frame when Aero Glass is enabled *or* the dialog is parented. I think the old behavior was a bug - it is not supported to use a custom frame with no parent window. Some reworking of the DialogTest suite was required, because this suite used to override ShouldUseCustomFrame to return true despite not having a parent widget for the test dialogs. This change introduces a parent widget so that these tests continue to get the custom frame they desire. Bug: 1011446 Change-Id: Ib3a8521368e1d7d779c2346fc74c97633fd13f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846317Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#704614}
-
Daniel Nicoara authored
Create a message that will be used by JS message channels to pass data back into the Webview client. Bug: b/141864193 Test: Compiled Change-Id: Iada17bc8f3cf1276f3a59813406f67bc43af8247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850363Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#704613}
-
Lowell Manners authored
This CL addresses a bunch of TODOs to properly set FrameHostMsg_DidCommitProvisionalLoad_Params on BackForwardCache navigations. With this CL, we store the DidCommitProvisionalLoad_Params used for the navigation on RenderFrameHostImpl, so that it can be reused when restoring from the BackForwardCache. This approach should be somewhat more future proof, particlarly when adding new fields to DidCommitProvisionalLoad_Params. In order to prevent any change in memory usage, the parameters are only stored on the RenderFrameHostImpl if BackForwardCache is enabled. Change-Id: Idb72e7366876e59d1dfd046fa83284f6f280422c Bug: 1005718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819251 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#704612}
-
Arthur Hemery authored
Filtering remaining failing tests after increased sharding. Bug: 1007276 Change-Id: I75b67a9a9e60b5aa1741b2a33cdd53c35936f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852249Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Canon Mukai authored
There were some differences between CompressionStream and DecompressionStream. So I aligned them. Also, I made CompressionStream accept BufferSource. Bug: 999091 Change-Id: Iaf6c3e54804a10ef22d05c5f4da0d5ae07d0e765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847605 Commit-Queue: Canon Mukai <canonmukai@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Daniel McArdle authored
Bug: 1012848 Change-Id: If0b9c22bcf3d8341d826dfbc718fe47ebb6328ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850432 Commit-Queue: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#704609}
-
Thomas Tangl authored
- The profile feature buttons are added - Browser tests for the guest profile are re-enabled after crrev.com/c/1848371 - Autofill buttons are not shown in incognito mode - The guest profile is moved to selectable profiles Bug: 995720 Change-Id: I8499848add6fcc06bb984ce79c4bc5f36ac4546a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850155Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c89b6cab. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Icac6ce43c8297b2649fc8f13232ecff7ae18e0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852666Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704607}
-
David Roger authored
Only one test is flaky: EndToEndTestServerPush.ServerPushOverLimitNonBlocking However, it's not possible to disable only this test, because it's in a third party repository. This CL excludes the whole file from the build instead. TBR=rch Bug: 1010206 Change-Id: Id897407c56f59e632159c73a8d82f669e7c748ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852207Reviewed-by:
-
Maksim Sisov authored
No functionality changes here, but just moving the code and implementing missing interfaces in PlatformWindow. Bug: 990756 Change-Id: Ia39b15c580ea831a5e31bb6d76a807b3321c4f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844820 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#704605}
-
