- 27 Jun, 2018 40 commits
-
-
Tetsui Ohkubo authored
Previously, volume slider was missing when UnifiedSystemTray was collapsed and volume key was pressed. This CL ensures UnifiedSystemTray to be expanded when volume key is pressed. TEST=manual BUG=855508 Change-Id: Ia1408082a74a9b11a6a7802849c9dc391cf601a8 Reviewed-on: https://chromium-review.googlesource.com/1114520Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#570652}
-
Darren Shen authored
Forgot to install event handler to handle dragging, which meant dragging stopped working (on mouse). Dragging still worked on touch because IME still has code that handles touch dragging ¯\_(ツ)_/¯ Bug: 849980 Change-Id: Ic19aa886e23bd5f944b41ba066b94e26eed9c99a Reviewed-on: https://chromium-review.googlesource.com/1114562Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#570651}
-
Andrew Grieve authored
* Renames compute_grit_inputs_for_analyze -> compute_inputs_for_analyze * Computes .py inputs via exec_script (when compute_inputs_for_analyze=true) * Enforce that sub-included .jinja files are listed in targets. Bug: 843562 Change-Id: I3698c7846375530a86474bd5960bb002ac45f71a Reviewed-on: https://chromium-review.googlesource.com/1112867Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#570650}
-
Ryan Hamilton authored
Merge internal change: 202011580 Change-Id: I997c8dc7dbbf87fa32d2dcaf125ea2231cac4e23 Reviewed-on: https://chromium-review.googlesource.com/1114143 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570649}
-
Weidong Guo authored
1. Create a AppListConfig that includes all layout info for app list. Override certain info for homecher flag during initialization. 2. Change AppListItem's layout and put the changes behind homecher flag. specs: https://screenshot.googleplex.com/dcJy96seMQR Bug: 853973 Change-Id: I678fc7af9cf93c677721b171436afb841d833b20 Reviewed-on: https://chromium-review.googlesource.com/1105400Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#570648}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1b45f0dc972b..47bb72284a37 git log 1b45f0dc972b..47bb72284a37 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 dgarrett@google.com lint: change type() checks to use isinstance() instead 2018-06-26 dgarrett@google.com cbuildbot_launch: Add metrics for CleanupChroot stage. 2018-06-26 dgarrett@google.com cros_sdk_lib: Add timeout for CleanupChrootMount. Created with: gclient setdep -r src/third_party/chromite@47bb72284a37 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:855151,chromium:855151 TBR=chrome-os-gardeners@chromium.org Change-Id: I7a982eceeabd1233818cc7545bc7cdcf2c04cefd Reviewed-on: https://chromium-review.googlesource.com/1116082Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570647}
-
Hirokazu Honda authored
Since VDA unittest doesn't manage properly the number of play throughs, VDA (i.e. decoder) is not deleted at the specified timing in TearDownTiming case. This corrects the management of play though times to make TearDownTiming case the intended behavior. TearDownTimingCase in CS_RESET is removed because the case is already covered by DecodeVarations/0 test case. BUG=chromium:833698, chromium:834170 TEST=VDA unittest on eve, hana, kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9ef0ab3d4a7b80f022b9c73befeb561655c6b2fc Reviewed-on: https://chromium-review.googlesource.com/1102224 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#570646}
-
dpapad authored
Specifically fixing: CrSettingsAppearanceFontsPageTest.All CrSettingsAppearancePageTest.All CrSettingsCategoryDefaultSettingTest.All CrSettingsCategorySettingExceptionsTest.All CrSettingsSiteDetailsPermissionTest.All CrSettingsSiteDetailsTest.All CrSettingsSiteListTest.SiteList Bug: 738611 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0e45615eee75d823c2aaf7c6fca65e90ee222b4a Reviewed-on: https://chromium-review.googlesource.com/1115499Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570645}
-
dpapad authored
Bug: 752636 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I60e551d903fa275b48eab0c2bf33c6a65dd080c3 Reviewed-on: https://chromium-review.googlesource.com/1114059Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570644}
-
Alexis Hetu authored
EGL was assumed to be EGLGLES2 on Ozone, but it can also be SwiftShader if SwiftShader is enabled. Bug: chromium:848035 Change-Id: Iaec05de39e2077b36d5b46928eac0134799989bb Reviewed-on: https://chromium-review.googlesource.com/1115566Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570643}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b201e3b0ba8..c421ca1d6e41 git log 5b201e3b0ba8..c421ca1d6e41 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 khushalsagar@chromium.org gpu: Expose GrContextPriv::abandoned in the public API. 2018-06-27 csmartdalton@google.com ccpr: Add a context option to disable ccpr 2018-06-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@c421ca1d6e41 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:854416 TBR=jcgregorio@chromium.org Change-Id: I51befa088472f9b71cf8068ff0a399dd108ec124 Reviewed-on: https://chromium-review.googlesource.com/1116080Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570642}
-
Keishi Hattori authored
Add missing const in HeapTest.NeedsAdjustPointer Bug: None Change-Id: Ic007ef5a4a993e8b3f090b05cf81a482a556a56b Reviewed-on: https://chromium-review.googlesource.com/1115039Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570641}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1d5659c89760..a991ac69eb05 git log 1d5659c89760..a991ac69eb05 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 scottmg@chromium.org gn: Look in src for gn binaries before trying old buildtools location Created with: gclient setdep -r src/third_party/depot_tools@a991ac69eb05 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:855791 TBR=agable@chromium.org Change-Id: Ib04195c40fab284b947011a2c173759ab11d11b6 Reviewed-on: https://chromium-review.googlesource.com/1116081Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570640}
-
Matt Falkenhagen authored
I don't recall ever using the site suffix breakdowns and they aren't worth the complexity: * Hardcoded sites didn't scale well. Nowadays we should use UKM if appropriate. * It's unclear why we used the site suffixes for this particular UMA and not the rest. * This pattern resulted in (# event types) * (# of sites) histograms. This doesn't change the semantic of the histogram, and just folds the breakdown into the parent histogram, so no renaming is done. Bug: 852668 Change-Id: I5a090967a0d351f1291c67b37a071f77b324ce54 Reviewed-on: https://chromium-review.googlesource.com/1113378Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#570639}
-
John Budorick authored
This only includes the upgrade to platforms;android-28. build-tools and platform-tools upgrades to follow. Requires http://crrev.com/c/1112707. There will be a matching internal CL. Bug: 850652 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I99c50246f326ffa0b1190d7473b5343613804573 Reviewed-on: https://chromium-review.googlesource.com/1112729 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#570638}
-
Chris Blume authored
Several Vulkan functions were handled specially because they were near other bindings that need special handling. This CL will move those functions into generate_bindings.py and document the functions which are handled specially. BUG=856360 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie9ce4f83a27b3b95589ad759cbb1d36c463126a9 Reviewed-on: https://chromium-review.googlesource.com/1115811 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#570637}
-
Maggie Chen authored
This new command line option is created to disable the non-sandboxed gpu process for collecting DX12/Vulkan information. Although this process only exists for a very short period of time, it can sometimes interfere with the layout test or the performance tests. With this option, those tests can run without any interfering. BUG=852796,856398 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I43582a15cd2451da9081111b79adec396c9acd4f Reviewed-on: https://chromium-review.googlesource.com/1112463 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
-
Han Leon authored
This CL moves the ServiceWorkerStatusCode enum definition files service_worker_status_code.{cc,h} from content/common/service_worker/ into Blink public folder. After that the ServiceWorkerStatusCode enum is still available to be used by both browser and renderer code. This CL also moves a TypeConverter for ServiceWorkerStatusCode into Blink. BUG=789854 Change-Id: Ie8032cb7474c7f90f17e58170a38b97263643fbd Reviewed-on: https://chromium-review.googlesource.com/1114474Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#570635}
-
Scott Haseley authored
Allow Active --> Frozen state transitions, but only from the renderer. This is the expected state transition for renderer-initiated freezing. Bug: 856266 Change-Id: I4aae9e3cba4c60d118e026fb185cf274a5645d58 Reviewed-on: https://chromium-review.googlesource.com/1113956Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#570634}
-
Kenneth Russell authored
This will help some partners set up their in-house testing. Tbr: dpranke@chromium.org Tbr: zmo@chromium.org Bug: None Change-Id: I90778b52ed03a3dcef85e13423d9bfe762e8adc2 Reviewed-on: https://chromium-review.googlesource.com/1116278Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570633}
-
Stephen Martinis authored
Adds a function to common.py which parses gtest results. Right now it only lists which tests fail, but it could be augmented in the future as needed. Bug: 855234 Change-Id: I327042f93683c429d46685225098e366e9de0cda Reviewed-on: https://chromium-review.googlesource.com/1112738Reviewed-by:
-
Andrew Grieve authored
Example output: For an explanation of these metrics, see: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/binary_size/metrics.md#Metrics-for-Android Specifics: +777,299 bytes normalized apk size -34 zip entries file count InstallSize: +3,324,232 bytes APK size +875,238.32 bytes Estimated installed size InstallBreakdown (+877,390.32 bytes): +14,290 bytes Native resources (no l10n) size -114,080 bytes ICU (i18n library) data size +1,984,772 bytes unwind_cfi (dev and canary only) size +13,250 bytes Non-compiled Android resources size +69,159 bytes V8 Snapshots size Dex: +996 entries fields +2,148 entries methods MonochromePublic.apk_Specifics normalized apk size=777299 Bug: 702625 Change-Id: Ib48b2e35633ba9b11facc74b47aa927758afeac5 Reviewed-on: https://chromium-review.googlesource.com/1115463 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by: -
Maggie Chen authored
A workaround was previously added to avoid a crash during the Vulkan gpu information collection. This workaround was first applied to the 64-bit AMD Vulkan driver with version 1.0.39.0, 1.0.51.0 and 1.0.54.0 only. But now more crashes have been reported with amdvlk32.dll or systems with Intel/nVidea GPUs. In this case, the AMD GPU could be seconday or doesn't exist at all. This CL adds the 32-bit dll amdvlk32.dll to the workaround. It also removes the detection for the AMD device ID. Just detecting amdvlk32.dll and amdvlk64.dll is enough. BUG=850881 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ief8fe9dbaec8a5fb1417bf6be87aca8845da5967 Reviewed-on: https://chromium-review.googlesource.com/1094262 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
-
Jun Choi authored
In order to implement virtual CTAP2 security key we need to parse and validate serialized GetAssertion request that the client sends to the device. Add corresponding parsing logic. Bug: 829413 Change-Id: Idd20a7b138ebaeda39b412824519750eccd7c673 Reviewed-on: https://chromium-review.googlesource.com/1110447 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#570629}
-
Victor Costan authored
Bug: 856362 Change-Id: Icaddfb82b2c41924cca7f058dea2e8da03183ae9 Reviewed-on: https://chromium-review.googlesource.com/1114379 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#570628}
-
Daniel Murphy authored
This is embarrassingly late - oops! Finally cleaning this up so I can remove the finch config. Bug: 855743 Change-Id: I1d4c2d28e3c63079176873d803548dffa966b03a Reviewed-on: https://chromium-review.googlesource.com/1112624Reviewed-by:
-
Kyle Horimoto authored
This CL relands this CL (uploaded as patchset 1): https://chromium-review.googlesource.com/c/chromium/src/+/1113020 Which was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1116158 The issue here is that I forgot to make a virtual function pure virtual. Original CL description: This class provides an interface for fetching the current host status and, when applicable, the current host device. Additionally, this class provides an observer interface for being notified when the status changes. TBR=dcheng@chromium.org Bug: 824568 Change-Id: Ice48e925295f50716aa696a80acdb8ad1f515bed Reviewed-on: https://chromium-review.googlesource.com/1116072 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#570626}
-
sczs authored
Bug: 851395 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2199f83c410d9e42fa9e8c990c9b527ff9608156 Reviewed-on: https://chromium-review.googlesource.com/1115507 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570625}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/41b7748..659d89e BUG= TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ia1d02a4e6cefd4f43cf11447982fc5d0e1fe1eab Reviewed-on: https://chromium-review.googlesource.com/1115558Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#570624}
-
David Michael Barr authored
Adding or removing a file from a jumbo source set causes on average half of the chunks to have their inputs reallocated. Derive chunk boundaries from a combination of list position and path content. This is so that when a file is added or removed, only the boundaries with adjacent chunks typically move. For a balance between maximum chunk size and stability of partitions: * Partition uniformly into the required number of chunks. * Pick a "center" from each chunk by minimum hash value. * Pick the boundaries between centers by maximum hash value. Bug: 782863 Change-Id: Ie71d82b132e8145b4ed3d1141f85886a12149d5a Reviewed-on: https://chromium-review.googlesource.com/1102218Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#570623}
-
Sergiy Byelozyorov authored
R=pcc@chromium.org Bug: 856128 Change-Id: I3e90a4f40e75439ad6cfa72d5b3dea1c0002d601 Reviewed-on: https://chromium-review.googlesource.com/1114848Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570622}
-
Adam Rice authored
Modify blink::ReadableStreamOperations::IsDisturbed() to take an ExceptionState& parameter. Modify all callers so that the ExceptionState is passed through all the way from the bindings layer. Where IsDisturbed() is called from code that runs asynchronously, the context_type, interface_name and property_name are cached and used to create a new ExceptionState object in the asynchronous context. Also change methods in the implementation of the payment API to use the cached context_type, interface_name and property_name instead of hard-coding the values. Add the extended attribute "RaisesException" to all the asynchronous body-reading methods in body.idl so that they receive an ExceptionState& parameter which is used to handle exceptions thrown when calling IsDisturbed() inside RejectInvalidConsumption(). RejectInvalidConsumption() now always rejects by throwing an exception and no longer returns a promise. An exception-ignoring IsBodyUsedForDCheck() method is added which doesn't change the exception state. Also add the [RaisesException] attribute to the bodyUsed accessor. Since it now throws if it has ever failed, fix the call-extra-crash-is-disturbed.html layout test to reflect that. Bug: 853189 Change-Id: Ib6df486a5f4ea7c58ecc123a716ee76ace0c92ed Reviewed-on: https://chromium-review.googlesource.com/1107578Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#570621}
-
Adam Rice authored
Test the various ways of setting or changing the port on a blink::KURL and verify that KURL::Port() returns the correct answers in each case. The results are different depending on how the port was set: the constructors are strict about disallowing invalid ports. SetPort() converts any input to a valid port. SetHostAndPort() is somewhere inbetween. Bug: 606462 Change-Id: I1533d47aa113d2bb4482cdfe17e682a5da56649a Reviewed-on: https://chromium-review.googlesource.com/1114572Reviewed-by:
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/bc383e76d631..4d67b3e851b1 $ git log bc383e76d..4d67b3e85 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 fbarchard Add H420 and H422 to ConvertToARGB() 2018-06-20 johannkoenig use unix line endings 2018-06-20 johannkoenig add const to msa loads Created with: roll-dep src/third_party/libyuv Bug: libyuv:799 Change-Id: I45facaa7902660ea064057c16030a836bbc11c9d Reviewed-on: https://chromium-review.googlesource.com/1115873 Commit-Queue: Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Frank Barchard <fbarchard@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#570619}
-
wutao authored
This cl updates shortcuts' colors to match Chrome's. Changes: 1. All Grey 800 #3C4043 should be changed to Grey 900 #202124. 2. All Grey 600 #80868B should be changed to Grey 700 #5F6368. These changes apply everywhere, including searchbox, side nav and keys. Bug: 835374 Test: manual. Change-Id: I772a54012c031540e8a3476d97bff15805b322e6 Reviewed-on: https://chromium-review.googlesource.com/1115801 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#570618}
-
Oystein Eftevaag authored
NOTRY=true TBR=nednguyen@chromium.org BUG=856864 Change-Id: I6cf5b595c15295076feb88a11e8e7009e108e674 Reviewed-on: https://chromium-review.googlesource.com/1116248Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#570617}
-
Wenzhao Zang authored
Spec: https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8 Bug: 847574, 835195 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I801925ded3b74520e1f92d1ce269fdbb8bc8bf09 Reviewed-on: https://chromium-review.googlesource.com/1115903Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570616}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a481ed6f083d..1b45f0dc972b git log a481ed6f083d..1b45f0dc972b --date=short --no-merges --format='%ad %ae %s' 2018-06-26 yunlian@google.com remove USE=thinlto from elm and peach_pit release Created with: gclient setdep -r src/third_party/chromite@1b45f0dc972b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854801 TBR=chrome-os-gardeners@chromium.org Change-Id: Iaf752b79eead83599902e5bdb3bf9a2b81620527 Reviewed-on: https://chromium-review.googlesource.com/1115978Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7ccf2f0c21b3..1d5659c89760 git log 7ccf2f0c21b3..1d5659c89760 --date=short --no-merges --format='%ad %ae %s' 2018-06-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1d5659c89760 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie209632d1682b953ff34278ea245873ad082028f Reviewed-on: https://chromium-review.googlesource.com/1115938Reviewed-by:
-
Alexei Filippov authored
Change-Id: I49957e9b7c6b9bda6588823a7b864754a4de0f10 Reviewed-on: https://chromium-review.googlesource.com/1115970Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#570613}
-
