GitLab

kRunPostLayoutTasksAsyhnchronously -> kRunPostLayoutTasksAsynchronously

Change-Id: Ice2387d068a38bfcbe6a6fc14b1a35db576fa289
Reviewed-on: https://chromium-review.googlesource.com/c/1460916
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#630299}

This CL prepares the reached code profiler for the finch experiment. It adds:
- base::Feature "ReachedCodeProfiler", which state is cached in
- Android shared preference "reached_code_profiler_enabled", that determines
whether to set
- command line switch "enable-reached-code-profiler", that eventually enables
the profiler

We cannot simply use a base::Feature for the reached code profiler because
we have to know the feature state very early in the startup, before the
FeatureList is initialized.

To work around this limitation we cache the feature state in Android shared
preferences that are available in Java before native is initialized.

Since only the browser process has a right to read the shared preferences we
pass the value of the cached feature state as a command line flag to all
processes.

Bug: 916263
Change-Id: I730b98c5484ca595bdfda46592572f5853784aa8
Reviewed-on: https://chromium-review.googlesource.com/c/1393328Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630298}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/054df48c..b8e007d8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I0d22585fca837ecf962d03351d5407149cdbdac1
Reviewed-on: https://chromium-review.googlesource.com/c/1460856Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630297}

lld currently ignores -rpath-link. Given that, it's likely this
isn't needed for any linker.

Please shout (on the review) if you do need this.

Change-Id: I928692772c649f172a88adbe5b4483721d2beb7c
Reviewed-on: https://chromium-review.googlesource.com/c/1459634Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630296}

This is temporary to get the keyboard drawing again. I will swing back to this
and refactor MusLsiAllocator to better accomodate embed roots.

BUG=none
TEST=none

Change-Id: I22e48825daca32d69ef7591a5e8f2c81be35ebdd
Reviewed-on: https://chromium-review.googlesource.com/c/1460440
Auto-Submit: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630295}

|AccountReconcilor::EnableReconcile| DCHECKs for
|delegate_->IsReconcileEnabled()|. However for an entity external to
|AccountReconcilor| and / or its delegate, it is impossible to know if
the delegate has reconciliation enabled. This was fine earlier because
|AccountReconcilor::EnableReconcile| was only called by the delegate but
after the introduction of |AccountManagerMigrator| on Chrome OS, the
delegate is not the only caller of |AccountReconcilor::EnableReconcile|.

Fix this by removing the DCHECK. This is fine because
|AccountReconcilor::StartReconcile| already checks for
|delegate_->IsReconcileEnabled| before actually starting any mutations.

Check the attached bug for context.

Bug: 929739
Change-Id: Iac4eddf3485221d4f3a0a5ebee08e287ecd0d7c4
Reviewed-on: https://chromium-review.googlesource.com/c/1459621Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630294}

This CL moves OAuth2TokenServiceDelegateAndroid that is
ProfileOAuth2TokenService's Android delegate from the signin
component's 'browser' GN target to its 'internals' GN target.

Bug: 927231
Change-Id: Ifbddc513c0ceb42b6ca3af0f60e1ca94015da8ce
Reviewed-on: https://chromium-review.googlesource.com/c/1457799Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Miyoung Shin <myid.shin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630293}

CL implements IdentityManager::StartObservingCookieChanges as a wrapper to
GaiaCookieManagerService::InitCookieListener API.

As for the unittest, the following was done:

- Removed the call to GCMS::InitCookieListener() from IdentityManagerTest
ctor. Reason: up to this point, all existing tests pass without this method
being invoked, given that no calls to GCMS::OnCookieChange() were actually
coming from network::CookieManager through mojo (GCMS inherits from
network::mojom::CookieChangeListener). Instead SimulateCookieDeletedByUser()
was being used to call GCMS::OnCookieChange().

- Actually calls GCMS::InitCookieListener() from the newly added
IdentityManagerTest.StartObservingCookieChanges test, though the newly added
IdentityManager::StartObservingCookieChanges API.
From this test, dispatch a cookie change through the mojo pipe with a
known cause, so that the test blocks on the expected IdentityManager
observer call (OnAccountsCookieDeletedByUserAction).

BUG=926864

Change-Id: I88d4499831e80252716a605e2fa346b73d5289d6
Reviewed-on: https://chromium-review.googlesource.com/c/1460016
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630292}

This is necessary to green-up the 'Build From Tarball' bot.  The bot is running
Trusty, which has a system libstdc++ that's too old to support many of the
features in base that gn relies on.

Here's the story of why this is now necessary:

1. Chromium's gn was originally built with libc++ to get around this exact
   issue.
2. gn was moved into a standalone repo.
3. The libc++ sources weren't copied into standalone gn, so their solution to
   fix this issue was to pull Chromium's debian sysroot that has newer libstdc++
   headers.
4. For whatever reason, the option to build with the sysroot was removed from
   the public repository and now the bots have a step to pull the sysroot.

This can be removed once Ubuntu Trusty reaches EOL, or when Chromium's
infrastructure is upgraded from Trusty to Xenial, whichever comes second
ideally.

BUG=807400
R=thakis

Change-Id: I00901b3df4005f6ac098774822fffe12dd67e561
Reviewed-on: https://chromium-review.googlesource.com/c/1460187
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630291}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c539fa95b0a..7b4aa52e2435


Created with:
  gclient setdep -r src-internal@7b4aa52e2435

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ic60c473776f638e7d31829ce6cb8068bf9449775
Reviewed-on: https://chromium-review.googlesource.com/c/1460146Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630290}

This change removes LoginPair from passwords_private.idl as only the
PasswordUiEntry dictionary made use of it. Instead, the previous
contents of LoginPair are inlined in PasswordUiEntry, removing an
unnecessary layer of indirection.

Bug: 377410
Change-Id: I85cc4467dc7aa00176416eec15257ca19992fe32
Reviewed-on: https://chromium-review.googlesource.com/c/1458443Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630289}

Disable heap compaction for incremental marking because crash in blink::HeapCompact::MovableObjectFixups::Relocate is not fixed.

Bug: 918064
Change-Id: I459ec394539e139c8586fdb131f613b9488dad37
Reviewed-on: https://chromium-review.googlesource.com/c/1460740Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630288}

The code was triggering a navigation from within a currentRouteChanged
observer, which triggers another round of observer notifications, which
resulted in observers getting in a weird state.

Unfortunately triggering a navigation from within such an observer is not
well suported from the routing mechanism (no such use case previously AFAIK).

Fixed by yielding first, such that all observers finish, before triggering
a new navigation.

Bug: 929026
Change-Id: Iee89af435bb2c8a7c738622abdc45d568173d07b
Reviewed-on: https://chromium-review.googlesource.com/c/1460398
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630287}

The base URL is really only needed for variables registered as <url>,
so it's wasteful to store an entire KURL for every variable. Storing a
String instead saves some memory.

This saves around 110kB on the YouTube front page (desktop).

Note: The ResolveRelativeUrls has been moved. The 'base_url' parameter
was changed from a KURL to a String, but is otherwise identical.

TEST=external/wpt/css/css-properties-values-api/url-resolution.html
R=futhark@chromium.org

Change-Id: I5438aefa15a77550f6ba2b261555c1d61b90ee1b
Reviewed-on: https://chromium-review.googlesource.com/c/1458436Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630286}

Use BackgroundTaskScheduler to wake up Chrome for Android, if the
newly introduced feature flag is enabled.

Bug: 924490
Change-Id: Iaa42ff2c10af4fbb466e8d892ccf626ee1827cd6
Reviewed-on: https://chromium-review.googlesource.com/c/1432840
Commit-Queue: Mugdha Lakhani <nator@google.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630285}

PreflightController still have one more issue that didn't check
headers existence before calling response_code().

Bug: 928394
Change-Id: I5841ba0b8d26c5d30b8eae257f6e4a88c6d158e3
Reviewed-on: https://chromium-review.googlesource.com/c/1457810
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630284}

This reverts commit f61b660b.

Reason for revert: After today's clang roll, this should now work better.

Original change's description:
> Revert "win: Always set strip_absolute_paths_from_debug_symbols, independent of goma."
>
> This reverts commit 2bf513af.
>
> Reason for revert: Breaks the symbol step for the official build, see crbug.com/911873
>
> Original change's description:
> > win: Always set strip_absolute_paths_from_debug_symbols, independent of goma.
> >
> > There's no downside of doing this on Windows and it makes the build
> > deterministic, so always enable it.
> >
> > Bug: 330260
> > Change-Id: I0e86a2ae5864af2fb4e1716cff1718c9606ab42f
> > Reviewed-on: https://chromium-review.googlesource.com/c/1358700
> > Reviewed-by: Scott Graham <scottmg@chromium.org>
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#613200}
>
> TBR=thakis@chromium.org,hans@chromium.org,scottmg@chromium.org,tikuta@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 330260
> Change-Id: I4a80dc0d3ce0a5125aa94b1367a11e66aefc1ea8
> Reviewed-on: https://chromium-review.googlesource.com/c/1362492
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613838}

Bug: 330260, 929108
Change-Id: I8175162afcbab9097cbfca6564edef3e95d10bd5
Reviewed-on: https://chromium-review.googlesource.com/c/1456294Reviewed-by: Michael Moss <mmoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630283}

This reverts commit a2fafd30.

Reason for revert: breaking ios-device-xcode-clang

TBR=thakis@chromium.org

Original change's description:
> Reland "Reland "Add build file for PFFFT""
>
> This is a reland of c1086af0
>
> This CL fixes the compile issues of the reverted CL by defining M_LN2 when not defined.
>
> TBR=thakis@chromium.org
>
> Original change's description:
> > Reland "Add build file for PFFFT"
> >
> > This is a reland of 8e4cf155
> >
> > This CL includes the following changes:
> > 1. when fuzzing, PFFFT is compiled disabling SIMD
> > 2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__
> > 3. unit test to validate the output of PFFFT (compared against that of FFTPACK)
> >
> > The first change fixes the problem due to which the original CL has been reverted;
> > however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used.
> >
> > Similarly, the second change is a temporary solution to allow landing this CL.
> > SIMD will be re-enabled in a follow-up CL.
> >
> > Original change's description:
> > > Add build file for PFFFT
> > >
> > > - fuzzer corpus generator and fuzzer targets
> > > - fftpack isolated as private test only target (only needed for the benchmark)
> > >
> > > Bug: webrtc:9577
> > > Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1452000
> > > Commit-Queue: Ale Bzk <alessiob@chromium.org>
> > > Reviewed-by: Nico Weber <thakis@chromium.org>
> > > Reviewed-by: Olga Sharonova <olka@chromium.org>
> > > Reviewed-by: Max Moroz <mmoroz@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#629627}
> >
> > Bug: webrtc:9577
> > Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea
> > Reviewed-on: https://chromium-review.googlesource.com/c/1458076
> > Commit-Queue: Ale Bzk <alessiob@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Max Moroz <mmoroz@chromium.org>
> > Reviewed-by: Max Morin <maxmorin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#630085}
>
> Bug: webrtc:9577
> Change-Id: I6bfe6d5f103570cebb6ca7909bd0369ecd8a7c45
> Reviewed-on: https://chromium-review.googlesource.com/c/1460616
> Commit-Queue: Ale Bzk <alessiob@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630278}

TBR=thakis@chromium.org,mmoroz@chromium.org,olka@chromium.org,maxmorin@chromium.org,alessiob@chromium.org

Change-Id: I00b1df98e043d2b845f3cee2a88e3307c7151939
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: webrtc:9577
Reviewed-on: https://chromium-review.googlesource.com/c/1459543
Auto-Submit: Ale Bzk <alessiob@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630282}

https://crrev.com/c/1456058 ported IdentityGetAccountsFunction::Run to
talk to the IdentityManager C++ instead of Mojo. In doing so, it changed
the returned account list order. This CL reworks the code to keep the
primary account as the first account in the list.

Bug: 928184
Change-Id: Ic6d305154fc4c46641e0ef2a3d58022ddfeb5de6
Reviewed-on: https://chromium-review.googlesource.com/c/1457316
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630281}

When the BFCs being re-attached were detached from that method, we
would sometimes nuke LayoutObjects later in the blocks_ vector, causing
a crash later in the iteration.

Use the new SetForceReattachLayoutTree() instead which means we do the
DetachLayoutTree() from the RebuildLayoutTree() instead. Also, store
the Elements instead of the LayoutObjects since they are traced GC
objects which is more robust.

We no longer need to check if any ancestors have already been marked
for forced legacy layout before marking for forced reattach since the
forced reattaches will be handled by the same passes over the dom tree
for style recalc and layout tree rebuild, not doing multiple layout
tree detaches.

Needed to modify the ShouldRecalcStyleFor() in order to traverse into
elements which are true for GetForceReattachLayoutTree() but not
otherwise style dirty. This is the first time we do a forced layout
tree re-attach without recalculating style.

Bug: 927983
Change-Id: Idb08f7b9a4bda81dd5a00458ef9751b754d3bd2e
Reviewed-on: https://chromium-review.googlesource.com/c/1455960
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630280}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ife57cd235f6d0da77599c0cb94d9a0eb2a01920e
Reviewed-on: https://chromium-review.googlesource.com/c/1460148Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630279}

This is a reland of c1086af0

This CL fixes the compile issues of the reverted CL by defining M_LN2 when not defined.

TBR=thakis@chromium.org

Original change's description:
> Reland "Add build file for PFFFT"
>
> This is a reland of 8e4cf155
>
> This CL includes the following changes:
> 1. when fuzzing, PFFFT is compiled disabling SIMD
> 2. SIMD is also disabled on fuchsia and android because PFFFT only checks __arm__
> 3. unit test to validate the output of PFFFT (compared against that of FFTPACK)
>
> The first change fixes the problem due to which the original CL has been reverted;
> however, it makes fuzzing slower and reduces the coverage since SIMD cannot be used.
>
> Similarly, the second change is a temporary solution to allow landing this CL.
> SIMD will be re-enabled in a follow-up CL.
>
> Original change's description:
> > Add build file for PFFFT
> >
> > - fuzzer corpus generator and fuzzer targets
> > - fftpack isolated as private test only target (only needed for the benchmark)
> >
> > Bug: webrtc:9577
> > Change-Id: Idc904bc4b05f945a7461a14893518551bbe34b84
> > Reviewed-on: https://chromium-review.googlesource.com/c/1452000
> > Commit-Queue: Ale Bzk <alessiob@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Olga Sharonova <olka@chromium.org>
> > Reviewed-by: Max Moroz <mmoroz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#629627}
>
> Bug: webrtc:9577
> Change-Id: Icfbb4b966c3ad866e9e2970b63363e0e258b1fea
> Reviewed-on: https://chromium-review.googlesource.com/c/1458076
> Commit-Queue: Ale Bzk <alessiob@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Max Moroz <mmoroz@chromium.org>
> Reviewed-by: Max Morin <maxmorin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#630085}

Bug: webrtc:9577
Change-Id: I6bfe6d5f103570cebb6ca7909bd0369ecd8a7c45
Reviewed-on: https://chromium-review.googlesource.com/c/1460616
Commit-Queue: Ale Bzk <alessiob@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630278}

This patch adds a parameter to URLLoaderFactoryParam so to have a factory
bound OriginAccessList in addition to the NextworkContext bound one.

Bug: 909639
Change-Id: Iefa477becd4b869e29486315ea11bf057d450ad8
Reviewed-on: https://chromium-review.googlesource.com/c/1454065
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630277}

Previously, CreateChromeBrowserStateForIdentityTestEnvironment() would
always create a FakeProfileOAuth2TokenService with a production
PO2TSIOSDelegate. This CL makes the default behaviour use the default
FakeProfileOAuth2TokenService constructor, which currently creates a
FakeOAuth2TokenServiceDelegate, but allows to use the production
delegate with an optional parameter.

Bug: 926907
Change-Id: I06a3a7866643b95196dbe0e8e506bd4253c1f3e4
Reviewed-on: https://chromium-review.googlesource.com/c/1454536
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630276}

In crrev.com/c/1454618 FamilyInfoFetcher was migrated to
PrimaryAccountAccessTokenFetcher as all the clients of
FamilyInfoFetcher were using the primary account. It turns out that
this allows us to do a nice cleanup by just moving from using
Mode::kImmediate to Mode::kWaitUntilAvailable. This way the
PrimaryAccountAccessTokenFetcher will listen for token updates and
thus, FamilyInfoFetcher does not need to do so.

Bug: 920965
Change-Id: I710120c784682e42a327b6656c63fc0a17225b40
Reviewed-on: https://chromium-review.googlesource.com/c/1458187
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630275}

When a fatal signal is received in a content_browsertest, make sure the
stack trace is logged to both the (redirected) error log as well as the
system log (logcat) on Android. Previously the crash was only written to
logcat where we don't have any other log messages from the test for
context.

TBR=sky@chromium.org

Bug: 863341
Change-Id: I913f099a7f2ec976db986d3d648cbbcf51839847
Reviewed-on: https://chromium-review.googlesource.com/c/1456079Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630274}

It's only used internally so it makes no sense to expose it.

Bug: 926867
Change-Id: I398a3e33402e1db6d8cb48f06ac99f3f29ad113c
Reviewed-on: https://chromium-review.googlesource.com/c/1455904Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#630273}

The IdentityManager is a way to access Google identities known to
the Chrome. The important information about those identities are
their identifiers (gaia, account_id and email).

Conversion IdentityManager API to works in term of CoreAccountInfo
is done incrementally one method at a time. This CL corresponds to
the method IdentityManager::Observer::OnPrimaryAccountSet().

TBR=sky@chromium.org

Bug: 926204
Change-Id: I4f192b2bcff1713c0137b24476650d6f7e244038
Reviewed-on: https://chromium-review.googlesource.com/c/1450192Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630272}

The crash was fixed in v8 by https://crrev.com/c/1454598.

R=agable@chromium.org

Bug: chromium:928458
Change-Id: I35f43b574f4153185fb7847173bc71a7f86b81a8
Reviewed-on: https://chromium-review.googlesource.com/c/1458206
Auto-Submit: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630271}

This CL adds 2 studies MirrorMultiloginAndroid and MirrorMultiloginIOS
that both enable feature UseMultiloginEndpoint to match the server-side
finch configuration.

Bug: None

Change-Id: I56114b9dad258fdc369ac0cbeccc926217acc473
Reviewed-on: https://chromium-review.googlesource.com/c/1455999
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630270}

After consulting the compositor team, it seems that it is actually ok
to pass a nullptr for the HitTestData, since we wont contain any
SurfaceDrawQuads.

Bug: 746182
Change-Id: Iaa6716caa8e825bc6edb6c4260bdfec6a03b69be
Reviewed-on: https://chromium-review.googlesource.com/c/1460117Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630269}

Now ResourceRequest has multiple special header entries that are aimed
for escaping from CORS checks for internal uses. This patch introduces
cors_exempt_headers to handle this kind of entries in an unified way.

Also this patch removes {Get|Set}ClientDataHeader interfaces from
WebURLRequest because these should not be used in Blink.

Bug: 870173
Change-Id: I5ae5a4a58df30e54064da5b7ab74abb69c9e42a7
Reviewed-on: https://chromium-review.googlesource.com/c/1445178
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630268}

replacing droger with mahmadi in the OWNERS file as the most recent author.

Bug: 910994
Change-Id: I91bde8f2ad436386155540396f538d179db2109a
Reviewed-on: https://chromium-review.googlesource.com/c/1448808
Auto-Submit: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630267}

Bug: v8:7279, v8:8562
Change-Id: I62bba21320a708bbb6e901077fba8c445f5ace44
Reviewed-on: https://chromium-review.googlesource.com/c/1458211
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630266}

These flags are the second part of launch of the new password form
parser.

Bug: 831123, 852742
Change-Id: Id059c0a50083dfe843e37acf878ca8e697db7ab3
Reviewed-on: https://chromium-review.googlesource.com/c/1451999Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630265}

Bug: 899235
Change-Id: Ifb75bcd27cf74e95e4b30511f72d367a349d762b
Reviewed-on: https://chromium-review.googlesource.com/c/1418372
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630264}

Starting with DICE, the sign-in view controller does no longer
present the modal sign-in dialog. So InlineLoginHandler is never used
from the signin view controller. This CL removes references to
signin_view_controller from the inline login handler.

Change-Id: I915e255eca516af651a8ca0e31d4ca05ee63aa7c
Reviewed-on: https://chromium-review.googlesource.com/c/1454534Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630263}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79ffba7a9de6..7c539fa95b0a


Created with:
  gclient setdep -r src-internal@7c539fa95b0a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I3d227848cfdcb60ea951f6dc112013ad76a30680
Reviewed-on: https://chromium-review.googlesource.com/c/1460756Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#630262}

Bug: 929601, 739170
Change-Id: Id70c05906fcb9d0d836641992b4d2d9f1c26b65f
Reviewed-on: https://chromium-review.googlesource.com/c/1458179Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630261}

The SigninManagerAndroidTest.DeleteGoogleServiceWorkerCaches test was
found to not be testing anything useful. It uses a browsing data
helper which is not hooked in anywhere to observe deletions, and the
test's assertions have inverted expectations. It only passed due to a
quirk in the test data (URLs without trailing slashes).

Disabled to allow refactoring of dependent code, pending a rework.

Bug: 929456
Change-Id: Ic7d7f8d0eae41f99bd8943f121c97b1a346fab19
Reviewed-on: https://chromium-review.googlesource.com/c/1459516
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630260}