- 01 Jun, 2017 40 commits
-
-
ssid authored
This CL does: 1. Url index uses flat_set instead of set. 2. Do not load image data and page data from bookmarks metadata into memory these are deprecated. 3. BookmarkNode stores ptr to icon_url instead of GURL BUG=691698 Review-Url: https://codereview.chromium.org/2883523002 Cr-Commit-Position: refs/heads/master@{#476158}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2fdc3d56a250..3f3075819f24 $ git log 2fdc3d56a..3f3075819 --date=short --no-merges --format='%ad %ae %s' 2017-05-31 mtklein delete some dead code in SampleApp 2017-05-31 fmalita Store SkPerlinNoiseShaderImpl's PaintingData inline 2017-05-31 brianosman Blacklist sRGB MSAA on AMD (ATI) Macs 2017-05-31 csmartdalton Add support for instanced draws 2017-05-31 brianosman Do color correction of vertex colors in GPU drawVertices 2017-05-31 reed slant colorfilter away from filterSpan4f 2017-05-31 borenet Add CIPD asset for Valgrind 2017-05-30 ethannicholas fix incorrect variable not assigned error in skslc 2017-05-26 ethannicholas enable geometry shader support in GrGLShaderStringBuilder 2017-05-30 robertphillips Update clearOp for split-OpList world (take 3) 2017-05-31 mtklein remove 565 sprite blitter too 2017-05-31 mtklein allow sprite blitter for equal color spaces 2017-05-31 reed add stages to colorfiltershader 2017-05-31 bsalomon Revert "Expand partial render target write pixels workaround." 2017-05-31 mtklein assume sRGB transfer function on untagged images Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: If9e643b22a52a85096e5d67c954331931314a17a Reviewed-on: https://chromium-review.googlesource.com/520185Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#476157}
-
chenwilliam authored
Combines the network and & CPU throttling components into a single module since they will be surfaced as a single UI. This also extracts network priorities into its own module which had a dubious home in network_conditions to begin with. Also improves extract_module: - Includes comments on how to use extract_module - Use 'npm run extract' to run extract_module script BUG=728262 Review-Url: https://codereview.chromium.org/2915883002 Cr-Commit-Position: refs/heads/master@{#476156}
-
hashimoto authored
Data is collected by Chrome OS side code https://chromium-review.googlesource.com/c/512482/ BUG=714935 Review-Url: https://codereview.chromium.org/2907123002 Cr-Commit-Position: refs/heads/master@{#476155}
-
xutan authored
This reverts commit eb85d566. This reverts commit bc979776. BUG=728344 TEST=unit_tests --gtest_filter="*AboutFlagsHistogramTest*" Review-Url: https://codereview.chromium.org/2917773002 Cr-Commit-Position: refs/heads/master@{#476154}
-
tkent authored
add() -> Add() remove() -> Remove() because they are not web-exposed. Also, this CL removes ExceptionState arguments and adds ASSERT_NO_EXCEPTION in the functions. This CL has no behavior changes. BUG=726214 Review-Url: https://codereview.chromium.org/2910143002 Cr-Commit-Position: refs/heads/master@{#476153}
-
martiw authored
The automation test will check if: 1. the new translation infobar appears 2. there are at least 2 tabs 3. overflow menus could be shown 4. overflow menu dismiss upon orientation BUG=727203 Review-Url: https://codereview.chromium.org/2908253002 Cr-Commit-Position: refs/heads/master@{#476152}
-
scottchen authored
There's a bug in the Polymer gesture code that prevents "keydown" to be recognized after the "track" (unless "mousedown" happens and resets the prevention state). Manually calling Gesture's reset function will fix the issue. This should be considered a temporary fix until Polymer fixes the gesture code. BUG=706709 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2864563002 Cr-Commit-Position: refs/heads/master@{#476151}
-
Daniel Cheng authored
Script contexts should only be associated with local frames, so just pass a WebLocalFrame. Bug: 416660 Change-Id: I0f2e0ba96e9a1ea1675b0d0edd826b2ab5af7b3b Reviewed-on: https://chromium-review.googlesource.com/520402Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#476150}
-
tansell authored
The compositor worker tests are flaky, crashing and timing out. They have always been slightly flaky but have recently become a lot more so with the rollout of layout tests on swarming. See the flakiness dashboard at; * https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=compositorworker * https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests%20(with%20patch)&tests=compositorworker * https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=compositorworker * https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests%20(with%20patch)&tests=compositorworker BUG=727991,728036,727505 TBR=majidvp@chromium.org,mcgreevy@chromium.org,tyoshino@chromium.org CC=dpranke@chromium.org,qyearsly@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2915003002 Cr-Commit-Position: refs/heads/master@{#476149}
-
yosin authored
This patch moves |{Left,Right}WordPosition()| to static member of |SelectionModifier| since they are used only in it to reduce global functions for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2912863004 Cr-Commit-Position: refs/heads/master@{#476148}
-
zhongyi authored
BUG=726725 Review-Url: https://codereview.chromium.org/2914943002 Cr-Commit-Position: refs/heads/master@{#476147}
-
skau authored
In order to track printer churn, we record an event when a printer is succesfully added and when a printer is removed in the settings dialogs. This data is tracked by protocol. BUG=726103 Review-Url: https://codereview.chromium.org/2903883003 Cr-Commit-Position: refs/heads/master@{#476146}
-
eroman authored
BUG=634456,634453 Review-Url: https://codereview.chromium.org/2907353002 Cr-Commit-Position: refs/heads/master@{#476145}
-
xiaochengh authored
TextIterator used to have the following member functions returning |bool| to indicate whether the handling of a node is complete or not: - HandleTextNode - HandleReplacedElement - HandleNonTextNode However, the return value has become arbitrary and not that useful after the class has evolved for so many years. Hence, this patch removes their return value to make the state change in TextIterator clean. BUG=721957 TEST=n/a; shouldn't have any behavioral change Review-Url: https://codereview.chromium.org/2914883002 Cr-Commit-Position: refs/heads/master@{#476144}
-
ashleymarie authored
BUG=chromium:720002 Review-Url: https://codereview.chromium.org/2914733002 Cr-Commit-Position: refs/heads/master@{#476143}
-
rlanday authored
In https://codereview.chromium.org/2904093002 I'm moving the storage for the MatchStatus flag from a subclass of DocumentMarkerDetails into TextMatchMarker. This CL follows up by removing the getter/setter methods for this flag from DocumentMarker, forcing callers to cast to TextMatchMarker. This helps clarify where callers are making assumptions about the types of certain DocumentMarkers. BUG=707867 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2909553002 Cr-Commit-Position: refs/heads/master@{#476142}
-
shend authored
Currently, the user-modify property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the EUserModify enum and use the generated CSSValueID <-> EUserModify mappings. Diff of generated files: https://gist.github.com/21e3b6343b06a190a48ab3e22c9e10bc/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2912923003 Cr-Commit-Position: refs/heads/master@{#476141}
-
hansberry authored
BUG=672263 Review-Url: https://codereview.chromium.org/2913313002 Cr-Commit-Position: refs/heads/master@{#476140}
-
Walter Korman authored
Bug: 709137 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I22266784ee485421f9f3748631e30c3d306572d1 Reviewed-on: https://chromium-review.googlesource.com/518314 Commit-Queue: Walter Korman <wkorman@chromium.org> Reviewed-by:
Chris harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#476139}
-
John Budorick authored
This reverts commit 9cbc9e00. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=728433 Original change's description: > [Offline Pages] Ensure the archive folder exists when saving a page. > > Move the logic ensuring archives directory is created from the startup of > OfflinePageModel to every time saving a page. This change will also handle > the directory creation gracefully to not crash Chrome. > > Bug: 725266 > Change-Id: Iec46b007e51c33d90c3e282919a6313d7a5e3f85 > Reviewed-on: https://chromium-review.googlesource.com/513984 > Commit-Queue: Yafei Duan <romax@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#475992} TBR=fgorski@chromium.org,romax@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 725266 Change-Id: Ic9da92f529b68f3b472c072cecec2b9fc1059802 Reviewed-on: https://chromium-review.googlesource.com/520484Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#476138}
-
msw authored
Also remove WmWindow::GetRootWindowController. Also perform some minor cleanup/refactoring. BUG=NONE TEST=No functional changes. R=sky@chromium.org Review-Url: https://codereview.chromium.org/2911393002 Cr-Commit-Position: refs/heads/master@{#476137}
-
lpy authored
This patch moves TabManager and other related class into chrome/browser/resource_coordinator, they are tab_manager* and tab_stats.*, header include and BUILD files are also updated. Review-Url: https://codereview.chromium.org/2898033002 Cr-Commit-Position: refs/heads/master@{#476136}
-
renjieliu authored
Refactoring the code so it can also be used by the iOS client. Also add a unit test. BUG=722679 Review-Url: https://codereview.chromium.org/2912843003 Cr-Commit-Position: refs/heads/master@{#476135}
-
ichikawa authored
- Add a menu item to toggle the incognito mode in ios_web_view_shell. - Change "Deallocate web view" menu item to "Recreate web view". These makes it easy to test these features. Review-Url: https://codereview.chromium.org/2917583002 Cr-Commit-Position: refs/heads/master@{#476134}
-
Quinten Yearsley authored
Related: http://crbug.com/726571 Change-Id: Ibf18f5197d6b75db9ba6bb74574983a6b4575b38 Reviewed-on: https://chromium-review.googlesource.com/517323Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#476133}
-
Xianzhu Wang authored
Scenario in which this is useful: I'm rebaselining some tests to create flag-specific results for enable-slimming-paint-invalidation. Most of the tests to be rebaselined only produced different text results, but not image results. This CL can avoid unnecessary image rebaselines. Change-Id: Ia08bf0b850f2da0074598c7713baa788bf2b4b56 Reviewed-on: https://chromium-review.googlesource.com/517918 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#476132}
-
xiaochengh authored
This patch prunes a call site of the deprecated function, which is safe because layout is already clean there (DCHECK-ed). BUG=698633 Review-Url: https://codereview.chromium.org/2919573002 Cr-Commit-Position: refs/heads/master@{#476131}
-
pfeldman authored
BUG=727795 Review-Url: https://codereview.chromium.org/2914663002 Cr-Commit-Position: refs/heads/master@{#476130}
-
pmonette authored
The usage of BrowserThread::FILE is deprecated in favor of the post_task.h API. BUG=689520 Review-Url: https://codereview.chromium.org/2888693003 Cr-Commit-Position: refs/heads/master@{#476129}
-
sujiths.s authored
HTMLOptionElement::SetDirty() ignored the argument. This CL fixes it. Signed-off-by:
sujiths.s <sujiths.s@samsung.com> Review-Url: https://codereview.chromium.org/2906883002 Cr-Commit-Position: refs/heads/master@{#476128}
-
Jeremy Roman authored
Bug: 727010 Change-Id: I8361d0040e1bff9a4e1e45da725f7f9e5157947e Reviewed-on: https://chromium-review.googlesource.com/520206Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#476127}
-
Marijn Kruisselbrink authored
Adds a feature flag for blob mojofication, as well as adds the basic mojom interface definitions. Also adds some of the framework code to blink to transport blobs over mojo to the browser. Bug: 611935 Change-Id: I6ab9486053d4fd7982b4732b8f732c89cc7d27f5 Reviewed-on: https://chromium-review.googlesource.com/514426 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#476126}
-
mpearson authored
BUG=714081 Review-Url: https://codereview.chromium.org/2902043004 Cr-Commit-Position: refs/heads/master@{#476125}
-
Dale Curtis authored
This is equivalent to YouTube's MTBR metric in that it corresponds to the total watch time for a session divided by the number of underflow events that occur during that session. The metric is recorded by having the WatchTimeReporter count the number of underflow events that occur and pass them along to MediaInternals during each watch time reporting interval. At finalization MTBR is calculated for AudioVideo.MSE, AudioVideo.SRC, AudioVideo.EME, Audio.MSE, Audio.SRC, and Audio.EME. This is nicer than the existing Media.UnderflowDuration metric since it is not as susceptible to scaling issues due to more playbacks and has no automatic zero weighting. BUG=648710, 727862 TEST=new unittests Change-Id: I144333e6e25cc599bfc89ee2be9a25bac476d156 Reviewed-on: https://chromium-review.googlesource.com/516528Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#476124}
-
fsamuel authored
This CL does two things: 1. It propagates the translucent bit to the window manager so that it can update its top level window. 2. It skips guttering in ClientSurfaceEmbedder if the window is transparent. BUG=672962 TBR=tsepez@chromium.org Review-Url: https://codereview.chromium.org/2919523004 Cr-Commit-Position: refs/heads/master@{#476123}
-
palmer authored
We have 2 hostname goodness predicates: checking that `net::IsValidHostLabelCharacter` returns true for all characters in all labels, and `net::IsCanonicalizedHostCompliant`. The latter is more strict than the former, in that it imposes an additional constraint on the final label: it can only begin with an alphanumeric character. Add a counter to see how often hostnames would pass the former check but fail the latter, stricter check. This will help us decide which predicate to finalize on. BUG=695474 Review-Url: https://codereview.chromium.org/2906723002 Cr-Commit-Position: refs/heads/master@{#476122}
-
dpapad authored
BUG=720034 Review-Url: https://codereview.chromium.org/2913453002 Cr-Commit-Position: refs/heads/master@{#476121}
-
patricialor authored
AvatarButton declares a variable that is only used on Win/Linux. This breaks the MacViews browser compile (mac_views_browser=true in gn), so fix it by declaring the same variable inside both #ifdef branches in which it's used. BUG=425229 Review-Url: https://codereview.chromium.org/2913663004 Cr-Commit-Position: refs/heads/master@{#476120}
-
jamescook authored
For mustash we need to eliminate ash to chrome delegates. Moving this class will allow it to be called directly from the system tray IME code in ash, which will allow methods to be removed from SystemTrayDelegate. Move the class into ui/base/ime/chromeos because that's where most of the other utility code lives (like extension_ime_util). * Move kBrailleIme constants to ui/base/ime/chromeos/extension_ime_util.h * Fix input_method_whitelist.cc usage in BUILD rules for test targets * Move Chrome OS IME strings to ui_chromeos_strings.grd BUG=724305 TEST=ui_base_unittests, chrome unit_tests TBR=rockot@chromium.org Review-Url: https://codereview.chromium.org/2919583002 Cr-Commit-Position: refs/heads/master@{#476119}
-