GitLab

V8TestingScope is a "scope" object, so it's not a good idea to allow people to create V8TestingScope on heap.
This CL forbids it. V8TestingScope should be used on stack or as a part of object.

NOTRY=true

Review URL: https://codereview.chromium.org/302893004

git-svn-id: svn://svn.chromium.org/blink/trunk@175112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/305963006

git-svn-id: svn://svn.chromium.org/blink/trunk@175111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=361045
R=alph@chromium.org

Review URL: https://codereview.chromium.org/306803003

git-svn-id: svn://svn.chromium.org/blink/trunk@175110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This also fixes "inspect element" for virtual viewport.

BUG=371843

Review URL: https://codereview.chromium.org/309473002

git-svn-id: svn://svn.chromium.org/blink/trunk@175109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The HTMLImportsController wishes to become more of an Actor-style object,
and it being a root of the import tree leads to ambiguities in responsibilities.
So we should split these responsibilities cleanly.

R=morrita
BUG=

Review URL: https://codereview.chromium.org/301803002

git-svn-id: svn://svn.chromium.org/blink/trunk@175108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Length destructor is nontrivial and every non-const Length
argument adds an unnecessary branch from calling Length's destructor.
This patch removes most of the non-const Length arguments which should
lead to a small performance improvement.

A few LengthSize, LengthPoint, and LengthBox arguments were also
constref'ified for consistency.

No new tests as there is no observable change in behavior.

Review URL: https://codereview.chromium.org/305883002

git-svn-id: svn://svn.chromium.org/blink/trunk@175107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/303783002

git-svn-id: svn://svn.chromium.org/blink/trunk@175106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When working with FloatPoints in mapToContainer we currently round the
accumulated offset before adding to the current point. This can lead to
incorrect results when we add the two values together.

This CL removes the rounding call on accumulatedOffset.

BUG=371640

Review URL: https://codereview.chromium.org/302023003

git-svn-id: svn://svn.chromium.org/blink/trunk@175105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Though r174748 added a test case to check if scheme contains colon,
it would be better if scheme contains colon explicitly. This cl checks
scheme contains colon. if so, this cl generates syntax error exception.

BUG=none

Review URL: https://codereview.chromium.org/298273008

git-svn-id: svn://svn.chromium.org/blink/trunk@175104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Node.textContent setter should treat undefined the same way as null.
Previously, undefined would get stringified to "undefined" in the
setter, instead of being treated as "". This is inconsistent with
what happens when assigning null and with the DOM specification:
http://dom.spec.whatwg.org/#dom-node-textcontent

Since the textContent attribute is nullable, both null and undefined
input should be treated as null as per the Web IDL specification:
http://heycam.github.io/webidl/#es-nullable-type

The new behavior is consistent with Firefox 29. However, IE11 returns
"undefined" in this case.

R=arv@chromium.org, tkent@chromium.org
BUG=378454
TEST=fast/dom/Node/textContent-set-undefined.html

Review URL: https://codereview.chromium.org/303163002

git-svn-id: svn://svn.chromium.org/blink/trunk@175103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/305753005

git-svn-id: svn://svn.chromium.org/blink/trunk@175102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/307813004

git-svn-id: svn://svn.chromium.org/blink/trunk@175101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Scrollbar stores original scroll position in non-negative scroll coordinates.
When sending those coordinates to ScrollableArea, they should be offsetted
with minimumScrollPosition() first.

R=jchaffraix@chromium.org
BUG=377131

Review URL: https://codereview.chromium.org/302603009

git-svn-id: svn://svn.chromium.org/blink/trunk@175100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mark the fast/text/decorations-transformed.html test as flaky on
Windows. Possibly caused by the switch to DW.

BUG=378610
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/304183004

git-svn-id: svn://svn.chromium.org/blink/trunk@175099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Windows XP specific rebaselines for r175038 as the XP > Win7 fallback is
no longer valid for text tests.

TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/301353002

git-svn-id: svn://svn.chromium.org/blink/trunk@175097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add unittests for WebCore::WebSocket class.

BUG=NONE

Review URL: https://codereview.chromium.org/298893008

git-svn-id: svn://svn.chromium.org/blink/trunk@175096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NOTRY=true
BUG=379032

Review URL: https://codereview.chromium.org/301243004

git-svn-id: svn://svn.chromium.org/blink/trunk@175095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=100004, 105447

Review URL: https://codereview.chromium.org/249133002

git-svn-id: svn://svn.chromium.org/blink/trunk@175094 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a follow up CL to https://codereview.chromium.org/305783004/

BUG=357163
NOTRY=true

Review URL: https://codereview.chromium.org/308793003

git-svn-id: svn://svn.chromium.org/blink/trunk@175093 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL fixes two issues:
- Add clang support for InstanceCounter type resolver
- Add a mutex when writing to objectgraph map.
-- Oilpan GC marking phase is only run on single thread, however, weak processing are not.
-- Heap wtf collection implementations may mark their back store on weak processing phase.

BUG=378157
NOTRY=true

Review URL: https://codereview.chromium.org/304033004

git-svn-id: svn://svn.chromium.org/blink/trunk@175092 bbb929c8-8fbe-4397-9dbb-9b2b20218538

if the browser is in OOM situation and PartitionAllocReturnNull is set,
it returns null instead of OOM crash.

BUG=374087

Review URL: https://codereview.chromium.org/295803005

git-svn-id: svn://svn.chromium.org/blink/trunk@175091 bbb929c8-8fbe-4397-9dbb-9b2b20218538

GraphicsLayer.

In particular, do so for squashing layers. This allows us
to track repaints for squashed layers where the layer itself
does not change but the layer moves with respect to the
layer it squashes into.

BUG=370664

Review URL: https://codereview.chromium.org/301843002

git-svn-id: svn://svn.chromium.org/blink/trunk@175090 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In a previous CL we disabled main frame impl-side scrolling if there is a
fullscreen element because the fullscreen element can balloon up scroll events
to the (invisible) main frame layer and cause weird artifacts.

However if the element that enter fullscreen is the main frame document itself,
we should allow it remain scrollable.

BUG=376699

Review URL: https://codereview.chromium.org/305833002

git-svn-id: svn://svn.chromium.org/blink/trunk@175089 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In oilpan builds, |m_syncBaseDependents| and |m_syncBase| are changed to weak references from manual detach in d-tors.

|m_syncBase| is changed from Element* -> SVGSMILElement* as its only valid value is SVGSMILElement*.

BUG=357163

Review URL: https://codereview.chromium.org/305783004

git-svn-id: svn://svn.chromium.org/blink/trunk@175088 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This does not fix the clusterfuzz testcase in the bug, but I found it while
investigating that bug. See also the comment at the top of doUpdateElement.

I was unable to write a crashing testcase for this...

R=eseidel,esprehn
BUG=376748

Review URL: https://codereview.chromium.org/296343002

git-svn-id: svn://svn.chromium.org/blink/trunk@175087 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method is only called from destructors or document teardown. We
apparenly also skip it when in Oilpan mode. That would seem to indicate
that by the time we get here there should be no subframes left connected.

Lets change the loop into an ASSERT to verify that.

Review URL: https://codereview.chromium.org/303653005

git-svn-id: svn://svn.chromium.org/blink/trunk@175086 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should omit closest-side value, wherever is possible. Specification:
​http://www.w3.org/TR/2014/CR-css-shapes-1-20140320/#basic-shape-computed-values
This change aligns the behavior to the specification.
Added new test cases for the shape-outside parsing tests.

This is a merge of http://trac.webkit.org/changeset/169406 by Zoltan Horvath <zoltan@webkit.org>.

BUG=371934

Review URL: https://codereview.chromium.org/300843011

git-svn-id: svn://svn.chromium.org/blink/trunk@175085 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL is stubbing Blink security features that operate on
frames across origins, so that they can deal with RemoteFrames
being in the FrameTree. They will not yet work with cross-process
frames because there is not enough information in most cases, but
this allows us to put the frame infrastructure in place before
we implement cross-process information sharing to correct the
relevant behavior.

BUG=346764
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/303793003

git-svn-id: svn://svn.chromium.org/blink/trunk@175084 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/307973002

git-svn-id: svn://svn.chromium.org/blink/trunk@175083 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Correctly handle object classname and add Symbol type to PropertyPreview and CallArgument in the protocol.

BUG=376194

Review URL: https://codereview.chromium.org/303113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175082 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Part of the larger task of creating an unprefixed Pointer Lock API.
Intent to Implement and Ship approved April 21 2014
http://goo.gl/uQTJjH.

BUG=359738

Review URL: https://codereview.chromium.org/281383010

git-svn-id: svn://svn.chromium.org/blink/trunk@175081 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The srcset parser spec (http://picture.responsiveimages.org/#parse-srcset-attr )
have recently changed to have better future compatibility.
It will enable us to add future descriptors of the form "descriptor(value, anotherValue)".
It will also ease the envisioned addition of the 'h' descriptor.

BUG=376726

Review URL: https://codereview.chromium.org/293423002

git-svn-id: svn://svn.chromium.org/blink/trunk@175080 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move the editing commands and style objects to the Oilpan heap, along
with having them use transition types throughout.

R=zerny@chromium.org,haraken@chromium.org,tkent@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/299353004

git-svn-id: svn://svn.chromium.org/blink/trunk@175079 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Some tests in style-with-shadow-pseudo-element.html and
style-with-deep-combinator.html did check if a style rule
in a shadow tree can be applied to its sibling shadow tree(s),
which is against the current spec.

I will add some test *against* such case, that a style rule
doesn't apply to its sibling shadow tree, along with the fix for
bug 355674 later.

BUG=355674
TEST=pass layout tests.

Review URL: https://codereview.chromium.org/304123002

git-svn-id: svn://svn.chromium.org/blink/trunk@175078 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We shouldn't call ensureUserAgentShadowRoot() from inside an element's
constructor since not all constructors in the inheritance chain may
have run, and also since it means going into DOM methods that may want
to ref |this| before it's ever been adopted.

This patch fixes this and also fixes the RefPtr protects inside
notifyNodeInserted.

Review URL: https://codereview.chromium.org/304003002

git-svn-id: svn://svn.chromium.org/blink/trunk@175077 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After r174546 a v8::TryCatch object is in scope when calling a method's
C++ implementation early due to missing optional arguments.  If the
implementation throws an exception, we need to call ReThrow() on that
v8::TryCatch object for the exception to be propagated correctly.

BUG=362388

Review URL: https://codereview.chromium.org/307883002

git-svn-id: svn://svn.chromium.org/blink/trunk@175076 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=esprehn@chromium.org

Review URL: https://codereview.chromium.org/308743003

git-svn-id: svn://svn.chromium.org/blink/trunk@175072 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=leviw@chromium.org

Review URL: https://codereview.chromium.org/303223003

git-svn-id: svn://svn.chromium.org/blink/trunk@175068 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/304323003

git-svn-id: svn://svn.chromium.org/blink/trunk@175065 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=175044

TBR=eae@chromium.org

Review URL: https://codereview.chromium.org/303213002

git-svn-id: svn://svn.chromium.org/blink/trunk@175063 bbb929c8-8fbe-4397-9dbb-9b2b20218538