GitLab

This could happen in cases where we initiate a transfer but end up navigating
in the original SiteInstance.

BUG=402018
TEST=No proxy host for the current RFH after navigating an about:blank tab.

Review URL: https://codereview.chromium.org/452673002

Cr-Commit-Position: refs/heads/master@{#288406}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288406 0039d316-1c4b-4281-b951-d872f2087c98

Normally, the paste popup is hidden when its position changes. However, there
are legitimate cases outside of scrolling where the position may change, e.g.,
due to a resize, where the popup should remain visible. Handle this case by
only hiding the popup if its position changes while scrolling.

BUG=380084

Review URL: https://codereview.chromium.org/312293002

Cr-Commit-Position: refs/heads/master@{#288404}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288404 0039d316-1c4b-4281-b951-d872f2087c98

We can miss applying a transform if we have a transformed, partially
occluded DelegatedRendererLayerImpl with a contributing RenderPass. This
causes the wrong transform to be sent into the occlusion tracker, so
occlusion gets applied incorrectly, which hides desired content.

BUG=379072,390873

Review URL: https://codereview.chromium.org/447193005

Cr-Commit-Position: refs/heads/master@{#288403}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401344

Review URL: https://codereview.chromium.org/447963005

Cr-Commit-Position: refs/heads/master@{#288402}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288402 0039d316-1c4b-4281-b951-d872f2087c98

According to Alan, the shadow on the SSL warning illustration was 1px off. This updates the pngs.

BUG=401289
R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/457433002

Cr-Commit-Position: refs/heads/master@{#288401}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288401 0039d316-1c4b-4281-b951-d872f2087c98

Reason: blink_glue.* is too generic for this.

It just contains a single function to convert from base::File::Info to
blink::WebFileInfo. Similar to web_url_request_util.h and
pepper_file_util.h.

BUG=345892
TEST=None
R=avi@chromium.org

Review URL: https://codereview.chromium.org/455623002

Cr-Commit-Position: refs/heads/master@{#288399}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288399 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288398}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288398 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179817:179832&mode=html
TBR=jbroman@chromium.org,zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/458493002

Cr-Commit-Position: refs/heads/master@{#288397}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288397 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates some dependencies from NetworkingPrivateServiceClient
that will allow it to be moved to src/extensions.

It also changes NetworkingPrivatCrypto from a class to a namespace since that is how we use it.

BUG=363776

Review URL: https://codereview.chromium.org/442073003

Cr-Commit-Position: refs/heads/master@{#288396}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288396 0039d316-1c4b-4281-b951-d872f2087c98

Don't bother IPC owners with mojo changes.

TEST=none
BUG=none
R=darin@chromium.org,jam@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/451073002

Cr-Commit-Position: refs/heads/master@{#288395}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288395 0039d316-1c4b-4281-b951-d872f2087c98

uber.onContentFrameLoaded is mistakenly called *after* the overlay is opened. This function
always brings the navigation frame to the foreground, so it should be called before any overlay
might be opened. The overlay being opened will then cause the navigation frame to recede
into the background.

This was inadvertently broken in r287989 (issue 423533003).

BUG=401903
TBR=dbeam@chromium.org

Review URL: https://codereview.chromium.org/452113002

Cr-Commit-Position: refs/heads/master@{#288394}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288394 0039d316-1c4b-4281-b951-d872f2087c98

Quick Launch shortcut.

InstallShortcutTest.CreateAllShortcutsSystemLevel has been broken since http://crrev.com/164849 ...

The test expectations had not been adjusted in this CL as setup_unittests.exe
doesn't run on the waterfall yet (issue #153829) and the breakage had gone
unnoticed.

Expectations have now been adjusted such that we no longer expect a system-level
(Default-user) Quick Launch shortcut, but a per-user Quick Launch shortcut for
the admin running the install as the product code's logic has been doing for over
a year...

Also remove the code cleaning up the legacy Default-user Quick Launch shortcut as
this cleanup code has been running for 21 months now and leaving this shortcut
behind for a few users is a no-op (i.e. the Default-user shortcut will get copied
to new Windows profiles and Active Setup will kick in a few seconds later to try
to install the same shortcut which will already exist... the UX result will be
the same: a single Chrome Quick Launch shortcut will be installed).

BUG=329239, 153829

Review URL: https://codereview.chromium.org/432273005

Cr-Commit-Position: refs/heads/master@{#288393}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288393 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Revert of [Android] Use UIResource for overscroll glow (https://codereview.chromium.org/454863003/)

Reason for revert:
The ToT builder failures appear to be unrelated to this change, and the
upstream instrumentation already exercise these code paths. Tentatively
reverting the revert and will keep an eye on downstream rolls.

Original issue's description:
> Revert of [Android] Use UIResource for overscroll glow (https://codereview.chromium.org/422013003/)
> 
> Reason for revert:
>  This is breaking chrome ToT downstream  and the change quie complex so
>     I don't feel qualified to try to fix it in place.
>     
>     The failure we hit is
>      F/chromium( 2961): [FATAL:system_ui_resource_manager_impl.cc(35)] Check failed: !bitmap.empty().
>     
>     See an example of a failed run in
>     https://uberchromegw.corp.google.com/i/clank.tot/builders/instrumentation-yakju-clankium-tot/builds/32007
>     
>     (but just trying to boot clank with this patch will trigger it)
> 
> 
> Original issue's description:
> > [Android] Use UIResource for overscroll glow
> > 
> > Introduce a SystemUIResourceManager class for loading and providing access to
> > shared UIResourceId's.  Wire this class to the existing OverscrollGlow effect,
> > using the shared id's with a UIResourceLayer for both glow and edge layers.
> > 
> > This patch is a subset of powei@'s original SystemUIResource patch found at
> > https://codereview.chromium.org/377013002/.
> > 
> > BUG=326326
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288095
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288330

TBR=aelias@chromium.org,powei@chromium.org,yfriedman@chromium.org,sky@chromium.org,miguelg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=326326

Review URL: https://codereview.chromium.org/454113002

Cr-Commit-Position: refs/heads/master@{#288392}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288392 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288391}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288391 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288390}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288390 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
I misunderstood the outcome of the discussion surrounding this topic. We need to keep this code in order to not break google.com while gathering data about this feature.

Original issue's description:
> Enable HTMLMediaElement@autoplay on Android
> 
> This CL sets user_gesture_required_for_media_playback to false in Chrome for
> Android. Previously, we removed this requirement as a special case for the
> Google Search Results page. Now that this setting matches Chrome's behavior on
> other platforms, we don't need the special case for google.com and can remove
> the entire VoiceSearchTabHelper.
> 
> This CL leaves the user_gesture_required_for_media_playback WebPreference
> because that's used by android_webview.
> 
> R=klobag@chromium.org, darin@chromium.org
> BUG=178297
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288308

TBR=darin@chromium.org,klobag@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=178297

Review URL: https://codereview.chromium.org/453023002

Cr-Commit-Position: refs/heads/master@{#288389}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288389 0039d316-1c4b-4281-b951-d872f2087c98

This way I don't have to duplicate it across bots. I'll remove from
the other files once the recipe side has been updated.

BUG=109173
TEST=none
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/450403002

Cr-Commit-Position: refs/heads/master@{#288388}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=383635

Review URL: https://codereview.chromium.org/445353003

Cr-Commit-Position: refs/heads/master@{#288387}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288387 0039d316-1c4b-4281-b951-d872f2087c98

Previously under resources/contextual_search/, now moving Roboto to its own directory. Also using Roboto2 now.

BUG=401100
R=dbeam@chromium.org, huangs@chromium.org
TBR=jam
TEST=Didn't break Contextual Search promo

Review URL: https://codereview.chromium.org/450433002

Cr-Commit-Position: refs/heads/master@{#288386}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288386 0039d316-1c4b-4281-b951-d872f2087c98

The title of the window widget should be the product name (Chrome/Chromium).

Added a "close" button to make the last bubble in the tutorial dismissible.

BUG=399698,399697
TEST=Start Chrome with --new-avatar-menu. Choose "Switch person" from the
avatar menu of a brand new profile. Once you go through all the slides in
the tutorial, the last bubble which points to the "Add Person" button
should have a little x button in the top right corner. Also, the title of
the window should be "Chrome".

Review URL: https://codereview.chromium.org/440713005

Cr-Commit-Position: refs/heads/master@{#288385}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401769

Review URL: https://codereview.chromium.org/449253002

Cr-Commit-Position: refs/heads/master@{#288384}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288384 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/456533002

Cr-Commit-Position: refs/heads/master@{#288383}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394220
TBR=rnk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/456833002

Cr-Commit-Position: refs/heads/master@{#288382}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288382 0039d316-1c4b-4281-b951-d872f2087c98

Assign cmasone@chromium.org as the owner of the
Login.ConsumerNewUsersAllowed histogram.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/453723002

Cr-Commit-Position: refs/heads/master@{#288381}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=400552

Review URL: https://codereview.chromium.org/448953002

Cr-Commit-Position: refs/heads/master@{#288380}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288380 0039d316-1c4b-4281-b951-d872f2087c98

Fills in ServiceWorkerFetchStores.  Adds a stub ServiceWorkerFetchStore class which will need to be filled in. Also adds some tests.

A CL to refactor ServiceWorkerFetchStores -> ServiceWorkerCacheStorage is upcoming.

BUG=392621

Review URL: https://codereview.chromium.org/424863002

Cr-Commit-Position: refs/heads/master@{#288379}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288379 0039d316-1c4b-4281-b951-d872f2087c98

BUG=342336
TEST=None

Review URL: https://codereview.chromium.org/448923003

Cr-Commit-Position: refs/heads/master@{#288378}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288378 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401928

Review URL: https://codereview.chromium.org/453943002

Cr-Commit-Position: refs/heads/master@{#288377}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288377 0039d316-1c4b-4281-b951-d872f2087c98

This moves AwWebContentsObserver to be a separate class so that
it can has it's own unittests.

BUG=None
TEST=AndroidWebviewTests

Review URL: https://codereview.chromium.org/445403002

Cr-Commit-Position: refs/heads/master@{#288376}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288376 0039d316-1c4b-4281-b951-d872f2087c98

-----------------------------------------------------------
1. filter expired suggestions before loading from cache
2. assign default expiry timestamps (now + 72 hours), to those ones which don't have expiry timestamps, before storing in cache

BUG=387926

Review URL: https://codereview.chromium.org/423133003

Cr-Commit-Position: refs/heads/master@{#288375}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288375 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the ability to do encoding/decoding of tokens in the audible range.
It also simplifies the parameters we send in to the whispernet pnacl wrapper.
All the parameters removed are now picked up as defaults in the wrapper itself.
There is literally no reason we'd ever touch those defaults hence it made no
sense to send them hardcoded from wrapper.js.

R=ckehoe@chromium.org
BUG=390393

Review URL: https://codereview.chromium.org/444373004

Cr-Commit-Position: refs/heads/master@{#288374}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288374 0039d316-1c4b-4281-b951-d872f2087c98

This was deliberately NOT done previously, because it indicates a likely
source of future problems.

> Changed PLOG to VPLOG
> 
> Moved recvmsg log to VPLOG
> 
> BUG=377403
> 
> Review URL: https://codereview.chromium.org/414243002

TBR=giji.g@samsung.com

Review URL: https://codereview.chromium.org/452973002

Cr-Commit-Position: refs/heads/master@{#288373}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288373 0039d316-1c4b-4281-b951-d872f2087c98

Use gfx::CrossProduct() instead of defining a new static function.

BUG=

Review URL: https://codereview.chromium.org/444983002

Cr-Commit-Position: refs/heads/master@{#288372}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288372 0039d316-1c4b-4281-b951-d872f2087c98

This is a temporary measure until:
- we can disable the API only on Win8 Metro OR,
- we can make it work on Win8 Metro.

The API is currently broken on Win8 Metro and it is not trivial to
disable it on that mode only. Given the discussion with the Blink API
owners, disabling it on Win8 would be better than not shipping because
of the bug on Win8 Metro.

BUG=400846

Review URL: https://codereview.chromium.org/456623003

Cr-Commit-Position: refs/heads/master@{#288371}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288371 0039d316-1c4b-4281-b951-d872f2087c98

Move them from internal histograms.xml to chromium.org histograms.xml since they are/were referenced only in chromium.org code.

BUG=none

Review URL: https://codereview.chromium.org/449913002

Cr-Commit-Position: refs/heads/master@{#288370}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288370 0039d316-1c4b-4281-b951-d872f2087c98

Was a blocker on a P0 bug, http://crbug.com/380709, but not anymore.

After the tryserver split, the blacklisting doesn't trigger, so it is a no-op change. Consider it a cleanup.

R=phajdan.jr@chromium.org,stip@chromium.org
BUG=225464
TEST=git cl try -m tryserver.chromium.win -b win_chromium_x64_rel

Review URL: https://codereview.chromium.org/319983004

Cr-Commit-Position: refs/heads/master@{#288368}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371463

Review URL: https://codereview.chromium.org/421393002

Cr-Commit-Position: refs/heads/master@{#288367}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288367 0039d316-1c4b-4281-b951-d872f2087c98

A regression was introduced in r275142 causing the permissions dialog to not
show permissions. Obviously very bad. Fixed, and added a regression test.

BUG=397900

Review URL: https://codereview.chromium.org/448883002

Cr-Commit-Position: refs/heads/master@{#288365}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288365 0039d316-1c4b-4281-b951-d872f2087c98

BUG=398169

Review URL: https://codereview.chromium.org/428883013

Cr-Commit-Position: refs/heads/master@{#288363}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288363 0039d316-1c4b-4281-b951-d872f2087c98

Fixes issues with EWDTAH lifetime. Now EWDTAH lives as long as there is a scoped_refptr referencing it or the worker is alive.

Split off https://codereview.chromium.org/349033009/

BUG=389454

Review URL: https://codereview.chromium.org/405603002

Cr-Commit-Position: refs/heads/master@{#288362}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288362 0039d316-1c4b-4281-b951-d872f2087c98