- 02 Nov, 2018 40 commits
-
-
Kouhei Ueno authored
Bug: 711706 Change-Id: I46271b96329d45d4b2ad6ad0988490dcad98943e Reviewed-on: https://chromium-review.googlesource.com/c/1314013 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#604851}
-
BUG=762641 TBR=oshima@chromium.org Change-Id: I512f29e5f8d9bba022890b401ef8e938683baa1a Reviewed-on: https://chromium-review.googlesource.com/c/1314132 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604850}
-
Asami Doi authored
changed. Some tests in update-registration-with-type.https.html fail because a new worker is not created when a script type is changed and a script content is identical. This CL makes |skip_script_comparison_| true when a script type is same. Also, I replaced has_installed_version() newest_installed_version(). Bug: 824647 Change-Id: I755e3d031b97d6659a7a35a1f93f9acfc654368c Reviewed-on: https://chromium-review.googlesource.com/c/1312828 Commit-Queue: Asami Doi <asamidoi@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/502d2e215556..c0b6c639b109 git log 502d2e215556..c0b6c639b109 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 yizhou.jiang@intel.com Implement GetTexLevelParameter api of texture multisample extension Created with: gclient setdep -r src/third_party/angle@c0b6c639b109 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I04fd25db433714cd0b7e788585ef1d5b8857ed3f Reviewed-on: https://chromium-review.googlesource.com/c/1314090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604848}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39b7746e. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." 24c885e6 "[css-properties-values-api] Invalidate paint worklet on registration." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler jsbell@chromium.org: external/wpt/resources kojii@chromium.org: external/wpt/css/CSS2/text rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0f7d7e40a7a6c5bfade6a3f585521c25f09299f6 Reviewed-on: https://chromium-review.googlesource.com/c/1314128 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604847}
-
Stuart Langley authored
We're still waiting on the correct artwork, so for now just re-use existing icons so we get the feature working. Still needs to support "USB and External Devices" after confirming with drive folks that this name will not be localized. Tested manually as there are no automated tests for style right now. Bug: 884020 Change-Id: I209f6e1a76c75655475e4c62ee6e97f79c9215df Reviewed-on: https://chromium-review.googlesource.com/c/1313988Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#604846}
-
Shu Chen authored
Bug: 859432 Change-Id: I61f8540a9027d43a29dcde5892f4547bad09c026 Reviewed-on: https://chromium-review.googlesource.com/c/1312143 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#604845}
-
Mitsuru Oshima authored
This is 2nd attempt to land: crrev.com/c/1304973 [2] are the difference from above CL. *[2] Added null check in OnStartingAnimationComplete. * Pause occusion tracker during overview animation [2] wait 5000ms when exiting overview before resume because a user may re-enter overview [2] wait 50ms when entering overview before resume because it can take 2 frame to finish draing the frame after animation observer is called. * Activate the text filter after animation * [2]Animate shelf after overview animation. * [2] Improve blur animation: Use Compositor's AnimationObesrver to drive animation Progress only by 2 to reduce the frequency. * Don't animate backdrop window during overview animation. * Fix the bounds change issue in WindowGrid. It shouldn't change the parent window's bounds. Bug: 898077, 897387, b/118675936 Test: no functional change. Manually tested visual change by entering/exiting overview mode in both clamshell and tabletmode. The web contents should load after animations without backdrop animation. No gap at the bottom of the screen after exiting overview mode. Change-Id: I5e5dc17afd62d4dc477d87becdeee91c55bd81ca Reviewed-on: https://chromium-review.googlesource.com/c/1304973 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:Sammie Quon <sammiequon@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#604206} Reviewed-on: https://chromium-review.googlesource.com/c/1312614Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#604844}
-
Sam McNally authored
If a file is not openable while preparing the launch data for a file handler, the file handling app is launched without any file entries and without the handler ID. With DriveFS, hosted docs will fail in this fashion; when attempting to zip files including a hosted doc, this causes the zip archiver to fail silently since it's launched without any information. Pass the handler ID to the app when launching without any entries so it can identify what the user was attempting to do. In the zip archiver, display the same notification that would be displayed if the zip pack operation later failed when such launch events are received. Bug: 892595 Change-Id: I3d2e145a8c6e955b03891063813c0624b692d943 Reviewed-on: https://chromium-review.googlesource.com/c/1303320Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604843}
-
Kouhei Ueno authored
This should serve as a better proxy for measuring ES6 modules usage in the wild. Before this CL, we relied on kPrepareModuleScript, which only counts ES6 module usage via <script type=module>, and no other invocation paths. kInstantiateModuleScript will also cover module usage via dynamic import, via workers, and others. Bug: 594639 Change-Id: I5d1690fcfb7ea6ee9eac3beb22a4659a1410c561 Reviewed-on: https://chromium-review.googlesource.com/c/1314011Reviewed-by:
-
Shakti Sahu authored
Fixed an issue where the filter change callback was not getting propagated correctly to the mutator, due to which the back button press was unable to update the contents of the tab. Bug: 899936 Change-Id: I46f83fd651a453aba875c62ef47da9d8ee8b2067 Reviewed-on: https://chromium-review.googlesource.com/c/1309427Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#604841}
-
Koji Ishii authored
Following bot results are included. 11268 11270 11273 11280 11287 11296 11304 11316 11319 11324 11330 11336 11341 11351 11357 11362 11368 1 lines were removed and 1 lines were deflaked by consecutive results since 11296. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I9876bcba7cfbf94a3500e9b9a4ae41f45eaa0b3e Reviewed-on: https://chromium-review.googlesource.com/c/1308956 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#604840}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/94d7af7bcc96..26fcd7166c74 git log 94d7af7bcc96..26fcd7166c74 --date=short --no-merges --format='%ad %ae %s' 2018-11-02 reed@google.com remove scale parameter from getFontMetrics 2018-11-02 caryclark@skia.org match getFontMetrics change in docs 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a23184454e9c..42e8e54e3049 (1 commits) 2018-11-02 reed@google.com remove (unused and weird) zoom parameter on getFontMetrics 2018-11-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2197dc529052..502d2e215556 (1 commits) Created with: gclient setdep -r src/third_party/skia@26fcd7166c74 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ic17491a3ec84e6000b1fd9a33c02b75f1a842d19 Reviewed-on: https://chromium-review.googlesource.com/c/1314088Reviewed-by:
-
Shakti Sahu authored
Fixed several bugs : 1 - On orientation change, toolbar needs to readjust its contents. 2 - Search menu item visibility needs to be correctly initialized based on the contents. 3 - The downloads area (recycler view and toolbar) will be limited to 600dp on wide screen. Bug: 899139 Change-Id: I5eaad5c68d6ff4d268ac0c7da4489a591f8bf29f Reviewed-on: https://chromium-review.googlesource.com/c/1303401Reviewed-by: -
Keishi Hattori authored
Converts all HeapHashSet, HeapLinkedHashSet, HeapListHashSet allocations from new to MakeGarbageCollected. Allocations using new will be banned from now on. Bug: 757708 Change-Id: I065d7e2f86bc11ce6e46dda378583f8cc630947c Reviewed-on: https://chromium-review.googlesource.com/c/1309894 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#604837}
-
Luciano Pacheco authored
This is a reland of 2903236d Original change's description: > Change NavigationListModel to support MyFiles as Volume. > > Add MYFILES_VOLUME_ENABLED in private strings to be able to have the > feature flag in the JS/UI code. > > Change VolumeManager to use MyFiles folder for Downloads volume, the > method |GetMyFilesFolderForProfile| takes care of returning the right > value based on the feature flag MyFilesVolume. > > Change NavigationListModel to support MyFiles as Volume when > MyFilesVolume feature flag is enabled: > 1. MyFiles volume is the Downloads volume (after the feature flag is > removed we can rename it accordingly). Setup Downloads volume as > VolumeEntry, > 2. Create a NavigationModelFakeItem with "My files" label, based on the > VolumeEntry (step #1). > 3. Skip adding "Downloads" to Myfiles, since now MyFiles is in fact > Downloads volume. > 4. Continue to add Linux and Play files to Myfiles. > > Test: unit_tests --gtest_filter='VolumeManagerTest.GetVolumeListMyFilesVolume' and browser_test --gtest_filter='FileManagerJsTest.DirectoryTreeTest:FileManagerJsTest.NavigationList*' > Bug: 873539 > Change-Id: Ia242d52a1e4d7b4fb3c7ca219d9cfdc4fce72543 > Reviewed-on: https://chromium-review.googlesource.com/c/1308235 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#604143} Bug: 873539 Change-Id: I396cda87781c21856a736c6f5eae8f76efb4e62c Reviewed-on: https://chromium-review.googlesource.com/c/1314012Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#604836}
-
Koji Ishii authored
This patch fixes two excessive marking of line box dirtiness in NGInlineNode::MarkLineBoxesDirty(). 1. LayoutObject::InsertedIntoTree() marks dirty, even if it will be dirtied again later in NGInlineNode:: MarkLineBoxesDirty(). Fixed LayoutNGMixin<Base>:: DirtyLinesFromChangedChild() to do only if it was in NG inline formatting context. 2. It may dirty the first line box because it clears LayoutObject::FirstInlineFragment as it traverses in pre- order, but NGPaintFragment::DirtyLinesFromChangedChild() needs FirstInlineFragment of its previous siblings. Changed to keep previous fragment in this loop. blink_perf.layout does not show observable improvements, but loading.desktop shows ~3% improvements. Bug: 636993 Change-Id: Ia0706bb2407427b3e4ed093290646eb21bc5c0f3 Reviewed-on: https://chromium-review.googlesource.com/c/1309388 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604835}
-
Xiaocheng Hu authored
This patch changes HotModeSpellCheckRequester to use uncanonical versions of PreviousWordPosition and EndOfWord to reduce usage of VisiblePosition. Bug: 657237 Change-Id: I26428ede826bc63ee76af02ace14a8bf43d69e25 Reviewed-on: https://chromium-review.googlesource.com/c/1313839Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#604834}
-
Tarun Bansal authored
Currently, optimization hints are fetched only when data saver pref is set. This can be done by going to data saver setting or by installing the extension on the desktop. This CL additionally checks if data saver is enabled via command line switch. This makes it simpler to test hints on Linux without having to install the extension. This is not really a user-facing change since users are not expected to turn data saver via that switch. Bug: 878131 Change-Id: I4f728a3e9bbfe30119257ff43c8eeb52b211732d TBR: dougarnett@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1313274 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#604833}
-
Xiaocheng Hu authored
This patch exposes noncanonical versions of Previous/NextWordPosition to reduce usage of VisiblePosition. Bug: 657237 Change-Id: I0815b0c0bf4de34427432ca8f6aa769c356c6385 Reviewed-on: https://chromium-review.googlesource.com/c/1313876Reviewed-by:
-
Sungguk Lim authored
Implementation for chrome.tabs.goBack and chrome.tabs.goForward Above APIs provide a reliable way to trigger a navigate-back/forward action like back/forward button on toolbar. Bug: 830622 Change-Id: I1f5e8d5e4768161f43b2df1621a03a6cc3383b4f Reviewed-on: https://chromium-review.googlesource.com/c/1274225Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604831}
-
Zhuoyu Qian authored
This patch stops passing VisiblePosition to the functions, and hoists creation of VisiblePosition to the callers, to decrease the usage of VisiblePosition. Bug: 657237 Change-Id: I52a6a34e240aa0180d2459c262b2db919fab4674 Reviewed-on: https://chromium-review.googlesource.com/c/1309568Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#604830}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Id8d03ff031991eeea8a2d4069332adb17b6ae869 Reviewed-on: https://chromium-review.googlesource.com/c/1314148Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#604829}
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I8724b84354fda40bcaa90a7d90a82c563fb11698 Reviewed-on: https://chromium-review.googlesource.com/c/1312151Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#604828}
-
Reilly Grant authored
This change fixes a number of issues with sending bulk and interrupt transfers to a USB device using the new Windows backend. * Posting completion callbacks to the proper thread (a requirement for DevTools) has been fixed. * Overlapped I/O results are now read using the correct method (WinUsb_GetOverlappedResult) and from the correct handle. * Aborting transfers on handle close no longer results in a double-free. Bug: 637404 Change-Id: I4fdb254e4ea6e9cbf7d764f588c94d698d61cb02 Reviewed-on: https://chromium-review.googlesource.com/c/1313828 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#604827}
-
Julie Jeongeun Kim authored
It adds X11ScreenOzone for PlatformScreen which has basic implementation. When it creates PlatformScreen for Ozone/X11, X11ScreenOzone is created and it creates X11DisplayFetcherOzone, which communicates with 'x11::xrandr'. The way to get display information in X11DisplayFetcherOzone is similar to DesktopScreenX11. Once it builds display information from 'x11::xrandr', it adds the information to display list from X11ScreenOzone. This patch also moves 'GetICCProfileForMonitor' to x11_util.cc to share it with X11ScreenOzone. Bug: 891175 Test: ozone_x11_unittests Change-Id: I2d901f72ca2d9609ef19eef7da35bf99aec62d2a Reviewed-on: https://chromium-review.googlesource.com/c/1293290Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#604826}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b281d52b301d..971689c0597c git log b281d52b301d..971689c0597c --date=short --no-merges --format='%ad %ae %s' 2018-11-01 bpastene@chromium.org Revert "ADB commands should only retry errors, not exceptions." Created with: gclient setdep -r src/third_party/catapult@971689c0597c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:895027 TBR=sullivan@chromium.org Change-Id: I805d1b998211fe410ea719e9a3486f8f90dc61ae Reviewed-on: https://chromium-review.googlesource.com/c/1313689Reviewed-by:
-
rbpotter authored
Bug: 829414 Change-Id: Ib6b84bcac405deda514b76c426b14f19888687a3 Reviewed-on: https://chromium-review.googlesource.com/c/1311655Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#604824}
-
Istiaque Ahmed authored
During browser startup, registering a service worker can be slow (in order of a few seconds). We currently register SW based extension's script on every extension activation (when we load extensions), which isn't necessary as SW registrations are suppose to persist across browser restart by design. Add a pref to remember the fact that we have successfully registered an extension's background SW script for a particular version of that extension and use that to decide whether or not to register the SW during OnActivateExtension. This CL will improve SW based extension's startup time. Bug: 889687 Test: Demo browser clock extension doesn't lag much with the change (note that this is requires local modification to chromium, specifically Patchset #2) Change-Id: Icfb7174be27f65a1cb6b8ac6d99ddc6b33fdf1c0 Reviewed-on: https://chromium-review.googlesource.com/c/1265821 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Change-Id: I36f9dc912bd90e8ea4c5726089b70d76dba0d6e9 Reviewed-on: https://chromium-review.googlesource.com/c/1311927 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dd8eb5ae7bcc..86e5fbf71b88 git log dd8eb5ae7bcc..86e5fbf71b88 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 tsepez@chromium.org Move Non-JS date functions to fx_date_helpers.cpp Created with: gclient setdep -r src/third_party/pdfium@86e5fbf71b88 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I494fb3ce687a4b8d32b0344724a9a209c75b52f2 Reviewed-on: https://chromium-review.googlesource.com/c/1313296Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73b23f5ede8f..da627bb2e1dc Created with: gclient setdep -r src-internal@da627bb2e1dc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id486fa305563fb93b88f25fe06e02027fa2cb7d1 Reviewed-on: https://chromium-review.googlesource.com/c/1313293Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#604820}
-
Michael Giuffrida authored
This is a logical revert of "Use preferred language in extension i18n" (commit 693d01a6). Because of some intervening changes causing more complicated merges, it's simpler to just undo the side effects of the original change, leaving the changed boilerplate intact. Reason for revert: Testing perf regression in crbug.com/898191 If this exonerates the original CL, we will revert this change. Otherwise, we will clean up the boilerplate added for the original CL. Original change's description: > Use preferred language in extension i18n > > When localizing an extension, prioritize the user's preferred language > over the application locale. > > Normally, these are the same. In some cases, they differ. For example, > the user may choose to display Chrome in "en-CA" (the intl.app_locale > pref), but because we don't have translations for that, the actual > UI locale is "en-GB". > > This CL makes extensions try to use the user's preferred locale for i18n > ("en_CA"), falling back to the UI locale ("en_GB") if no locale > directory is found for the preferred locale. > > This change also updates the "current_locale" manifest key to reflect > the user's preferred locale, or the UI locale if intl.app_locale is > unset. > > Note: Like the application locale, the preferred locale is only set at > startup (and in certain situations in CrOS). If the user changes their > intl.app_locale pref, they have to restart Chrome before extensions are > re-localized, just like before. > > Bug: 874225 > Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d > Reviewed-on: https://chromium-review.googlesource.com/c/1244666 > Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600619} Bug: 898191 Change-Id: Iaddceb16d61ffc5572a25ed31276443ea5b5baa4 Reviewed-on: https://chromium-review.googlesource.com/c/1308765Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#604819}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c3879dcec38..94d7af7bcc96 git log 6c3879dcec38..94d7af7bcc96 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-01 herb@google.com Revert "Remove the unused buffers for unique glyph handling" 2018-11-01 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 75889d00033b..a23184454e9c (1 commits) Created with: gclient setdep -r src/third_party/skia@94d7af7bcc96 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: Ic5e9b7a8d262ad5e9f180e2a915c7f23109f3ab8 Reviewed-on: https://chromium-review.googlesource.com/c/1313691Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f8a50d00a8b..fec80c41355c git log 8f8a50d00a8b..fec80c41355c --date=short --no-merges --format='%ad %ae %s' 2018-11-01 ehmaldonado@chromium.org git-cl: Report git push information to metrics collection. Created with: gclient setdep -r src/third_party/depot_tools@fec80c41355c The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:897394 TBR=agable@chromium.org Change-Id: Ie1478e08383e456d754435c88cad4c980afcbb4f Reviewed-on: https://chromium-review.googlesource.com/c/1313295Reviewed-by:
-
Jeremy Roman authored
In addition to being somewhat silly and inefficient, this also made it impossible to check whether these things need to be removed on destruction (because it would add a reference to a doomed object). Bug: 856641 Change-Id: Ia017304cddbc417a5fce5350de6726471aff930f Reviewed-on: https://chromium-review.googlesource.com/c/1312571Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604816}
-
Pavel Feldman authored
This is a follow up to the content-side change, we need chrome to respect these overrides as well when the check originates outside of the web platform. Bug: 631464 Change-Id: I8300a17d6b2b65140aef8232a58a694e56a709e3 Reviewed-on: https://chromium-review.googlesource.com/c/1308935 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#604815}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2197dc529052..502d2e215556 git log 2197dc529052..502d2e215556 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 jmadill@chromium.org Vulkan: Crunch RenderPassDesc. Created with: gclient setdep -r src/third_party/angle@502d2e215556 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ia275637aa1efcadf797eefe58cd0930916010cf7 Reviewed-on: https://chromium-review.googlesource.com/c/1313766Reviewed-by:
-
Min Qin authored
If a download is getting no response while it completes, it shouldn't carry the DOWNLOAD_INTERRUPT_REASON_NONE reason. Otherwise, it will fail the DCHECK in InProgressDownloadManager::StartDownload(). This CL fixes the issue by adding the NETWORK_FAILED reason to the download. BUG=900149 Change-Id: Ic068691f8bc5146fba92e75894eec74ce5c54bc8 Reviewed-on: https://chromium-review.googlesource.com/c/1308672Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#604813}
-
Kouhei Ueno authored
No behaviour change. This CL clarifies which HTTP methods are actually in the allowed set. Bug: 803774 Change-Id: Ie787a72c2600b96e97aa8540826b5adf63894715 Reviewed-on: https://chromium-review.googlesource.com/c/1313809 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
