- 01 Apr, 2020 40 commits
-
-
Timothy Gu authored
Currently, no matter what the branding of the browser is, the name of the PulseAudio contexts are always "Chromium" and "Chrome Input". This is shown in e.g., GNOME Settings. Instead, use current branding to determine the name to use: "Chromium" and "Chromium Input", or "Google Chrome" and "Google Chrome Input". Change-Id: Ibff97112b990cb43eb568be11310d85604642b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130766Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755378}
-
Colin Blundell authored
WebLayer currently passes null as the RedirectHandler implementation used by ExternalNavigationHandler. We are targeting sharing Chrome's RedirectHandler implementation. In advance of that sharing, this CL adds tests of WebLayer's external navigation launching that verify areas impacted by the RedirectHandler implementation used. In particular, these tests highlight area where WebLayer's external intent launching is not up to par with Chrome's thanks to the missing RedirectHandler implementation: the tests launch intents that in Chrome would be blocked. When WebLayer brings in Chrome's RedirectHandler impl, these tests should fail and consequently have their behavior updated to verify that the intents are blocked. Change-Id: I35a00ed4b15cbd046c3106bf4d91bb042ec91da3 Bug: 1031465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130277 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#755377}
-
Maksim Sisov authored
As was discussed in https://crrev.com/c/2013106, the workspace updates have been moved to the display::Screen class. How it worked: A client called to X11DesktopHandler singleton and setup self as an observer, which was then notified about workspace updates. How it works now: display::Screen and DisplayObserver interfaces were extended and new methods were added OnCurrentWorkspaceChanged and GetCurrentWorkspace. X11DesktopHandler no longer receives any workspace updates. Instead, that functionality was moved to ui/base/x/x11_workspace_handler. In case of non-Ozone/X11 and Ozone/X11, both DesktopScreenX11 and X11ScreenOzone create XDisplayManager that stores DisplayObservers and notifies them about workspace changes that it gets from X11DesktopHandler. Thus, the run-time flow looks like that: non-Ozone/X11: - Client-->display::Screen::GetScreen()->AddObserver()--> XDisplayManager::AddObserver(); - X11WorkspaceHandler::DispatchXEvent()--> XDisplayManager::OnCurrentWorkspaceChanged()--> DisplayChangeNotifier::NotifyCurrentWorkspaceChanged(); Ozone/X11: - Client-->display::Screen::GetScreen()->AddObserver()--> PlatformScreen->AddObserver()--> XDisplayManager::AddObserver(); - X11WorkspaceHandler::DispatchXEvent()--> XDisplayManager::OnCurrentWorkspaceChanged()--> DisplayChangeNotifier::NotifyCurrentWorkspaceChanged(); Basically, the difference is who owns the XDisplayManager. In non-Ozone case, it's DesktopScreenX11 and in Ozone/X11 case, it's X11ScreenOzone. Bug: 1044555 Change-Id: Ic0e31ad4b9f4dbffbdc8a6bda0a6f592094feffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093438 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#755376}
-
Maksim Sisov authored
When X11Window goes to fullscreen, it takes bounds of the display and provides XServer with updated size and origin of itself. XServer expects the bounds to be in pixels, but X11Window got the bounds in dip. This CL fixes the issue by taking display's size in pixels instead. Also, a test was written to verify this functionality. Bug: 1055057 Change-Id: If964856386e700a4a651303fe0e4ca81c769e851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124710Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#755375}
-
Andreas Haas authored
The benchmarks have already been deleted in https://crrev.com/c/1576030, but there seem to be some leftover configs. Bug: chromium:936998 Change-Id: I7968902a59e10ee82e02edca743ef3be93574587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132212Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#755374}
-
Timothy Gu authored
Currently in some geometry classes we are using std::min() and std::max() over numbers specified in IDL as "unrestricted double", meaning they could take the special value NaN. These STL helpers internally use the < operator, as in std::min(a, b) = a < b ? a : b. However, the IEEE 794 < operator always returns false when _either_ operand is NaN, so the result of min(0, NaN) and min(NaN, 0) could, confusingly, be different. This is difference is in fact visible through JavaScript. For instance, new DOMQuad({ x: NaN }, { x: 0 }, { x: 0 }, { x: 0 }).getBounds().x gives NaN, but new DOMQuad({ x: 0 }, { x: 0 }, { x: 0 }, { x: NaN }).getBounds().x gives 0. A similar problem is present for DOMRect/DOMRectReadOnly as well. This CL implements [1], which is to adopt semantics similar to JavaScript's Math.min() and Math.max(), which propagates NaN from either operand. This also aligns our behavior with WebKit. [1]: https://github.com/w3c/fxtf-drafts/pull/395 Fixed: 1066499 Change-Id: Id9a4282fa00dafcfe9c5616643efbe2eaace411e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129889 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#755373}
-
Haiyang Pan authored
android-pie-x86-fyi-rel CI builder is kept so that the links in the associated crbugs are still reachable. Bug: 1022533 Change-Id: I1cf9ca11c401584de4c1f841b033b080c6678115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121497Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#755372}
-
Liviu Tinta authored
Fixed memory leaks. Bug: 810882 Change-Id: I36397952cb86df4a21afb47ba186cd599818610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124242Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#755371}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I6a3042388d83f90492aa2caba8ba1e2f119990e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132146Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#755370}
-
David Van Cleve authored
The experimental Trust Token API (https://github.com/wicg/trust-token-api) takes in parameters specifying a Trust Tokens protocol operation, annotates outgoing requests with request headers corresponding to protocol state, and processes corresponding response headers. For the MVP of the API, we're making the functionality available via Fetch, iframe, and XHR. To implement the XHR surface, this CL adds a new XHR setter, that accepts a trustToken object (identical to the one for the Fetch interface added in crrev.com/c/2036648) specifying a Trust Tokens operation to execute against the request. propagated correctly from the XHR interface to the network stack. Test: Expands integration tests to ensure Trust Tokens params are Bug: 1062395 Change-Id: I5f32d60c7b59002e79dc877719ba549ce5b9f412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120266Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#755369}
-
Clemens Arbesser authored
Also changed IntegerSum from two operands to N operands. Not sure why it wasn't set up like that in the first place. Bug: b/145043394 Change-Id: I81bf164b7fd10e76c0741889b479f04061fd5e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130552 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#755368}
-
Mugdha Lakhani authored
1. Move the padding from the icon to the textview. 2. Reduce the padding to 5dp to improve aesthetics. 3. Set the color of the icon and the text to modern-grey-900. Screenshots here: https://drive.google.com/drive/folders/1gvXWF_0ZKFG0VDmEsqrUHbI45Dx2zJMz?usp=sharing Bug: 1025607 Change-Id: I87200d7e4dc7f4436008136233ae99e31f154e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130247Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#755367}
-
Andrew Solovey authored
Send missing parameter |platform_version| to Gaia during Chrome OS add account flow. Bug: 1064677 Change-Id: I6e4745eb62fdc34c3ed303d138639e6d26bdb81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121264 Commit-Queue: Andrei Salavei <solovey@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#755366}
-
Chris Harrelson authored
These fields are only ever set for content layers such as canvas and video. However, such uses don't make sense any more, because the "parent" concept originally had to do with a parent layer, which is no longer a concept in layer list mode. Bug: 1008483 Change-Id: I053f9048e5a152f84c4df761f1b1500a5a0019c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129893Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755365}
-
Vidhan authored
Bug: 928851 Change-Id: I0983a1d6bfa734379fd0c1e770e212207847e843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130851Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#755364}
-
Guillaume Jenkins authored
- Update the Ukrainian spell check Hunspell dictionary used by Chromium - Roll src/third_party/hunspell_dictionaries/ e96f230bf..6fdad5388 (1 commit) Bug: 913536 Change-Id: I6e49dc2d4caba6311888aa861ff840d3ac54990c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130068Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#755363}
-
Christos Froussios authored
Also some minor visual changes Bug: 1066785 Change-Id: Ia6c58c2f3cc5b78fce2ab819f8d4fe1d45782e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128491Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#755362}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f5e7581a004..e8d2080a34ed git log 0f5e7581a004..e8d2080a34ed --date=short --first-parent --format='%ad %ae %s' 2020-04-01 bsalomon@google.com Revert x2 "Assert that all GrCaps colortype/format -> swizzle queries are legal." 2020-04-01 reed@google.com remove unused flag Created with: gclient setdep -r src/third_party/skia@e8d2080a34ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1066850 Tbr: michaelludwig@google.com Change-Id: I7dda3321899f4b6c0f88691b87ba194fb9308959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132173Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755361}
-
sandromaggi authored
Previously, we did run the |safeNativeSetVisible(true)| which does not show the content or expand the bottom sheet while in the |RUNNING| state. This CL forces an expand of the bottom sheet in that scenario. Bug: b/152951618 Change-Id: I9702f825f8ee29e90814c3b15524d0181dc6f821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132367Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#755360}
-
Donn Denman authored
This reverts commit fcbf5784. Reason for revert: Tests are still flaking. Original change's description: > [TTS] Workaround for flaky test suite CSM Test > > The whole ContextualSearchManagerTest has been disabled due to flakiness > involving the focus moving into the Omnibox. > > This CL implements a workaround by removing a delay after loading the > test page, which should not be needed anyway. > > BUG=1058362 > > Change-Id: Ia4d7e5a65d36ec4c4c32d4b4e0eec2c8225e07af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131347 > Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755332} TBR=donnd@chromium.org,jinsukkim@chromium.org Change-Id: Id5f1a13645ac04347028eb36642099e9adbee935 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132586Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#755359}
-
Kevin Babbitt authored
This patch fixes several issues that were causing problems with accessibility hit testing and bounding rectangles when device scale factor was something other than 1, for example on a high-DPI monitor. In making these changes I'm adopting Blink terminology for various coordinate spaces: http://www.chromium.org/developers/design-documents/blink-coordinate-spaces - Device scale factor: Blink will apply device scale factor either at the transition from screen coordinates to physical pixels, or at the transition from CSS pixels to document pixels, depending on whether use-zoom-for-dsf is enabled. By contrast, Views will always apply device scale factor at the transition from screen coordinates to physical pixels in order to present UI in device-independent pixels. For accessibility this means that at the node level, application of device scale factor must be handled at the delegate level. That in turn means that callers of AXPlatformNodeDelegate must pass and receive values in physical pixels. - Windows: There may be flags to control what Windows platform APIs report and expect, but it appears that in our configuration the answer is always "physical pixels" regardless of monitor DPI. Platform API implementations have been adjusted to reflect this fact. - Also on Windows, when retrieving view bounds from the render widget, we were incorrectly always applying device scale factor regardless of use-zoom-for-dsf feature state. Fixed the code to take feature state into account and added an explanatory comment. - I could not find any test coverage exercising various combinations of device-scale-factor and use-zoom-for-dsf cross-platform -- all of the existing tests run according to the host device's defaults. Added a test to exercise these combinations independent of device configuration. Bug: 1007488 Change-Id: If111a7ce3f60829bb9c69cc4d641b0d204409c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117330Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#755358}
-
Jan Wilken Dörrie authored
This change fixes CalculateUsernamePasswordState to account for cases where a typed or filled password also matches a saved username. Prior to this change this was always recorded as a typed or filled username, while now we also take the form control type into account to break tries. Fixed: 1066796 Change-Id: Idfa9c2f4c371c30aa61dfb0fa4f61bca192c8dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132447Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#755357}
-
Peter Kotwicz authored
BUG=None Change-Id: I50358fb8522fa814dcf9c2a2bfb39e42714b541b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131368Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#755356}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ab04c72210a..71a7f0fe976c Created with: gclient setdep -r src-internal@71a7f0fe976c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1050050 Tbr: jbudorick@google.com Change-Id: Ie29e53d2701916eaed93b5e5067740493fc1b5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132168Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755355}
-
Stepan Khapugin authored
Moves the first run UI flag to SceneState, and updates MainController to look for any scene showing first run UI. Bug: 1045660 Change-Id: Ia3cc3b6db9b4899e96c8c7098c336c72ee5c9704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129538Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755354}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c839d063efb6..7108574e87d0 git log c839d063efb6..7108574e87d0 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 aerotwist@chromium.org [e2e] Fails tests on in-page errors 2020-04-01 aerotwist@chromium.org Revert "Show unbound breakpoints as disabled" Created with: gclient setdep -r src/third_party/devtools-frontend/src@7108574e87d0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iba252e472ef35829073ba99daabcdc9c1d7ec91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755353}
-
David Bertoni authored
The ServiceWorkerBasedBackgroundTest.Basic test is no longer flaky. See the bug for more details regarding testing. Bug: 1003244 Change-Id: I3cc6a02409086af691fe6d3f0d6270b307c702dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130782Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#755352}
-
Ioana Pandele authored
This CL disables waiting for server predictions in tests and makes sure to wait for the text field to be filled before comparing the generated password to the text in the field. A previous attempt at unflaking the entire test suite was made at crrev.com/c/1995273, but the fix uncovered other flakes for the manual generation tests. This is why this CL is only scoped to the automatic generation cases, which are simpler. Bug: 1064960 Change-Id: I3c4c60cebbeef0ce73f4e3dddbd4747b89e5f61f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132248Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#755351}
-
sauski authored
As part of the Friendly Settings privacy settings redesign a new Safe Browsing control was introduced. This controls offered a new way of interacting with existing Safe Browsing settings and supported the new "Enhanced" SB mode. This CL adds a C++ handler to provide the current managed state of the new controls for immediate display by JavaScript. Bug: 1061947 Change-Id: Ib52d2a8f52747fcb19d45dc950cabd548e72210e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124750 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755350}
-
Anastasiia Nikolaienko authored
TBR=xiyuan@chromium.org Bug: 1043108 Change-Id: Icbed69edd08040f2d92d91811b14361b2db93c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132130Reviewed-by:
Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#755349}
-
Javier Ernesto Flores Robles authored
This reverts commit b010b7f5. Reason for revert: Reason for revert is fixed now. Original change's description: > Revert "[ios] Add data to CPE password list in showcase" > > This reverts commit 0fb67af0. > > Reason for revert: This broke the tree by indirectly compiling > ios_internal/chrome/credential_provider_extension/internal_account_verification_provider/account_verification_provider > which is broken at the moment. See https://critique.corp.google.com/#review/303938281 for its fix. > > Original change's description: > > [ios] Add data to CPE password list in showcase > > > > No styling yet. > > > > Bug: 1045454 > > Change-Id: I05155cd76c88cdaf828c62627914dffc0a1a7475 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129536 > > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Commit-Queue: David Jean <djean@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755278} > > TBR=edchin@chromium.org,javierrobles@chromium.org,djean@chromium.org > > Change-Id: I2fbc8f6c95f535a2db997954d3782f9b25792b2c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1045454 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130279 > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755297} TBR=edchin@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: I5fd47ee4cfa8eef908e4c93103cf3917e4d1f82b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132368Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#755348}
-
Liquan (Max) Gu authored
Before: * PaymentSuccessCallback#onIsReadyToPayServiceResponse After: * PaymentSuccessCallback#onPaymentSuccess Before: * PaymentErrorCallback#onError After: * PaymentErrorCallback#onPaymentError Change-Id: I5a6d3176865edf34393c63f78fd844a12b076396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123627Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#755347}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/784630f0e63e..e283d1ca64c6 git log 784630f0e63e..e283d1ca64c6 --date=short --first-parent --format='%ad %ae %s' 2020-04-01 philipp.hancke@googlemail.com add tcptype to prflx tcp candidates 2020-04-01 philipp.hancke@googlemail.com doc: remove mention of obsolete relayserver target 2020-04-01 phensman@webrtc.org Remove some more instances of IP logging. 2020-04-01 marinaciocea@webrtc.org Insert audio frame transformer between depacketizer and decoder. Created with: gclient setdep -r src/third_party/webrtc@e283d1ca64c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5359b7b14037acdf64695d037da9046a161f66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755346}
-
ckitagawa authored
This CL attempts to re-implement ui/base/clipboard/clipboard_android_unittests.cc which was deleted in http://crrev.com/2839753007 as part of removing GetApplicationContext. This CL does 2 things 1. clipboard_unittests.cc was made part of interactive_ui_tests (for context see crbug/434620); however, this target is not run on Android. Since gtests aren't sharded on Android (no clipboard contention) we can include clipboard_unittests.cc in an Android specific target to cover clipboard_android.{h|cc}. Note that this requires disabling some tests in clipboard_test_template.h that work with TestClipboard but not ClipboardAndroid (see inline bugs). 2. This adds the Android platform specific ClipboardAndroidTest.java with a testcase that simulates another application copying to the clipboard and correctly propagating that to Chrome's clipboard. This test needs to be driven from Java as per the re-implementation discussion in crbug/715619. Also related from crbug/434620 is the request for a last modified time testcase. However, this appears to reference preference-related functions which no longer exist. Bug: 434620, 715619, 1064968 Change-Id: I5e1b74711c638b947dde0dd205f575dd07cdb436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121045 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755345}
-
Nina Satragno authored
Fix the empty allowCredentials credentials.get() WPT. The test was expecting the browser to return a non-resident credential with an undefined allowCredentials list (which defaults to empty). Moreover, the test helper itself was failing because it was expecting a credential to be added to the test. Instead, move the test to its own file that sets up the test environment to support resident keys and add rk support to the helper with the isResidentKeyTest flag that avoids appending credentials to allowCredentials. Bug: 875444 Change-Id: I8baefa3a74c2a707227df430712a09935c1fbbf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130671Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#755344}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/98a3c0a4..0301269a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8dc321679762f78d7867bff043c4c76d322597ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132027Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755343}
-
nancy authored
BUG=1061843 Change-Id: I25a5dc2f46bab171ea48b38c5b2a6824e84a2ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123576Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755342}
-
Viktor Semeniuk authored
This change adds reminder about compromised credentials found during password check to the autofill page. Also, this change implements PasswordCheckBehavior to reduce code duplication in password_check passwords_section and autofill_page files. Mock: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g7c9229dfe2_9_1 Bug: 1047726 Change-Id: I48e3e2b999d4f521f5018fb3ca0b0376d66eefa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120417Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#755341}
-
Luke Zielinski authored
external/wpt/paint-timing/fcp-only/fcp-typographic-pseudo.html virtual/paint-timing/external/wpt/paint-timing/fcp-only/fcp-typographic-pseudo.html Bug: 1066848 Change-Id: I193c9df05f690be9e37b877965a005624bcfa7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132286 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#755340}
-
Anatoliy Potapchuk authored
This test have been failing on debug build. It has been already disabled for half a year on release build. Example failure:https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/17887 TBR: msramek@chromium.org Bug: 1028676 Change-Id: I349a36319f321ab1654fe8b78f11e5461e7b9d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132210Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#755339}
-